Add documentation pointer to README

Change-Id: Ibc3798c8d764bf59ce5ef00f115605bcfd03412a
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

Move sensor adjust within sensor object

All sensor adjustments should be contained within the sensor object for
the sensor. This allows the adjustments to be retrieved for a given
sensor and applied

Move sensor adjust within sensor object

All sensor adjustments should be contained within the sensor object for
the sensor. This allows the adjustments to be retrieved for a given
sensor and applied accordingly.

Tested:
No change in adjusting a sensor value
No change in removing a sensor given a removal return code

Change-Id: I5e1e40fe41b4064422a47178aec1f297b781566d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add EMSGSIZE to the list of retryable errors

Some devices return -EMSGSIZE if the hardware is being powered off in a
normal manner, as incomplete data is received. Retrying allows time for
the syste

Add EMSGSIZE to the list of retryable errors

Some devices return -EMSGSIZE if the hardware is being powered off in a
normal manner, as incomplete data is received. Retrying allows time for
the system to clean up driver devices, or in the event of a real
failure, attempt to get the rest of the data.

Resolves openbmc/openbmc#3226

Change-Id: Ib507acf4cbd4094e4369e15b8519058c57a74bc2
Signed-off-by: Eddie James <eajames@us.ibm.com>

show more ...

Move value iface creation into sensor object

Create the Sensor.Value interface for a sensor within the sensor object.
Each sensor must have an input sysfs file to get a Value property on the
Sensor.

Move value iface creation into sensor object

Create the Sensor.Value interface for a sensor within the sensor object.
Each sensor must have an input sysfs file to get a Value property on the
Sensor.Value interface and be included by hwmon.

Tested:
No change in value interface creation for sensors

Change-Id: I09b1c79142ba2a34424f5ec29f41d19a987c84e7
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Move status iface creation into sensor object

For sensors that have a status interface created with a functional
property set according to its fault sysfs file value, the object
associated with the

Move status iface creation into sensor object

For sensors that have a status interface created with a functional
property set according to its fault sysfs file value, the object
associated with the sensor should contain the creation of this
interface.

Tested:
No change in status interface creation for sensors

Change-Id: Ic3c0a81c661ac481b90ad9bd4c8bf415dae3520e
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add sensor object framework

Create a sensor object to store sensor monitoring specifications.

Tested:
Sensor objects are created and stored for each sensor

Change-Id: Idfa982f1bb8da888abbd4738

Add sensor object framework

Create a sensor object to store sensor monitoring specifications.

Tested:
Sensor objects are created and stored for each sensor

Change-Id: Idfa982f1bb8da888abbd473881870df4beec6824
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add MAINTAINERS file

Change-Id: I21fd38620b72c984bbe8afdca71fd17c65fcb144
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

Use s.c_str() in log messages

Resolves openbmc/openbmc#2905

Tested: static_assert only

Change-Id: Iac42db5c4a63116959b8f5fb7b611106e36e51bf
Signed-off-by: Joseph Reynolds <jrey@us.ibm.com>

.gitignore: Add test-driver

Change-Id: I08226c55afaebf0f2633a2a34879589e66fdf9ee
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

Support indirections other than just "label"

The current code only allowed the MODE_<type><Num> env var
to be "label" when doing DBus naming indirection.

Add support to allow it to be anything, and

Support indirections other than just "label"

The current code only allowed the MODE_<type><Num> env var
to be "label" when doing DBus naming indirection.

Add support to allow it to be anything, and then use that value
to do the lookup.

For example, if MODE_temp1 = "foo", then the code will read the
temp1_foo file to find the value to append to LABEL to find the
DBus object name. So if temp1_foo contained a 42, then the code
will use the LABEL_temp42 var to find the object name.

Tested: Test on the OpenPower OCC device which use 'label' and now
'function_id' for the indirections.

Change-Id: I1f3115a2d37d008efca74748ac7eff8434d8320a
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

mainloop: add uniqueness to busname

There can be multiple daemon instances that have the
same devpath which leads to a collision which errors silently.
This adds uniqueness to the path, which was no

mainloop: add uniqueness to busname

There can be multiple daemon instances that have the
same devpath which leads to a collision which errors silently.
This adds uniqueness to the path, which was no longer human-readable
to avoid this collision situation.

Tested: Ran on quanta-q71l with unique devices and two instances
pointing to the same device and it correctly set them up with unique
but deterministic bus names.
Change-Id: Id5aea3c3df5f793b28557a74995608ec40792a43
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Remove OCC EREMOTEIO return code hack

With openbmc/openbmc#2329, an OCC sensor value will not be read when the
associated fault file is set to true. This will set the value to 0 when
a sensor is fau

Remove OCC EREMOTEIO return code hack

With openbmc/openbmc#2329, an OCC sensor value will not be read when the
associated fault file is set to true. This will set the value to 0 when
a sensor is faulted at startup or not update the previous value during
the monitoring loop if the OCC sensor becomes faulted.

Applications(i.e. fan control) needing to react to a faulted OCC sensor
can subscribe to property changed signals on the OperationalStatus
Functional property for the sensor's dbus object.

Tested:
A faulted OCC sensor has a non-functional status on dbus

Change-Id: Ia43ebb1e0fe0227797bc4034e617ac357edd348d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Refresh sensor functional state

During the monitoring loop, the associated fault file of a sensor is
read and its functional status is updated prior to reading the sensor's
input file.

Tested:

Refresh sensor functional state

During the monitoring loop, the associated fault file of a sensor is
read and its functional status is updated prior to reading the sensor's
input file.

Tested:
The functional property is updated according to its fault file

Resolves: openbmc/openbmc#2329

Change-Id: Icc28e914df79c6681d45e92a5ea4054704ad8efd
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Skip updating value for faulted sensors

When a sensor is marked as faulted, the input value is skipped from
being read and updated in the sensor's dbus object during the monitoring
loop. This keeps

Skip updating value for faulted sensors

When a sensor is marked as faulted, the input value is skipped from
being read and updated in the sensor's dbus object during the monitoring
loop. This keeps the sensor's value set to its previously known state.

The hwmon documentation states that when a sensor input channel presents
an associated fault file, the measurement value provided for that
channel should not be trusted when the fault boolean has a value of
1. Not updating the sensor value follows this specification.

Tested:
A non-functional sensor's input value is not read
A non-functional sensor's value state in dbus object is not updated
Any functional sensor's input value is read during monitoring
Any functional sensor's value state is updated during monitoring
All sensors without a fault sysfs file are read/updated normally

Change-Id: Iccf3e4e44125d6e481ce91c8f63e8f0e4ee3df4b
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Fault status check before reading sensor value

Checking for the fault sysfs file should be done prior to reading the
input value when creating the sensor's dbus object. A sensor providing a
fault sy

Fault status check before reading sensor value

Checking for the fault sysfs file should be done prior to reading the
input value when creating the sensor's dbus object. A sensor providing a
fault sysfs file will have a status interface functional property
created with its initial functional state. A sensor in a nonfunctional
state when the object is created, will have an initial value of 0.

The hwmon documentation states that when a sensor input channel presents
an associated fault file, the measurement value provided for that
channel should not be trusted when the fault boolean has a value of 1.
Using an initial value of 0 follows this specification and allows the
corresponding dbus object to be created.

Tested:
Faulted sensor at hwmon start shows functional status of false.
Faulted sensor at hwmon start contains a sensor value of 0.

Change-Id: I6388a3f84f638360b03e557aadc6de8331e67a69
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add status interface to sensors

When a fault sysfs file is present for a sensor, the OperationalStatus
interface is attached to the sensor object. The functional property is
initially set to the cor

Add status interface to sensors

When a fault sysfs file is present for a sensor, the OperationalStatus
interface is attached to the sensor object. The functional property is
initially set to the corresponding value read from the fault sysfs file
when the sensor object is created. A follow-up commit will address
updating the functional property based on reading the fault sysfs file
during the polling interval.

Tested:
OperationalStatus interface created for sensors with fault files
Interface not created for sensors without fault file
Functional property set to correct value from sensor's fault file

Change-Id: Id75b3711d048d4667d2173a3255512cf5482ab67
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Return sensor object state data as optional

Previously, the getObject function moved the sensor data passed in as a
constant reference, which should not have been done. The intention of
the getObjec

Return sensor object state data as optional

Previously, the getObject function moved the sensor data passed in as a
constant reference, which should not have been done. The intention of
the getObject function is to retrieve the sensor's object state data.
Then, the necessary sensor data and the created object state data can be
appropriately handled for monitoring.

This change is to remove this confusion and clearly create the sensor's
object state data without modifying the sensor set data passed in to
getObject.

Tested:
Sensor objects are still created correctly
Sensor states are monitoring and updated as before

Change-Id: I19fc22fa79094d749e7d5f3b2693094e245b5a4a
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

hwmonio: split IoAccess object out

Split out the hwmon io access object from the sysfs namespace
into its own.

Change-Id: I8d1a45630117d1d503d0d5fa6061163911b695e8
Signed-off-by: Patrick Venture <v

hwmonio: split IoAccess object out

Split out the hwmon io access object from the sysfs namespace
into its own.

Change-Id: I8d1a45630117d1d503d0d5fa6061163911b695e8
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

hwmon module unit-tests -- first one

This patchset just starts the process of adding unit-tests
to the hwmon module.

Change-Id: I569aa97658b0ff56634ddf1a599fedb4caa95abe
Signed-off-by: Patrick Vent

hwmon module unit-tests -- first one

This patchset just starts the process of adding unit-tests
to the hwmon module.

Change-Id: I569aa97658b0ff56634ddf1a599fedb4caa95abe
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

test: moved to tools

Moved the current test folder to tools and started a new test
folder. This will allow for rapid introduction of new unit-tests into
phosphor-hwmon. The tools folder contains s

test: moved to tools

Moved the current test folder to tools and started a new test
folder. This will allow for rapid introduction of new unit-tests into
phosphor-hwmon. The tools folder contains small tools to aid in
phosphor-hwmon configuration and misc. This folder will go under review
at another time.

Change-Id: Ice18ffb5cdcbd519d49088e233a8082a9410b03e
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

sysfs: cleanup: add missing namespace comment

Namespace was missing terminator comment.

Change-Id: I9a35742fbdf5c0cdf162dfead0e86864b635a9ab
Signed-off-by: Patrick Venture <venture@google.com>

mainloop cleanup: added std namespace where missing

A few calls into libc weren't wrapped with the standard
namespace. This will ensure they are the calls intended via
the wrapped cpp libraries.

C

mainloop cleanup: added std namespace where missing

A few calls into libc weren't wrapped with the standard
namespace. This will ensure they are the calls intended via
the wrapped cpp libraries.

Change-Id: I966b5d2133efe6c0ac56701a2a60eef6d6d7f6e0
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Get sensor identifiers function

To minimize handling the return cases when getting a sensor object,
retrieve the sensor identifiers from a function. The identifiers
returned are then checked to be v

Get sensor identifiers function

To minimize handling the return cases when getting a sensor object,
retrieve the sensor identifiers from a function. The identifiers
returned are then checked to be valid before proceeding in creating the
sensor object.

Tested:
Sensor objects created the same
Empty id or label cause sensor object to not be created

Change-Id: I7c2f0df3fee99448af5365e0a40c4282f9a235fa
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Check for empty return code list on adding

Move the check for an empty return code list for sensor removal to
within the function that adds the return codes per sensor. This
eliminates the need to c

Check for empty return code list on adding

Move the check for an empty return code list for sensor removal to
within the function that adds the return codes per sensor. This
eliminates the need to check for an empty return code list prior to
calling this function.

Tested:
Empty return code sensor removal list is handled

Change-Id: Icdf3692cd79b3198d90ad8c0688104e4a8040186
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

mainloop cleanup: moved getAttrs to hwmon namespace

Moved the code that maps a sensor type to its dbus and
hwmon components from mainloop to the hwmon namespace.

Change-Id: I7963951c9484c02d17a3eb4

mainloop cleanup: moved getAttrs to hwmon namespace

Moved the code that maps a sensor type to its dbus and
hwmon components from mainloop to the hwmon namespace.

Change-Id: I7963951c9484c02d17a3eb415906859609e0efd3
Signed-off-by: Patrick Venture <venture@google.com>

show more ...