History log of /openbmc/phosphor-host-ipmid/dbus-sdr/ (Results 26 – 50 of 103)
Revision Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
7bb412f525-Sep-2023 Willy Tu <wltu@google.com>

dbus-sdr: sel: Fix dst setting

Use the day time saving information on the system to calculate the time
instead of zero (no dst) as the default.

https://linux.die.net/man/3/mktime

Failure Example,

dbus-sdr: sel: Fix dst setting

Use the day time saving information on the system to calculate the time
instead of zero (no dst) as the default.

https://linux.die.net/man/3/mktime

Failure Example,
```
$ stat /var/log/ipmi_sel
File: /var/log/ipmi_sel
Size: 88 Blocks: 8 IO Block: 4096 regular file
Device: 1bh/27d Inode: 4125 Links: 1
Access: (0644/-rw-r--r--) Uid: ( 0/ root) Gid: ( 0/ root)
Access: 2023-09-25 14:37:03.631424968 -0700
Modify: 2023-09-25 14:37:02.291422780 -0700
Change: 2023-09-25 14:37:02.291422780 -0700

$ ipmitool sel
SEL Information
Version : 1.5 (v1.5, v2 compliant)
Entries : 0
Free Space : 65535 bytes or more
Percent Used : unknown
Last Add Time : 09/25/23 14:30:08 PDT
Last Del Time : Not Available
Overflow : false
Supported Cmds : 'Reserve'

$ ipmitool sel list
1 | 09/25/23 | 15:30:07 PDT | reserved #0xff | | Asserted
```

Tested:
Fixed the timezone issues
```
$ ipmitool sel list
1 | 09/25/23 | 14:30:07 PDT | reserved #0xff | | Asserted
```

Change-Id: I23bdb5039bed8e135f06d399a5e970bbc1e5ed58
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

e70c59b821-Sep-2023 Thang Tran <thuutran@amperecomputing.com>

dbus-sdr: support reading OEM SEL logs

This commit supports reading OEM SEL record type in range 0xC0-0xDF and
0xE0-0xFF.

Tested:
Request to show SEL logs, OEM SEL log is shown.

Change-Id: I8e

dbus-sdr: support reading OEM SEL logs

This commit supports reading OEM SEL record type in range 0xC0-0xDF and
0xE0-0xFF.

Tested:
Request to show SEL logs, OEM SEL log is shown.

Change-Id: I8e2d2d84143c79cb7e3575c3f713d2b3ad2aaaf7
Signed-off-by: Thang Tran <thuutran@amperecomputing.com>

show more ...

dbf66e1b21-Sep-2023 Thang Tran <thuutran@amperecomputing.com>

dbus-sdr: remove redundant Get/Set SEL time commands

In the dbus-sdr, the Set SEL time command is not implemented, it is an
dummy function. Beside that the Get SEL command does not refer to dbus
int

dbus-sdr: remove redundant Get/Set SEL time commands

In the dbus-sdr, the Set SEL time command is not implemented, it is an
dummy function. Beside that the Get SEL command does not refer to dbus
interface to get the SEL time, it is geting directly from hardware.

Both Set/Get SEL time commands are implemented in storagehandler.cpp
file, therefore, we should remove redundant commands in the dbus-sdr.

Tested:
1. Disable NTP
$timedatectl set-ntp false
2. Request to Set SEL time
$ipmitool sel time set "12/31/2020 12:00:00"
12/31/20 00:00:00 UTC
3. Request to Get SEL time
$ipmitool sel time get
12/31/20 00:00:03 UTC

Change-Id: I8545d4a604c2f01f5c771be99cff9a638d08d54d
Signed-off-by: Thang Tran <thuutran@amperecomputing.com>

show more ...

369824e720-Oct-2023 Patrick Williams <patrick@stwcx.xyz>

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ic5fd073faa7391d3f0b37787d6a9c7688c9a3253
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

085de48d26-Sep-2023 Alexander Hansen <alexander.hansen@9elements.com>

phosphor-sel-logger clears SEL

the SEL logger now clears the SEL and the option
'sel-logger-clears-sel' is removed.

This removes the ambiguity about who should clear it and provides
a single implem

phosphor-sel-logger clears SEL

the SEL logger now clears the SEL and the option
'sel-logger-clears-sel' is removed.

This removes the ambiguity about who should clear it and provides
a single implementation.

Tested: together with the other topic changes. SEL Add/Clear works.

Change-Id: I9d228ac418406272caf220170a824735108b5599
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...


/openbmc/phosphor-host-ipmid/app/channel.cpp
/openbmc/phosphor-host-ipmid/app/watchdog.cpp
/openbmc/phosphor-host-ipmid/app/watchdog_service.cpp
/openbmc/phosphor-host-ipmid/app/watchdog_service.hpp
/openbmc/phosphor-host-ipmid/apphandler.cpp
/openbmc/phosphor-host-ipmid/chassishandler.cpp
storagecommands.cpp
/openbmc/phosphor-host-ipmid/dcmihandler.cpp
/openbmc/phosphor-host-ipmid/error-HostEvent.hpp
/openbmc/phosphor-host-ipmid/globalhandler.cpp
/openbmc/phosphor-host-ipmid/host-cmd-manager.cpp
/openbmc/phosphor-host-ipmid/host-interface.cpp
/openbmc/phosphor-host-ipmid/host-interface.hpp
/openbmc/phosphor-host-ipmid/include/ipmid/handler.hpp
/openbmc/phosphor-host-ipmid/include/ipmid/message/unpack.hpp
/openbmc/phosphor-host-ipmid/ipmi_fru_info_area.cpp
/openbmc/phosphor-host-ipmid/ipmid-new.cpp
/openbmc/phosphor-host-ipmid/libipmid/utils.cpp
/openbmc/phosphor-host-ipmid/meson.build
/openbmc/phosphor-host-ipmid/meson.options
/openbmc/phosphor-host-ipmid/read_fru_data.cpp
/openbmc/phosphor-host-ipmid/selutility.cpp
/openbmc/phosphor-host-ipmid/sensordatahandler.cpp
/openbmc/phosphor-host-ipmid/sensorhandler.cpp
/openbmc/phosphor-host-ipmid/settings.cpp
/openbmc/phosphor-host-ipmid/softoff/mainapp.cpp
/openbmc/phosphor-host-ipmid/softoff/softoff.cpp
/openbmc/phosphor-host-ipmid/softoff/softoff.hpp
/openbmc/phosphor-host-ipmid/storageaddsel.cpp
/openbmc/phosphor-host-ipmid/storagehandler.cpp
/openbmc/phosphor-host-ipmid/systemintfcmds.cpp
/openbmc/phosphor-host-ipmid/transporthandler.cpp
/openbmc/phosphor-host-ipmid/transporthandler.hpp
/openbmc/phosphor-host-ipmid/user_channel/shadowlock.hpp
/openbmc/phosphor-host-ipmid/user_channel/user_mgmt.cpp
/openbmc/phosphor-host-ipmid/whitelist-filter.cpp
2f0a6d0317-Aug-2023 Patrick Williams <patrick@stwcx.xyz>

sensorcommands: avoid stringop-truncation warning

When compiling ipmi-fru-parser with GCC 13.2.0, I observed the
following:

```
../subprojects/phosphor-host-ipmid/dbus-sdr/sensorcommands.cpp:1748:1

sensorcommands: avoid stringop-truncation warning

When compiling ipmi-fru-parser with GCC 13.2.0, I observed the
following:

```
../subprojects/phosphor-host-ipmid/dbus-sdr/sensorcommands.cpp:1748:17: error: ‘char* __builtin_strncpy(char*, const char*, long unsigned int)’ specified bound 16 equals destination size [-Werror=stringop-truncation]
1748 | std::strncpy(record.body.id_string, name.c_str(),
```

Switch to a memcpy instead of a strncpy to avoid the warning.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I43d5cddd74cf1ad2d686e9529e87ec416e2bb6a0

show more ...

c2c26f9317-Jul-2023 Alexander Hansen <alexander.hansen@9elements.com>

multiple ipmi shortname implementations

As ipmi subsystem requires short names, and there are multiple
ways to implement that, this patch provides compile-time configuration
options.

- shortname-r

multiple ipmi shortname implementations

As ipmi subsystem requires short names, and there are multiple
ways to implement that, this patch provides compile-time configuration
options.

- shortname-remove-suffix
- shortname-replace-words

Previously, PSU Sensor Names were stripped of some
suffixes, some of which uniquely identified the sensor.

e.g. "_Input_Voltage", "_Output_Voltage".
Without the suffix, the sensor cannot be uniquely identified.

Example: "PSU0_Input_Voltage", "PSU0_Output_Voltage"
both become "PSU0".

Tested:
- with both configurations turned off, name is only trucated
- with nothing configured, default config is applied and suffix is
removed (current behavior)
- word replacement enabled and suffix removal disabled: expected
behavior
- word replacement disabled and suffix removal enabled: expected
behavior

Change-Id: I01dd35f31e75df3c31733e9818884813a241440a
Signed-off-by: Alexander Hansen <alexander.hansen@9elements.com>

show more ...

7bb84dba25-Jun-2023 Harvey Wu <Harvey.Wu@quantatw.com>

dbus-sdr: change to continue when path not found

- If the virtual sensor has two association paths as below, and the real
inventory path is related to entity-manager according to the HW
config.

dbus-sdr: change to continue when path not found

- If the virtual sensor has two association paths as below, and the real
inventory path is related to entity-manager according to the HW
config. So we need to continue for loop when the first inventory path
not found.

```
{
"type" : "a(sss)",
"data" : [
[
"chassis",
"all_sensors",
"/xyz/openbmc_project/inventory/system/board/BMC"
],
[
"chassis",
"all_sensors",
"/xyz/openbmc_project/inventory/system/board/BMCV2"
]
]
}

```

Signed-off-by: Harvey Wu <Harvey.Wu@quantatw.com>
Change-Id: I3c4ebe953793c7f28a112bb85a6cb89bd41adc3a

show more ...

6dbea08121-Jul-2023 Vernon Mauery <vernon.mauery@linux.intel.com>

Return error when SDR offset is out of range

When reading SDRs, if the requested offset is beyond the end of the SDR,
we should return an error indicating that the offset is out of range.

Tested:
C

Return error when SDR offset is out of range

When reading SDRs, if the requested offset is beyond the end of the SDR,
we should return an error indicating that the offset is out of range.

Tested:
Confirmed that reading offset 0x40 or 0x41 of a 64-byte SDR return an
error:
ipmitool raw 0xa 0x23 0x01 0x00 0x87 0x00 0x40 0x1
Unable to send RAW command (channel=0x0 netfn=0xa lun=0x0 cmd=0x23
rsp=0xc9): Parameter out of range
ipmitool raw 0xa 0x23 0x01 0x00 0x87 0x00 0x41 0x1
Unable to send RAW command (channel=0x0 netfn=0xa lun=0x0 cmd=0x23
rsp=0xc9): Parameter out of range

Ported from intel-ipmi-oem Change-Id: I3423dddadeb3d2a5e2075ae079d263503ac0679e

Change-Id: Ibb64572a56be06cfad0710fdadafb4791a64513c
Signed-off-by: Jason M. Bills <jason.m.bills@intel.com>
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

49152e7606-Jun-2023 Harvey Wu <Harvey.Wu@quantatw.com>

dbus-sdr: fix undefined symbols error

- When enable hybrid-sensors option, it will include sensordatahandler
in sensorcommands.cpp. So need to add some src and dependency in
meson.build.

Test:

dbus-sdr: fix undefined symbols error

- When enable hybrid-sensors option, it will include sensordatahandler
in sensorcommands.cpp. So need to add some src and dependency in
meson.build.

Test:
Before:
```
ipmitool sdr elist
Err in cmd get sensor sdr info
Unable to open SDR for reading

journalctl -o json-pretty MESSAGE="ERROR opening IPMI provider"
{
"SYSLOG_IDENTIFIER" : "ipmid",
"_MACHINE_ID" : "0e6c70e7379c41fc9388fd64e1433923",
"_BOOT_ID" : "2cfdedb0cafd43758e2469ea1bc81a19",
"_PID" : "1306",
"ERROR" : "/usr/lib/ipmid-providers/libdynamiccmds.so.0.1: undefined symbol: _ZN4ipmi6sensor7sensorsE",
"MESSAGE" : "ERROR opening IPMI provider",
"_SYSTEMD_UNIT" : "phosphor-ipmi-host.service",
"_SYSTEMD_INVOCATION_ID" : "fd19f671e20147aea359bef0fc59c2c6",
"_SYSTEMD_SLICE" : "system.slice",
"_CAP_EFFECTIVE" : "1ffffffffff",
"_GID" : "0",
"_SOURCE_REALTIME_TIMESTAMP" : "1678071749865544",
"__REALTIME_TIMESTAMP" : "1678071749865607",
"_EXE" : "/usr/bin/ipmid",
"CODE_LINE" : "77",
"_COMM" : "ipmid",
"_TRANSPORT" : "journal",
"__MONOTONIC_TIMESTAMP" : "45349903",
"PRIORITY" : "3",
"CODE_FUNC" : "helper_log",
"PROVIDER" : "/usr/lib/ipmid-providers/libdynamiccmds.so.0.1",
"_HOSTNAME" : "gsz",
"CODE_FILE" : "/usr/include/phosphor-logging/log.hpp",
"__CURSOR" : "s=d8544f6ea872488fa319e44a1e5da636;i=39d;b=2cfdedb0cafd43758e2469ea1bc81a19;m=2b3fc0f;t=5f632868ef087;x=c4b27446a5eae068",
"_RUNTIME_SCOPE" : "system",
"_UID" : "0",
"TRANSACTION_ID" : "2224375320",
"_CMDLINE" : "ipmid",
"_SYSTEMD_CGROUP" : "/system.slice/phosphor-ipmi-host.service"
}
```

After:
```
ipmitool sdr elist
power | 00h | ok | 23.2 |
reset | 01h | ok | 23.1 |
CATERR | 02h | ok | 65.2 |
...
...
```

Signed-off-by: Harvey Wu <Harvey.Wu@quantatw.com>
Change-Id: I02132cd734e098f1d858628094b911a461821a80

show more ...

6615d47931-May-2023 Tom Tung <shes050117@gmail.com>

dbus-sdr: Log error only after all paths failed

getManagedObjects is now checking multiple paths and log errors whenever
it fails with a path. However, for instance,
xyz.openbmc_project.ExternalSens

dbus-sdr: Log error only after all paths failed

getManagedObjects is now checking multiple paths and log errors whenever
it fails with a path. However, for instance,
xyz.openbmc_project.ExternalSensor only supports
/xyz/openbmc_project/sensors (and not supports /xyz/openbmc_project/vr).
We should only log error when getManagedObjects fail for all paths.

Also, log the service name when failing.

Tested: with the change, there is no getManagedObjects errors in our
system.

Change-Id: Icafeae61a640ccc3e196e5ade8de2676994aae04
Signed-off-by: Tom Tung <shes050117@gmail.com>

show more ...

d74df5f225-May-2023 Chau Ly <chaul@amperecomputing.com>

Change Get DCMI sensor info privilege to OPERATOR

This commit changes the privilege to execute the command get DCMI sensor
info (command 0x07) from USER to OPERATOR to match with Table 6.1 of
DCMI s

Change Get DCMI sensor info privilege to OPERATOR

This commit changes the privilege to execute the command get DCMI sensor
info (command 0x07) from USER to OPERATOR to match with Table 6.1 of
DCMI specification.

Tested:
1. Create a user with USER/READONLY privilege
2. $ipmitool -H ${BMC_IP} -U root -P 0penBmc -C 17 -I lanplus \
-L USER raw 0x2c 0x07 0xdc 0x01 0x41 0x00 0x00
Result: Unable to send RAW command
(channel=0x0 netfn=0x2c lun=0x0 cmd=0x7 rsp=0xd4):
Insufficient privilege level
3. Change the user privilege to OPERATOR or ADMIN:
$ipmitool -H ${BMC_IP} -U root -P 0penBmc -C 17 -I lanplus \
user priv <user id> 0x3/0x4
4. Can successfully get the result from step 2.

Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: Id841fe94a79dcbf389249209b27ad6b08f39d119

show more ...

9cf0838a28-Apr-2023 Vernon Mauery <vernon.mauery@linux.intel.com>

move entity_map_json to libipmid

entity_map_json is used by dbus-sdr sensor handling so it needs to be in
a common location or loading order matters. This change moves the file
from the ipmi20 provi

move entity_map_json to libipmid

entity_map_json is used by dbus-sdr sensor handling so it needs to be in
a common location or loading order matters. This change moves the file
from the ipmi20 provider library to libipmi, a common library.

Tested: Found that even though the dbus-sdr provider loads before
ipmi20, it loads properly without missing symbols.

Change-Id: I9ab6833c78e6f3c89c02cf998ce0a36353059c3d
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

23a722ca12-May-2023 Johnathan Mantey <johnathanx.mantey@intel.com>

Enable Yocto control of the USING_ENTITY_MANAGER_DECORATORS

The USING_ENTITY_MANAGER_DECORATORS compile switch is hard coded to
enabled in a header file. The changes here allow the feature to be
con

Enable Yocto control of the USING_ENTITY_MANAGER_DECORATORS

The USING_ENTITY_MANAGER_DECORATORS compile switch is hard coded to
enabled in a header file. The changes here allow the feature to be
controlled in recipes via PACKAGECONFIG entries in bbappend files.

Tested:
Applied https://gerrit.openbmc.org/c/openbmc/openbmc/+/63434
Modified internal bbappend file to PACKAGECONFIG:remove
entity-manager-decorators
Confirmed the code guarded by the ifdef no longer compiled
Removed change to bbappend file
Confirmed the code guarded by the ifdef was restored.

Change-Id: I4f3072451f893fcb5edaa478d0546253e7005b9f
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

fbc6c9d710-May-2023 Patrick Williams <patrick@stwcx.xyz>

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I44441096113929ce96eb1439e2932e6ff3c87f27
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...


/openbmc/phosphor-host-ipmid/.clang-format
/openbmc/phosphor-host-ipmid/app/channel.cpp
/openbmc/phosphor-host-ipmid/app/watchdog.cpp
/openbmc/phosphor-host-ipmid/app/watchdog_service.cpp
/openbmc/phosphor-host-ipmid/apphandler.cpp
/openbmc/phosphor-host-ipmid/chassishandler.cpp
sdrutils.cpp
sensorcommands.cpp
sensorutils.cpp
storagecommands.cpp
/openbmc/phosphor-host-ipmid/dcmihandler.cpp
/openbmc/phosphor-host-ipmid/dcmihandler.hpp
/openbmc/phosphor-host-ipmid/elog-errors.hpp
/openbmc/phosphor-host-ipmid/entity_map_json.cpp
/openbmc/phosphor-host-ipmid/entity_map_json.hpp
/openbmc/phosphor-host-ipmid/error-HostEvent.hpp
/openbmc/phosphor-host-ipmid/globalhandler.cpp
/openbmc/phosphor-host-ipmid/groupext.cpp
/openbmc/phosphor-host-ipmid/host-cmd-manager.cpp
/openbmc/phosphor-host-ipmid/host-cmd-manager.hpp
/openbmc/phosphor-host-ipmid/host-interface.cpp
/openbmc/phosphor-host-ipmid/host-interface.hpp
/openbmc/phosphor-host-ipmid/include/dbus-sdr/sdrutils.hpp
/openbmc/phosphor-host-ipmid/include/dbus-sdr/sensorcommands.hpp
/openbmc/phosphor-host-ipmid/include/ipmid-host/cmd.hpp
/openbmc/phosphor-host-ipmid/include/ipmid/api-types.hpp
/openbmc/phosphor-host-ipmid/include/ipmid/filter.hpp
/openbmc/phosphor-host-ipmid/include/ipmid/handler.hpp
/openbmc/phosphor-host-ipmid/include/ipmid/message.hpp
/openbmc/phosphor-host-ipmid/include/ipmid/message/pack.hpp
/openbmc/phosphor-host-ipmid/include/ipmid/message/types.hpp
/openbmc/phosphor-host-ipmid/include/ipmid/message/unpack.hpp
/openbmc/phosphor-host-ipmid/include/ipmid/oemrouter.hpp
/openbmc/phosphor-host-ipmid/include/ipmid/types.hpp
/openbmc/phosphor-host-ipmid/include/ipmid/utility.hpp
/openbmc/phosphor-host-ipmid/include/ipmid/utils.hpp
/openbmc/phosphor-host-ipmid/ipmi_fru_info_area.cpp
/openbmc/phosphor-host-ipmid/ipmid-new.cpp
/openbmc/phosphor-host-ipmid/ipmisensor.cpp
/openbmc/phosphor-host-ipmid/libipmid/sdbus-asio.cpp
/openbmc/phosphor-host-ipmid/libipmid/signals.cpp
/openbmc/phosphor-host-ipmid/libipmid/systemintf-sdbus.cpp
/openbmc/phosphor-host-ipmid/libipmid/utils.cpp
/openbmc/phosphor-host-ipmid/read_fru_data.cpp
/openbmc/phosphor-host-ipmid/read_fru_data.hpp
/openbmc/phosphor-host-ipmid/selutility.cpp
/openbmc/phosphor-host-ipmid/selutility.hpp
/openbmc/phosphor-host-ipmid/sensordatahandler.cpp
/openbmc/phosphor-host-ipmid/sensordatahandler.hpp
/openbmc/phosphor-host-ipmid/sensorhandler.cpp
/openbmc/phosphor-host-ipmid/sensorhandler.hpp
/openbmc/phosphor-host-ipmid/settings.cpp
/openbmc/phosphor-host-ipmid/settings.hpp
/openbmc/phosphor-host-ipmid/softoff/softoff.cpp
/openbmc/phosphor-host-ipmid/softoff/softoff.hpp
/openbmc/phosphor-host-ipmid/storageaddsel.cpp
/openbmc/phosphor-host-ipmid/storagehandler.cpp
/openbmc/phosphor-host-ipmid/sys_info_param.hpp
/openbmc/phosphor-host-ipmid/systemintfcmds.cpp
/openbmc/phosphor-host-ipmid/test/dbus-sdr/sensorcommands_unittest.cpp
/openbmc/phosphor-host-ipmid/test/entitymap_json_unittest.cpp
/openbmc/phosphor-host-ipmid/test/message/pack.cpp
/openbmc/phosphor-host-ipmid/test/message/payload.cpp
/openbmc/phosphor-host-ipmid/test/oemrouter_unittest.cpp
/openbmc/phosphor-host-ipmid/testaddsel.cpp
/openbmc/phosphor-host-ipmid/testit.cpp
/openbmc/phosphor-host-ipmid/transporthandler.cpp
/openbmc/phosphor-host-ipmid/transporthandler.hpp
/openbmc/phosphor-host-ipmid/user_channel/channel_layer.hpp
/openbmc/phosphor-host-ipmid/user_channel/channel_mgmt.cpp
/openbmc/phosphor-host-ipmid/user_channel/channel_mgmt.hpp
/openbmc/phosphor-host-ipmid/user_channel/channelcommands.cpp
/openbmc/phosphor-host-ipmid/user_channel/cipher_mgmt.cpp
/openbmc/phosphor-host-ipmid/user_channel/cipher_mgmt.hpp
/openbmc/phosphor-host-ipmid/user_channel/passwd_mgr.cpp
/openbmc/phosphor-host-ipmid/user_channel/passwd_mgr.hpp
/openbmc/phosphor-host-ipmid/user_channel/user_layer.cpp
/openbmc/phosphor-host-ipmid/user_channel/user_layer.hpp
/openbmc/phosphor-host-ipmid/user_channel/user_mgmt.cpp
/openbmc/phosphor-host-ipmid/user_channel/user_mgmt.hpp
/openbmc/phosphor-host-ipmid/user_channel/usercommands.cpp
/openbmc/phosphor-host-ipmid/whitelist-filter.cpp
/openbmc/phosphor-host-ipmid/xyz/openbmc_project/Ipmi/Internal/SoftPowerOff/meson.build
7589306422-Mar-2023 Harvey Wu <Harvey.Wu@quantatw.com>

dbus-sdr: define the global const LUN parameter

- Define global const LUN number parameter to make code more readable

Signed-off-by: Harvey Wu <Harvey.Wu@quantatw.com>
Change-Id: Iea513b5e10d2be9cb

dbus-sdr: define the global const LUN parameter

- Define global const LUN number parameter to make code more readable

Signed-off-by: Harvey Wu <Harvey.Wu@quantatw.com>
Change-Id: Iea513b5e10d2be9cba3c24f5374c8934ad563d91

show more ...

a347627321-Mar-2023 Harvey Wu <Harvey.Wu@quantatw.com>

fix sdr count when number > 255

- After PR-60906, it will count the fru data and type 12 sensors.
But when SDR count > 255, there are some problems.

- If the lun of cmd isn't 0, the start positio

fix sdr count when number > 255

- After PR-60906, it will count the fru data and type 12 sensors.
But when SDR count > 255, there are some problems.

- If the lun of cmd isn't 0, the start position of recordID need to be
updated.
- Using if condition to add type 12 sensors. Because if sensor number
+ fru device is 254, it will overflow after adding 2 type 12 sensors.
- The type of sdrCount is uint8, which means the maximum value is 255,
so it needs to break while loop if the count reaches 255.

refs:
https://gerrit.openbmc.org/c/openbmc/phosphor-host-ipmid/+/60906

TEST:
root@bmc:~# ipmitool sdr elist | wc -l
281 => 0x119
root@bmc:~# ipmitool sdr elist all | wc -l
295 => 0x127

Before:
root@bmc:~# ipmitool raw -l 0 0x04 0x20 0x00
ff 83 c8 56 a2 63
root@bmc:~# ipmitool raw -l 0 0x04 0x20 0x01 ERROR
27 83 c8 56 a2 63
=> count overflow
root@bmc:~# ipmitool raw -l 1 0x04 0x20 0x00
1a 83 c8 56 a2 63
root@bmc:~# ipmitool raw -l 1 0x04 0x20 0x01 ERROR
1c 83 c8 56 a2 63
=> doesn't count the fru data

After:
root@bmc:~# ipmitool raw -l 0 0x04 0x20 0x00
ff 83 3e 2c a3 63
root@bmc:~# ipmitool raw -l 0 0x04 0x20 0x01
ff 83 3e 2c a3 63
root@bmc:~# ipmitool raw -l 1 0x04 0x20 0x00
1a 83 3e 2c a3 63
root@bmc:~# ipmitool raw -l 1 0x04 0x20 0x01
28 83 3e 2c a3 63

If count < 255,
root@bmc:~# ipmitool sdr elist | wc -l
151
root@bmc:~# ipmitool sdr elist all | wc -l
165
root@bmc:~# ipmitool raw -l 0 0x04 0x20 0x00
97 81 f0 2b a2 63
root@bmc:~# ipmitool raw -l 0 0x04 0x20 0x01
a5 81 f0 2b a2 63

Signed-off-by: Harvey Wu <Harvey.Wu@quantatw.com>
Change-Id: Ic4645c82d85e154bea5dc7fdd6b54d1331e58c36

show more ...

7b2e550413-Feb-2023 selvaganapathi <selvaganapathim@ami.com>

Add compact sensor data record and fix sdr count

Description
- Commit added compact sensor data record structure
- Total sdr count from get sdr list and get device sdr
info mismatch
- Fixed by added

Add compact sensor data record and fix sdr count

Description
- Commit added compact sensor data record structure
- Total sdr count from get sdr list and get device sdr
info mismatch
- Fixed by added condtion to check fru data record,
type12 record and sdrcount increamented
- Also added condition for compact sensor data record count
- get device sdr info command, keep reading record in while. As
"getSensorDataRecord" handler function adds record in end, everytime
record vector keeps growing. So get device info command keep reading the
same record and end up with wrong sdr count
- Changed code to add record in begin everytime

Tested
Successfully built and tested in reference platform. SDR count from
both get sdr list and get device sdr info matches.

$ ipmitool raw 0x04 0x20 0x01
e6 81 7d 01 00 00
$ ipmitool sdr elist all | wc -l
230

$ ipmitool raw 0x04 0x20 0x00
c8 81 7d 01 00 00
$ ipmitool sensor list | wc -l
200

Change-Id: Ifd76a53485de8d92af955e2bb4d4268b3e891110
Signed-off-by: selvaganapathi <selvaganapathim@ami.com>

show more ...

c2cb1bc210-Jan-2023 Sui Chen <suichen@google.com>

dbus-sdr: Look for ObjectManagers on /xyz/openbmc_project/vr

There are event-only voltage regular control sensors using the code
merged in https://gerrit.openbmc.org/q/hashtag:dbus-sdr-vr-sensors
th

dbus-sdr: Look for ObjectManagers on /xyz/openbmc_project/vr

There are event-only voltage regular control sensors using the code
merged in https://gerrit.openbmc.org/q/hashtag:dbus-sdr-vr-sensors
that install ObjectManagers at /xyz/openbmc_project/vr.

In commit 9a9ac0bcfc2df48873ca0f9725eb5255f7191d84, dbus-sdr was updated
to only look for ObjectManagers located at and under
/xyz/openbmc_project/sensors. This broke the VR daemon as the VR
controls now do not appear in `ipmitool sdr elist event`.

The reason is, before the above commit, dbus-sdr looked for
ObjectManagers located at and under the root path, which involved
both /xyz/openbmc_project/sensors and /xyz/openbmc_project/vr. After the
move, /vr got left out.

This change adds /vr back, so dbus-sdr looks for ObjectManagers on both
paths.

Tested: `ipmitool sdr elist event` makes the VR daemon's event-only IPMI
sensors show up again.

Signed-off-By: Sui Chen <suichen@google.com>
Change-Id: Icab98137a0115e1c5a482cc97598f7dd66d26bfc

show more ...

ffa76e5917-Jan-2023 Tom Joseph <rushtotom@gmail.com>

dbus-sdr: Revert sensor name modifications partially

With commit [1] the leaf of the D-Bus object path was stripped of
well known suffixes, in addition to that `_` was replaced by space.

Replacing

dbus-sdr: Revert sensor name modifications partially

With commit [1] the leaf of the D-Bus object path was stripped of
well known suffixes, in addition to that `_` was replaced by space.

Replacing `_` with space is not needed to solve the problem statement
[2]. For sensor names which are less than 16 characters, this creates
expectation differences on scripts which tried to validate the ipmitool
output.

[1] https://github.com/openbmc/phosphor-host-ipmid/commit/d950f410b71e0ac4650519eb5bf7ea683e98684d
[2] https://github.com/openbmc/intel-ipmi-oem/issues/4

Change-Id: If7028e517385ebfc1fc3541a6c23d559ad0c8d69
Signed-off-by: Tom Joseph <rushtotom@gmail.com>

show more ...

5113698418-Aug-2022 Paul Fertser <fercerpav@gmail.com>

Specify "8-bit ASCII + Latin 1" SDR encoding

Applications using OpenSolaris libipmi can't handle "Unicode" (type 0)
encoding for the sensor names [0].

This results in issues with VMWare ESXi which

Specify "8-bit ASCII + Latin 1" SDR encoding

Applications using OpenSolaris libipmi can't handle "Unicode" (type 0)
encoding for the sensor names [0].

This results in issues with VMWare ESXi which uses IPMI to fetch sensor
data from the BMC, all the names are shown as "Unspecified 1" (if
default EntityId is used), so status page, SEL entries and the logs
become very confusing.

Fix this by telling it to process all bytes as is by using "8-bit ASCII
+ Latin 1" type.

The patch is untested however similar changes to intel-ipmi-oem were
tried with VMWare ESXi 7.0 Update 2 and regular ipmitool (using GNU
FreeIPMI), both show names correctly.

[0] https://github.com/kofemann/opensolaris/blob/master/usr/src/lib/libipmi/common/ipmi_util.c#L258

Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Change-Id: Idf19833e4877af1acb32f016e85e93c6f58df27e

show more ...

d90b3f0811-Nov-2022 krishnar4 <krishnar@ami.com>

Extended support for 16bit logic bus

This commit will add the support of 16 bit logical bus.

Tested :
all EEPROM fru getting listed Successfully which were connected
to 8 and 16 bit logical bus.

d

Extended support for 16bit logic bus

This commit will add the support of 16 bit logical bus.

Tested :
all EEPROM fru getting listed Successfully which were connected
to 8 and 16 bit logical bus.

dependent commit:-
https://gerrit.openbmc.org/c/openbmc/entity-manager/+/58634

Signed-off-by: krishnar4 <krishnar@ami.com>
Change-Id: I547ef8a27fdc74ec34a421c4cf5949c29fcc77b4

show more ...

5253562428-Nov-2022 William A. Kennington III <wak@google.com>

dbus-sdr/storagecommands: Fix type

Return type of writeFruCache is unused, set it to void.

Change-Id: I3d60867c9366ff22dc0a39085ff000f45ddebf2f
Signed-off-by: William A. Kennington III <wak@google.

dbus-sdr/storagecommands: Fix type

Return type of writeFruCache is unused, set it to void.

Change-Id: I3d60867c9366ff22dc0a39085ff000f45ddebf2f
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

0679e4b111-Nov-2022 Willy Tu <wltu@google.com>

enable dbus-sdr in testing by default

Fix the build issues with dbus-sdr

Change-Id: If91de78de5f9ffeb8581b8ee5862363722103cac
Signed-off-by: Willy Tu <wltu@google.com>

9a9ac0bc04-Oct-2022 Ed Tanous <edtanous@google.com>

Move the location of sensor object manager

Per phosphor-dbus-interfaces, all sensor implementations should be
implementing an ObjectManager at /xyz/openbmc_project/sensors

This commit updates dbus-

Move the location of sensor object manager

Per phosphor-dbus-interfaces, all sensor implementations should be
implementing an ObjectManager at /xyz/openbmc_project/sensors

This commit updates dbus-sdr to look from the corrrect location.

Tested:
Combined with the other patches with this same topic, ipmitool sensor
list returns the same data as previously on an s7106 platform.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I68ae41a403b388ed76c583d30db69ac8fb7a29f1

show more ...

12345