| #
43dd2d8a |
| 18-Nov-2019 |
Matt Spinler <spinler@us.ibm.com> |
Fix "Add device dependency for services"
Not all systems use gpio-keys-polled, so adding a hard requirement on
that in the service files will cause the services to fail on those
syst
Fix "Add device dependency for services"
Not all systems use gpio-keys-polled, so adding a hard requirement on
that in the service files will cause the services to fail on those
systems.
Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I62ab4ebc496bc1fb3ed7f2fc258930f2e509a189
Fixes: 58dc277a9df27cc79565b20f48d42c95a877d3c2.
show more ...
|
| #
58dc277a |
| 05-Nov-2019 |
Alvin Wang <alvinwang@msn.com> |
Add device dependency for services
In Mihawk /dev/input/by-path/platform-gpio-keys-event is not created
by udev while phospho-gpio-monitor@id_button.service is running.
In Mihawk it
Add device dependency for services
In Mihawk /dev/input/by-path/platform-gpio-keys-event is not created
by udev while phospho-gpio-monitor@id_button.service is running.
In Mihawk it takes much more time for udev to create device files
because there are more devices in Mihawk. Other platforms may hit the
same issue in the future This patch adds the dependency of
platform-gpio-keys and platform-gpio-keys-polled to
phosphor-gpio-monitor@.service and phosphor-gpio-presence@.service to
fix the issue in Mihawk.
The timing of kernel, udev and id_button service. The
platform-gpio-keys-event is created at 09:32 while id_button service
in running at 09:31
Nov 01 09:31:11 mihawk kernel: input: gpio-keys as /devices/platform
/gpio-keys/input/input2
Nov 01 09:31:11 mihawk systemd[1]: Started udev Kernel Device Manager.
Nov 01 09:31:17 mihawk systemd[1]: Started udev Coldplug all Devices.
Nov 01 09:31:46 mihawk systemd[1]: phosphor-gpio-monitor@id_button.
service: Main process exited, code=killed, status=6/ABRT
Nov 01 09:31:46 mihawk systemd[1]: phosphor-gpio-monitor@id_button.
service: Failed with result 'signal'.
lrwxrwxrwx 1 root root 9 Nov 1 09:32
/dev/input/by-path/platform-gpio-keys-event
Tested: The phosphor-gpio-monitor@id_button.service can be started
successfully.
Signed-off-by: Alvin Wang <alvinwang@msn.com>
Change-Id: I3fd3422e06f39175cc7c5321dcfadc9ad184b9ae
show more ...
|
| #
166ef2de |
| 01-Nov-2019 |
Brad Bishop <bradleyb@fuzziesquirrel.com> |
systemd: remove double braces
Previously these unit files were processed by pythons format() method,
so the double braces would be reduced to a single brace.
The unit files are
systemd: remove double braces
Previously these unit files were processed by pythons format() method,
so the double braces would be reduced to a single brace.
The unit files are no longer processed so the double braces are not
removed and break starting of the unit.
Tested:
From systemctl status phosphor-gpio-presence@0.service:
`-398 /usr/bin/phosphor-gpio-presence --path=/dev/input/by-path/platform-gpio-keys-event --inventory=/system/chassis/motherboard/powersupply0 --key=104 --name=powersupply0 --drivers=/sys/bus/i2c/drivers/ibm-cffps,3-0069 --extra-ifaces=xyz.openbmc_project.Inventory.Item.PowerSupply
Nov 01 19:28:33 witherspoon-Y230UF71K03T systemd[1]: Started Phosphor GPIO 0 Presence.
Nov 01 19:28:34 witherspoon-Y230UF71K03T phosphor-gpio-presence[398]: Updating inventory present property
Change-Id: Iacb29c8524152f87c676fd70227b076a6c84b877
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
show more ...
|
| #
a1ac1802 |
| 30-Oct-2019 |
Brad Bishop <bradleyb@fuzziesquirrel.com> |
presence: fix systemd unit syntax error
26373ab Add systemd units for monitor and presence
added system units for the monitor and presence applications, but that
patch does not
presence: fix systemd unit syntax error
26373ab Add systemd units for monitor and presence
added system units for the monitor and presence applications, but that
patch does not remove the special {envfiledir} replacement token that
exists in the original unit file. Replace with the actual path.
Change-Id: Ib51f30edb45d6186ea3890783f0f3430d3c184ea
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
show more ...
|
| #
26373abe |
| 19-Sep-2019 |
Brad Bishop <bradleyb@fuzziesquirrel.com> |
Add systemd units for monitor and presence
Change-Id: I77593fe6b7927511042aeebff17519719c0742e3
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
|