monitor: include previous targets and tachs in PEL

To discover the source of certain fan ramp-up failures, this change
outputs the previous 8 targets and tach readings. The strategy is to see
if har

monitor: include previous targets and tachs in PEL

To discover the source of certain fan ramp-up failures, this change
outputs the previous 8 targets and tach readings. The strategy is to see
if hardware limitations prevent attaining the targets quickly enough.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: Ia38867986b8a8a651de5d01766393c07d413273c

show more ...

monitor: Capture BMC dumps on fan/ambient shutdowns

When fan-monitor or sensor-monitor generates an EPOW, this change
creates a BMC dump after the system is powered off and all error logs
are create

monitor: Capture BMC dumps on fan/ambient shutdowns

When fan-monitor or sensor-monitor generates an EPOW, this change
creates a BMC dump after the system is powered off and all error logs
are created.

Change-Id: Iacdd2d2b388e79988e2536d52497f0e697e1d444
Signed-off-by: Mike Capps <mikepcapps@gmail.com>

show more ...

Use regular std::filesystem

Now that std::filesystem is available there's no need to use
std::experimental::filesystem.

Note the '/' operator does behave differently when the RHS is an
absolute pat

Use regular std::filesystem

Now that std::filesystem is available there's no need to use
std::experimental::filesystem.

Note the '/' operator does behave differently when the RHS is an
absolute path (starts with /), but none of the uses here make use of an
absolute path.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ice5ed7e85f6bf9c8355a66b5b00fe8550899a258

show more ...

monitor: remove POWER_THERMAL_CRITICAL_FAULT PEL message

This message has been deprecated due to the removal of the PowerFault
bit.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I730d

monitor: remove POWER_THERMAL_CRITICAL_FAULT PEL message

This message has been deprecated due to the removal of the PowerFault
bit.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I730dca008d15f5b985a3c2006e164edba53330c6

show more ...

monitor - Run fan status/health change after sensors updated

A bug was found when removing a fan and replugging it that the shutdown
counters would not reset causing the system to shutdown after add

monitor - Run fan status/health change after sensors updated

A bug was found when removing a fan and replugging it that the shutdown
counters would not reset causing the system to shutdown after additional
fans are removed/replugged. This was caused by the fan status/health was
being updated prior to the fan and its sensor's functional states being
updated. Having the fan status/health updated after the fan and its
sensor's functional states updated provides the correct state to the
shutdown rules.

Change-Id: I61957dcd43e59ac672b04f3d893339b5f512e718
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

monitor: ibm3223 partial revert, restore service file dependency

monitor depends on inventory before it can start

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: Ib4f2885f04a5d178a66077

monitor: ibm3223 partial revert, restore service file dependency

monitor depends on inventory before it can start

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: Ib4f2885f04a5d178a6607780774662560a3da041

show more ...

Monitor: disable inventory svc dependency in systemd

Startup Monitor without the systemd dependency on inventory.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I9700b061d7d6b42ace2985

Monitor: disable inventory svc dependency in systemd

Startup Monitor without the systemd dependency on inventory.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I9700b061d7d6b42ace2985936a98df18e790c395

show more ...

Monitor : avoid mapper lookups in Tach Sensor

There is a race condition that can fail in certain situations where
mapper has not completed introspection, causing a lookup failure and
D-Bus exception

Monitor : avoid mapper lookups in Tach Sensor

There is a race condition that can fail in certain situations where
mapper has not completed introspection, causing a lookup failure and
D-Bus exception. This change uses a hard-coded service name, thus
avoiding the lookup and allowing tach sensors to write status directly
to inventory.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: If6ad105055762c6240b36d904d169094088b7c81

show more ...

monitor: ibm3223 partial revert, restore service file dependency

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I834b99e0033dd75e0189f2b9ef4884646e4a764b

Fix fmt violation

The newest version of fmt enables more safety flags to ensure that no
implicit casts are done by default. The line changed was trying to
implicitly cast an enum. This commit make

Fix fmt violation

The newest version of fmt enables more safety flags to ensure that no
implicit casts are done by default. The line changed was trying to
implicitly cast an enum. This commit makes this explicit with a
static_cast.

Tested: Code compiles against the latest subtree update.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I1eda57cf1bd2cbf3551f6c2d59660119ef713dbe

show more ...

Monitor: disable inventory svc dependency in systemd

Now that Monitor can startup properly without depending on inventory,
this commit removes the systemd dependency, allowing the system to
startup

Monitor: disable inventory svc dependency in systemd

Now that Monitor can startup properly without depending on inventory,
this commit removes the systemd dependency, allowing the system to
startup more quickly.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: If36aee2265c9909a18ce27c8fbf56d04095dcc14

show more ...

Monitor : handle inventory service offline

Using nameHasOwner and nameOwnerChanged D-Bus signals, a callback is
activated when inventory is started.

There are two primary modes for operation: Compa

Monitor : handle inventory service offline

Using nameHasOwner and nameOwnerChanged D-Bus signals, a callback is
activated when inventory is started.

There are two primary modes for operation: Compatible Interfaces, the
inventory-detection callback will fail, however start() will be called a
second time after EntityManager starts and forces a reload of the proper
config for the machine type. Separately, if no EntityManager exists,
then the callback for Inventory-detection will succeed and use the
default configuration file.

To test: stop fan monitor and inventory services. start monitor, wait
10s, start Inventory, after about 15s you should see the online
detection.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I289493a0aabb849abee8ce8de047513e94ee2219

show more ...

monitor: Add ignoring feedback sensors above allowed max

There may be situations where fan rotor feedback speeds above the
allowed range could be ignored, essentially ignoring any overspeed
detectio

monitor: Add ignoring feedback sensors above allowed max

There may be situations where fan rotor feedback speeds above the
allowed range could be ignored, essentially ignoring any overspeed
detections. This adds an optional `ignore_above_max` attribute to the
fan sensors that can be added, set to 'true', to ignore marking that fan
sensor as nonfunctional when its above the allowed max. Without this
attribute, the fan sensor must remain within the allowed min/max range
to be deemed functional. This is the default behavior.

Change-Id: I4876b4c1963a8a1becd55732ca19496f5df6b003
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

sdbusplus: remove usage of deprecated alias

The alias `server::match` has been deprecated since 2016. Use the new
alias under bus.

Change-Id: I21baf6b70401d996519b5940d0cd685535475a2f
Signed-off-b

sdbusplus: remove usage of deprecated alias

The alias `server::match` has been deprecated since 2016. Use the new
alias under bus.

Change-Id: I21baf6b70401d996519b5940d0cd685535475a2f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

monitor:p10bmc:ibm,rainier-2u: Functional fan range update

Update the allowed deviation of the fan speeds to be 18% and adjust the
factor and offset of the outlet(slower) rotor.

Change-Id: I491c00b

monitor:p10bmc:ibm,rainier-2u: Functional fan range update

Update the allowed deviation of the fan speeds to be 18% and adjust the
factor and offset of the outlet(slower) rotor.

Change-Id: I491c00ba7db422d4ff2f35431809b1e1267e4220
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

monitor:p10bmc: Add `set_func_on_present`

Utilize the `set_func_on_present` configuration attribute to have each
fan immediately marked functional upon presence being detected.

Signed-off-by: Matth

monitor:p10bmc: Add `set_func_on_present`

Utilize the `set_func_on_present` configuration attribute to have each
fan immediately marked functional upon presence being detected.

Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
Change-Id: Ib54aa6834ebf25f18cd956d0a9bc9590fca10365

show more ...

monitor:p10bmc: Set `num_sensors_nonfunc_for_fan_nonfunc` to 0

A separate application will be setting the fan FRU's functional state
based on when an error is logged for too many fan sensors being
n

monitor:p10bmc: Set `num_sensors_nonfunc_for_fan_nonfunc` to 0

A separate application will be setting the fan FRU's functional state
based on when an error is logged for too many fan sensors being
nonfunctional.

Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
Change-Id: Ie431a76363159dec6563e18583ad754775749a77

show more ...

monitor:config:ibm,rainier_2u: Update for MAX31785revB

The revB version of the MAX31785 fan controller is available now and
this update to the fan monitor config is necessary on Rainier 2U systems
t

monitor:config:ibm,rainier_2u: Update for MAX31785revB

The revB version of the MAX31785 fan controller is available now and
this update to the fan monitor config is necessary on Rainier 2U systems
to support revB with the latest fan hardware.

The sensor trust groups are no longer necessary with revB. The override
tool has been updated to modify this config for systems with revA to
include the sensor trust groups.

Change-Id: I10dd03c35d29b3c58d03589fc0583cb8de500d90
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id1b5054d3147c39d98309bc11ed7016d6909e2a6

Monitor - improved use of Inventory for Sensor func. state

When Monitor starts, Tach Sensors attempted to read their functional
state from inventory first. This fails on a genesis state and generate

Monitor - improved use of Inventory for Sensor func. state

When Monitor starts, Tach Sensors attempted to read their functional
state from inventory first. This fails on a genesis state and generates
a D-Bus exception what was previously indistinguishable from an
Inventory-service-not-running state. No functional record entries
existed for any sensors.

This change catches Inventory-offline exceptions separately from
invalid-records, so that the Inventory can be correctly established
during the genesis state.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I0c4a3f0453a05859d640fa299471d33fae3ade10

show more ...

Monitor: Support hwmon service offline during startup

It is possible for fan-monitor to startup before the Hwmonitor service,
causing unhandled exceptions that block system initialization. This fix

Monitor: Support hwmon service offline during startup

It is possible for fan-monitor to startup before the Hwmonitor service,
causing unhandled exceptions that block system initialization. This fix
catches the exception until a proper hwmon presence detector is
deployed.

If the exception is caught, this code change forces a re-subscription
during the poweron event to ensure tach sensors will receive published
updates upon resumption of the hwmon service.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I8e696e747c432d7a6f696c5ccd9dab73abf7708f

show more ...

monitor: Subscribe to tach target and feedback services

Subscribes to nameOwnerChanged signals for the services of the sensor
and target interfaces for each configured fan. If those services go
offl

monitor: Subscribe to tach target and feedback services

Subscribes to nameOwnerChanged signals for the services of the sensor
and target interfaces for each configured fan. If those services go
offline, the fan tach sensors should get marked nonfunctional due to no
longer receiving updated target or feedback values. In this design, we
use the existing method of determining when a fan tach sensor should be
marked nonfunctional to allow a recovery window, wherein a brief
offline/online transition (such as during a restart) will not trigger a
nonfunctional state change.

Change-Id: I0a935ccad5a864dc952d023185356a1ef1226830
Signed-off-by: Mike Capps <mikepcapps@gmail.com>

show more ...

monitor: Install JSON config files from repo

Install the JSON config files for the machine name provided in the
environment variable "MACHINE" into the application's data directory.
When no "MACHINE

monitor: Install JSON config files from repo

Install the JSON config files for the machine name provided in the
environment variable "MACHINE" into the application's data directory.
When no "MACHINE" name is given, the entire contents of the
`config_files` directory is installed and when a given "MACHINE" named
directory does not exist, the installation is intended to fail. This
failure of installation is to ensure that the fan application's
necessary JSON config files will exist so the fan application does not
fail to start.

Change-Id: Ife710869646ba227bd5cb429aeb5074dfd9bfb59
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

monitor: Add machine JSON config files

Add the known JSON config files that exist in the openbmc repository to
be installed for each machine.

Change-Id: Ic99e525ee3aaf542e5a8ff4c49383ddd50ee55c8
Si

monitor: Add machine JSON config files

Add the known JSON config files that exist in the openbmc repository to
be installed for each machine.

Change-Id: Ic99e525ee3aaf542e5a8ff4c49383ddd50ee55c8
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

monitor : do not trigger error when inventory unavailable

Under some startup scenarios, fan-monitor can start before the
InventoryManager service has populated inventory. This leads to
false-positiv

monitor : do not trigger error when inventory unavailable

Under some startup scenarios, fan-monitor can start before the
InventoryManager service has populated inventory. This leads to
false-positives when marking fans non-functional.

This fix detects D-Bus exceptions and defaults the fans to functional.
They subscribe to the interfaces-added signal which will populate the
fans with correct values as soon as Inventory Manager completes startup.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I14bff20da14cba3f5ef4b79763867b5cecab0267

show more ...