control:ibm,everest: Cutoff temp updates

Updates to the increase and decrease temps for 3 of the memory related
sensor groups.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ic9deccf1f

control:ibm,everest: Cutoff temp updates

Updates to the increase and decrease temps for 3 of the memory related
sensor groups.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ic9deccf1f7a83c6ea6796b2e2babf813280c58e6

show more ...

control:ibm,everest: Fix events.json line endings

Change them to unix line endings.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I5a2fae2fd83b1becfabd1cc8427e4b91e42c2ee5

control:ibm,everest: Update events.json

Several updates to the control config in events.json from thermal
testing.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I6da31c45b9472fcc63dff

control:ibm,everest: Update events.json

Several updates to the control config in events.json from thermal
testing.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I6da31c45b9472fcc63dff5677d807d73266a22ca

show more ...

control: Be more lenient toward missing sensors

In the cases where the service name of a sensor (i.e. group member) is
known ahead of time, but that service isn't actually running, the code
will try

control: Be more lenient toward missing sensors

In the cases where the service name of a sensor (i.e. group member) is
known ahead of time, but that service isn't actually running, the code
will try to make a get property call on it anyway and crash. Fix that
by catching the exception and continuing on.

Also, if the same type of service isn't running but is used in an action
that runs on a timer with 'preload_groups' set in the config to have the
code try to get all properties in the groups after each timer
expiration, there will be an exception thrown there too. In that case,
the exception is caught by the sdeventplus handler so the app doesn't
crash, but it prevents the run() call from completing. Catch that
exception as well in Manager::addGroups() so the actions can complete.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ifb56333508c3ceb6027e1e004d946c330dbd8634

show more ...

control: Increase flight recorder max entries

Double the number of entries per key from 20 to 40. Mostly this is for
capturing more target changes.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>

control: Increase flight recorder max entries

Double the number of entries per key from 20 to 40. Mostly this is for
capturing more target changes.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I6576dc1574f2db00d9753759cf5a37078168f76e

show more ...

control:configs: Add an intfs removed trigger

Add an interfaces_removed trigger to the action that sets fan floors
when sensors are nonfunctional so that it runs when the
OperationalStatus interface

control:configs: Add an intfs removed trigger

Add an interfaces_removed trigger to the action that sets fan floors
when sensors are nonfunctional so that it runs when the
OperationalStatus interface is removed from D-Bus.

This is necessary so that if the only non functional sensor is removed
the action will run and remove its floor hold.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I44b60d5087e3c48421c91246ccce8e48682f4005

show more ...

control: Add 'events' section to dump

Add an events section to the fan control dump that contains all of the
configured events with their contained action and group names.

Signed-off-by: Matt Spinl

control: Add 'events' section to dump

Add an events section to the fan control dump that contains all of the
configured events with their contained action and group names.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I8e9fa9ce975ac30837b0842908faeb63ddc31e2a

show more ...

control: Let Manager::addObjects() take a service

When calling Manager::addObjects(), pass in the service of the object,
if known, so that addObjects() can use that service to call
getManagedObjects

control: Let Manager::addObjects() take a service

When calling Manager::addObjects(), pass in the service of the object,
if known, so that addObjects() can use that service to call
getManagedObjects() with and add objects to the cache even if the
D-Bus path passed in doesn't exist.

This fixes a bug where if the path doesn't exist, that function won't
add anything at all, even though getProperties() in init.cpp was
depending on it doing that so that it only needed to call addObjects()
once per group as a performance enhancement.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I971a244d665d3aaf493c3d03e7a4fec87e7e512d

show more ...

control: Log target changes in flight recorder

With this there will be a history of how the fans were changing over
time. There's a 20 entry limit in the flight recorder so it will always
just show

control: Log target changes in flight recorder

With this there will be a history of how the fans were changing over
time. There's a 20 entry limit in the flight recorder so it will always
just show the 20 latest target changes.

Example:
zone-set-target0: Set target 10500 (from 11300)"

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I93b55eea5ef288bc069eb6c29a15770165067848

show more ...

control: count_state_target: Use default name

This action can just use the getUniqueName() from the base class to give
a more meaningful key name when shown in a dump:

"target_holds": {
"count_

control: count_state_target: Use default name

This action can just use the getUniqueName() from the base class to give
a more meaningful key name when shown in a dump:

"target_holds": {
"count_state_before_target-1(fan rotor(s) faulted)": 11300
}

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ia8e874ffd7a27ec239a4a2a082f616554f831af1

show more ...

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I54c31e5892def4ae3ed7898ebd5d04c3c91e1a49

show more ...

control:p10bmc:config:everest: Fan floor tables

Add the fan floor table config received from the thermal team. Also
update the maximimum fan speed on Everest to 11300.

Signed-off-by: Matt Spinler

control:p10bmc:config:everest: Fan floor tables

Add the fan floor table config received from the thermal team. Also
update the maximimum fan speed on Everest to 11300.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Id4352f596c3ae0ec92d4a4aba04dad1a1612f94b

show more ...

Use regular std::filesystem

Now that std::filesystem is available there's no need to use
std::experimental::filesystem.

Note the '/' operator does behave differently when the RHS is an
absolute pat

Use regular std::filesystem

Now that std::filesystem is available there's no need to use
std::experimental::filesystem.

Note the '/' operator does behave differently when the RHS is an
absolute path (starts with /), but none of the uses here make use of an
absolute path.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ice5ed7e85f6bf9c8355a66b5b00fe8550899a258

show more ...

control: Add event name to the action unique name

The unique name of an action was previously just <action name>-ID, where
ID was unique number. When there are multiple instances of an action,
it c

control: Add event name to the action unique name

The unique name of an action was previously just <action name>-ID, where
ID was unique number. When there are multiple instances of an action,
it can be difficult to tell which action is being referred to when it
shows up in the fan control dump in either the flight recorder or zones
section.

To fix this, add the name of the owning event to the action's name so
now it's <action name>-ID(event name). Here is an example from the fan
control dump now:

"floor_holds": {
"count_state_floor-4(Non-active OCCs)": 18000,
"mapped_floor-64(Fan floors)": 11200
}

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I879e05a05da50545319635e82cc9a2d9ebac6b82

show more ...

control:init trigger: Only call addObjects once

The 'init' trigger will attempt to add the D-Bus properties of all of
its group members to the objects cache with the Manager::addObjects()
function.

control:init trigger: Only call addObjects once

The 'init' trigger will attempt to add the D-Bus properties of all of
its group members to the objects cache with the Manager::addObjects()
function.

That function will call GetManagedObjects to add *all* group D-Bus
paths provided by the service that has the path/interface/property
passed in.

If the group had a service listed in its JSON configuration, then all
members of the group come from the same service, so we know the
first addObjects call would add all group members so there is no need to
keep calling it on the remaining members.

This can lead to a significant performance improvement on startup when
the D-Bus objects in the groups don't exist yet since it would end up
calling addObjects on each member which drives at least GetSubTree
mapper calls each time.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Icc27fdae922fa6f068cd72d9c2299451f768e7d6

show more ...

control: Don't cache non-group properties

The code was previously adding every single D-Bus
path/interface/property of a service when Manager::addObjects() was
being used to cache D-Bus property val

control: Don't cache non-group properties

The code was previously adding every single D-Bus
path/interface/property of a service when Manager::addObjects() was
being used to cache D-Bus property values. This was resulting in a lot
of extra items in the cache that fan control would never use.

To fix this, create a single static set of all of the D-Bus paths from
all of the Group objects, which would be the master list of all the
D-Bus paths fan control would ever care about. Then, only add a
path/interface/property to the cache if that path is in that set.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I787c9c36b88d003fe9fe7ac1d517fbb5aa510e4e

show more ...

control: Stop caching uninteresting service ifaces

In the code that adds the path/service/interface to the services cache,
there was one code path that would add every interface on the path to
the c

control: Stop caching uninteresting service ifaces

In the code that adds the path/service/interface to the services cache,
there was one code path that would add every interface on the path to
the cache map instead of just the service being requested. Change the
code to only add that single interface.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I5c3d03d2855c4506dcf58fd1d805f1ec9ae3c25a

show more ...

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7b9c5e7548be323b7b63da1cf5b5cdcc82c7d109

show more ...

control:p10bmc:rainier-4u/1s4u: Enable floor altitude offsets

Instead of having a static floor for different altitude ranges, have the
altitude provide an offset to the chosen floor per ambient rang

control:p10bmc:rainier-4u/1s4u: Enable floor altitude offsets

Instead of having a static floor for different altitude ranges, have the
altitude provide an offset to the chosen floor per ambient range. This
allows the thermal team to define the floors per ambient for a baseline
altitude point and then offset those floors by a set amount for some set
of difference in altitude from their baseline.

Included in this change, the altitude continues to be updated in fan
control when the fan control app starts and at any point it is added to
dbus, however it's now refreshed every 24hrs instead of thru properties
changed signals.

Change-Id: I5649c3e94bc0f180dfa7083f3c0ab5a4b9038f72
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control:p10bmc:rainier4u/1s4u: Thermal updates

Multiple updates provided by the thermal team including:

- Adjustments to 1s4u floors
- External memory buffer t-control updates
- 2s4u Haleakela floo

control:p10bmc:rainier4u/1s4u: Thermal updates

Multiple updates provided by the thermal team including:

- Adjustments to 1s4u floors
- External memory buffer t-control updates
- 2s4u Haleakela floor index change

Change-Id: I8e813e268b29cc5e3f45943bd8cfeee5cb2636e6
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control:p10bmc:rainier2u: PMICs & DRAMs t-controls -1C

Thermal has requested both t-control high and t-control low for the
PMICs and DRAMs be decreased by 1C.

Change-Id: I3e6d4ef89362a28a643004841b

control:p10bmc:rainier2u: PMICs & DRAMs t-controls -1C

Thermal has requested both t-control high and t-control low for the
PMICs and DRAMs be decreased by 1C.

Change-Id: I3e6d4ef89362a28a643004841bf57aea63a15b82
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control:p10bmc: Rename PCIe temp sensors: phase 2

The old Flett and cable card sensor names can now be removed since the
new ones are in everywhere.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>

control:p10bmc: Rename PCIe temp sensors: phase 2

The old Flett and cable card sensor names can now be removed since the
new ones are in everywhere.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I5adc7cf67175b2d68779a8438b5ef1fc8a6bc4dc

show more ...

control:p10bmc:rainier2u: Floor updates

Floor adjustments made by thermal team to accommodate the use of the
altitude offsets based on chamber testing.

Change-Id: I0d1f0752e25d15a821d95a4fe93530837

control:p10bmc:rainier2u: Floor updates

Floor adjustments made by thermal team to accommodate the use of the
altitude offsets based on chamber testing.

Change-Id: I0d1f0752e25d15a821d95a4fe935308377608135
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control:p10bmc:rainier2u: Enable floor altitude offsets

Instead of having a static floor for different altitude ranges, have the
altitude provide an offset to the chosen floor per ambient range. Thi

control:p10bmc:rainier2u: Enable floor altitude offsets

Instead of having a static floor for different altitude ranges, have the
altitude provide an offset to the chosen floor per ambient range. This
allows the thermal team to define the floors per ambient for a baseline
altitude point and then offset those floors by a set amount for some set
of difference in altitude from their baseline.

Included in this change, the altitude continues to be updated in fan
control when the fan control app starts and at any point it is added to
dbus, however it's now refreshed every 24hrs instead of thru properties
changed signals.

Change-Id: I2fc404849130633a927073aa440425b199a30909
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control:zone: Override floor to current ceiling

When a requested floor is above the currently set ceiling, override the
requested floor value with the current ceiling value. This ensures that
a floo

control:zone: Override floor to current ceiling

When a requested floor is above the currently set ceiling, override the
requested floor value with the current ceiling value. This ensures that
a floor is never above a set ceiling. If a floor is intended to be
higher than a current ceiling, then fan control must be configured to
change the ceiling value prior to the requested floor change being made.

Change-Id: I59daf32140d94a05a32652c4502b4a4ed5cb3fca
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...