control:p10bmc: Events to set DVFS temp params

Create the events that use the set_parameter_from_group_max action to
set parameters with the processor core and IO ring DVFS (Dynamic
Frequency and Vo

control:p10bmc: Events to set DVFS temp params

Create the events that use the set_parameter_from_group_max action to
set parameters with the processor core and IO ring DVFS (Dynamic
Frequency and Voltage Slewing) temperatures, minus 3 degrees.
Subtracting 3 degrees allows the fans to start increasing before the
DVFS kicks in. The value chosen is just a starting point.

Parameter names:
* proc_N_core_dvfs_temp
* proc_N_ioring_dvfs_temp

These parameters can then be used by the set_net_increase_target action
as the value to compare the actual temperatures against to know when to
start increasing fan targets.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I40320ef87b2e3ccd5ea6761b61b3c3fcc3f0b526

show more ...

control: set_parameter_from_group: handle no max

Handle the case where no members of the group have a value (i.e. they
aren't on D-Bus). In that case, remove that parameter from the
manager.

Chan

control: set_parameter_from_group: handle no max

Handle the case where no members of the group have a value (i.e. they
aren't on D-Bus). In that case, remove that parameter from the
manager.

Change-Id: Idc70d637b1031288fa9bf3a8f23cd7fca09ae8fb

show more ...

control: Change `addGroup()` to get all managed objects

The addGroup method is used to populate the cache with event groups
triggered by a timer when the "preload_groups" directive is used.
Instead

control: Change `addGroup()` to get all managed objects

The addGroup method is used to populate the cache with event groups
triggered by a timer when the "preload_groups" directive is used.
Instead of going out to dbus to refresh the cache for each group member,
use the ObjectManager interface to retrieve all the managed objects for
each unique service of the group members.

Change-Id: I61136409f035cd78a1762b4e22b00376e1cb4a43
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Support state parameter on net decrease target action

The net increase target action supports the use of a parameter to
determine the state at which group members must be at to request an
i

control: Support state parameter on net decrease target action

The net increase target action supports the use of a parameter to
determine the state at which group members must be at to request an
increase delta. The net decrease target action should also support the
use of a parameter to determine the state for decreases.

Change-Id: Ied883c70566b19bacfa1f76cc2a6c738c1cea85a
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control:p10bmc: Add processor `vdd vrm temps` groups

Change-Id: I2c5170cf9e0a5d892057bb43285977b6bb64ba38
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

control:p10bmc: Add all possible dimm temps groups

Change-Id: I10e86bfb7d5b0b6dd84d16562c315465368316b3
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

control:p10bmc: Add processor `ioring temp` groups

Change-Id: I35f490ae74f945205fbca530d79428649c46291e
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

control: Remove iostream include from get_managed_objects action

Change-Id: I8054e2f12d3324b918be5e3c5a204aa024adb5a1
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

control: Add zone ceiling to debug dump

Change-Id: I5e6e4b3de97a32aae0a21b7a201ec67f7b99239e
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

control:p10bmc: OCC inactive fan floor event

Set and hold a fan floor unless all OCCs are active.

Example of a boot with just this floor event:
zone-floor0: count_state_floor-2 is setting floor hol

control:p10bmc: OCC inactive fan floor event

Set and hold a fan floor unless all OCCs are active.

Example of a boot with just this floor event:
zone-floor0: count_state_floor-2 is setting floor hold to 10000",
zone-floor0: Setting new floor to 10000",
zone-floor0: count_state_floor-2 is removing floor hold",
zone-floor0: No set floor exists, using default floor"

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ia4521764130822c0962b8e2c7570f87bddf77b7e

show more ...

control: Create parameter trigger

Create a new event trigger that will run actions when a parameter is
either added, removed, or changed.

When the trigger is enabled it is added to the Manager clas

control: Create parameter trigger

Create a new event trigger that will run actions when a parameter is
either added, removed, or changed.

When the trigger is enabled it is added to the Manager class since that
is where parameters are stored, and then the Manager watches for
parameter changes and runs actions as needed.

The JSON config would look like:
{
"class": "parameter",
"parameter": "pcie_floor_index"
}

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I8ff281d49ac780e8ff38f3e8ed02ab95395f1fd3

show more ...

control:p10bmc: Add processor `core temps` groups

Change-Id: Ibc2dbe6de271391af9ba089a955e3aca3c101e95
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

control: get_managed_objects action

This new action adds all interfaces/properties in its groups into the
Manager's _objects cache, and then calls other actions.

It uses Manager::addObjects() which

control: get_managed_objects action

This new action adds all interfaces/properties in its groups into the
Manager's _objects cache, and then calls other actions.

It uses Manager::addObjects() which uses the GetManagedObjects
ObjectManager D-Bus method to obtain all properties provided by the
service, even ones not listed in a group.

This allows an action to run with the latest values in the cache without
having to subscribe to propertiesChanged for them all.

In the below example, the action will call the set_net_increase_target
after it's done populating the cache.

"actions": [
{
"name": "get_managed_objects",
"groups": [
{
"name": "the_temps",
"interface": "xyz.openbmc_project.Sensor.Value",
"property": {
"name": "Value"
}
}
],
"actions": [
{
"name": "set_net_increase_target",
"state": 30,
"delta": 100
}
]
}
]

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ic528392139904abd16181d85138395ccfd68a9a6

show more ...

control:p10bmc: Add missing `fan inventory`

When the change was made that events would only be triggered by the
groups configured on the events, the `fan inventory` group was missing
in the critical

control:p10bmc: Add missing `fan inventory`

When the change was made that events would only be triggered by the
groups configured on the events, the `fan inventory` group was missing
in the critical services event. This adds the `fan inventory` group to
trigger the critical services event when the `fan inventory` group's
service(s)' are no longer owned on dbus for 5sec.

Change-Id: Icad2a0e6f9cfbb4450606f5f62566de11295f4d7
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: remove NaN from D-Bus properties

When sensors are offline, its possible for some driver parameters to
appear as NaN. These values are prevented from being stored in fan
control and are remo

control: remove NaN from D-Bus properties

When sensors are offline, its possible for some driver parameters to
appear as NaN. These values are prevented from being stored in fan
control and are removed if they are detected in the cache.

Signed-off-by: Mike Capps <mikepcapps@gmail.com>
Change-Id: I22aa0c551faffdfc83eb1992b1242ac477d08180

show more ...

sdbusplus: remove usage of deprecated alias

The alias `server::match` has been deprecated since 2016. Use the new
alias under bus.

Change-Id: I21baf6b70401d996519b5940d0cd685535475a2f
Signed-off-b

sdbusplus: remove usage of deprecated alias

The alias `server::match` has been deprecated since 2016. Use the new
alias under bus.

Change-Id: I21baf6b70401d996519b5940d0cd685535475a2f
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

control: Correct same signal object subscription of actions

When the same signal for a signal object is subscribed to (such as
across events), the actions should be included on the list of actions t

control: Correct same signal object subscription of actions

When the same signal for a signal object is subscribed to (such as
across events), the actions should be included on the list of actions to
be called when that specific signal is received. Previously these
actions were being moved off the event's list of actions, which was not
ideal. This instead copies a reference to the event's list of actions to
the list of actions to be called when the particular signal is received.

Change-Id: I260f7134a67ec82f9e90a66c4cfe9189ca7d4304
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: Correct subscribing/handling of signals

When subscribing to signals, a pointer to the signal packages should be
used for the location to store the list of signal packages. This way the
call

control: Correct subscribing/handling of signals

When subscribing to signals, a pointer to the signal packages should be
used for the location to store the list of signal packages. This way the
callback is bound to the pointer and not the local variable that was
then getting moved.

Also, in handling signal messages, since there could be more than one
signal package to check against the signal received, a rewind must be
done to the signal message so that additional signal packages can read
the message contents again.

Change-Id: Iddea2011d25068d6f71bdee91801537cd5994728
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

control: mapped_floor: Allow missing parameters

If the mapped_floor actions is configured to use a parameter, and that
parameter is missing, then simply skip that floor table entry and
continue on i

control: mapped_floor: Allow missing parameters

If the mapped_floor actions is configured to use a parameter, and that
parameter is missing, then simply skip that floor table entry and
continue on instead of forcing the floor to the default.

Other actions may remove the parameter from the manager when it no
longer applies, such as when there are no PCIe cards present so the
floor doesn't need to depend on PCIe cards.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Ia4a01e36c57c1731c0bb0fa245a2ec46e1522dec

show more ...

control: Fix typo in Manager::dumpCache

The typo was hardcoding the JSON key name to "name" instead of the
actual parameter name in the parameters section.

Signed-off-by: Matt Spinler <spinler@us.i

control: Fix typo in Manager::dumpCache

The typo was hardcoding the JSON key name to "name" instead of the
actual parameter name in the parameters section.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I09ea10fe70602e4d3054fd63a6601317298d5726

show more ...

control: fanctl query dump: Deal with arrays

The existing fanctl query_dump code was expecting the JSON it was
dealing with to be an object and not an array. When the JSON was an
array it would conv

control: fanctl query dump: Deal with arrays

The existing fanctl query_dump code was expecting the JSON it was
dealing with to be an object and not an array. When the JSON was an
array it would convert it into an object, which could change the entry
ordering.

To fix it, specifically check for the array type and use the '--name'
parameter to match on text in the array.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: Id1dc1c5b3516c5ffe00484012d72464e1058ec8e

show more ...

control: Have iA match use arg0Path param

InterfacesAdded signals are sent from the path the ObjectManager is
implemented on, and the path that has the new interface is in the first
argument of the

control: Have iA match use arg0Path param

InterfacesAdded signals are sent from the path the ObjectManager is
implemented on, and the path that has the new interface is in the first
argument of the signal.

For example, this dbus-monitor output:
path=/org/open_power/control;
interface=org.freedesktop.DBus.ObjectManager;
member=InterfacesAdded
object path "/org/open_power/control/occ1"

Update the match string for this signal to match on the group member
using 'arg0path' (the .../occ1 entry above) instead of 'path' (the
/org/open_power/control entry).

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: If22157aa863504415f771aa366bc45b0e91405d7

show more ...

control: Manager::addServices() fix

In Manager::addServices(), when adding a new path into the service tree,
add all services on that path with the requested interface as opposed to
just the first.

control: Manager::addServices() fix

In Manager::addServices(), when adding a new path into the service tree,
add all services on that path with the requested interface as opposed to
just the first.

Change-Id: If10930a271e94ecadc434bff25f284917884769f

show more ...

control: Subscribe to nameOwnerChanged once per service

When more than one member of an event group's service is the same,
there's no need to subscribe to the nameOwnerChanged signal again for
the s

control: Subscribe to nameOwnerChanged once per service

When more than one member of an event group's service is the same,
there's no need to subscribe to the nameOwnerChanged signal again for
the same service. This was causing the same actions that the first
subscription already moved into the list of actions for this signal to
be "moved" again which is not possible nor what should be done since
those same actions were already associated to the signal.

Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
Change-Id: Idfc1da551cbdf8ca2e1697c02c408d3ed51bc31f

show more ...

control:fanctl: `reload` option only for JSON

Similar to how the `dump` option is completely removed when not JSON
configuration based, only show the `reload` option when JSON is enabled.
There is n

control:fanctl: `reload` option only for JSON

Similar to how the `dump` option is completely removed when not JSON
configuration based, only show the `reload` option when JSON is enabled.
There is no support for reloading a YAML based configuration, so this
change removes the `reload` option over the previous error message that
was returned.

Signed-off-by: Matthew Barth <msbarth@us.ibm.com>
Change-Id: Idab7903edf429051b80d4a766fd8201514663eb6

show more ...