Remove unused DumpType from Notify implementation.

Each type of dump is hosted in its own service so DumpType
is no more needed to differentiate between dumps in Notify.
So removing from implementat

Remove unused DumpType from Notify implementation.

Each type of dump is hosted in its own service so DumpType
is no more needed to differentiate between dumps in Notify.
So removing from implementation to match the interface.

Changes are tested with creation of a system dump.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: Ib34b2235f7b7a6331e52f3dc55660bd6082aa29a

show more ...

Update createDump to accept additional parameters

Updating create dump implementation to match the change
in the interface to accept the additional parameters.

Testing:
Created BMC dump
Creat

Update createDump to accept additional parameters

Updating create dump implementation to match the change
in the interface to accept the additional parameters.

Testing:
Created BMC dump
Created system dump

Dbus changes associated with this:
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/37355

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I1402a9c4c8e0e5c6277055d835f7d024673831d8

show more ...

host: Added support to delete system dump

To delete host system dump using pldm oem command "FileAck" with
dump file type and dump id which is present as source dump id (which
is got from pldm after

host: Added support to delete system dump

To delete host system dump using pldm oem command "FileAck" with
dump file type and dump id which is present as source dump id (which
is got from pldm after created the host system dump) in system dump entry
dbus object and also, to use pldm oem command added support to indicate
delete host system dump support is not available for other host transport
consumer and for other oem vendors who are using pldm as host transport
to get host dump.

Also, changed existing commited error i.e internal failure into not allowed
for host system dump offload to avoid bmc dump creation in dump path.

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: Ib6be5b521fb3c5aa2926497bae0b03c1d9737161

show more ...

ibm-host-system-dump-offload: Used CustomFd

Used "CustomFd" class instead closeFD() to avoid call in requried place
for close fd.

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: Id2107

ibm-host-system-dump-offload: Used CustomFd

Used "CustomFd" class instead closeFD() to avoid call in requried place
for close fd.

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: Id210713e4ae67495ee504fab47067c8a5643c930

show more ...

offload: Moved existing pldm offload as oem/ibm command

Currently used host mctp end point id is ibm specific and also
the used effecter id (0x05) is for phyp and "SetNumericEffecterValue"
pldm comm

offload: Moved existing pldm offload as oem/ibm command

Currently used host mctp end point id is ibm specific and also
the used effecter id (0x05) is for phyp and "SetNumericEffecterValue"
pldm command is common so, changing existing pldm offload implementation
into oem based and added default pldm offload interface as well.

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: I8a401e03d29f9245dd54577b8b7b1d87d4a13d18

show more ...

host-dump: Renamed host-dump-offload-transport build option

Currently dump manager using "host-dump-offload-transport" to mention
the transport protocol name to offload host dumps but, same transpor

host-dump: Renamed host-dump-offload-transport build option

Currently dump manager using "host-dump-offload-transport" to mention
the transport protocol name to offload host dumps but, same transport
can use to other actions i.e create and delete. So, Changing build option
name into "host-transport" to make generic.

Also, transport code sources files are organized based on "offload" name
so, changed same as "host-transport".

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: I9e229218ea8c606e7092daf4d24fd6d16eb425c8

show more ...

Progress tracking support for dump entries.

A new attribute status is added which indicates the status of the
dump creation. The user requested dump entries will be created
with InProgress and updat

Progress tracking support for dump entries.

A new attribute status is added which indicates the status of the
dump creation. The user requested dump entries will be created
with InProgress and updated to Completed once the dump creation
is completed

Test: Request user initiated BMC and system dump and
make sure the progress is changing and the dump details
are updated correctly

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I68e25c865765dff97913af00bf89c8c3a4b65d43

show more ...

Return the object path for user requested dumps.

Return the object path to a dump entry for the user requested
dump. A dump entry will be created when the user request for
the dump and that will be

Return the object path for user requested dumps.

Return the object path to a dump entry for the user requested
dump. A dump entry will be created when the user request for
the dump and that will be used for tracking the progress.
The dump details like size etc will be empty and the complete
details will be filled once the dump creation is completed.

Executed current BMC and system dump test cases on a test build
- Create BMC dump
- List All dumps
- Offload BMC dump
- Delete BMC dump
- Create manual system dump.
- Attempt to offload dump.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I89b252e2731f4f1fb924d26c7ac05999341fc691

show more ...

Modify dump offload method to write dump on to unix socket path

This commit enables bmc dump offload through unix socket
On dump offload request, dump manager setup unix socket and
writes data on un

Modify dump offload method to write dump on to unix socket path

This commit enables bmc dump offload through unix socket
On dump offload request, dump manager setup unix socket and
writes data on unix socket, on other end bmcweb connects to
this socket and get this data offloaded to client.

Tested By:
Ran BMC Dump offload and verified content

Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>
Change-Id: I9ce558778a73cf33b3f65a002490d3ad01fe75f3

show more ...

Make OpenPower specific dump an optional feature

Make all OpenPower dumps as optional feature and should be
enabled in the configuration. System dump is the currently
implemented example of OpenPowe

Make OpenPower specific dump an optional feature

Make all OpenPower dumps as optional feature and should be
enabled in the configuration. System dump is the currently
implemented example of OpenPower dump. BMC dump will be
enabled by default.

To enable
openpower-dumps-extension=enabled

Test:
Tested all existing dump operations using automated
testing.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: If20b4711dfcf02a2a8ea23848f7409576813c832

show more ...

Creating dump header for IBM systems

-Adding dump header script:
-Changes are related to IBM specific systems only, no
impact on the existing dump package format without
dump header. In package func

Creating dump header for IBM systems

-Adding dump header script:
-Changes are related to IBM specific systems only, no
impact on the existing dump package format without
dump header. In package function only for IBM systems
the generated header will be added to the dump, for
remaining systems the existing dump format remains same.
-Adding dump header which will be added on top of the
the <obmc file>.tar.xz, only on IBM systems

Note: If user wants to extract the dump, they need to remove
the header from the dump using dd command.
Example
dd bs=628 skip=1 if=<input_dump_file> of=<output_file>

Result:
Tested the dump header using busctl command and dreport script.
Able to add dump header on top of the <obmcdump>.tar.xz file.

Separated out the header from the output file using dd command:
dd bs=628 skip=1 if=<obmc dump>.tar.xz of=openbmc.tar.xz

The new output file doesn't have the header now and can be unzipped.
Post unzipping the files in the dump can be seen.

hexdump ooutput of the dump header:-
00000000 46 49 4c 45 20 20 20 20 00 40 00 00 00 00 00 00 |FILE .@......|
00000010 00 00 00 00 00 01 00 0f 42 4d 50 44 55 4d 50 2e |........BMPDUMP.|
00000020 53 49 4d 50 31 30 52 2e 30 30 30 30 30 30 30 36 |SIMP10R.00000006|
00000030 2e 32 30 32 30 30 39 32 39 31 31 31 30 34 33 00 |.20200929111043.|
00000040 53 45 43 54 49 4f 4e 20 00 30 00 00 00 00 00 00 |SECTION .0......|
00000050 00 00 00 01 00 02 00 00 00 00 00 00 00 02 ad dc |................|
00000060 42 4d 43 44 55 4d 50 00 00 00 00 00 00 00 00 00 |BMCDUMP.........|
00000070 42 4d 43 20 44 55 4d 50 00 00 00 00 00 00 00 00 |BMC DUMP........|
00000080 00 00 00 00 02 10 02 00 00 00 00 00 00 02 ad dc |................|
00000090 39 31 30 35 2d 32 32 41 00 00 00 00 00 00 00 00 |9105-22A........|
000000a0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
000000b0 53 65 72 76 65 72 2d 39 31 30 35 2d 32 32 41 2d |Server-9105-22A-|
000000c0 53 4e 2d 53 49 4d 50 31 30 52 00 00 00 00 00 00 |SN-SIMP10R......|
000000d0 00 53 49 4d 50 31 30 52 00 00 00 00 00 70 00 00 |.SIMP10R.....p..|
000000e0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
00000270 01 01 00 00 fd 37 7a 58 5a 00 00 04 e6 d6 b4 46 |.....7zXZ......F|

Signed-off-by: Chirag Sharma <chirshar@in.ibm.com>
Change-Id: I27bffdd96a6da0777d88e3c7f93eee92cffbfd6e

show more ...

Implement user requested system dump.

Add method to set the diag mode target to start the creation of
user requested system dump.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Cha

Implement user requested system dump.

Add method to set the diag mode target to start the creation of
user requested system dump.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: Id4986b615133db575767956d435e6a14faa147b8

show more ...

Create dump manager for each dump type.

Currently all types of dumps exist in the same path
and under the single dump manager. When there are
multiple dumps to be created separate path is needed
for

Create dump manager for each dump type.

Currently all types of dumps exist in the same path
and under the single dump manager. When there are
multiple dumps to be created separate path is needed
for creating and managing the dump. this commit
is splitting the dump manager into multiple objects
without adding any new functionality. There will be
only one dump manager process but it will contain
seperate dump manager objects for system and BMC
dumps as per current scope.

Tested the existing dump functions with the build
- created bmc dump
- created system dump using notify
- deleted dump entry
- offloaded bmc dump

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: Id4806660be1f1ba0b3cb6f840ae185a967f05a83

show more ...

Fix shellcheck errors in dreport

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I64e9de12b9e8c71fc501936a39926388729fb370

Unit test framework for phosphor-debug-collector

Change:
-Serialize method does not use any of the watch functionalities,
so defining set in serialization header as using watch header
creates unnece

Unit test framework for phosphor-debug-collector

Change:
-Serialize method does not use any of the watch functionalities,
so defining set in serialization header as using watch header
creates unnecessary dependency.

Test:
Added 3 test cases related to dump serialization.
Ran the UTs on docker environment.

Result:
1/1 debug_inif_test OK 1.48s

Ok: 1
Expected Fail: 0
Fail: 0
Unexpected Pass: 0
Skipped: 0
Timeout: 0

Signed-off-by: Chirag Sharma <chirshar@in.ibm.com>
Change-Id: I6a88559bf407fa70a96dda3b31aaa1acd038c958

show more ...

build: Removed autotools support

Removing autotools build infrastructure because, phosphor-debug-collector
will support meson build tool so, maintaining two build tool is
unnecessary so, removed.

S

build: Removed autotools support

Removing autotools build infrastructure because, phosphor-debug-collector
will support meson build tool so, maintaining two build tool is
unnecessary so, removed.

Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>
Change-Id: Ie6edf6d06ac11274d5925baa5054cbd8f670f791

show more ...

build: Enabled meson build infrastructure

In this commit enabled meson build infrastructure which is taking less
time than autotools to build.

Changes:
- Same default value used for all build tim

build: Enabled meson build infrastructure

In this commit enabled meson build infrastructure which is taking less
time than autotools to build.

Changes:
- Same default value used for all build time configure option.
- All external library checks are added into meson as well.
- In meson, no need to mention list of files which are not required
to install because, by default nothing will be installed.
- Auto generated files are added into custom target and that will
trigger when some target dependent with that.
- In meson, enabled to treat warning as error so, modified few sources
which are producing un-used variables.
- Fixes made by removing those function parameters identifier alone.

By using meson, can able to see below built improvement time between meson
and autotools.

meson:
- time sh -c 'meson builddir -Dhost-dump-offload-transport=pldm
-Dubifs-workaround=enabled; ninja -C builddir/'
real 0m12.244s
user 0m57.575s
sys 0m7.793s

autotools:
- time sh -c 'autoreconf -i;
./configure ${CONFIGURE_FLAGS} --enable-ubifs-workaround
--with-host-dump-offload-transport=pldm; make'
real 1m16.539s
user 1m2.738s
sys 0m9.645s

TestedBy:
- meson builddir
ninja -C builddir

- meson builddir -Dubifs-workaround=enabled
ninja -C builddir

- meson builddir -Dubifs-workaround=disabled
ninja -C builddir

- meson builddir -Dhost-dump-offload-transport=pldm
ninja -C builddir

- meson builddir -Dhost-dump-offload-transport=pldm \
-Dubifs-workaround=enabled
ninja -C builddir

Note: Need to update openbmc phosphor-debug-collector recipe to use meson
instead autotools, this will be updated once this patch got merged
and also autotools build infrastructure will be removed as well.

Change-Id: Iadf2d3542dc2556377e7b2f91f01b04d5f8d7218
Signed-off-by: Ramesh Iyyar <rameshi1@in.ibm.com>

show more ...

plugins/hostlogger: Replace dbus call with signal

The latest version of the Hostlogger supports multi-host mode, each host
is served by a separate service instance.
The service instance now uses SIG

plugins/hostlogger: Replace dbus call with signal

The latest version of the Hostlogger supports multi-host mode, each host
is served by a separate service instance.
The service instance now uses SIG_USR1 signal to flush collected messages
to a file.

Tested: Run dreport inside the BMC console, the result dump archive
contains host console logs.

Change-Id: I2ba926dad79b362d0f4abac50619d7969a4f28f7
Signed-off-by: Artem Senichev <a.senichev@yadro.com>
Tested-by: Artem Senichev <a.senichev@yadro.com>

show more ...

Changes in dreport to accept /tmp/ as a valid dir

In the dreport script there is a condition which checks for
'/tmp' only. When the user passes directory as '/tmp/' this
check fails. As a result the

Changes in dreport to accept /tmp/ as a valid dir

In the dreport script there is a condition which checks for
'/tmp' only. When the user passes directory as '/tmp/' this
check fails. As a result the overall operation fails.
This commit fixes this by treating '/tmp/' as a valid directory.

Signed-off-by: Chirag Sharma <chirshar@in.ibm.com>
Change-Id: Ie11f96f0ff71bfb1fa4fedc59c40d8191116c5c6

show more ...

Enable the BMC dump offload through given URI

Add the support for reading the dump and writing to the
path provided. The supported for writing the BMC dump
is added.
Tested using offloading a BMC du

Enable the BMC dump offload through given URI

Add the support for reading the dump and writing to the
path provided. The supported for writing the BMC dump
is added.
Tested using offloading a BMC dump to a remote system
using NBD.

Change-Id: I5250b41ed162905548a7d522b9dc86533d0a9a83
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Fix blocking SIGCHLD

Unblocking the `SIGCHLD` signal before the child process completes
prevents the `callback()` from being ever called.

This commit makes the blocking `SIGCHLD` once for the whole

Fix blocking SIGCHLD

Unblocking the `SIGCHLD` signal before the child process completes
prevents the `callback()` from being ever called.

This commit makes the blocking `SIGCHLD` once for the whole main process
life by moving the corresponding code block to the main().

Tested: `callback()` now called when the child process completes.

Change-Id: I553c683e5dfcbc0b33c72aa2d7b394f689772966
Signed-off-by: Alexander Filippov <a.filippov@yadro.com>

show more ...

Block SIGCHLD before calling sd_event_add_child

Based on the documentation sd_event_add_child will return
EBUSY if the SIGCHLD is not blocked, so adding the code
to block the SIGCHLD

Testing:

Block SIGCHLD before calling sd_event_add_child

Based on the documentation sd_event_add_child will return
EBUSY if the SIGCHLD is not blocked, so adding the code
to block the SIGCHLD

Testing:
Without the patch CreateDump will fail and with the fix
the CreateDump is working

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I33f250bdb472dca08588c48ffa663d561bc2bc84

show more ...

sdbusplus: replace message::variant with std::variant

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I927996a9ce14cfb6251c6d7a1d8be081d9369174

sdbusplus: remove deprecated variant_ns

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9e4cfb1c3632a3b26f197a0af2e417e9824f7e72

ensure deleted object is entry

Some code is coming that puts a new D-Bus object on the
/xyz/openbmc_project/logging/ path. The addCallback() interface
correctly verified the path was an entry but th

ensure deleted object is entry

Some code is coming that puts a new D-Bus object on the
/xyz/openbmc_project/logging/ path. The addCallback() interface
correctly verified the path was an entry but the delCallBack() path did
not.

Tested:
Verified with this change that phosphor-dump-manager no longer core
dumps when one of these new objects is deleted.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ie702e52b97bc484a44543719e10eab573f8ecb73

show more ...