sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.

sdbusplus: object: don't use 'bool' argument constructor

`sdbusplus::server::object_t` has long had an enum-based parameter for
signal action, but maintained a backwards compatible boolean mapping.
It is time to remove this boolean to make it more observable which
actions are being used in applications. Map all `true` occurrences to
`action::defer_emit` or `action::emit_no_signals` as appropriate.

- DumpEntry: emit_no_signals (secondary object)
- {bmc,resource,system}::DumpEntry: defer_emit (primary object)
- Manager: defer_emit (primary object)

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I91990031384230550903a46332adc04d691a3cb9

show more ...

main: move busname claiming later

We should not claim the bus name until the daemon is fully initialized,
especially because we create objects on the dbus that we don't send a
signal for (the manage

main: move busname claiming later

We should not claim the bus name until the daemon is fully initialized,
especially because we create objects on the dbus that we don't send a
signal for (the manager itself).

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I303fa9a4ab40c93996f9ad64afdc85147c034c86

show more ...

openpower:dreport: add core and BMC generated dump file list to the BMC dump

List all the dump file names with path and append the output file to
BMC dump.

Tested
[core files]

[BMC dumps]
/var/lib

openpower:dreport: add core and BMC generated dump file list to the BMC dump

List all the dump file names with path and append the output file to
BMC dump.

Tested
[core files]

[BMC dumps]
/var/lib/phosphor-debug-collector/dumps/23/BMCDUMP.13E8CEX.00000023.20220328231804
/var/lib/phosphor-debug-collector/dumps/24/BMCDUMP.13E8CEX.00000024.20220329045155

[Hardware dumps]

[Hostboot dumps]

[SBE dumps]

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: Iac5f0e6d542ba1fa5b18b5c9399ee7537e05e274

show more ...

dreport: add active services (systemd) status to the BMC dump

Generate the status of the active services "systemctl status --all"
and add it to the dump.

Tested:
State: degraded
Jobs: 0 qu

dreport: add active services (systemd) status to the BMC dump

Generate the status of the active services "systemctl status --all"
and add it to the dump.

Tested:
State: degraded
Jobs: 0 queued
Failed: 3 units
Since: Wed 2022-03-30 03:17:48 UTC; 7min ago
CGroup: /
├─sys-kernel-debug.mount
├─sys-kernel-config.mount

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I45cef0ccfd4c86711a64bf5dcacb04f89bc5b50d

show more ...

openpower:dreport: add PHAL device tree debug data to BMC dump

1. Generate attribute list to a file and append the file to
the dump.

2. Append the device tree blob file to the dump

3. Append expor

openpower:dreport: add PHAL device tree debug data to BMC dump

1. Generate attribute list to a file and append the file to
the dump.

2. Append the device tree blob file to the dump

3. Append export device tree file to the dump

4. Append attributes_info.db file to the dump

Tested
root@ever8bmc:/tmp/test/obmcdump_00000000_1648657576# ls -lah DEVTREE
-r--r----- 1 root root 840.0K Mar 30 16:26 DEVTREE
root@ever8bmc:/tmp/test/obmcdump_00000000_1648657576# ls -lah attributes_info.db
-rw-r--r-- 1 root root 10.4K Mar 30 16:26 attributes_info.db
root@ever8bmc:/tmp/test/obmcdump_00000000_1648657576# ls -lah PHAL_devtree.txt
-rw-r--r-- 1 root root 2.2M Mar 30 16:26 PHAL_devtree.txt

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I3b60f136e04be2ed44349c9c91fe3858dd78a91a

show more ...

dreport: add hwmon details to the BMC dump

Copy the hwmon details from /sys/class/hwmon/* to hwmon.log
and append the file to the BMC dump

Tested:
/sys/class/hwmon/hwmon0/in1_max_alarm: 0
/sys/clas

dreport: add hwmon details to the BMC dump

Copy the hwmon details from /sys/class/hwmon/* to hwmon.log
and append the file to the BMC dump

Tested:
/sys/class/hwmon/hwmon0/in1_max_alarm: 0
/sys/class/hwmon/hwmon0/curr2_crit_alarm: 0
/sys/class/hwmon/hwmon0/temp5_crit: -500

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I20a2f20323a9d5095eac0cede46595a2e011ba9f

show more ...

dreport: add active file descriptors list to the BMC dump

List all the active file descriptors to procfd.log and
append the file to the BMC dump

Tested:
cat procfd.log
/proc/1/fd/:
lrwx------ 1

dreport: add active file descriptors list to the BMC dump

List all the active file descriptors to procfd.log and
append the file to the BMC dump

Tested:
cat procfd.log
/proc/1/fd/:
lrwx------ 1 root root 64 Mar 25 11:05 0 -> /dev/null
lrwx------ 1 root root 64 Mar 25 11:05 1 -> /dev/null

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I412abade104e5685a42150036e5149dadc94b3e7

show more ...

openpower:dreport: add obmconsole1 log file to the BMC dump

Add the host console log to the BMC dump.

Tested:
root@xxxxbmc:/tmp/test/obmcdump_00000000_1648205747# cat obmc-console1.log
0B6EB088 "FC

openpower:dreport: add obmconsole1 log file to the BMC dump

Add the host console log to the BMC dump.

Tested:
root@xxxxbmc:/tmp/test/obmcdump_00000000_1648205747# cat obmc-console1.log
0B6EB088 "FC" 000000000053000B
1599.92700|1329 SBEIO|trace_lite 15FEB01A 0000000000000001 0000000000000004 0

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: Ia2f0bb8a89d4e2a9d7249fd6e8d7efa6194f1542

show more ...

dreport: add fanctl dump output to BMC dump

Execute "fanctl dump" command and append the output json
file to the BMC dump.

Tested:
Fan control dump written to: /tmp/fan_control_dump.json
{
"fli

dreport: add fanctl dump output to BMC dump

Execute "fanctl dump" command and append the output json
file to the BMC dump.

Tested:
Fan control dump written to: /tmp/fan_control_dump.json
{
"flight_recorder": [
"Mar 24 14:12:55.323331: main: Startup",
.
.
.

}

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I52e972382f9e9c2aabab8c9034fd4da7775203e5

show more ...

dreport: Add time and date to the BMC dump

Execute the script and append the output log file to BMC dump.

[timedatectl]
Local time: Thu 2022-03-24 10:28:17 UTC
Universal t

dreport: Add time and date to the BMC dump

Execute the script and append the output log file to BMC dump.

[timedatectl]
Local time: Thu 2022-03-24 10:28:17 UTC
Universal time: Thu 2022-03-24 10:28:17 UTC
RTC time: Thu 2022-03-24 10:28:17
Time zone: UTC (UTC, +0000)
System clock synchronized: no
NTP service: active
RTC in local TZ: no

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: Ie1ac4e730d93d1959b2543de00b98c7513552560

show more ...

dreport: add network details to the BMC dump

Captured below information and add it to the BMC dump

1) Adding route info the network.log file
2) Adding contents of eth0 and eth1 to the network.log f

dreport: add network details to the BMC dump

Captured below information and add it to the BMC dump

1) Adding route info the network.log file
2) Adding contents of eth0 and eth1 to the network.log file
3) Add network interface statistics to the network.log file
4) Add active TCP connection details to the network.log file

Append network.log to the BMC dump

Tested:
[route]
Kernel IP routing table
Destination Gateway Genmask Flags Metric Ref Use Iface
default x.x.xx.x 0.0.0.0 UG 0 0 0 eth1
default x.x.xx.x 0.0.0.0 UG 0 0 0 eth0
x.x.xx.0 * 255.255.255.0 U 0 0 0 eth0

[eth0]
[Match]
Name=eth0
[Link]
MACAddress=xx:xx:xx:xx:xx:xx
[Network]
LinkLocalAddressing=no
IPv6AcceptRA=false
DHCP=ipv6
[Address]
Address=x.x.xx.xxx/xx
[Route]
Gateway=x.x.xx.x
[DHCP]
ClientIdentifier=mac
UseDNS=true
UseNTP=true
UseHostname=true
SendHostname=true

[eth1]
[Match]
Name=eth1
[Link]
MACAddress=xx:xx:xx:xx:xx:xx
[Network]
LinkLocalAddressing=no
IPv6AcceptRA=false
DHCP=true
[Route]
Gateway=x.x.xx.x
[DHCP]
ClientIdentifier=mac
UseDNS=true
UseNTP=true
UseHostname=true
SendHostname=true

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I8325b18400140f8f6e1463a5abbc1b9c526fad99

show more ...

Fix the invalid value of Elapsed property

The Elapsed property is described in microseconds in the interface but the result value is in seconds before

Tested:
1. get the property by this: busctl in

Fix the invalid value of Elapsed property

The Elapsed property is described in microseconds in the interface but the result value is in seconds before

Tested:
1. get the property by this: busctl introspect xyz.openbmc_project.Dump.Manager /xyz/openbmc_project/dump/bm:c/entry/20 xyz.openbmc_project.Time.EpochTime
2. check the value
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.Elapsed property t 1645758497000000 emits-change writable

Change-Id: Ib6cd5261c4cd6ac7de239f291a9f5fb556b29e89
Signed-off-by: Xie Ning <xiening.xll@bytedance.com>

show more ...

dreport: Added error handling support in badvpd

This is to fix below error message in the journal logs.
cp: can't stat '/tmp/bad-vpd': No such file or directory

"bad-vpd" is an optional file create

dreport: Added error handling support in badvpd

This is to fix below error message in the journal logs.
cp: can't stat '/tmp/bad-vpd': No such file or directory

"bad-vpd" is an optional file created vpd, to store the
failing data.

Tested: verified using dreport command line tool
"INFO: No Bad VPD data"

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I56854c044d5479f48669736204d9b929fc5d8db5

show more ...

dreport: Added dmesginfo plugin

Plugin used for collecting dmesg log

Tested: verified using dreport

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: If374c7c3a5d861bc6d562f2e23b428

dreport: Added dmesginfo plugin

Plugin used for collecting dmesg log

Tested: verified using dreport

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: If374c7c3a5d861bc6d562f2e23b4287ad1bb979e

show more ...

dreport: Added pldmflightrecorder plugin

Plugin used for collecting pldm flight recorder

Tested: verified using dreport

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I49f5a06507

dreport: Added pldmflightrecorder plugin

Plugin used for collecting pldm flight recorder

Tested: verified using dreport

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I49f5a06507593fc6dc07a2ae3d0e36891d176dfc

show more ...

dreport: fix symlinks copy

Added -L option during directory copy to always
follow symbolic links in SOURCE.

Tested: Verified using dreport.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Ch

dreport: fix symlinks copy

Added -L option during directory copy to always
follow symbolic links in SOURCE.

Tested: Verified using dreport.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I65312424591ab4c29ef89df403dbdf999b3b6fa7

show more ...

dreport: fix missing log messages related to skipping copy

Existing add_copy_file function not logging "skipping copy"
warning message incase dump size is reached to max size.

This message logging

dreport: fix missing log messages related to skipping copy

Existing add_copy_file function not logging "skipping copy"
warning message incase dump size is reached to max size.

This message logging problem is fixed by call log function
prior to return call.

Tested: verified using dreport tool

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I98ebe43e455e9b4cb93a102b7eb27e2a0f677309

show more ...

Remove host running check for system dump

The check for host running was added for the
operations on the dumps stored in the host
but in the case of request for offload The system dump
is ready to o

Remove host running check for system dump

The check for host running was added for the
operations on the dumps stored in the host
but in the case of request for offload The system dump
is ready to offload as soon as it is ready in the host.
The state of the host in the BMC may not be updated by
then, so it is not reliable to depend on the host state
in the BMC and if the host is not ready there will be an
error from PLDM.

This commit is for removing the host running check before
sending the initiate offload request to host. The check
for other operations like delete or initiate will not
be impacted

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I665485c7605b54fe4f361ec73e2bff9bba87c49e

show more ...

Add OWNERS file

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I2fbfa6a3ff5ec962bf0304f9946257a844b1f582

ramoops: Check files in pstore

The code was wrong that it passes the pstore dir and create a dump.
Actually it should get the files in pstore dir, and do not create a dump
if it's an empty dir or th

ramoops: Check files in pstore

The code was wrong that it passes the pstore dir and create a dump.
Actually it should get the files in pstore dir, and do not create a dump
if it's an empty dir or the dir does not exist.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: Id9e2452c93c5e2897441d22d00aeec8b04aca3ee

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Id4f88568c2897ab1117dcad647783a9127c0600d

meson: update deprecated source_root()

The `source_root` function has been split into `project_source_root`
and `global_source_root` variants as of meson-0.57. Update to use
`project_source_root`,

meson: update deprecated source_root()

The `source_root` function has been split into `project_source_root`
and `global_source_root` variants as of meson-0.57. Update to use
`project_source_root`, which is generally the appropriate variant to
use.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I32b2a66a742c9b0a78e9fb93276d62aff42ab240

show more ...

meson: remove cpp-fs dependency

Any compiler which supports C++17 doesn't have the std::filesystem
support in a separate library. Remove all the meson magic to attempt to
find this because it is al

meson: remove cpp-fs dependency

Any compiler which supports C++17 doesn't have the std::filesystem
support in a separate library. Remove all the meson magic to attempt to
find this because it is all integrated into the standard C++ library.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1e788e38d26a825f2ee5836da740657ffb5ea072

show more ...

meson: update to c++20

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie01eb0006c75ba753685a98e7357b436b6e7d748

meson: add proper cereal dependency

There are source files that assume cereal header files will be present
without the meson build explicitly finding that dependency. This leads
to compile failures

meson: add proper cereal dependency

There are source files that assume cereal header files will be present
without the meson build explicitly finding that dependency. This leads
to compile failures when using the meson-subproject based build. Add a
proper dependency and wrap file for this, based on similar code found in
phosphor-logging.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6819be89101ded9f8a4dbe885074d30cb06e2df7

show more ...