shellcheck: add ignore for files currently failing

I am going to enable shellcheck everywhere by default and instead
enable repositories to specify a .shellcheck-ignore of files that
can be ignored.

shellcheck: add ignore for files currently failing

I am going to enable shellcheck everywhere by default and instead
enable repositories to specify a .shellcheck-ignore of files that
can be ignored. I'm hoping going forward that the maintainers here
will work at slowly reducing this file over time...

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I03a147a6b0b418bf9b7875826ece44a3cc231769

show more ...

Update OWNERS file to add reviewer

Update OWNERS file to add myself as reviewer
- name: Dhruvaraj Subhashchandran
email: dhruvaraj@in.ibm.com
discord: dhruvibm

Signed-off-by: Dhruvaraj Subhashc

Update OWNERS file to add reviewer

Update OWNERS file to add myself as reviewer
- name: Dhruvaraj Subhashchandran
email: dhruvaraj@in.ibm.com
discord: dhruvibm

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I1bb0e479f88154a78c706f079d99d4a2998f9c8d

show more ...

remove unused com.ibm specific header file from dump utils

This is to fix build issue reported in the latest master related
to com.ibm specific header file in base code. Removed unused com.ibm
inter

remove unused com.ibm specific header file from dump utils

This is to fix build issue reported in the latest master related
to com.ibm specific header file in base code. Removed unused com.ibm
interface specific header file from dump_utils.hpp file now.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I1082bc7de8430983dec952463724706dd38e3aba

show more ...

dreport: move ipaddr plugin commands into network plugin

Combining all network related commands into network plugin.
Removing iplink plugin and command as it is capturing duplicate
data.

Tested:
ro

dreport: move ipaddr plugin commands into network plugin

Combining all network related commands into network plugin.
Removing iplink plugin and command as it is capturing duplicate
data.

Tested:
root@rain104bmc:/tmp/test/obmcdump_00000000_1649837600# cat network.log
[ip addr]
1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue qlen 1000
link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00
inet 127.0.0.1/8 scope host lo
valid_lft forever preferred_lft forever
.....

[netstat]
Kernel IP routing table
Destination Gateway Genmask Flags MSS Window irtt Iface
.....

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: Ie95865ca729e06fafdf8a6cbc9a9c294c9e4fa34

show more ...

Revert "dreport: add active services (systemd) status to the BMC dump"

Listing activer service status is taking over 10 seconds and is
delaying generating user dump.

Removing the script as we alrea

Revert "dreport: add active services (systemd) status to the BMC dump"

Listing activer service status is taking over 10 seconds and is
delaying generating user dump.

Removing the script as we already have listing of failed
service script which lists failed services.

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I7de203d5ad1619707461734e2431394689e107c7

show more ...

dreport: Add Linux Kernel trace to dump

Added Linux Kernel trace to "core" and "user" dumps.

Tested:
Manually ran dreport for both type core and type user. Verified
trace was included in trace an

dreport: Add Linux Kernel trace to dump

Added Linux Kernel trace to "core" and "user" dumps.

Tested:
Manually ran dreport for both type core and type user. Verified
trace was included in trace and could be extracted.

Change-Id: Ib0ff61da8e3798e7327a5effe38f52873ead7c20
Signed-off-by: Janet Adkins <janeta@us.ibm.com>

show more ...

Implement OriginatedBy interface in dump entry dbus obj

This new interface "OriginatedBy" will be implemented
by all the dump entry dbus objects. It contains a property
"OriginatorId" which stores t

Implement OriginatedBy interface in dump entry dbus obj

This new interface "OriginatedBy" will be implemented
by all the dump entry dbus objects. It contains a property
"OriginatorId" which stores the unique id of the user that
has initiated the dump. The unique id in this case is a string
that contains the ip address of the client that initiated
the dump.

The dbus interface change for the same is at:
[1] https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-dbus-interfaces/+/47057

Tested By:

[1] busctl call xyz.openbmc_project.Dump.Manager /xyz/openbmc_project/dump/bmc xyz.openbmc_project.Dump.Create CreateDump a{sv} 2 "xyz.openbmc_project.Dump.Create.CreateParameters.OriginatorId" s "<unique-id>" "xyz.openbmc_project.Dump.Create.CreateParameters.OriginatorType" s "xyz.openbmc_project.Common.OriginatedBy.OriginatorTypes.Client" o "/xyz/openbmc_project/dump/bmc/entry/2"

[2] busctl --verbose call xyz.openbmc_project.Dump.Manager /xyz/openbmc_project/dump/resource xyz.openbmc_project.Dump.Create CreateDump a{sv} 4 "com.ibm.Dump.Create.CreateParameters.VSPString" s "vsp" "com.ibm.Dump.Create.CreateParameters.Password" s "password" "com.ibm.Dump.Create.CreateParameters.OriginatorId" s "<unique-id>" "xyz.openbmc_project.Dump.Create.CreateParameters.OriginatorType" s "xyz.openbmc_project.Common.OriginatedBy.OriginatorTypes.Client"
MESSAGE "o" {
OBJECT_PATH "/xyz/openbmc_project/dump/resource/entry/1";
};

[3] busctl call xyz.openbmc_project.Dump.Manager /xyz/openbmc_project/dump/system xyz.openbmc_project.Dump.Create CreateDump a{sv} 2 "com.ibm.Dump.Create.CreateParameters.OriginatorId" s "<unique-id>" "xyz.openbmc_project.Dump.Create.CreateParameters.OriginatorType" s "xyz.openbmc_project.Common.OriginatedBy.OriginatorTypes.Client" o "/xyz/openbmc_project/dump/system/entry/1"

Signed-off-by: Asmitha Karunanithi <asmitk01@in.ibm.com>
Change-Id: I23c9f769fd39cd84e042d6effbb3d71c7af4e889

show more ...

dreport: removing logging error in altfwprintenv dump plugin

This script logs error when executed on system which has
single BMC flash chip.

This Alt flash config script works only on systems
which

dreport: removing logging error in altfwprintenv dump plugin

This script logs error when executed on system which has
single BMC flash chip.

This Alt flash config script works only on systems
which has 2 BMC flash chips.

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: If80645cf4946e454ae676a2e656b091117deafb1

show more ...

openpower:dreport: add cfam details to BMC dump

Tested:
Fri Apr 29 04:03:17 UTC 2022 INFO: Collected cfam 283c
Fri Apr 29 04:03:17 UTC 2022 INFO: Collected cfam 1007
Fri Apr 29 04:03:17 UTC 2022 INF

openpower:dreport: add cfam details to BMC dump

Tested:
Fri Apr 29 04:03:17 UTC 2022 INFO: Collected cfam 283c
Fri Apr 29 04:03:17 UTC 2022 INFO: Collected cfam 1007
Fri Apr 29 04:03:17 UTC 2022 INFO: Collected cfam 2809

sh-5.1# cat cfam.log
pu k0:n0:s0:p00 0x00000000
pu k0:n0:s0:p01 0x00000000
pu k0:n0:s0:p02 0x00000000
pu k0:n0:s0:p03 0x00000000
/usr/bin/edbg getcfam pu 283c -pall
pu k0:n0:s0:p00 0x002000C4
pu k0:n0:s0:p01 0xC2200084
pu k0:n0:s0:p02 0x00200404
pu k0:n0:s0:p03 0x00200104
/usr/bin/edbg getcfam pu 1007 -pall
pu k0:n0:s0:p00 0x00000000
pu k0:n0:s0:p01 0x00000000
pu k0:n0:s0:p02 0x00000000
pu k0:n0:s0:p03 0x00000000
/usr/bin/edbg getcfam pu 2809 -pall

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I7184d9676b9123f048f5b681e0cbdfeb6be7774c

show more ...

dreport: add settings data to BMC dump

Test case1 - busctl success
Wed Apr 27 02:23:56 UTC 2022 INFO: Collected settings
sh-5.1# ls -lah settings.log
-rw-r--r-- 1 root root 46.3K Apr 27

dreport: add settings data to BMC dump

Test case1 - busctl success
Wed Apr 27 02:23:56 UTC 2022 INFO: Collected settings
sh-5.1# ls -lah settings.log
-rw-r--r-- 1 root root 46.3K Apr 27 02:23 settings.log
sh-5.1#

Test case2 - busctl failure
Wed Apr 27 04:59:11 UTC 2022 ERROR: Failed to collect settings
Wed Apr 27 04:59:11 UTC 2022 INFO: Copied settings
/var/lib/phosphor-settings-manager/settings
sh-5.1# du -sh settings
16.0K settings

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I2448a3108e0c6c1e6aa1eca49ebf6c76ed4664d9

show more ...

dreport: Add BIOS settings data to BMC dump

Tested
Wed Apr 27 02:23:48 UTC 2022 INFO: Collected bios
sh-5.1# ls -lah bios.log
-rw-r--r-- 1 root root 260.5K Apr 27 02:23 bios.log
sh-5.1#

dreport: Add BIOS settings data to BMC dump

Tested
Wed Apr 27 02:23:48 UTC 2022 INFO: Collected bios
sh-5.1# ls -lah bios.log
-rw-r--r-- 1 root root 260.5K Apr 27 02:23 bios.log
sh-5.1#

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I564f46228eeeae4ce6a7769e4cf22a593f107500

show more ...

op:dreport Add OCC details to BMC dump

Test case1 - busctl success
Wed Apr 27 02:23:48 UTC 2022 INFO: Collected occ control
Wed Apr 27 02:23:48 UTC 2022 INFO: Collected occ sensor
sh-5.1# ls -lah oc

op:dreport Add OCC details to BMC dump

Test case1 - busctl success
Wed Apr 27 02:23:48 UTC 2022 INFO: Collected occ control
Wed Apr 27 02:23:48 UTC 2022 INFO: Collected occ sensor
sh-5.1# ls -lah occ.log
-rw-r--r-- 1 root root 12.5K Apr 27 02:23 occ.log
sh-5.1#

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I927e5767b41b56d4b70d1c613313f07e247a6e2f

show more ...

op:dreport list existing dump details to BMC dump

Query for the dump manager managed objects and write to BMC
dump file

If the busctl command fails list the dump files present
in the system and add

op:dreport list existing dump details to BMC dump

Query for the dump manager managed objects and write to BMC
dump file

If the busctl command fails list the dump files present
in the system and add to BMC dump.

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: Ifd1efc2e8322c2f64be79a91b7e5bef2d7a174dd

show more ...

dreport: Fix warnings displayed during plugin execution

Tested:
Tue Apr 26 07:20:23 UTC 2022 INFO: Collected proc fd
Tue Apr 26 07:20:18 UTC 2022 INFO: Collected Attribute list
Tue Apr 26 07:20:18 U

dreport: Fix warnings displayed during plugin execution

Tested:
Tue Apr 26 07:20:23 UTC 2022 INFO: Collected proc fd
Tue Apr 26 07:20:18 UTC 2022 INFO: Collected Attribute list
Tue Apr 26 07:20:18 UTC 2022 INFO: Copied Device tree file
/var/lib/phosphor-software-manager/hostfw/running/DEVTREE
Tue Apr 26 07:20:18 UTC 2022 INFO: Copied Attribute info db
/usr/share/pdata/attributes_info.db

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I34e454552b5f903721acf6149a4abee6b3f53bb7

show more ...

ibm:dreport: move IBM specific dump plugins to repository

1) IBM specific plugins from the IBM specific dump recipe will
be moved to ibm.d/plugins.d folder in the repository.

2) IBM specific dump r

ibm:dreport: move IBM specific dump plugins to repository

1) IBM specific plugins from the IBM specific dump recipe will
be moved to ibm.d/plugins.d folder in the repository.

2) IBM specific dump recipe will install the IBM specific dump
plugins from the repository.

4) Recipe changes will be made similar to
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/52752/6/
meta-openpower/recipes-phosphor/dump/phosphor-debug-collector_%2525.bbappend
to copy plugins from repository to /usr/share during install

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I7f4d092d4678cee1c2831b024523057c2fc3474f

show more ...

dreport: add led manager persistent data to BMC dump

Adding plugin to copy /var/lib/phosphor-led-manager/ directory
where LED manager persistent data is stored to BMC dump.

----------<Test case - f

dreport: add led manager persistent data to BMC dump

Adding plugin to copy /var/lib/phosphor-led-manager/ directory
where LED manager persistent data is stored to BMC dump.

----------<Test case - failure in busctl command>-------
Thu Apr 14 08:16:53 UTC 2022 ERROR: Failed to collect led groups
Thu Apr 14 08:16:53 UTC 2022 INFO: Copied led groups
/var/lib/phosphor-led-manager/

root@xxx:/tmp/test/obmcdump_00000000_1649924210# du -sh
phosphor-led-manager/
4.0K phosphor-led-manager/

----------<Test case - busctl command success>----------
root@xxx:/tmp/test/obmcdump_00000000_1649927154# ls -lah ledgroups.log
-rw-r--r-- 1 root root 409.7K Apr 14 09:05 ledgroups.log

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I2939ae24762bf799f3fd1ccf6ebcc2c3c6d2c593

show more ...

dreport: add inventory persistent data to BMC dump

1.Run busctl command to get the inventory data and add to
BMC dump.
2.Add /var/lib/phosphor-inventory-manager data to BMC dump.

Tested:

root@perf

dreport: add inventory persistent data to BMC dump

1.Run busctl command to get the inventory data and add to
BMC dump.
2.Add /var/lib/phosphor-inventory-manager data to BMC dump.

Tested:

root@perfrain86bmc:/tmp/test/obmcdump_00000000_1649923539# du -sh
phosphor-inventory-manager/
12.4M phosphor-inventory-manager/
root@perfrain86bmc:/tmp/test/obmcdump_00000000_1649923539#

root@perfrain86bmc:/tmp/test/obmcdump_00000000_1649923539# ls -la inventory.log
-rw-r--r-- 1 root root 0 Apr 14 08:05 inventory.log

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: Iccb50e5f3a068fe3e13326326bfc5e66471b8b9e

show more ...

op:dreport change path of device-tree to copy to dump

1) At present using mount path, which might change so using the
permanent path.

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-

op:dreport change path of device-tree to copy to dump

1) At present using mount path, which might change so using the
permanent path.

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: Id29bbed3ac462ea6c74bb4112d515feb29657962

show more ...

dreport: fix capturing guard data in BMC dump

At present using mount path to copy the guard partition to the
BMC dump same is changed to /var/lib path as mount path is no
longer used.

Export device

dreport: fix capturing guard data in BMC dump

At present using mount path to copy the guard partition to the
BMC dump same is changed to /var/lib path as mount path is no
longer used.

Export device tree environment variables as the guard tool needs
it to parse the guard records from the guard partition.

Tested:
[Guard list]
ID | ERROR | Type | Path
00000001 | 00000000 | manual | physical:sys-0/node-0/proc-1

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I74b1720ce8c7140a59e00d35ac45ac8a7c020e53

show more ...

Add README for dreport

Document how dreport works, especially the 'config' comment line in
plugins that specifies when the plugins run.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I

Add README for dreport

Document how dreport works, especially the 'config' comment line in
plugins that specifies when the plugins run.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: I2063bd8ba8397139f38396752dfbb85eea570455

show more ...

Populate timestamps with microsecond precision

xyz.openbmc_project.Time.EpochTime is defined as time elapsed since the
epoch in microseconds.

xyz.openbmc_project.Common.Progress.StartTime and
xyz.o

Populate timestamps with microsecond precision

xyz.openbmc_project.Time.EpochTime is defined as time elapsed since the
epoch in microseconds.

xyz.openbmc_project.Common.Progress.StartTime and
xyz.openbmc_project.Common.Progress.CompletedTime are similarly
defined as microseconds.

Change timestamps that are currently captured in seconds to
microseconds.

Tested:

Check xyz.openbmc_project.Time.EpochTime,
xyz.openbmc_project.Common.Progress.StartTime, and
xyz.openbmc_project.Common.Progress.CompletedTime timestamps of dump
entries.

Example:
busctl introspect xyz.openbmc_project.Dump.Manager /xyz/openbmc_project/dump/bmc/entry/1

Signed-off-by: Claire Weinan <cweinan@google.com>
Change-Id: I6ea220af07f06ad79de0b62b24ce6cd5ba5fd33d

show more ...

OpenPOWER: Add additional traces when requesting instance id

The dump manager requests an instance id from PLDM to communicate
with the host. Since the number of instances is limited
PLDM needs to k

OpenPOWER: Add additional traces when requesting instance id

The dump manager requests an instance id from PLDM to communicate
with the host. Since the number of instances is limited
PLDM needs to keep track of the requests, adding
additional traces while requesting the instance id.
Added exception handling for bus errors while
getting instance id from PLDM.

Testing:
Execute offload and delete to see whether traces are coming.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: Id15a99d349851ca00baf7fc8d59a83d7d266fa44

show more ...

OpenPOWER: Add PCIInit also as host running state

PCI init starts once the host is started and the resource dump or
system dump can be initiated at this stage. There are usecase
where host is stuck

OpenPOWER: Add PCIInit also as host running state

PCI init starts once the host is started and the resource dump or
system dump can be initiated at this stage. There are usecase
where host is stuck at this stage so collecting a system dump
or resource dump is critical for the debug.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I8ba7246fe84c146c104644b18507cd217db42d18

show more ...

OpenPower: Return unavailable if any error in deleting host dump

If there is a failure in sending dump delete request to host
for resource and system dump, return unavailable error.

Signed-off-by:

OpenPower: Return unavailable if any error in deleting host dump

If there is a failure in sending dump delete request to host
for resource and system dump, return unavailable error.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: Ia85ef46c55c5a2b54af2b8632f94c3318ef1d4d1

show more ...

OpenPOWER: Prevent dump delete while offloading

Prevent the deletion of the dumps stored in host memory
while offload is in progress

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

OpenPOWER: Prevent dump delete while offloading

Prevent the deletion of the dumps stored in host memory
while offload is in progress

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I053d802a96548fdd9240cf21ef2bf91c4b38e367

show more ...