Collect Bad VPD as a part of BMC dump.

Collect bad VPD as a part of user intiated BMC dump.
In openpower-vpd-parser we collect IBM vpd using a feature flag "ibm-parser".
So the vpd we collect are sp

Collect Bad VPD as a part of BMC dump.

Collect bad VPD as a part of user intiated BMC dump.
In openpower-vpd-parser we collect IBM vpd using a feature flag "ibm-parser".
So the vpd we collect are specific to ibm-systems. Hence placing the badvpd plugin
in tools/dreport.d/ibm.d rather than in tools/dreport.d/plugins.d.

The badvpd plugin will get installed via phosphor-debug-collector recipe file from meta-ibm layer.

The symlink creation to the right type of plugin directory(say - pl_user.d/pl_elog.d/pl_checkstop.d/pl_core.d)
will also be done from the meta-ibm layer in phosphor-debug-collector recipe file.

Tested on simics:

root@rainier:~# mkdir /tmp/bad-vpd
root@rainier:~# dreport -v
Wed Mar 3 04:43:18 UTC 2021 Name: obmcdump_00000000_1614746598.tar.xz
Wed Mar 3 04:43:18 UTC 2021 Epochtime: 1614746598
Wed Mar 3 04:43:18 UTC 2021 ID: 00000000
Wed Mar 3 04:43:18 UTC 2021 Type: user
Wed Mar 3 04:43:18 UTC 2021 INFO: Collected disk usage
Wed Mar 3 04:43:18 UTC 2021 INFO: Collected failed services
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected Journal pretty log
Wed Mar 3 04:43:19 UTC 2021 INFO: Copied Memory info /proc/meminfo
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected top
Wed Mar 3 04:43:19 UTC 2021 INFO: Copied Bad VPD /tmp/bad-vpd
Wed Mar 3 04:43:19 UTC 2021 INFO: Copied OS release info /etc/os-release
Wed Mar 3 04:43:19 UTC 2021 INFO: No elog entries
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected inventory
Wed Mar 3 04:43:19 UTC 2021 INFO: Copied OBMC console log /var/log/obmc-console.log
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected ip addr
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected ip link
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected PRI-Flash: U-Boot environment variables
Wed Mar 3 04:43:19 UTC 2021 INFO: Copied GUARD Records /var/lib/phosphor-software-manager/pnor/prsv/GUARD
Wed Mar 3 04:43:19 UTC 2021 ERROR: /etc/alt_fw_env.config does not exist
Wed Mar 3 04:43:19 UTC 2021 INFO: Copied CPU info /proc/cpuinfo
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected uptime
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected BMC State
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected Chassis State
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected hostnamectl
Wed Mar 3 04:43:19 UTC 2021 INFO: Collected Host State
Adding Dump Header :/usr/share/dreport.d/include.d/gendumpheader
Wed Mar 3 04:44:08 UTC 2021 Report is available in /tmp
Wed Mar 3 04:44:08 UTC 2021 Successfully completed

Check the dump tar file generated in /tmp directory.
After skipping 628 bytes of dump header in tar, untar it.
The files in /tmp/bad-vpd directory will get collected.

Signed-off-by: PriyangaRamasamy <priyanga24@in.ibm.com>
Change-Id: I47f6dde077f9852cc3061cc8c03819c12749337c

show more ...

Creating dump header for IBM systems

-Adding dump header script:
-Changes are related to IBM specific systems only, no
impact on the existing dump package format without
dump header. In package func

Creating dump header for IBM systems

-Adding dump header script:
-Changes are related to IBM specific systems only, no
impact on the existing dump package format without
dump header. In package function only for IBM systems
the generated header will be added to the dump, for
remaining systems the existing dump format remains same.
-Adding dump header which will be added on top of the
the <obmc file>.tar.xz, only on IBM systems

Note: If user wants to extract the dump, they need to remove
the header from the dump using dd command.
Example
dd bs=628 skip=1 if=<input_dump_file> of=<output_file>

Result:
Tested the dump header using busctl command and dreport script.
Able to add dump header on top of the <obmcdump>.tar.xz file.

Separated out the header from the output file using dd command:
dd bs=628 skip=1 if=<obmc dump>.tar.xz of=openbmc.tar.xz

The new output file doesn't have the header now and can be unzipped.
Post unzipping the files in the dump can be seen.

hexdump ooutput of the dump header:-
00000000 46 49 4c 45 20 20 20 20 00 40 00 00 00 00 00 00 |FILE .@......|
00000010 00 00 00 00 00 01 00 0f 42 4d 50 44 55 4d 50 2e |........BMPDUMP.|
00000020 53 49 4d 50 31 30 52 2e 30 30 30 30 30 30 30 36 |SIMP10R.00000006|
00000030 2e 32 30 32 30 30 39 32 39 31 31 31 30 34 33 00 |.20200929111043.|
00000040 53 45 43 54 49 4f 4e 20 00 30 00 00 00 00 00 00 |SECTION .0......|
00000050 00 00 00 01 00 02 00 00 00 00 00 00 00 02 ad dc |................|
00000060 42 4d 43 44 55 4d 50 00 00 00 00 00 00 00 00 00 |BMCDUMP.........|
00000070 42 4d 43 20 44 55 4d 50 00 00 00 00 00 00 00 00 |BMC DUMP........|
00000080 00 00 00 00 02 10 02 00 00 00 00 00 00 02 ad dc |................|
00000090 39 31 30 35 2d 32 32 41 00 00 00 00 00 00 00 00 |9105-22A........|
000000a0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
000000b0 53 65 72 76 65 72 2d 39 31 30 35 2d 32 32 41 2d |Server-9105-22A-|
000000c0 53 4e 2d 53 49 4d 50 31 30 52 00 00 00 00 00 00 |SN-SIMP10R......|
000000d0 00 53 49 4d 50 31 30 52 00 00 00 00 00 70 00 00 |.SIMP10R.....p..|
000000e0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................|
*
00000270 01 01 00 00 fd 37 7a 58 5a 00 00 04 e6 d6 b4 46 |.....7zXZ......F|

Signed-off-by: Chirag Sharma <chirshar@in.ibm.com>
Change-Id: I27bffdd96a6da0777d88e3c7f93eee92cffbfd6e

show more ...

Fix shellcheck errors in dreport

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I64e9de12b9e8c71fc501936a39926388729fb370

plugins/hostlogger: Replace dbus call with signal

The latest version of the Hostlogger supports multi-host mode, each host
is served by a separate service instance.
The service instance now uses SIG

plugins/hostlogger: Replace dbus call with signal

The latest version of the Hostlogger supports multi-host mode, each host
is served by a separate service instance.
The service instance now uses SIG_USR1 signal to flush collected messages
to a file.

Tested: Run dreport inside the BMC console, the result dump archive
contains host console logs.

Change-Id: I2ba926dad79b362d0f4abac50619d7969a4f28f7
Signed-off-by: Artem Senichev <a.senichev@yadro.com>
Tested-by: Artem Senichev <a.senichev@yadro.com>

show more ...

Changes in dreport to accept /tmp/ as a valid dir

In the dreport script there is a condition which checks for
'/tmp' only. When the user passes directory as '/tmp/' this
check fails. As a result the

Changes in dreport to accept /tmp/ as a valid dir

In the dreport script there is a condition which checks for
'/tmp' only. When the user passes directory as '/tmp/' this
check fails. As a result the overall operation fails.
This commit fixes this by treating '/tmp/' as a valid directory.

Signed-off-by: Chirag Sharma <chirshar@in.ibm.com>
Change-Id: Ie11f96f0ff71bfb1fa4fedc59c40d8191116c5c6

show more ...

Fix dreport os-release script point to a symbolic link

The os-release file in the dump points to a symbolic link
rather than the actual release details.

As "cp -r" command is used to copy the conte

Fix dreport os-release script point to a symbolic link

The os-release file in the dump points to a symbolic link
rather than the actual release details.

As "cp -r" command is used to copy the contents of a symbolic
link file, it copies the link rather than the actual file.

Modified to use cp command to copy the contents of the file

Tested:
before fix
root@witherspoon:/tmp# mkdir test1
root@witherspoon:/tmp# cp -r /etc/os-release test1/
root@witherspoon:/tmp# ls -la test1/
drwxr-xr-x 2 root root 60 Jun 6 12:27 .
drwxrwxrwt 13 root root 320 Jun 6 12:26 ..
lrwxrwxrwx 1 root root 21 Jun 6 12:27 os-release -> ../usr/lib/os-release

after fix
root@witherspoon:/tmp# mkdir test2
root@witherspoon:/tmp# cp /etc/os-release test2/
root@witherspoon:/tmp# ls -la test2/
-rw-r--r-- 1 root root 295 Jun 6 12:27 os-release

Change-Id: I6980ffa40b925fb02be0bf53704d17ebc7995af0
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Specify plugins to be invoked for chekstop error

Set the config value for the scripts that need to be
invoked during dump collection for checkstop error.

Checkstop dump enum type has value 4.

Chan

Specify plugins to be invoked for chekstop error

Set the config value for the scripts that need to be
invoked during dump collection for checkstop error.

Checkstop dump enum type has value 4.

Change-Id: Ic75fa0f800ed459b8e493b191eec18f144664655
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Refactor to pass errors to watch through config YAML

Add errors to watch for through error YAML file
Add support for checkstop error type

Tested:
Generating dumps for elog, core, checkstop type err

Refactor to pass errors to watch through config YAML

Add errors to watch for through error YAML file
Add support for checkstop error type

Tested:
Generating dumps for elog, core, checkstop type errors.

Change-Id: Idd00ace2e3d0c472a74ec142e6d150e55e843a6f
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Add phosphor-hostlogger plugin to dreport

phosphor-hostlogger project stores host's console output data, such as
boot logs or Linux kernel messages printed to the system console.
https://github.com/

Add phosphor-hostlogger plugin to dreport

phosphor-hostlogger project stores host's console output data, such as
boot logs or Linux kernel messages printed to the system console.
https://github.com/openbmc/phosphor-hostlogger

Tested: Run dreport inside the BMC console, the result dump archive must
contains host console logs.

Change-Id: Icc45888a43b42de78c93aa0bc0ba7a295f0a76e3
Signed-off-by: Artem Senichev <artemsen@gmail.com>
Tested-by: Artem Senichev <artemsen@gmail.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I192b4

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I192b40fcab98b64e39b3100d41ea025ca280d842
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

dreport: Added altfwprintenv plugin

Plugin used for collecting alt flash U-boot
environment variables.

Resolves openbmc/openbmc#2862

Change-Id: Ife6eec8e85640e1933771cd149c49f1579430473
Signed-off

dreport: Added altfwprintenv plugin

Plugin used for collecting alt flash U-boot
environment variables.

Resolves openbmc/openbmc#2862

Change-Id: Ife6eec8e85640e1933771cd149c49f1579430473
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

dreport: Added fwprintenv plugin

Plugin used for collecting primary flash U-boot
environment variables.

Resolves partially openbmc/openbmc#2862

Change-Id: I9cffd936575311a39d8006b84a612f0223158fbb

dreport: Added fwprintenv plugin

Plugin used for collecting primary flash U-boot
environment variables.

Resolves partially openbmc/openbmc#2862

Change-Id: I9cffd936575311a39d8006b84a612f0223158fbb
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

dreport: Collect journal log in case PID is not present

dreport uses PID information from the elog or core file to
collect PID based journal logs as part the BMC dump.
Existing dreport skips journal

dreport: Collect journal log in case PID is not present

dreport uses PID information from the elog or core file to
collect PID based journal logs as part the BMC dump.
Existing dreport skips journal log collection in case PID
information is missing in the elog or core file.

Proposed changes help to collect the last 500 journal entries when
the PID is not present in the elog entry or core file.

Resolves openbmc/openbmc#2716

Change-Id: Ib3d8dfea64ea17f4b020b429267294c36530848b
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

dreport: Added ip link plugin

Resolves openbmc/openbmc#2537

Change-Id: Id5ce18da3652e39edf3b970a99c75424ed039c35
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

dreport: Added ip address plugin

Change-Id: I1ec3489330abf23eaf87e26a12424d1949f3bf4b
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

dreport: Added inventory plugin

Change-Id: Ifbb6754aa860ac2dab693c76bf14c54e1df6dc9c
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

Added GetManagedObjects based elog data collection

GetManagedObjects based elog data collection will reduce
to one d-bus call, for entire elog properties dump.

Change-Id: I2d2a5922418e0c26b5cf93d94

Added GetManagedObjects based elog data collection

GetManagedObjects based elog data collection will reduce
to one d-bus call, for entire elog properties dump.

Change-Id: I2d2a5922418e0c26b5cf93d94203747121910a50
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I562cc

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I562cc5b407fb2a3a728c6167aaab75acde3adfca
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

dreport: initial commit for Plugin based infrastrcture

Refactor existing dreport to support new plugin
based reporting infrastructure.

Resolves openbmc/openbmc#2351

Change-Id: Ibf078cf0609e93a873d

dreport: initial commit for Plugin based infrastrcture

Refactor existing dreport to support new plugin
based reporting infrastructure.

Resolves openbmc/openbmc#2351

Change-Id: Ibf078cf0609e93a873dbcb28a9bfdc25b182500f
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

dreport: Added core file plugin

Plugin used for moving dreport requestd core file
into the dreport packaging.

Change-Id: I927841ac82394b8736331169d91968feec11f4d5
Signed-off-by: Jayanth Othayoth <o

dreport: Added core file plugin

Plugin used for moving dreport requestd core file
into the dreport packaging.

Change-Id: I927841ac82394b8736331169d91968feec11f4d5
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

dreport: Added systemd failed units plugin

Plugin used for collecting systemd failed units
information.

Change-Id: Icc5f910f613b78fef2e7e557ddfe85692904bce2
Signed-off-by: Jayanth Othayoth <ojayant

dreport: Added systemd failed units plugin

Plugin used for collecting systemd failed units
information.

Change-Id: Icc5f910f613b78fef2e7e557ddfe85692904bce2
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

show more ...

dreport: Added cpuinfo plugin

Plugin used for collecting BMC cpu core information.

Change-Id: I3cddd89ebe1468d131ddef8ba517ae68aa30c8ab
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

dreport: Added uptime plugin

Plugin used for collecting uptime command output data.

Change-Id: Ia6e7f815c4c8e0106cbe77c2c433ff1a01775f95
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

dreport: Added disk usage plugin

Plugin used for collecting BMC disk usage data.

Change-Id: I507a7516453aeff7b7675a41a52ec54b881c6ca1
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>

dreport: Added osrelease plugin

Plugin used for collecting OS release information.

Change-Id: I27fcc47f3a0a1d44aa07001ec61f43d6bf523bf0
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>