Switch to python 3

The python scripts in this repo supports both python2 and python3.
Use python3 now since python2 is EOL.

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I85855

Switch to python 3

The python scripts in this repo supports both python2 and python3.
Use python3 now since python2 is EOL.

Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: I858553eb9ec86c2010e649679dee1607006e89b3

show more ...

maintainers: add some, remove some

Remove myself. I'm not able to keep up.
Add Matt and Devender, both active in the project.

Change-Id: Icf3ee0e15285f15e46c9a5b731a11fe87eca7339
Signed-off-by: Br

maintainers: add some, remove some

Remove myself. I'm not able to keep up.
Add Matt and Devender, both active in the project.

Change-Id: Icf3ee0e15285f15e46c9a5b731a11fe87eca7339
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

dbus-name: do startup work before registering name

The following commit aggravated an existing issue within OpenBMC
software:

https://gerrit.openbmc-project.xyz/c/openbmc/meta-phosphor/+/26476

A b

dbus-name: do startup work before registering name

The following commit aggravated an existing issue within OpenBMC
software:

https://gerrit.openbmc-project.xyz/c/openbmc/meta-phosphor/+/26476

A busctl pcap of the failure shows mapper trying to introspect the
dbus monitor while the dbus monitor is trying to set itself up to
monitor its defined dbus events. This includes calls into mapper and
inventory manager.

This results in a timeout on the mapper side and the dbus monitor object
never being stored within mapper.

The above commit appears to aggravate this bug by allowing mapper to
start introspecting the dbus monitor sooner then it normally does.

Tested:
Verified with this fix that the issue, which was 100% recreatable prior
to this change, did not recreate with multiple BMC reboots

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I6c9380af8b7331bbdbbee0ea3bd0b5ff17dc4187

show more ...

test: Add median condition generation test entries

A median condition generates the same way a count condition does, this
adds entries to the condition generation test yaml to generate median
condit

test: Add median condition generation test entries

A median condition generates the same way a count condition does, this
adds entries to the condition generation test yaml to generate median
conditions. These median condition generation tests have separate
callbacks configured to be verified by the condition generation tests.

Tested:
conditiongentest.hpp generates as expected
`make check` passes conditiongentest

Change-Id: I7c51e320cfeacfa92a31d3fbc42f44c7e50b6183
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

test: Fix condition generation callbacks size test

Change-Id: I634f25726e069dfe65fe6c99e1fd1072f70b33ec
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

test: Add property watch filter tests

Create test cases to perform operand filters to the property values used
within the storage array and validate against the expected any_ns::any
state. Filters r

test: Add property watch filter tests

Create test cases to perform operand filters to the property values used
within the storage array and validate against the expected any_ns::any
state. Filters reset the any object's state when a value is configured
to be filtered.

*Note: Filters are `positive` state based meaning values that pass the
filter check are kept and not reset.

Tested:
Non-filtered test cases still pass
Altering expected filtered results fail test case based on filters
Final filtered test cases pass

Change-Id: I72038c1621f6b8e3de28c50880c7e84177ebe7e4
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

test: Functionalize test state validation check

Create a function that is used as a parameter to the test that performs
the verification of the expected test results. This allows for different
test

test: Functionalize test state validation check

Create a function that is used as a parameter to the test that performs
the verification of the expected test results. This allows for different
test state validation checks to be done against the values used in
testing.

Tested:
No change in testing results

Change-Id: Ie14a47d7872970549dabf5dadc2cfc60062558f2
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

test: Rename "ExpectedValues" struct to "Values"

Additional tests will be added that utilize the same set of values and
may have different expected results. So to reflect this, the
"ExpectedValues"

test: Rename "ExpectedValues" struct to "Values"

Additional tests will be added that utilize the same set of values and
may have different expected results. So to reflect this, the
"ExpectedValues" struct is renamed as "Values" which will always be used
to populate the storage array used in property watch testing.

Tested:
No change in testing results

Change-Id: If07c10fdbf99d551fdac3475dc15df48954c2b24
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Create Filters class to store filter functions

Enhanced the generated code to now store the filter functions within an
array contained in a struct similar to other configured parameters.
This allows

Create Filters class to store filter functions

Enhanced the generated code to now store the filter functions within an
array contained in a struct similar to other configured parameters.
This allows the generated property watches to use an index within that
array to access a pointer to a Filters class containing a given set of
filter functions. The set of filter functions would then be applied
against all the properties being watched.

Tested:
Generated code provides structure needed to access filter functions
Filter functions filter property values that fail the filter(s)

Change-Id: I8f1f882704de521f2ab393530ad7ef096314975d
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add filters option to property watch class

Each property changed signal calls a defined callback, an optional set
of filters can be defined to filter out property values not intended to
be used with

Add filters option to property watch class

Each property changed signal calls a defined callback, an optional set
of filters can be defined to filter out property values not intended to
be used within the callback. These filters can be setup to eliminate
property value(s) that should be ignored per property group and its
configured callback.

ex.) Handle errant sensor values that could occur from a faulty device
so these values do not cause unwanted results from a callback function.

Example config entry to throw out an ambient temperature less than 0C or
greater than 100C:

- name: watch ambient temps
description: >
'Filter the ambient temps, discarding any value that
does not pass, then trigger the callback logic.'
class: watch
watch: property
paths: ambient sensors
properties: ambient temp
callback: median temps
filters:
- op: '>='
bound: 0
- op: '<='
bound: 100000

Tested:
Generate a single filter function against a group of properties
Generate multiple filter functions against a group of properties
Property values are cleared when it fails to pass a filter
Property values that pass all filters are updated

Change-Id: Id5126263096b4787a40befdb14cf3514038df3ed
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add median* condition

The median condition determines the median value from a configured group
of properties and checks that against a defined condition to determine
whether or not the callback is c

Add median* condition

The median condition determines the median value from a configured group
of properties and checks that against a defined condition to determine
whether or not the callback is called.

*Note: When 2 properties are used with the median condition, the
property determined to be the max is used instead of the average of the
2 properties. This is for providing a "worst case" median value.

An example would be to create a group consisting of multiple ambient
sensors where the median value from these ambient sensors would be used
to shutdown the system if above a given temperature.

i.e.)

- name: median temps
description: >
'If this condition passes the median ambient temperature
is too high(>= 45C). Shut the system down.'
class: condition
condition: median
paths: ambient sensors
properties: ambient temp
callback: ambient log and shutdown
op: '>='
bound: 45000
oneshot: true

Tested:
A defined median condition is generated according to the
MedianCondition class
The MedianCondition class produces a single median value from a
group of property values
Median value used against the given operation to determine if
callback is called or not

Change-Id: Icd53e1a6e30a263b7706a935f040eea97dcc2414
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add propertywatchtest unit tests to `make check`

Enable the propertywatchtest unit tests to be executed on a `make check`

Tested:
propertywatchtest runs on a `make check`

Change-Id: I6b40c571f

Add propertywatchtest unit tests to `make check`

Enable the propertywatchtest unit tests to be executed on a `make check`

Tested:
propertywatchtest runs on a `make check`

Change-Id: I6b40c571ffa5f3906ea1a694efd08bf63259a57a
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Fixup propertywatchtest

The propertywatchtest unit test is not included within the makefile to
be run on a `make check`. It was found that the propertywatchtest would
fail when executed and needed u

Fixup propertywatchtest

The propertywatchtest unit test is not included within the makefile to
be run on a `make check`. It was found that the propertywatchtest would
fail when executed and needed updates to use the sdbusplus match helper
functions.

Another needed update was to access the correct position within the
storage tuple that was added under the following commit:
abe43ab439bba463f4727a98ed0cc0c6a5e8251f

Tested:
propertywatchtest executable successfully runs and passes its tests

Change-Id: Icacfe5a6d3d58fee4753d82796f03a82aaddd9fb
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add generated interfaceaddtest to .gitignore

Change-Id: I3f051b334efdd6bb3422f2c87bf1373e43e0ca7e
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

Add generated interfaceaddtest.hpp to .gitignore

Change-Id: I66311c9ce86c1304df89b237424a966e115c73f5
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

build: install into bin instead of sbin

Installs into bin instead of sbin per guidelines.

Signed-off-by: Patrick Venture <venture@google.com>
Change-Id: Ife0be5530266404f75b30baf1ed52bfead513679

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: I16bdbf34b753bdf91dfa4dac824ff

build: pkg anti-pattern: use defaults

Use the defaults in the pkg check where the default error message is
sufficient to identify which package is missing.

Change-Id: I16bdbf34b753bdf91dfa4dac824ffd626fd190f7
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Exception processing added for CallDBusMethod::op.

Patch adds exception processing for CallDBusMethod::op function.
It prevents phosphor-dbus-monitor crashes, when calling service
doesn't exist.

Ch

Exception processing added for CallDBusMethod::op.

Patch adds exception processing for CallDBusMethod::op function.
It prevents phosphor-dbus-monitor crashes, when calling service
doesn't exist.

Change-Id: Iac9be4c14a52fa9c12eb08dfec1f4dfd68e8cdfb
Signed-off-by: Alexander Soldatov <a.soldatov@yadro.com>
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Saving current context in DeferrableCallback added.

DeferrableCallback operator() saves the context in
self instance. When the timer expires, it calls
operator() for the ConditionalCallback with the

Saving current context in DeferrableCallback added.

DeferrableCallback operator() saves the context in
self instance. When the timer expires, it calls
operator() for the ConditionalCallback with the
context saved in DeferrableCallback instance.

Resolves openbmc/phosphor-dbus-monitor#1

Change-Id: I8d235b0747005c403829f8262d0290548b0a9910
Signed-off-by: Alexander Soldatov <a.soldatov@yadro.com>

show more ...

sdevent: Remove in favor of sdeventplus

This change removes the one off sd-event wrapper from the project and
uses the openbmc wide sdeventplus library.

Change-Id: I8e042f875d06082e15606c7191a80739

sdevent: Remove in favor of sdeventplus

This change removes the one off sd-event wrapper from the project and
uses the openbmc wide sdeventplus library.

Change-Id: I8e042f875d06082e15606c7191a8073974f93990
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Use new Association interface name

The mapper changed the association interface name it
hosts to 'xyz.openbmc_project.Association' from
'org.openbmc.Association'.

Change-Id: Ida42ce2152deaafba0e488

Use new Association interface name

The mapper changed the association interface name it
hosts to 'xyz.openbmc_project.Association' from
'org.openbmc.Association'.

Change-Id: Ida42ce2152deaafba0e4881a5ee864ecef0d8ce4
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

std::variant: Fixup .get() usage

This is just a refactor from the mapbox specific .get() interface to the
common std::variant ::get<>() interface.

Tested:
Built and run through unit tests.

Cha

std::variant: Fixup .get() usage

This is just a refactor from the mapbox specific .get() interface to the
common std::variant ::get<>() interface.

Tested:
Built and run through unit tests.

Change-Id: Ic0737f632e80c9dd5b73717ec33d31f245f107db
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

event: use const reference for string params

[src/event.hpp:95]: (performance) Function parameter 'eventName' should be
passed by const reference.
[src/event.hpp:95]: (performance) Function paramete

event: use const reference for string params

[src/event.hpp:95]: (performance) Function parameter 'eventName' should be
passed by const reference.
[src/event.hpp:95]: (performance) Function parameter 'eventMessage' should be
passed by const reference.

Change-Id: I128100102c8ddb24bb847c2ed94acb1fa8871eb0
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

phosphor-dbus-monitor: use c++17

Update configure.ac to choose the c++17 standard

Change-Id: I864d373572d413b0985eee0d6c958b6c982290ef
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

Fix some journal metadata

Code shouldn't use MESSAGE in journal metadata as MESSAGE is
already taken by the journal message field.

Change-Id: I6b1e9033b2028e4fff67cbbeb1824f260657c247
Signed-off-by

Fix some journal metadata

Code shouldn't use MESSAGE in journal metadata as MESSAGE is
already taken by the journal message field.

Change-Id: I6b1e9033b2028e4fff67cbbeb1824f260657c247
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...