Saving current context in DeferrableCallback added.

DeferrableCallback operator() saves the context in
self instance. When the timer expires, it calls
operator() for the ConditionalCallback with the

Saving current context in DeferrableCallback added.

DeferrableCallback operator() saves the context in
self instance. When the timer expires, it calls
operator() for the ConditionalCallback with the
context saved in DeferrableCallback instance.

Resolves openbmc/phosphor-dbus-monitor#1

Change-Id: I8d235b0747005c403829f8262d0290548b0a9910
Signed-off-by: Alexander Soldatov <a.soldatov@yadro.com>

show more ...

sdevent: Remove in favor of sdeventplus

This change removes the one off sd-event wrapper from the project and
uses the openbmc wide sdeventplus library.

Change-Id: I8e042f875d06082e15606c7191a80739

sdevent: Remove in favor of sdeventplus

This change removes the one off sd-event wrapper from the project and
uses the openbmc wide sdeventplus library.

Change-Id: I8e042f875d06082e15606c7191a8073974f93990
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Use new Association interface name

The mapper changed the association interface name it
hosts to 'xyz.openbmc_project.Association' from
'org.openbmc.Association'.

Change-Id: Ida42ce2152deaafba0e488

Use new Association interface name

The mapper changed the association interface name it
hosts to 'xyz.openbmc_project.Association' from
'org.openbmc.Association'.

Change-Id: Ida42ce2152deaafba0e4881a5ee864ecef0d8ce4
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

std::variant: Fixup .get() usage

This is just a refactor from the mapbox specific .get() interface to the
common std::variant ::get<>() interface.

Tested:
Built and run through unit tests.

Cha

std::variant: Fixup .get() usage

This is just a refactor from the mapbox specific .get() interface to the
common std::variant ::get<>() interface.

Tested:
Built and run through unit tests.

Change-Id: Ic0737f632e80c9dd5b73717ec33d31f245f107db
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

event: use const reference for string params

[src/event.hpp:95]: (performance) Function parameter 'eventName' should be
passed by const reference.
[src/event.hpp:95]: (performance) Function paramete

event: use const reference for string params

[src/event.hpp:95]: (performance) Function parameter 'eventName' should be
passed by const reference.
[src/event.hpp:95]: (performance) Function parameter 'eventMessage' should be
passed by const reference.

Change-Id: I128100102c8ddb24bb847c2ed94acb1fa8871eb0
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Fix some journal metadata

Code shouldn't use MESSAGE in journal metadata as MESSAGE is
already taken by the journal message field.

Change-Id: I6b1e9033b2028e4fff67cbbeb1824f260657c247
Signed-off-by

Fix some journal metadata

Code shouldn't use MESSAGE in journal metadata as MESSAGE is
already taken by the journal message field.

Change-Id: I6b1e9033b2028e4fff67cbbeb1824f260657c247
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

update .clang-format

Added the header inclusion order to the .clang-format file generated
these changes.

Change-Id: I4f51a20f469de431ee6a5ba78e3f4da39c980fab
Signed-off-by: Patrick Venture <venture

update .clang-format

Added the header inclusion order to the .clang-format file generated
these changes.

Change-Id: I4f51a20f469de431ee6a5ba78e3f4da39c980fab
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

clang-format-6.0 bump fixes

The bump to use clang-format-6.0 now reports these issues.

Change-Id: I174c882727eaa9adf472599443a2f8ef637e2f0a
Signed-off-by: Patrick Venture <venture@google.com>

Raise SNMP trap by reading error entry properties

dbus-monitor is notified for any new error entry
created. dbus-monitor parses the error entry and
constructs ErrorNotification object and sends
SNMP

Raise SNMP trap by reading error entry properties

dbus-monitor is notified for any new error entry
created. dbus-monitor parses the error entry and
constructs ErrorNotification object and sends
SNMP trap.

Change-Id: I25916b087c5513916c90266278ccafc5db3c41a0
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

sdbusplus: Improve error handling

Ignore exceptions from sdbusplus for objects that are queried
as part of a property watch but are expected to be missing
when the BMC starts up.

Tested: The phosph

sdbusplus: Improve error handling

Ignore exceptions from sdbusplus for objects that are queried
as part of a property watch but are expected to be missing
when the BMC starts up.

Tested: The phosphor-dbus-monitor app does not core dump
with the latest sdbusplus changes.

Change-Id: I0f6a850f0e426478bd1ccacb910a44079b9c8a54
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

propertywatch: Improve error handling

Handle exceptions from the sdbusplus method call API.

A number of method calls are made at application startup. First the
mapper is queried and then host serv

propertywatch: Improve error handling

Handle exceptions from the sdbusplus method call API.

A number of method calls are made at application startup. First the
mapper is queried and then host services directly to obtain initial
values for the property cache.

In either case a missing object is sometimes expected and tolerated
(in a logical sense) without issue. Eat the new exceptions in these
scenarios and avoid a program crash.

Change-Id: Id79d28b2da997f3c545b86c21932e271e3df8bb3
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

tests: Get make check working again

A alias for string called 'Property' was added with 70aafbb58, making
the Property type in propertygentest ambiguous and unable to build.
Remove the ambiguity.

c

tests: Get make check working again

A alias for string called 'Property' was added with 70aafbb58, making
the Property type in propertygentest ambiguous and unable to build.
Remove the ambiguity.

callbacktest does not pass. Mark as expected to fail until resolved.

Tested: propertygentest compiles again, test suite runs to completion
Change-Id: I7df516e378dd7b8de94474ab90ce55c0ac8708a4
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Remove journal entries for failed sdbusplus calls

Calling code is already handling any missing method
call response data appropriately, and many times
the failed call is expected.

For example, any

Remove journal entries for failed sdbusplus calls

Calling code is already handling any missing method
call response data appropriately, and many times
the failed call is expected.

For example, any time there is a dbus monitor rule
that watches a property, it will try to read that
property right away on startup to cache the value
if possible. It's possible that some D-Bus objects
may not exist at that moment in time, and the code
already expects that.

Tested: No more 'Failed to parse method response'
journal entries.

Change-Id: Iaa84020a34a96395abf7a3460c96ec0dc255fa23
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

Add sdbusplus exception handling

Tested: Verified that the phosphor-dbus-monitor does
not core dump with the latest sdbusplus changes to
support sdbusplus exceptions. Instead it logs the
"Failed to

Add sdbusplus exception handling

Tested: Verified that the phosphor-dbus-monitor does
not core dump with the latest sdbusplus changes to
support sdbusplus exceptions. Instead it logs the
"Failed to parse method response" error msg in the journal.

Resolves openbmc/openbmc#3213

Change-Id: I11347725364b5a43df6c0c1c377d65ce361a419c
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Add unit test for watches created on object paths

Verify the watches created for the object path being watched
for 'interfaces added' signal.

Resolves openbmc/openbmc#3003

Change-Id: I88a3adbbe91f

Add unit test for watches created on object paths

Verify the watches created for the object path being watched
for 'interfaces added' signal.

Resolves openbmc/openbmc#3003

Change-Id: I88a3adbbe91fcbe5bdf606d2f460d4d0c6d9c1a2
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Modify parser and add mako scripts for watch on object path

Added support for watch and callback on 'interface added'
signal for the specified object paths.

Added mako scripts for events to auto cr

Modify parser and add mako scripts for watch on object path

Added support for watch and callback on 'interface added'
signal for the specified object paths.

Added mako scripts for events to auto create callback
and watch objects for the specified object path groups.

Clients specify object paths to watch and callbacks to
invoke in the config.yaml file

Change-Id: I3fa2ea1520649120b927c0cb83a16e5cace2f24e
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Add watch on D-Bus object paths

Clients specify the object paths to watch in the config yaml.

Example yaml file and parser changes are pushed in separate
patch

Callbacks are invoked based on the w

Add watch on D-Bus object paths

Clients specify the object paths to watch in the config yaml.

Example yaml file and parser changes are pushed in separate
patch

Callbacks are invoked based on the watch type created i.e
interfaceadded/interfaceremoved

Change-Id: Icb7b9bf4c072f8b8df33747c813a1f07b61de637
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Add SNMP event callback for error notification

Added callback support for SNMP events.

Parse the callback message and raise SNMP trap

Clients specify the object paths to watch and callbacks
to inv

Add SNMP event callback for error notification

Added callback support for SNMP events.

Parse the callback message and raise SNMP trap

Clients specify the object paths to watch and callbacks
to invoke in the config yaml.

Change-Id: I105652f65e4e1c5354c934c88e4d59866540f71c
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Fix callback unit test failure

Recently changes has been done in phosphor-logging commit
method causing the unit test failure with error message
"Error in mapper call". Earlier commit method
used to

Fix callback unit test failure

Recently changes has been done in phosphor-logging commit
method causing the unit test failure with error message
"Error in mapper call". Earlier commit method
used to return error but the same has been modified to throw
exception now.

Fixed to return from the callback method if context is
start

Change-Id: I606c638bd2d0bc2003af0b284586e53809bbca21
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>

show more ...

Add persistency for events

Persist event D-bus objects using cereal

Resolves openbmc/openbmc#2319

Change-Id: Ifa15d944fe1d1026761f65eeb647dcbdf6afdba0
Signed-off-by: Dhruvaraj Subhashchandran <dhr

Add persistency for events

Persist event D-bus objects using cereal

Resolves openbmc/openbmc#2319

Change-Id: Ifa15d944fe1d1026761f65eeb647dcbdf6afdba0
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I78f19

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I78f191f26da14203dc21c97d4fc4a31f95ffc95f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Enable clang-format

Fix up errors and enable clang-format during CI builds.

Change-Id: I4176b81f8b85a287af9354165e09ff66aeb9fb29
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

Add constants for tuple fields

Add constants for use with std::get.

Tested: Run unit tests

Change-Id: Ic09c13feeda69d61c98f63d227cae8f08d1bf50e
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

Add ElogWithMetaDataCapture class

This callback class will create an error log with
exactly 1 metadata field, which takes a string. This
metadata field will be filled in with the property paths,
na

Add ElogWithMetaDataCapture class

This callback class will create an error log with
exactly 1 metadata field, which takes a string. This
metadata field will be filled in with the property paths,
names, and values of the properties that passed the
condition checks that caused the callback to be called
in the first place.

Tested: Ran with YAML rules that used this callback and
checked that everything worked as specified.

Change-Id: Ib37206c63385939c583a09e7ba979d6e016691f6
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

count: Add missing functional include

std::function is not found with a GCC 7.3 runtime.

Change-Id: I4e5289794d405c42ab6291c211289d1ab175b197
Tested: Built repository with GCC 7.3
Signed-off-by: Br

count: Add missing functional include

std::function is not found with a GCC 7.3 runtime.

Change-Id: I4e5289794d405c42ab6291c211289d1ab175b197
Tested: Built repository with GCC 7.3
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...