Sensor.Value: add path constants

Add path constants that allow code to avoid hard-coding strings.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9e93017572933ffd920dd13c301867b33cb

Sensor.Value: add path constants

Add path constants that allow code to avoid hard-coding strings.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9e93017572933ffd920dd13c301867b33cbb0203

show more ...

host-state: define new allowed host transition prop

IBM has a system where the host firmware does not want to allow
a ForcedWarmReboot due to potential error paths with the chassis power
remaining o

host-state: define new allowed host transition prop

IBM has a system where the host firmware does not want to allow
a ForcedWarmReboot due to potential error paths with the chassis power
remaining on and their software being forcefully rebooted.

Define a new property which allows the BMC software to optionally define
which Transition actions they support.

bmcweb currently hard codes the AllowableValues in
redfish/v1/Systems/system/ResetActionInfo. That code will be changed
to first look for this new property on D-Bus. If it's not found or
empty, stick with the hard coded defaults. If it is found and it's
non-empty then use it to fill in the AllowableValues.

Change-Id: I65d29c2bbc54a64084aea21023fd7d33cd129dce
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Item Associations: Fix capitalization and clarify

This capitalization was mixed, move to the exact capitalization of the
interfaces. E.g. Cpu from [1].

Made clear it was Led.Group and Connector.Por

Item Associations: Fix capitalization and clarify

This capitalization was mixed, move to the exact capitalization of the
interfaces. E.g. Cpu from [1].

Made clear it was Led.Group and Connector.Port being associated.

[1] https://github.com/openbmc/phosphor-dbus-interfaces/blob/2117deabad40f9ac63815f3338e7ac3e1e3fe397/yaml/xyz/openbmc_project/Inventory/Item/Cpu.interface.yaml

Change-Id: I2a4bc4142b5c93335259c98538e0e1754c920bff
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Cpu/PCIeSlot: Add {connecting, connected_to}

https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/64951
removes the current associated_pcie_slots, upstream_processor
association.

This co

Cpu/PCIeSlot: Add {connecting, connected_to}

https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/64951
removes the current associated_pcie_slots, upstream_processor
association.

This commit adds that association back but with an existing association.
Redfish is adding this link to the PCIeDevice so will have to do
something like Cpu -> Connected_to -> PCIeSlot -> Containing ->
PCIeDevice to fill this out in bmcweb. If instead we put this on
PCIeDevice wouldn't be able to have this link for empty PCIeSlots.

[1] was the original commit for Cpu, PCIeDevice association.

https://gerrit.openbmc.org/c/openbmc/bmcweb/+/61509 is the commit adding
this Link to Redfish, it should be refreshed with this newly named
association.

Redfish describes this as "An array of links to the processors that are
directly connected or directly bridged to this PCIe slot."

Took descriptions from [2].

[1] https://github.com/openbmc/phosphor-dbus-interfaces/commit/df55704398ec8fc3cc608206f05a2226f134c786
[2] https://github.com/openbmc/phosphor-dbus-interfaces/commit/df32eb57476e86044a996c5f2b6765a772c10de4

Change-Id: I7a5be817b565de035e6166b07743f0ec8e919950
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

cpu/pcie: remove deprecated association name

There are currently no users of this association in the OpenBMC
organization and the name chosen here does not match the association
naming design. Remo

cpu/pcie: remove deprecated association name

There are currently no users of this association in the OpenBMC
organization and the name chosen here does not match the association
naming design. Remove these associations.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I811c0c49db71d89dab34567ddeaef3a5867ab3b1

show more ...

Dump.Create: add default path and service names

Add default service name for the phosphor-debug-collector
implementation and paths for the dump namespace.

Signed-off-by: Patrick Williams <patrick@s

Dump.Create: add default path and service names

Add default service name for the phosphor-debug-collector
implementation and paths for the dump namespace.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I30714dbe9f91e0bbff53b0fa45086ec871421d63

show more ...

Logging: add default path and service names

Add default paths and service names from the reference implementation
in phosphor-logging. The service for logging is expected to be a
singleton and the

Logging: add default path and service names

Add default paths and service names from the reference implementation
in phosphor-logging. The service for logging is expected to be a
singleton and the manager object resides at a fixed path.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia8d4ec354dbbe234109562bd76f1f779922da4e0

show more ...

Logging.Entry: fix old documentation

`org.openbmc` interfaces were removed years and years ago but the
description still referenced it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id

Logging.Entry: fix old documentation

`org.openbmc` interfaces were removed years and years ago but the
description still referenced it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I8b2994a053e137f7478a9b78c5ebfeec7d68ffec

show more ...

State: add default paths for BMC,Host,Chassis

Add namespace and path constants matching those in the README for
programmatic use.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ice4

State: add default paths for BMC,Host,Chassis

Add namespace and path constants matching those in the README for
programmatic use.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ice4e14716b2de6477f3dd7c15e53cc7bdb68270f

show more ...

ObjectMapper: Add default paths

The ObjectMapper service is expected to be at a specific location per
the description. Document this with code constants as well.

Signed-off-by: Patrick Williams <p

ObjectMapper: Add default paths

The ObjectMapper service is expected to be at a specific location per
the description. Document this with code constants as well.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6623d56ae5cfd01a55ffe628bd68c5fcfd3da1dc

show more ...

ObjectMapper: match interfaces with reality

The documented ObjectMapper interfaces do not match the reference
implementation in phosphor-objmgr. Lots of code currently uses
hand-written dbus calls

ObjectMapper: match interfaces with reality

The documented ObjectMapper interfaces do not match the reference
implementation in phosphor-objmgr. Lots of code currently uses
hand-written dbus calls to the ObjectMapper, using the real interfaces
and not the documented ones. Refactoring all of these implementations
is quite a bit of effort, which could be staged at a later time (or
leverage a versioned interface). Update the interface to match reality
so that generated bindings could be leveraged.

Tested:

Ran the reference implementation and compared the signatures with the
YAML and updated as necessary.
```
$ busctl --user introspect xyz.openbmc_project.ObjectMapper /xyz/openbmc_project/object_mapper xyz.openbmc_project.ObjectMapper
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.GetAncestors method sas a{sa{sas}} -
.GetAssociatedSubTree method ooias a{sa{sas}} -
.GetAssociatedSubTreePaths method ooias as -
.GetObject method sas a{sas} -
.GetSubTree method sias a{sa{sas}} -
.GetSubTreePaths method sias as -
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If6fc6a403d602d6c18c6e30dc1a216a47d059860

show more ...

Add Hostname property errors

Hostname does not allow special characters while setting hostname
this commit adds InvalidArgument error to handle invalid hostnames

Change-Id: I2ecc92637364baebe9e845b

Add Hostname property errors

Hostname does not allow special characters while setting hostname
this commit adds InvalidArgument error to handle invalid hostnames

Change-Id: I2ecc92637364baebe9e845bd22099fcb9744c2f4
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>

show more ...

Ipmi.SOL: add default values

In the absence of explicit defaults, the implicit defaults applied to
some of these parameters were somewhat less than ideal, such as
AccumulateIntervalMS getting set to

Ipmi.SOL: add default values

In the absence of explicit defaults, the implicit defaults applied to
some of these parameters were somewhat less than ideal, such as
AccumulateIntervalMS getting set to zero, leading to netipmid going wild
consuming all available CPU cycles whenever an SOL session was active.

This should also obviate the need for most of the currently-existing
overrides of these settings in the main openbmc repo, which are nearly
all identical.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: I745b53bae968976729e2c088c8821bec5f4803f0

show more ...

health-metric: add dbus path for total cpu

Add the DBus path for total CPU to be used in phosphor-health-monitor.

Change-Id: Id50d84c7cdc96e723575db591a3d97d052d016bb
Signed-off-by: Jagpal Singh Gi

health-metric: add dbus path for total cpu

Add the DBus path for total CPU to be used in phosphor-health-monitor.

Change-Id: Id50d84c7cdc96e723575db591a3d97d052d016bb
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

health-metric: add dbus path for read-write storage

Add the DBus path for read write storage to be used in phosphor-health-monitor.

Change-Id: Ic162468dc272a6707cd39476d8e9f128de83e874
Signed-off-b

health-metric: add dbus path for read-write storage

Add the DBus path for read write storage to be used in phosphor-health-monitor.

Change-Id: Ic162468dc272a6707cd39476d8e9f128de83e874
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

metric: rename from metrics

Generally use non-plural names. Do a trivial rename of the Metric
definitions before they start being used by applications.

Signed-off-by: Patrick Williams <patrick@stw

metric: rename from metrics

Generally use non-plural names. Do a trivial rename of the Metric
definitions before they start being used by applications.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia0f210684c8aa0f567d5a1d70baf7eb8956b8712

show more ...

common.Threshold: use dict-of-dict for Value

The Dbus specification does not allow the key of a dict to be a
non-basic type, such as a struct:

the first single complete type (the "key") must be

common.Threshold: use dict-of-dict for Value

The Dbus specification does not allow the key of a dict to be a
non-basic type, such as a struct:

the first single complete type (the "key") must be a basic type
rather than a container type.

If we try to instantiate an instance with a struct as a dict key, we
end up getting an EINVAL on the add-vtable call.

Switch to nested dictionary to avoid this violation.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2c512984e62166efec3f299d55efb39a9e93edbf

show more ...

Association between intrusion sensor and item

Chassis intrusion sensor does not have the Sensor.Value interface to be
legit into the "sensors" association with the chassis but there's a need
to asso

Association between intrusion sensor and item

Chassis intrusion sensor does not have the Sensor.Value interface to be
legit into the "sensors" association with the chassis but there's a need
to associate the sensor with the chassis that it is monitoring physical
security state.

This commit introduces the monitoring/monitored_by association between a
chassis intrusion sensor and the inventory items that it is currently
monitoring the physical security state. The association in this case
requires the two endpoint interfaces of
"xyz.openbmc_project.Chassis.Intrusion" and
"xyz.openbmc_project.Inventory.Item".

Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: I1d110c8a83c5d264785ce30c363a654cbf711731

show more ...

phosphor-health-monitor: add reset interface

- Add the reset interface for resetting the persistent counter, such as
reboot count.
- The intention of this change corresponds to ResetMetrics in Red

phosphor-health-monitor: add reset interface

- Add the reset interface for resetting the persistent counter, such as
reboot count.
- The intention of this change corresponds to ResetMetrics in Redfish
ManagerDiagnosticData -
https://redfish.dmtf.org/schemas/v1/ManagerDiagnosticData.v1_2_1.json

Change-Id: I31f2efac44f996afb2e0575585d3414196412dfd
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

phosphor-health-monitor: add D-Bus paths

- Add the D-Bus paths for BMC metrics.
- The code for these paths will be autogenerated in the common.hpp

Change-Id: I3d0273d83136659d67b0907006fb050db948a7

phosphor-health-monitor: add D-Bus paths

- Add the D-Bus paths for BMC metrics.
- The code for these paths will be autogenerated in the common.hpp

Change-Id: I3d0273d83136659d67b0907006fb050db948a732
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

phosphor-health-monitor: add new D-Bus interface

This commit introduces following changes -
- A new Metrics Value Interface.
- An interface to reset the metrics, if needed.
- Common Threshold interf

phosphor-health-monitor: add new D-Bus interface

This commit introduces following changes -
- A new Metrics Value Interface.
- An interface to reset the metrics, if needed.
- Common Threshold interface so it can be used in Metrics and Sensors.

For more detail, please refer to design -
https://gerrit.openbmc.org/c/openbmc/docs/+/64917

Unit Test: meson build passes.

Change-Id: I014a047f9db6fe470124baa41dcce93caf7ceb4b
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

Watchdog: Add LogTimeout property in watchdog

Add the LogTimeout property in watchdog yaml.
This property is used for configuring whether an event
will be logged on watchdog expiration.

Tested:
No

Watchdog: Add LogTimeout property in watchdog

Add the LogTimeout property in watchdog yaml.
This property is used for configuring whether an event
will be logged on watchdog expiration.

Tested:
No log bit is set to true :
ipmitool raw 0x06 0x24 0x84 0x00 0x00 0x3e 0x64 0x00

No log bit is set to false :
ipmitool raw 0x06 0x24 0x04 0x00 0x00 0x3e 0x64 0x00

Reset watchdog timer :
ipmitool mc watchdog reset

If the LogTimeout property is true, the event will be logged
on watchdog expiration.
We can use 'ipmitool sel elist' to check the system event log.
1 | 01/26/23 | 00:21:21 PST | Watchdog2 host0 | Timer expired | Asserted

If the LogTimeout property is false, the event will not be
logged when the watchdog expires.

Related-Commit-Id: 67727
Related-Commit-Id: 67728

Change-Id: I278b8bb3eec1951ba505ab53527826aef075a05f
Signed-off-by: Tim Chao <Tim.Chao@quantatw.com>

show more ...

common: Add new Priority interface

This commit introduces the new "Priority" interface, which is designed
to indicate the priority level of an entity. It can be used as a
decorator for other objects

common: Add new Priority interface

This commit introduces the new "Priority" interface, which is designed
to indicate the priority level of an entity. It can be used as a
decorator for other objects to specify their priority. While this
interface was initially developed for fan sensors, it can be applied to
various entities and is not limited to fans. This new interface provide
more specific information about the primary and secondary sensors, which
is needed for Redfish Fan schema.

bmcweb commit:
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/57657

Change-Id: Iee875dbe627980139199a6d9a56fde3e5d651af0
Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>

show more ...

MCTP: modify the type of Network ID and EID

Modify the data type of Network ID to uint32 to align with unsigned int from the Linux implementation (which uses the LP64 data model):
https://git.kernel

MCTP: modify the type of Network ID and EID

Modify the data type of Network ID to uint32 to align with unsigned int from the Linux implementation (which uses the LP64 data model):
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/mctp.h?h=v6.5#n25

The data size of Endpoint ID is 8 bits that was defined in document:
DSP0236. Correct the data type of EID to byte.

Change-Id: I31c98a82c126ace00e01dcb6ad557b6d5ca765d4
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

show more ...

Add new interface Debug.Pid.Thermal/Power

- According to the issue#27, adding new interface to record the driver
sensor name, driver sensor value and PID loop result to dbus.

interface:
Debug.Pid

Add new interface Debug.Pid.Thermal/Power

- According to the issue#27, adding new interface to record the driver
sensor name, driver sensor value and PID loop result to dbus.

interface:
Debug.Pid.ThermalPower => Record the sensor name and reading with the
highest temperature or power in the input
list. And record the result of pid loop

Debug.Pid.Zone => Record the pid config name that that is driving the
fans

refs:
https://github.com/openbmc/phosphor-pid-control/issues/27

Change-Id: I67051616958e07c148eabee658165082855c674d
Signed-off-by: Harvey Wu <Harvey.Wu@quantatw.com>

show more ...