Add 'EventId' parameter to BMC Dump creation parameters

This commit adds a new 'EventId' parameter to the BMC Dump
creation parameters. The 'EventId' parameter is used to
link a BMC dump with a spec

Add 'EventId' parameter to BMC Dump creation parameters

This commit adds a new 'EventId' parameter to the BMC Dump
creation parameters. The 'EventId' parameter is used to
link a BMC dump with a specific system event, providing
clearer context and allowing for the collection of additional,
relevant diagnostic data related to the event.

Change-Id: Ia092caa42c3917febfd5e8b447f49bc9078812c2
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Update InternalFailure Type and Add Error Type Parameter

This commit modifies the 'InternalFailure' dump type and replaces
it with a more generic 'ErrorLog' type. In addition, it introduces
a new pa

Update InternalFailure Type and Add Error Type Parameter

This commit modifies the 'InternalFailure' dump type and replaces
it with a more generic 'ErrorLog' type. In addition, it introduces
a new parameter for specifying the type of the error that
triggered the dump.

This is allowing it to cater to various types of errors beyond just
internal failures. With the capability to pass architecture-specific
errors, this change increases compatibility and maintainability without
requiring alterations in the common interface YAML file for each new
error type to be supported.

Change-Id: I896bb995632dad1206385ef92819f3bfffd16f88
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

bmc-ready: new error def for when bmc not ready

phosphor-state-manager is introducing a new optional feature that users
can enable which will not allow chassis or host power on operations if
the BMC

bmc-ready: new error def for when bmc not ready

phosphor-state-manager is introducing a new optional feature that users
can enable which will not allow chassis or host power on operations if
the BMC is not at its "Ready" state.

This commit defines some new error codes so callers will have the
appropriate return information when this situation arises.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ibbe71356b54675601b54179633e76310fdabccec

show more ...

Use createDump method to create different types of BMC dumps

There are two create interfaces for phosphor-debug-collector.
1- external create - this interface
Which accepts a list of key-value pairs

Use createDump method to create different types of BMC dumps

There are two create interfaces for phosphor-debug-collector.
1- external create - this interface
Which accepts a list of key-value pairs as input,
but initially, this was not accepting any parameters.

2- A create interface in phosphor-debug-collector,
which accepts the type of the BMC dump and a set of
paths to dbus or files to collect as part of dump creation.

The internal create is called by core-monitor or ramoops monitor
to create BMC dump when the error has occurred, or a core is created,
and now there is a new requirement to pass error log id along with
these create calls.

The internal create is added to pass parameters, and the external
one is always assumed as user-initiated. Since now the createDump method
is accepting additional parameters, internal create can be removed
and both system-generated and user-initiated dumps can use the
same interface and method.

This commit adds the dump type and enumeration for the types,
additionally changing the path parameter from the array of strings
to a single string because only for the core dump, there is an attempt
to send multiple paths but that can be captured in the packaging script
if the folder is sent.

Change-Id: Icbeb8499fbdfc1f8919b571495a50867bdcecac1
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>

show more ...

Added Connect() method in console DBUS interface

The "xyz.openbmc_project.Console.Access" interface is updated to add new
method called Connect(). This method returns the unix socket file
descriptor

Added Connect() method in console DBUS interface

The "xyz.openbmc_project.Console.Access" interface is updated to add new
method called Connect(). This method returns the unix socket file
descriptor. The consumer can use this file descriptor to receive the
console data. The leaf node in the object path is a console id.

Also, the "SocketName" property is deprecated and removed to avoid
exposing implementation details about the console.

The tree for the "default" console id.
$ busctl tree xyz.openbmc_project.Console.default
`-/xyz
`-/xyz/openbmc_project
`-/xyz/openbmc_project/console
`-/xyz/openbmc_project/console/default

The introspect for the "default" console id.
$ busctl introspect xyz.openbmc_project.Console.default \
/xyz/openbmc_project/console/default
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Console.Access interface - - -
.Connect method - h -

Change-Id: I52472320de0990dcf0e802add87141a97288085c
Signed-off-by: Ninad Palsule <ninadpalsule@us.ibm.com>

show more ...

Remove "Manufacturer" from PCIeDevice interface

"Manufacturer" is already part of Asset interface. Remove it from
PCIeDevice interface.

peci-pcie commit to set Manufacturer in the Asset interface:

Remove "Manufacturer" from PCIeDevice interface

"Manufacturer" is already part of Asset interface. Remove it from
PCIeDevice interface.

peci-pcie commit to set Manufacturer in the Asset interface:
https://gerrit.openbmc.org/c/openbmc/peci-pcie/+/62256

bmcweb commits:
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/62257
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/40051

Change-Id: I2ea7551968893e151219c3c620a52ad8bac7cfd1
Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>

show more ...

Control.Power.Throttle: Add throttle Interface

Define a throttle status interface. This allows users to determine if a
component is being throttled and if so, what the causes are for the
throttle.
T

Control.Power.Throttle: Add throttle Interface

Define a throttle status interface. This allows users to determine if a
component is being throttled and if so, what the causes are for the
throttle.
This is part of the Redfish 2022.3 Schema.

Change-Id: I30e820993e3c225cd82bbd6c78e0a01f9a432282
Signed-off-by: Chris Cain <cjcain@us.ibm.com>

show more ...

Show option->text of BIOS knob in Redfish response.

GET on /redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry/
shows list of Attributes under RegistryEntries. Each attribute
correspo

Show option->text of BIOS knob in Redfish response.

GET on /redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry/
shows list of Attributes under RegistryEntries. Each attribute
corresponds to a knob in BIOS.

If knob in BIOS is of type Enumeration, it will have 'option' with
'text' and 'value'. This text should be mapped to
attribute->Value->ValueDisplayName.

Code changes are made for the same.

Tested
Sample knobs from BIOS.

<knob name="AdaptiveRefreshMgmtLevel" ... >
<options>
<option text="Default" value="0x0"/>
<option text="Level A" value="0x1"/>
<option text="Level B" value="0x2"/>
<option text="Level C" value="0x3"/>
</options>
</knob>
<knob name="ADDDCEn" ... >
<options>
<option text="Disable" value="0x0"/>
<option text="Enable" value="0x1"/>
</options>
</knob>

Corresponding Redfish response in BiosAttributeRegistry

{
"AttributeName": "AdaptiveRefreshMgmtLevel",
"CurrentValue": "0x00",
"DefaultValue": "0x00",
"DisplayName": "AdaptiveRefreshMgmtLevel",
"HelpText": "ARFM Level when ... ",
"MenuPath": "./",
"ReadOnly": false,
"Type": "Enumeration",
"Value": [
{
"ValueDisplayName": "Default",
"ValueName": "0x0"
},
{
"ValueDisplayName": "Level A",
"ValueName": "0x1"
},
{
"ValueDisplayName": "Level B",
"ValueName": "0x2"
},
{
"ValueDisplayName": "Level C",
"ValueName": "0x3"
}
]
},
{
"AttributeName": "ADDDCEn",
"CurrentValue": "0x00",
"DefaultValue": "0x00",
"DisplayName": "ADDDCEn",
"HelpText": "Enable/Disable ADDDC Sparing",
"MenuPath": "./",
"ReadOnly": false,
"Type": "Enumeration",
"Value": [
{
"ValueDisplayName": "Disable",
"ValueName": "0x0"
},
{
"ValueDisplayName": "Enable",
"ValueName": "0x1"
}
]
}

Change-Id: I77b091fe86db21906c2556bb1be87aafc712bc76
Signed-off-by: Arun Lal K M <arun.lal@intel.com>

show more ...

Add association between FabricAdapter and Port

As a course of implementing PortCollection and Port schemas,
this commit adds a new association to describe the links
between FabricAdapter and Port.

Add association between FabricAdapter and Port

As a course of implementing PortCollection and Port schemas,
this commit adds a new association to describe the links
between FabricAdapter and Port.

- FabricAdapter may be "connected_to" one or more ports,
- A port may also be "connecting" one or more items.

The generic associations of 'containing' and 'contained_by'
are considered, but they are for the physically "containing" items.

Related schemas are:

- https://redfish.dmtf.org/schemas/v1/Port.v1_8_0.json

```
"Links": {
"description": "The links to other resources that are related to this resource.",
"properties": {
"AssociatedEndpoints": {
"description": "An array of links to the endpoints at the other end of the link.",
"items": {
"$ref": "http://redfish.dmtf.org/schemas/v1/Endpoint.json#/definitions/Endpoint"
},
"longDescription": "This property shall contain an array of links to resources of type Endpoint that represent the endpoints to which this port is connected.",
"readonly": true,
"type": "array"
},
"AssociatedEndpoints@odata.count": {
"$ref": "http://redfish.dmtf.org/schemas/v1/odata-v4.json#/definitions/count"
},
```

- https://redfish.dmtf.org/schemas/v1/FabricAdapter.v1_5_0.json

```
"Ports": {
"$ref": "http://redfish.dmtf.org/schemas/v1/PortCollection.json#/definitions/PortCollection",
"description": "The link to the collection of ports that exist on the fabric adapter.",
"longDescription": "This property shall contain a link to a Resource Collection of type PortCollection.",
"readonly": true
},
```

Change-Id: I2cc8caf0128bf1cfa619312e689fe02039977e44
Signed-off-by: Myung Bae <myungbae@us.ibm.com>

show more ...

Add Network Static Route D-bus Interface

Static routing provides the network administrator with full
control over the routing behavior of the BMC network.

This commit adds static route d-bus interf

Add Network Static Route D-bus Interface

Static routing provides the network administrator with full
control over the routing behavior of the BMC network.

This commit adds static route d-bus interface and properties
required.

Change-Id: Ib6abea1a9ce2f55cb54489c334b0072bf4fb726e
Signed-off-by: Ravi Teja <raviteja28031990@gmail.com>

show more ...

Add a new dbus interface to get list of consoles

The "xyz.openbmc_project.Console.Access" interface will provide a
single property containing the name of the abstract socket for the
object hosting t

Add a new dbus interface to get list of consoles

The "xyz.openbmc_project.Console.Access" interface will provide a
single property containing the name of the abstract socket for the
object hosting the interface. The caller can use mapper function to
find the list of registered consoles. The bmcweb can exploit this
interface by putting console for each console object.

The SocketName attribute provides unix abstract socket name and it's
first character is always null, the attribute type is an array of bytes
types instead of string type. The byte array does not include a null
terminator.

For example, object path and property exposed for host console is as
follows:
Object:
/xyz/openbmc_project/console/host
Property:
SocketName -> "\0obmc-console.host"

The tree for console0:
$ busctl tree xyz.openbmc_project.Console.console0
`-/xyz
`-/xyz/openbmc_project
`-/xyz/openbmc_project/console
`-/xyz/openbmc_project/console/console0

The introspect for console0:
busctl introspect xyz.openbmc_project.Console.console0 /xyz/openbmc_project/console/console0
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Console.Access interface - - -
.SocketName property ay 22 0 111 98 109 99 45 99 111 110 115 ... -

Related commits:
1) phosphor-dbus-interface: https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/61486
2) obmc-console: https://gerrit.openbmc.org/c/openbmc/obmc-console/+/62496
3) bmcweb: https://gerrit.openbmc.org/c/openbmc/bmcweb/+/62525

Change-Id: Ic50d311b327d9a4d917e4656af3ebeebfe95b5c9
Signed-off-by: Ninad Palsule <ninadpalsule@us.ibm.com>

show more ...

Add a new interface for ThermalDirection

This (xyz.openbmc_project.Inventory.Decorator.ThermalDirection)
interface will provide the general direction of the thermal
management path through the chass

Add a new interface for ThermalDirection

This (xyz.openbmc_project.Inventory.Decorator.ThermalDirection)
interface will provide the general direction of the thermal
management path through the chassis. It will indicate the
airflow direction of the chassis.

This patch is referred based on the below bmcweb patch.
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/61603

Tested: Tested and verified the interface with client and
server file creation.

Change-Id: I4620def4cf9e2401a531495caa8e25e589fe576d
Signed-off-by: Jayashree Dhanapal <jayashree-d@hcl.com>

show more ...

Power-interface: Revise released signal with pressing duration

Revise signal Released to bring power button pressing duration in microseconds

Tested:
Monitor Released dbus signal

Change-Id: Ic94bb

Power-interface: Revise released signal with pressing duration

Revise signal Released to bring power button pressing duration in microseconds

Tested:
Monitor Released dbus signal

Change-Id: Ic94bbb304d5774efc48cf77e18d92c2285cdd0a2
Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>

show more ...

updated telemetry service API

Reverted addReport function to take multiple parameters instead of list
of variants. Removed errors property from Report.

Change-Id: Idd9ac31958142b7ce120fad676877b722

updated telemetry service API

Reverted addReport function to take multiple parameters instead of list
of variants. Removed errors property from Report.

Change-Id: Idd9ac31958142b7ce120fad676877b7226a32be7
Signed-off-by: Krzysztof Grobelny <krzysztof.grobelny@intel.com>

show more ...

Cpu: Convert `Step` default value to maxint

https://gerrit.openbmc.org/c/openbmc/bmcweb/+/57143/3/redfish-core/lib/processor.hpp
makes the bmcweb ignore `Step` if its value is default (0 in this cas

Cpu: Convert `Step` default value to maxint

https://gerrit.openbmc.org/c/openbmc/bmcweb/+/57143/3/redfish-core/lib/processor.hpp
makes the bmcweb ignore `Step` if its value is default (0 in this case).
For a new processor, it's possible that the stepping is really `0`. In
this case, the `Step` will still be ignored which is not expected.
Changing its default to maxint can avoid this issue.

Change-Id: I0e40c65c943f1deb62b8d81f4b5259385af06700
Signed-off-by: Michael Shen <gpgpgp@google.com>

show more ...

Power.Cap: add properties to control Power Limit

Based on the chapter 6.6 - Power management of DCMI specification, BMC
needs more information to control Power Lmit.

This commit adds 3 properties t

Power.Cap: add properties to control Power Limit

Based on the chapter 6.6 - Power management of DCMI specification, BMC
needs more information to control Power Lmit.

This commit adds 3 properties to control Power Limit, the list of
added properties as below:
1. ExceptionAction: Exception Action
2. CorrectionTime: Correction time in microseconds
3. SamplingPeriod: Sampling period in microseconds

Those properties are used to monitor total power consumption, depending
on the user's configuration, BMC can turn off the power/log event only
or do nothing when the total power consumption is greater than the power
limit.

Change-Id: I981f06855d6a55b1207541c84d53d774d0d25491
Signed-off-by: Thang Tran <thuutran@amperecomputing.com>

show more ...

Add support for HotPluggable

This property describes if item can be hotplugged.

Tested: Tested and verified in YosemiteV2 platform.

Change-Id: I37dc08f57de3bcc7148f5bf8c7309f08a330890b
Signed-off-

Add support for HotPluggable

This property describes if item can be hotplugged.

Tested: Tested and verified in YosemiteV2 platform.

Change-Id: I37dc08f57de3bcc7148f5bf8c7309f08a330890b
Signed-off-by: Logananth Sundararaj <logananth_s@hcl.com>

show more ...

Chassis.Intrusion: Add Rearm property

This patch adds Rearm property under
"xyz.openbmc_project.Chassis.Intrusion" interface, to specify
the method for rearming the chassis cover and updating the
"S

Chassis.Intrusion: Add Rearm property

This patch adds Rearm property under
"xyz.openbmc_project.Chassis.Intrusion" interface, to specify
the method for rearming the chassis cover and updating the
"Status" property. As defined in Redfish schema specification,
this property is optional and can take "Automatic" or "Manual".
If not set, "Rearm" will default to "Automatic", which will
directly update the raw chassis intrusion status to the "Status"
property. If set to "Manual", after an intrusion event, the
"Status" property will be kept to "HardwareIntrusion", no update
accepted, until a reset event happends for it to be updated normally
again.

Signed-off-by: Chau Ly <chaul@amperecomputing.com>
Change-Id: I73f6404a03184bea828727dcab4c38cbe2bdf35f

show more ...

Add additional variant types for Notify D-Bus method

Add uint16_t and array[string] as variant types for
Notify method

Change-Id: Ic3c7accfb872815d60d1aef18c627abefc9e4c99
Signed-off-by: Pavithra B

Add additional variant types for Notify D-Bus method

Add uint16_t and array[string] as variant types for
Notify method

Change-Id: Ic3c7accfb872815d60d1aef18c627abefc9e4c99
Signed-off-by: Pavithra Barithaya <pavithra.b@ibm.com>

show more ...

Add a new chassisType for Redfish

ChassisType "Blade" is added under Chassis interface to represent
the multihost system chassis which can be plugged in OCP platform.

Tested: Tested in Facebook Yos

Add a new chassisType for Redfish

ChassisType "Blade" is added under Chassis interface to represent
the multihost system chassis which can be plugged in OCP platform.

Tested: Tested in Facebook YosemiteV2 platform.

Change-Id: Ia3ca61b01b96e4febd0d2054ad19d01c70bfed24
Signed-off-by: Jayashree Dhanapal <jayashree-d@hcl.com>

show more ...

add Enabled properties and remove unused methods nmiEnable

Currently, x86-power-control is using property "Enabled"
to monitor NMI Source. But, NMISource.interface.yaml didn't
have this "Enabled" pr

add Enabled properties and remove unused methods nmiEnable

Currently, x86-power-control is using property "Enabled"
to monitor NMI Source. But, NMISource.interface.yaml didn't
have this "Enabled" property and the methods "nmiEnable" seems
unused in current openbmc design, remove it avoid usage confusion.

Signed-off-by: Tim Lee <timlee660101@gmail.com>
Change-Id: I1d7751cfe0de6c919ecd0deaea4a801db4d8b86e

show more ...

Add ObjectManager path requirement for Voltage Regulator interfaces

Add the requirement/expectation of org.freedesktop.DBus.ObjectManager on
services implementing Control.VoltageRegular{Mode,Control

Add ObjectManager path requirement for Voltage Regulator interfaces

Add the requirement/expectation of org.freedesktop.DBus.ObjectManager on
services implementing Control.VoltageRegular{Mode,Control}.

The ObjectManager is expected to be implemented at
/xyz/openbmc_project/vr.

Currently, dbus-sdr specifically calls out the paths it uses to find the
ObjectManager, instead of using "/" which would find any ObjectManager
implemented at any location. "/xyz/openbmc_project/sensors" is listed in
dbus-sdr and in phosphor-dbus-interfaces now. This changes adds
"/xyz/openbmc_project/vr".

Change-Id: I6c74323189b74958301b445d6dc9a993a495e62f
Signed-off-By: Sui Chen <suichen@google.com>

show more ...

bootprogress: add OEM value for ProgressStages enumerations

This commit adds the OEM enumerations for the ProgressStages to
indicate the last stage is OEM as defined in the DSP0268_2021.2
Redfish Sc

bootprogress: add OEM value for ProgressStages enumerations

This commit adds the OEM enumerations for the ProgressStages to
indicate the last stage is OEM as defined in the DSP0268_2021.2
Redfish Schema Supplement.pdf specification and DEN0069D_SBMR_2.0.pdf
document section F.2.2.

Signed-off-by: Hieu Huynh <hieuh@os.amperecomputing.com>
Change-Id: I5a2b5943df54d5208fb847c7b9e89c09af3b73cd

show more ...

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts (and
copy latest config files where appropriate). Fix a few minor
markdownlint issues.

Signed-off-by: Pat

reformat with latest settings

Reformat with the latest settings from openbmc-build-scripts (and
copy latest config files where appropriate). Fix a few minor
markdownlint issues.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I55205817c29dc3f182a165ddf9cd5d4e07b90063

show more ...

Convert ServiceProviderNotify to enum

Converted ServiceProviderNotify to an enum.
Supported options are - "NotSupported", "Notify" and "Inhibit".

Changes in phosphor-logging are at the link below
h

Convert ServiceProviderNotify to enum

Converted ServiceProviderNotify to an enum.
Supported options are - "NotSupported", "Notify" and "Inhibit".

Changes in phosphor-logging are at the link below
https://gerrit.openbmc.org/c/openbmc/phosphor-logging/+/58815

For more details on the discussion look at the link below.
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/46886/7/redfish-core/lib/log_services.hpp#1411

Signed-off-by: Vijay F Lobo <vflobo@us.ibm.com>
Change-Id: Iefe95a5531792bc79e363923deb7fc894774ee67
Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>

show more ...