Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: I8870ce249bba3373e85f82903cfa875d6a7c8725
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

Populate MinimumVersion property

The Minimum Version is now an available D-Bus interface:
```
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/70110
```
Populate its value if it's bei

Populate MinimumVersion property

The Minimum Version is now an available D-Bus interface:
```
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/70110
```
Populate its value if it's being defined.

Tested: If the msl meson options are defined, the D-Bus property is
populated with the value of the defined minimum version:
```
root@witherspoon:~# busctl get-property xyz.openbmc_project.Software.BMC.Updater /xyz/openbmc_project/software xyz.openbmc_project.Software.MinimumVersion MinimumVersion
s "2.15.0"
```

Change-Id: I0f9df0cfd7c06794df836e161b3416094a8535de
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

meson: Provide wrap file for boost

Currently local build on the system without boost can fail with
the following message:
"""
meson.build: ERROR: Dependency "boost" not found, tried system
"""
Provi

meson: Provide wrap file for boost

Currently local build on the system without boost can fail with
the following message:
"""
meson.build: ERROR: Dependency "boost" not found, tried system
"""
Provide "boost.wrap" file to fix the issue.

Change-Id: Ia0344626f844c8f2da4cb3322819730549ad8d4f
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: Add boost to the dependencies

Since the project uses boost library add it to meson dependencies.

Tested:
Local build no longer fails with a missing boost headers message on the
system withou

meson: Add boost to the dependencies

Since the project uses boost library add it to meson dependencies.

Tested:
Local build no longer fails with a missing boost headers message on the
system without boost, but fails at the "meson setup build" stage with
an appropriate message.

Change-Id: I165fb61cf72adadbb1f67d64e378f84b0256307f
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: Fix local cereal build

Currently local build is failing with a message:
"""
cereal| Exception: Failed to configure the CMake subproject: Could NOT
find Boost (missing: Boost_INCLUDE_DIR seria

meson: Fix local cereal build

Currently local build is failing with a message:
"""
cereal| Exception: Failed to configure the CMake subproject: Could NOT
find Boost (missing: Boost_INCLUDE_DIR serialization)
Subproject subprojects/cereal is buildable: NO (disabling)
"""
Since cereal requires boost only for the sandbox build and this
functionality is not needed, add option to skip building performance
sandbox comparison to solve the issue.

Tested:
"meson setup build" no longer fails with the cereal error.

Change-Id: I3d5a6e02a10d853f6487806a4d04252e15d755ed
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

OWNERS: Update Gunnar's email address

I have multiple email addresses in my Gerrit account but as
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69506 shows my Preferred
email has to match the OWNERS

OWNERS: Update Gunnar's email address

I have multiple email addresses in my Gerrit account but as
https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69506 shows my Preferred
email has to match the OWNERS file, do that.

More discussion in Discord at
[1] https://discord.com/channels/775381525260664832/817151035197358081/1209585278025601094

Tested: With https://gerrit.openbmc.org/c/openbmc/bmcweb/+/69549 my +2
means something again.

Change-Id: Ia1460e85e418b75844abae7d5cce282cd1f66d7f
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

errors: Use non-deprecated namespaces

The error namespaces have been updated. Reference:
https://gerrit.openbmc.org/c/openbmc/sdbusplus/+/66308
https://gerrit.openbmc.org/c/openbmc/phosphor-logging/

errors: Use non-deprecated namespaces

The error namespaces have been updated. Reference:
https://gerrit.openbmc.org/c/openbmc/sdbusplus/+/66308
https://gerrit.openbmc.org/c/openbmc/phosphor-logging/+/66463

Tested: Compiled with the SDBUSPP_REMOVE_DEPRECATED_NAMESPACE option.

Change-Id: Idd1ca6f14635039bd8bd2f34d69afd3e97588648
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

owners: updated George email

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I2599be7c46bb1a9209bc44e843f75327420821d4

Updated to use errno instead of error_code in lg2

Since the std::error_code parameter is used in the std::filesystem
library to capture exception errors, but for some methods (such as
exists), if th

Updated to use errno instead of error_code in lg2

Since the std::error_code parameter is used in the std::filesystem
library to capture exception errors, but for some methods (such as
exists), if the file does not exist, the error_code is still 0,
because it is explained in cppreference:

```
Sets a std::error_code& parameter to the OS API error code if an OS
API call fails, and executes ec.clear() if no errors occur.
```

So the log printed as "Failed to find xxx file: success", This isn't
very clear about this log description, why the file is not found, and
then success is printed. So before printing the ec, we should first
check if it is non-zero.

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: I2829a5d3c22b14b8e03077f62869fb2195b19680

show more ...

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur

build: use allowed over enabled

Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.

Switch all uses of `enabled` to `allowed`.

Change-Id: Iebfa27c0094b2001eb3f87fcfbbf209d803d2190
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ie6cf6dc72e865345ac2534dfeccd9b5b99e2b7af
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Remove check for the 'verify-full-signature' option

'verify-full-signature' option is a legacy option that was recently
dropped from the build configuration. Therefore the build system
shouldn't che

Remove check for the 'verify-full-signature' option

'verify-full-signature' option is a legacy option that was recently
dropped from the build configuration. Therefore the build system
shouldn't check it.

Change-Id: I3a8be29991bd50d074fcfd6aa9d61a8777e5694e
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: Drop legacy 'verify-signature' option

Currently there are two options for the image signature verification:
- 'verify-signature' (legacy),
- 'verify-full-signature' (current).

Drop legacy op

meson: Drop legacy 'verify-signature' option

Currently there are two options for the image signature verification:
- 'verify-signature' (legacy),
- 'verify-full-signature' (current).

Drop legacy option and let the current one take its place.

Change-Id: Ia205424395179fd190e3d055159beca93cff0545
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

elog-errors: remove generated file

Since we use meson subprojects to build this repository outside of
Yocto, there is no need to carry along a pre-generated elog-errors
file anymore. Remove it and

elog-errors: remove generated file

Since we use meson subprojects to build this repository outside of
Yocto, there is no need to carry along a pre-generated elog-errors
file anymore. Remove it and ensure all code is using the real one
from phosphor-logging.

The Software.Image errors have been moved over to
phosphor-dbus-interfaces and can be used from there. Remove them from
this repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic16fdef298361a878644e989b661f6312af8a0cb

show more ...

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using t

meson_options.txt: Support for reading options from meson.options

Support has been added for reading options from meson.options instead
of meson_options.txt[1]. These are equivalent, but not using the .txt
extension for a build file has a few advantages, chief among them
many tools and text editors expect a file with the .txt extension to
be plain text files, not build scripts.

[1] https://mesonbuild.com/Release-notes-for-1-1-0.html#support-for-reading-options-from-mesonoptions

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I2468f7c524e8e0596e3e1feef0c38c9f83b91313

show more ...

sdbus++: use non-deprecated namespaces

The sdbusplus repository has deprecated some namespaces and they are
currently only enabled with the SDBUSPP_REMOVE_DEPRECATED_NAMESPACE
guard. Switch to the

sdbus++: use non-deprecated namespaces

The sdbusplus repository has deprecated some namespaces and they are
currently only enabled with the SDBUSPP_REMOVE_DEPRECATED_NAMESPACE
guard. Switch to the new namespace names.

Change-Id: Iaab6df118eb4dc65139e759dcb22851422f88389
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I897133dfa2ee421145e54

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: I897133dfa2ee421145e541e6e4309a3c2fa60f2a
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

mmc: Don't remove hostfw if it's not being updated

The image-hostfw is optional, therefore don't delete it unless it's
going to be updated, to prevent ending up with a system that doesn't
have a bio

mmc: Don't remove hostfw if it's not being updated

The image-hostfw is optional, therefore don't delete it unless it's
going to be updated, to prevent ending up with a system that doesn't
have a bios image to boot with.

Tested: Verify the hostfw image doesn't get deleted unless the tarball
contains an image-hostfw file.

Change-Id: Ifd48988d1a499eb8a3539701f12ca43efcb56f6d
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

mmc: Run fsck on the alternate image and hostfw

Before mounting the alternate image, run fsck on it to determine if the
filesystem is corrupted, this could happen if the BMC rebooted in the
middle o

mmc: Run fsck on the alternate image and hostfw

Before mounting the alternate image, run fsck on it to determine if the
filesystem is corrupted, this could happen if the BMC rebooted in the
middle of a code update for example. Invalidate the image if it's found
to be corrupted.

Run fsck on the hostfw partition too, this is a writable partition that
can benefit from autocorrection. The mmc initramfs runs fsck on the rwfs
partition already. It's a good practice to run fsck on writable
partitions. Do not fail if fsck fails on the hostfw partition, if it's
corrupted, an error would occur during the power on.

Tested: Verified there were no errors with this change. This change adds
about 1s to the execution of the mount service, from 5s to 6s to start:

May 24 19:07:27 p10bmc systemd[1]: Starting Mount BMC rofs volumes
after a reboot...
May 24 19:07:27 p10bmc obmc-flash-bmc[328]:
/dev/disk/by-partlabel/rofs-a: clean, 6430/68816 files, 192421/275012
blocks
May 24 19:07:27 p10bmc kernel: EXT4-fs (mmcblk0p4): mounted
filesystem with ordered data mode. Quota mode: disabled.
May 24 19:07:33 p10bmc fsck.ext4[474]: hostfw: clean, 247/655360
files, 196363/1310720 blocks
May 24 19:07:34 p10bmc kernel: EXT4-fs (mmcblk0p7): mounted
filesystem with ordered data mode. Quota mode: disabled.
May 24 19:07:34 p10bmc systemd[1]: obmc-flash-mmc-mount.service:
Deactivated successfully.
May 24 19:07:34 p10bmc systemd[1]: Finished Mount BMC rofs volumes
after a reboot.

Change-Id: I0efedb6d72e1d0d6018974598c4b361eafe7441b
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

fix GCC 13 issues

GCC 13 removes `uint*_t` family of types from one of the common
includes so we need to explicitly include cstdint.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I

fix GCC 13 issues

GCC 13 removes `uint*_t` family of types from one of the common
includes so we need to explicitly include cstdint.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7224585f0421b729b8a6b703851f5a000ab2d900

show more ...

systemd: no installation in templated targets

Upstream yocto introduced a change via e510222 (systemd-systemctl:
fix instance template WantedBy symlink construction).

This fixes a bug that we in Op

systemd: no installation in templated targets

Upstream yocto introduced a change via e510222 (systemd-systemctl:
fix instance template WantedBy symlink construction).

This fixes a bug that we in OpenBMC had been taking advantage of in that
we were able to document our templated target dependencies without it
actually doing anything. The real installation of services within
targets occurs in our bitbake recipes due to the complexity of chassis
and host instances on a per machine basis.

Leave the dependency information in the service files but comment them
out. It's useful to be able to look at a service and understand which
targets it's going to be installed into by the bitbake recipes.

In some cases, we had hard coded the target instance, which does install
the service correctly, but only in that one target. All services should
be installed via the bitbake recipe to ensure the service is properly
installed in all instances of the target. Once the bump for this commit
goes into openbmc/openbmc, I will ensure the recipe is updated to
install all services correctly.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I401f988e92efb37f4928b14433b9d3035ec462d5

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: I50e60f2b1a9db9039cb5450ae509064eaeaa9d2e
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: Disable 'verify-signature' option by default

Currently the 'verify-signature' option is enabled by default, and
there is no way to disable it via recipe PACKAGECONFIG.
As a result 'Software::

meson: Disable 'verify-signature' option by default

Currently the 'verify-signature' option is enabled by default, and
there is no way to disable it via recipe PACKAGECONFIG.
As a result 'Software::Version::Error::InvalidSignature' is generated
on unsigned updates even if user did not enable signature verification
feature.
Disable 'verify-signature' option by default to correct the issue.
If user enables signature verification feature the option
'verify-full-signature' is enabled which provides desired functionality.

Change-Id: Ie143bf7922115ec529a0d30fb68e7c26bce0be77
Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: I46c094c1a1e4793556e93f9e5158bff7c6042cc4
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

side-switch: adapt do chassis state instance change

phosphor-state-manager moved to a multi chassis and multi host design
point. This made their corresponding service files instance based. For
backw

side-switch: adapt do chassis state instance change

phosphor-state-manager moved to a multi chassis and multi host design
point. This made their corresponding service files instance based. For
backwards support, instance 0 will always represent the entire system,
so utilize that as the dependency in this service file.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I6a32ff5944b803cdeaa4ba9fd5faa0e3d49263fe

show more ...