clang-tidy: Enable readability-simplify-boolean-expr check

This check looks for boolean expressions involving boolean
constants and simplifies them to use the appropriate boolean
expression directly

clang-tidy: Enable readability-simplify-boolean-expr check

This check looks for boolean expressions involving boolean
constants and simplifies them to use the appropriate boolean
expression directly.

Change-Id: I79d7e4486bd0ea5f5b9b5a1644af99384e41e251
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable readability-redundant-smartptr-get check

This check finds and removes redundant calls to smart pointer’s
.get() method.

Change-Id: I0cc34b41fb118a93673e36cd684b67e147ab914a
Signe

clang-tidy: Enable readability-redundant-smartptr-get check

This check finds and removes redundant calls to smart pointer’s
.get() method.

Change-Id: I0cc34b41fb118a93673e36cd684b67e147ab914a
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable readability-isolate-declaration check

This check detects local variable declarations declaring more than
one variable and tries to refactor the code to one statement per
declarati

clang-tidy: Enable readability-isolate-declaration check

This check detects local variable declarations declaring more than
one variable and tries to refactor the code to one statement per
declaration.

Change-Id: Ie51ae4cbabb0d71e26e8cacd329a0886604395a9
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable readability-string-compare check

This check finds string comparisons using the compare method.
A common mistake is to use the string’s compare method instead of
using the equality

clang-tidy: Enable readability-string-compare check

This check finds string comparisons using the compare method.
A common mistake is to use the string’s compare method instead of
using the equality or inequality operators.

Change-Id: I261afa51d6af1db5afb94a127f45df7544911af9
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable readability-braces-around-statements check

This checks that bodies of if statements and loops (for, do while,
and while) are inside braces.

Change-Id: Iaf9d170f179f2363b632cbbc7d

clang-tidy: Enable readability-braces-around-statements check

This checks that bodies of if statements and loops (for, do while,
and while) are inside braces.

Change-Id: Iaf9d170f179f2363b632cbbc7da7b0ea3220aee7
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable readability-named-parameter check

This check finds functions with unnamed arguments.

Change-Id: I48e2eadbece410843559cd6077d67019e6e0464b
Signed-off-by: Pavithra Barithaya <pavit

clang-tidy: Enable readability-named-parameter check

This check finds functions with unnamed arguments.

Change-Id: I48e2eadbece410843559cd6077d67019e6e0464b
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable readability checks on repo

The readability-* checks in Clang-Tidy focus on improving code
readability by enforcing guidelines and suggesting improvements
that can enhance the clar

clang-tidy: Enable readability checks on repo

The readability-* checks in Clang-Tidy focus on improving code
readability by enforcing guidelines and suggesting improvements
that can enhance the clarity and maintainability of C++ code.

Change-Id: I93bbafe9bcf59fc0078a24f2013c516445438999
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable performance-unnecessary-value-param check

This check flags value parameter declarations of expensive to copy
types that are copied for each invocation but it would suffice to
pass

clang-tidy: Enable performance-unnecessary-value-param check

This check flags value parameter declarations of expensive to copy
types that are copied for each invocation but it would suffice to
pass them by const reference.

Change-Id: I631deda63fcbb74362313c9596bf7e72933b0d0c
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable performance-for-range-copy check

This check optimizes performance in C++ for range-based loops
(for (auto element : container)), the key consideration is to
avoid unnecessary copi

clang-tidy: Enable performance-for-range-copy check

This check optimizes performance in C++ for range-based loops
(for (auto element : container)), the key consideration is to
avoid unnecessary copies of elements, especially when dealing with
larger or more complex objects.

Change-Id: I3349630950f72e1c0365b2ab23b7858c1bfbc9d4
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable performance-faster-string-find check

This check optimizes the calls to std::string::find() when the
input passed is a single character string literal. The character
literal overlo

clang-tidy: Enable performance-faster-string-find check

This check optimizes the calls to std::string::find() when the
input passed is a single character string literal. The character
literal overload is more efficient.

Change-Id: I3c95a4214a4e858697c4b40927e0ef990ea86cef
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Add performance checks

The checks are valuable for improving the runtime efficiency and
resource utilization of your programs.

Change-Id: I2584258c88981f565c2f005c59e46d55defe2073
Signe

clang-tidy: Add performance checks

The checks are valuable for improving the runtime efficiency and
resource utilization of your programs.

Change-Id: I2584258c88981f565c2f005c59e46d55defe2073
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Add few misc checks

Checks that encompass various miscellaneous guidelines and rules
that don't fall into more specific categories like readability,
performance, or correctness. These ch

clang-tidy: Add few misc checks

Checks that encompass various miscellaneous guidelines and rules
that don't fall into more specific categories like readability,
performance, or correctness. These checks often focus on code
quality, stylistic preferences, or potential pitfalls that are
not covered by other specific checks.

Change-Id: Id01e06f3ef5e904887a6f0a7ca4f7c617f41b478
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable cppcoreguidelines-explicit-virtual-functions

This check enforces guidelines related to explicitly specifying
override or final when overriding virtual functions in C++
classes.

C

clang-tidy: Enable cppcoreguidelines-explicit-virtual-functions

This check enforces guidelines related to explicitly specifying
override or final when overriding virtual functions in C++
classes.

Change-Id: I5c7de19e9f7521f4b8a947a25540a44c400da104
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable cppcoreguidelines-special-member-functions

This check finds classes where some but not all of the special
member functions are defined.

Change-Id: Ic677e32df810c07eb5e4cc0fd14a03

clang-tidy: Enable cppcoreguidelines-special-member-functions

This check finds classes where some but not all of the special
member functions are defined.

Change-Id: Ic677e32df810c07eb5e4cc0fd14a03c4d6c376bb
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Add few cppcoreguidelines check

These checks cover a wide range of best practices and
recommendations aimed at improving the safety, readability,
maintainability, and performance of our

clang-tidy: Add few cppcoreguidelines check

These checks cover a wide range of best practices and
recommendations aimed at improving the safety, readability,
maintainability, and performance of our C++ codebase according
to the C++ Core Guidelines.

Change-Id: Icf692ee5ab826d6cdaa5f8c64e50e67a332ec173
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Add clang-analyzer checks

This checks primary purpose is to identify potential bugs,security
vulnerabilities, and adherence to coding standards by examining
the source code without execu

clang-tidy: Add clang-analyzer checks

This checks primary purpose is to identify potential bugs,security
vulnerabilities, and adherence to coding standards by examining
the source code without executing it.

Change-Id: I5cd2ecb4df182e766d4d118fdefeae4931df422b
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable bugprone-narrowing-conversions check

This check indicates instances where there's a potential loss of
data during type conversions, particularly when converting from
a wider type

clang-tidy: Enable bugprone-narrowing-conversions check

This check indicates instances where there's a potential loss of
data during type conversions, particularly when converting from
a wider type to a narrower type.

Change-Id: I43f3d9ff4a6d672f51c7b2d3eccca90f262fa852
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Add cert checks

clang-tidy provides a wide range of checks, including those that
cover CERT guidelines, through various modules and checks
specifically designed to catch potential securi

clang-tidy: Add cert checks

clang-tidy provides a wide range of checks, including those that
cover CERT guidelines, through various modules and checks
specifically designed to catch potential security vulnerabilities
and non-compliance with secure coding standards.

Change-Id: I87ffd146947e85ee8a92233cff9b8f8b7d1ce12b
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-tidy: Enable bugprone-implicit-widening-of-multiplication-result

The check diagnoses instances where a result of a multiplication is
implicitly widened, and suggests (with fix-it) to either si

clang-tidy: Enable bugprone-implicit-widening-of-multiplication-result

The check diagnoses instances where a result of a multiplication is
implicitly widened, and suggests (with fix-it) to either silence
the code by making widening explicit, or to perform the
multiplication in a wider type, to avoid the widening afterwards.

Change-Id: I97b1b3d3158d753e70bd2bd98f7938dc6e35af5a
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

Add clang-tidy to BMC-Code Management repo

This commit enables clang-tidy and adds few tidy checks.

Change-Id: Ic0e8d6b26381cf7aeea43d1789c97f1ddaf98f91
Signed-off-by: Pavithra Barithaya <pavithrab

Add clang-tidy to BMC-Code Management repo

This commit enables clang-tidy and adds few tidy checks.

Change-Id: Ic0e8d6b26381cf7aeea43d1789c97f1ddaf98f91
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-error: fix clang-diagnostic-inconsistent-missing-override error

This clang-error is generated when a function overrides a member
function but is not marked 'override'.

Change-Id: If27a9a75ae1

clang-error: fix clang-diagnostic-inconsistent-missing-override error

This clang-error is generated when a function overrides a member
function but is not marked 'override'.

Change-Id: If27a9a75ae1d7b6112226e233db30421a02e8556
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

clang-error: fix clang-diagnostic-defaulted-function-deleted error

The clang-diagnostic-defaulted-function-deleted error is generated when
explicitly defaulted move assignment operator is implicitly

clang-error: fix clang-diagnostic-defaulted-function-deleted error

The clang-diagnostic-defaulted-function-deleted error is generated when
explicitly defaulted move assignment operator is implicitly deleted.
This commit fixes those errors.

Change-Id: Id62b89eb3b58b819799194be91516f7c5e9cadc6
Signed-off-by: Pavithra Barithaya <pavithrabarithaya07@gmail.com>

show more ...

fix for phoshphor-software-manager start issue

Since, the earlier fix adds an empty app, it keeps on restarting because
it exits soon. Add logic for ctx run so app doesn't exit.

Change-Id: I0783af4

fix for phoshphor-software-manager start issue

Since, the earlier fix adds an empty app, it keeps on restarting because
it exits soon. Add logic for ctx run so app doesn't exit.

Change-Id: I0783af4121cd84044b2800742decef9634f2032f
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

host_bios_upgrade: Add Updateable Association

Let BIOS Object make updateable association, so that
Redfish would show "Updateable": true just like other

Testing:
curl https://*/UpdateService/Firmwa

host_bios_upgrade: Add Updateable Association

Let BIOS Object make updateable association, so that
Redfish would show "Updateable": true just like other

Testing:
curl https://*/UpdateService/FirmwareInventory/bios_active
{
"@odata.id": "/*/UpdateService/FirmwareInventory/bios_active",
"@odata.type": "#SoftwareInventory.v1_1_0.SoftwareInventory",
"Description": "Host image",
"Id": "bios_active",
"Name": "Software Inventory",
"RelatedItem": [
{
"@odata.id": "/redfish/v1/Systems/system/Bios"
}
],
"RelatedItem@odata.count": 1,
"Status": {
"Health": "OK",
"HealthRollup": "OK",
"State": "Enabled"
},
"Updateable": true,
"Version": "null"
}

Change-Id: I22614f7e5bf55764c785ad6c085162c5a3a45cc2
Signed-off-by: Daniel Hsu <Daniel-Hsu@quantatw.com>

show more ...

start-update-interface: add the new app

Add the meson option for the start update D-Bus interface
implementation. Add the SoftwareManager new daemon to run in parallel
with existing code. The intent

start-update-interface: add the new app

Add the meson option for the start update D-Bus interface
implementation. Add the SoftwareManager new daemon to run in parallel
with existing code. The intention for new daemon is to combine
ImageManager and ItemUpdater into one. After due testing and
verifications ImageManager and ItemUpdater would be retired for
SoftwareManager. For more more details on design refer to -
https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/65738
https://gerrit.openbmc.org/c/openbmc/docs/+/65739

Change-Id: Id11823ca0ff62e76595aa4ad33212a2a2428c261
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...