Fix rsync unexpectly skip file

Normally rsync will skip any files that are already the same size and
have the same modification timestamp. Due to this, if 2 modify event
in one file happen in a shor

Fix rsync unexpectly skip file

Normally rsync will skip any files that are already the same size and
have the same modification timestamp. Due to this, if 2 modify event
in one file happen in a short time, the second modify event will be
skipped by rsync.

This patch add a new option `-I` (--ignore-times) to rsync, which
sync file forcely even if the file size and modification timestamp
are the same.

Before this patch:
1. Prepare the file `foo`, content is:
```
123
```

2. Modify the file `foo` twice in a short time.
Note: Don't Change the File Size. I use this cpp code to mock.
```
\#include <fstream>
\#include <thread>

int main() {
std::ofstream file("foo");
file << "foo";
file.close();

std::this_thread::sleep_for(std::chrono::milliseconds(200));

std::ofstream file1("foo");
file1 << "bar";
file1.close();

return 0;
}
```

3. Check the syncd file, expect the content is `bar`, but the `foo`
was found.

After this patch the the file `foo` is synced always.

Change-Id: I25799319fed93631aa9d20b5b5efdd7391b585e1
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

Added ExtendedVersion creation to gen-bios-tar

Now with gen-bios-tar you can add the ExtendedVersion
using the -e --extended arguments

Change-Id: I6eb3bd7f3a1e4510c8383d8eff730d6aad827f5c
Signed-of

Added ExtendedVersion creation to gen-bios-tar

Now with gen-bios-tar you can add the ExtendedVersion
using the -e --extended arguments

Change-Id: I6eb3bd7f3a1e4510c8383d8eff730d6aad827f5c
Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>

show more ...

treewide: remove dependencies on mapper.target

The mapper is dbus activated now, so these explicit dependency
declarations are unnecessary and redundant.

Change-Id: Icea089154e642e8296847c30b662979

treewide: remove dependencies on mapper.target

The mapper is dbus activated now, so these explicit dependency
declarations are unnecessary and redundant.

Change-Id: Icea089154e642e8296847c30b6629797a9a1625d
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

Fix the core dump by using filesystem error_code

The currently used filesystem method will cause an exception if the
file system is damaged for some reason, resulting in a core dump of
the process.

Fix the core dump by using filesystem error_code

The currently used filesystem method will cause an exception if the
file system is damaged for some reason, resulting in a core dump of
the process.
So the overloaded method with the error_code parameter should be used
here to ensure that the process core dump will not be caused after an
exception is thrown.

Fixes: openbmc/phosphor-bmc-code-mgmt#12

Tested: built phosphor-bmc-code-mgmt successfully and CI passes.

Signed-off-by: George Liu <liuxiwei@inspur.com>
Change-Id: I329f78b481cb466e755bc1b78562583620f561c2

show more ...

u-boot mirroring support

Design is at the link below.
https://gerrit.openbmc.org/c/openbmc/docs/+/58025

Tested:
Tested all "Test Scenarios" specified in the design.

Signed-off-by: Lakshmi Yadlap

u-boot mirroring support

Design is at the link below.
https://gerrit.openbmc.org/c/openbmc/docs/+/58025

Tested:
Tested all "Test Scenarios" specified in the design.

Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com>
Change-Id: I064115ee1e966a0a1b3ce7ec246c1f88f0bd87f7

show more ...

Removed reset of the interface ActivationProgress

ActivationProgress reset was removing the activationProgress
interface which relates to Task progress. This was causing
failure of the DBus control

Removed reset of the interface ActivationProgress

ActivationProgress reset was removing the activationProgress
interface which relates to Task progress. This was causing
failure of the DBus control commands to set the progress in
the taskID, while BMC Firmware update is in progress.
Moreover, the interface should not be removed after creation
until the Firmware update completes.

Tested:

The DBus control commands work fine after removal of this reset.

Signed-off-by: moni kumar <monix.kumar@intel.com>
Change-Id: I7157b10164759dd3d24f310074867beb08a5dc61

show more ...

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Signed-off-by: Patric

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3e5a9d1fc03aeecd9a305a5270a0ed757ea0c591

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: Ib954d53a0fdfba96a0e0f9bdd2ad75ed3c4f4927
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: remove oe-sdk support

Very few of our projects have this extra code and it doesn't seem
very useful considering we have both meson-subproject support and
developers can use devtool.

Signed-o

meson: remove oe-sdk support

Very few of our projects have this extra code and it doesn't seem
very useful considering we have both meson-subproject support and
developers can use devtool.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I41f8ba99600c04596b4fc37cc5b0ec00976d1e24

show more ...

field mode: restore works on all systems

The restoreFieldModeStatus function previously read from a chip
that is not found on all systems. Changed it to read fieldmode
status using fw_printenv. Upda

field mode: restore works on all systems

The restoreFieldModeStatus function previously read from a chip
that is not found on all systems. Changed it to read fieldmode
status using fw_printenv. Updated utils::executeCmd to return the
print output of the command it executes.

Tested:
On p10bmc running mmc chip:
- Set the fieldmode env variable to "true" and verified FieldModeEnabled
was set to true:
root@p10bmc:~# fw_setenv fieldmode true
root@p10bmc:~# systemctl restart xyz.openbmc_project.Software.BMC.Updater.service
root@p10bmc:~# busctl introspect xyz.openbmc_project.Software.BMC.Updater /xyz/openbmc_project/software
...
xyz.openbmc_project.Control.FieldMode interface - -
.FieldModeEnabled property b true

- Set the fieldmode env variable to "false" (fw_setenv fieldmode false)
and also clear the variable (fw_setenv fieldmode) and verified
FieldModeEnabled was set to false with no error messages in the
journal:
root@p10bmc:~# fw_setenv fieldmode
root@p10bmc:~# systemctl restart xyz.openbmc_project.Software.BMC.Updater.service
root@p10bmc:~# busctl introspect xyz.openbmc_project.Software.BMC.Updater /xyz/openbmc_project/software
...
xyz.openbmc_project.Control.FieldMode interface - -
.FieldModeEnabled property b false

Change-Id: Ib1b54d83f058015ff5967c445a40318a02baae92
Signed-off-by: Isaac Kurth <blisaac91@gmail.com>
Signed-off-by: Adriana Kobylak <anoo@linux.ibm.com>

show more ...

ensure disable of reboot occurs after enable

Seen a few instances where both the enable and disable service seem to
get queued up at the same time (at least so close together that systemd
sees them

ensure disable of reboot occurs after enable

Seen a few instances where both the enable and disable service seem to
get queued up at the same time (at least so close together that systemd
sees them as being requested to run at the same time). This results in a
race condition on which runs first. Bad things happen if the disable
happens to get called before the enable.

Put an explicit dependency in the services so if they are both queued at
the same time, they are run in the correct order.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I0c7a04ede468e200b7fa2ca8184907ebeaf82d5d

show more ...

Fix tar error when packing files

Multiple quoted files are treated by tar as one file.
Test: ran `./gen-bios-tar -v "rev1" -m "MyTestMachine" bios.bin`

Signed-off-by: Glukhov Mikhail <mikl@greenfil

Fix tar error when packing files

Multiple quoted files are treated by tar as one file.
Test: ran `./gen-bios-tar -v "rev1" -m "MyTestMachine" bios.bin`

Signed-off-by: Glukhov Mikhail <mikl@greenfil.ru>
Change-Id: I1a0ad1d0dd89d8830a50fd059acac285156f04da

show more ...

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I93e3f0575354581445e342d4201803e925b70528

side-switch: ensure both host and chassis off

Ran into an issue where the BMC reboot occurs so early in the boot that
the chassis power never changed from Off to On, so the BMC reboot was
instant. T

side-switch: ensure both host and chassis off

Ran into an issue where the BMC reboot occurs so early in the boot that
the chassis power never changed from Off to On, so the BMC reboot was
instant. This caused an unwanted failure in a host-start service which
led to a BMC dump being generated on the subsequent BMC reboot.

Enhance the code to look for both the chassis and host to be off before
initiating the BMC reboot.

Tested:
- Verified on p10bmc hardware that the unwanted service failure no
longer occurs and side-switch waits for both host and chassis to be
off prior to rebooting the BMC

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ifb5e71aeaa4dbfff7ea21fa0bdce01642a3bec37

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I96286490697ce5d7fecc1c9c358f5f1d054137ec

show more ...

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4d3eb63d1c1550762f26f23de82ef40820241f09

show more ...

Change location of MSL error

The prev_entry() functionality that was being used to pass meta
data was not performing as expected. To make sure all the
desired information is passed to the event logs

Change location of MSL error

The prev_entry() functionality that was being used to pass meta
data was not performing as expected. To make sure all the
desired information is passed to the event logs. This is done
by reporting directly from the msl_verify.cpp file where the
information is then directly reported.

Signed-off-by: Zami Seck <zimzam17@gmail.com>
Change-Id: I4c4a41a104db9dcf303914b4a5e4e43908082414

show more ...

version: Change error to info for missing MANIFEST fields

The MANIFEST had an optional field Extended Version that was set to an
empty string by default. With the addition of the optional field
Comp

version: Change error to info for missing MANIFEST fields

The MANIFEST had an optional field Extended Version that was set to an
empty string by default. With the addition of the optional field
Compatible Names, the optional fields in the MANIFEST were removed
instead of being added as empty string as default:
https://gerrit.openbmc.org/c/openbmc/openbmc/+/52355

This causes an error message in the journal on every update:
phosphor-version-software-manager[528]: No values found in MANIFEST file for key: ExtendedVersion=
phosphor-version-software-manager[528]: No values found in MANIFEST file for key: CompatibleName=

Change the error message from severity error to info, so that the
message is still displayed, but it's not marked as an error.

Tested: The messages are not highlighted as errors in the journal.

Change-Id: I3c8c1d4f4767a12ab032bba0b4520add95f853b2
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Correct link to the Software Architecture document

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Change-Id: I9fec591eda2dbabbc2ee42a1d91ad21b2d1311d6

image-verify: Skip full verify for non-BMC images

The verifyFullImage() only supports verify BMC image, but does not apply
to other images like BIOS.

Skip doing verifyFullImage() for non-BMC images

image-verify: Skip full verify for non-BMC images

The verifyFullImage() only supports verify BMC image, but does not apply
to other images like BIOS.

Skip doing verifyFullImage() for non-BMC images so that it is possible
to do BIOS code update when fieldMode is enabled.

Tested: Verify BIOS update is successful without verification error.
Add related unit test case and verify it passes.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: Id9e72367bd2797f7a61c017b61fb81df1dd4d15c

show more ...

obmc-flash-bmc: Ignore SC2295

With the updated openbmc-build-scripts shellcheck reports SC2295 error.
Ignore this error to make CI pass.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I7

obmc-flash-bmc: Ignore SC2295

With the updated openbmc-build-scripts shellcheck reports SC2295 error.
Ignore this error to make CI pass.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I7b532aa9ba477bad8169e15b51bc2d19a2a066b6

show more ...

side-switch: add service to run side-switch function

The side switch check should occur on any host firmware boot so put in
the obmc-host-startmin@.target. Ensure this service does not run when
the

side-switch: add service to run side-switch function

The side switch check should occur on any host firmware boot so put in
the obmc-host-startmin@.target. Ensure this service does not run when
the BMC is reset while the host is at runtime. Do not want to ever cause
a power down of a running host.

Tested:
- Booted system with running firmware at priority 0 and verified a quick
return and successful boot.
- Booted system with running firmware at priority 1 and verified system
was powered off, bmc was rebooted to other image, and system auto
powered on up to operating system.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I5553ab6fb5ebd58734d1169663ea25ede7f37dd3

show more ...

side-switch: request bmc reboot to switch to new image

The final piece is to issue a BMC reboot so the system can get over to
the image with the highest priority.

Tested:
- Set running firmware pri

side-switch: request bmc reboot to switch to new image

The final piece is to issue a BMC reboot so the system can get over to
the image with the highest priority.

Tested:
- Set running firmware priority to 1 and ran the application. Side
switch detection ran and BMC was rebooted. After the reboot, the
system automatically powered on and running image was priority 0.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Iaafea49f75ad7dd959d4c71a4de29e763f593a83

show more ...

side-switch: set power restore policy to always-on

Utilize the one-time feature of the automatic power restore
functionality to ensure a one-time automatic boot of the system occurs
after the BMC re

side-switch: set power restore policy to always-on

Utilize the one-time feature of the automatic power restore
functionality to ensure a one-time automatic boot of the system occurs
after the BMC reboot.

This makes the whole process seamless to the user. They start a boot,
this function detects a bmc reboot is needed to pick up the priority 0
image, and this ensures the boot starts back up after the bmc reboot.

Tested:
- Verify policy set correctly
<6> Checking for side switch reboot
<6> Running firmware version path is /xyz/openbmc_project/software/74575136
<6> Running firmware version priority is 1
<6> Running image is at priority 1, execute side switch
<6> chassis power is off
<6> RestorePolicy set to AlwaysOn

busctl get-property xyz.openbmc_project.Settings
/xyz/openbmc_project/control/host0/power_restore_policy/one_time
xyz.openbmc_project.Control.Power.RestorePolicy PowerRestorePolicy
s "xyz.openbmc_project.Control.Power.RestorePolicy.Policy.AlwaysOn"

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I126283386c577fd9ec899a1402ae36e6111f1780

show more ...

side-switch: power off chassis in prep for update

When switching to a new level of firmware, ensure the host is off and
the chassis power is off before switching to the new firmware.

Tested:
- Veri

side-switch: power off chassis in prep for update

When switching to a new level of firmware, ensure the host is off and
the chassis power is off before switching to the new firmware.

Tested:
- Verify power off works
<6> Checking for side switch reboot
<6> Running firmware version path is /xyz/openbmc_project/software/74575136
<6> Running firmware version priority is 1
<6> Running image is at priority 1, execute side switch
<see power off occur in journal>
<6> chassis power is off

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ifdb3e0c51fe66e55ebb1c3fca7097af49607bf35

show more ...