Set severity for PELs

This commit adds an option to pass severity while logging PEL.
This will help to classify PELs based on their severity.
By default severity of all the PELs logged for system VP

Set severity for PELs

This commit adds an option to pass severity while logging PEL.
This will help to classify PELs based on their severity.
By default severity of all the PELs logged for system VPD failure
is set to be unrecoverable where as other failures are flagged as
predictive errors.

Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
Change-Id: I9cd10a29252a42f5031b91b9c7ad2e284ed5b861

show more ...

Segregate utility methods

This commit segregates utility methods required commonly by both
openpower-read-vpd and ibm-read-vpd from methods only required by
ibm-read-vpd.
All dependency required by

Segregate utility methods

This commit segregates utility methods required commonly by both
openpower-read-vpd and ibm-read-vpd from methods only required by
ibm-read-vpd.
All dependency required by utility methods specific to ibm-read-vpd
is not applicable to utility methods required by openpower-read-vpd.

Hence to avoid un-necessary dependency inclusion, this change is
introduced.

Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
Change-Id: I95f2be27dc0c391a45beb1654a99506317aaa52b

show more ...

Memory VPD parser review comments

In this commit review comments have been addressed for Memory vpd parser.

Change-Id: Ib9a67083048479ba3406a1932df3868d3953102c
Signed-off-by: Alpana Kumari <alpank

Memory VPD parser review comments

In this commit review comments have been addressed for Memory vpd parser.

Change-Id: Ib9a67083048479ba3406a1932df3868d3953102c
Signed-off-by: Alpana Kumari <alpankum@in.ibm.com>

show more ...

VPD Tool: Update Hardware

Vpd tool has --Hardware/-H flag which should be given along
with writeKeyword flags, if the user wants to write directly to "Hardware".

In general the user should give onl

VPD Tool: Update Hardware

Vpd tool has --Hardware/-H flag which should be given along
with writeKeyword flags, if the user wants to write directly to "Hardware".

In general the user should give only the object path in
--path/-P value.

Only if --Hardware/-H flag is given, the user has an
option to give either eeprom path or the object path in
--path/-P value.

Test:
Tested on simics.

./vpd-tool --writeKeyword -H --path < hardware path/object path > -R < record name > -K < keyword > -V < value in hex/ascii >

CASE 1: <updating eeprom path> < update directly on hardware using -H.>
./vpd-tool -u -H -P /sys/devices/platform/ahb/ahb:apb/ahb:apb:bus@1e78a000/1e78a480.i2c-bus/i2c-8/8-0051/8-00510/nvmem -R VINI -K PN -V 0x717273
updation successful on both dbus and hardware.

CASE 2:
./vpd-tool -u -H -P /sys/devices/platform/ahb/ahb:apb/ahb:apb:bus@1e78a000/1e78a480.i2c-bus/i2c-8/8-0051/8-00510/nvmem -R DINF -K FL -V 0x717273
updation successful on hardware. <this wont get updated in dbus as the given record-keyword pair is not required to update in dbus(only those record keywords
present in dbus_properties.json are required to be updated in dbus).

CASE 3: <failure case - invalid eeprom path>
root@rainier:/tmp# ./vpd-tool -u -H -P /sys/devices/platform/ahb/ahb:apb/ahb:apb:bus@1e78a000/1e78a490.i2c-bus/i2c-8/8-0051/8-00510/nvmem -R VINI -K PN -V 0x717273
Invalid object path : /sys/devices/platform/ahb/ahb:apb/ahb:apb:bus@1e78a000/1e78a490.i2c-bus/i2c-8/8-0051/8-00510/nvmem. Unable to find the corresponding EEPROM path for the given object path : /sys/devices/platform/ahb/ahb:apb/ahb:apb:bus@1e78a000/1e7$

Signed-off-by: PriyangaRamasamy <priyanga24@in.ibm.com>
Change-Id: I6b893e699fe343c90c3a3fd2b07fd8b9a4711687

show more ...

support new fitconfig u-boot syntax

The following commit changed the syntax of the fitconfig u-boot
environment variable:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta?id=cfc0e21b1066b

support new fitconfig u-boot syntax

The following commit changed the syntax of the fitconfig u-boot
environment variable:
https://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta?id=cfc0e21b1066b5d5d0fc37fbc5d79f40f4576f1d

OpenBMC pulled this in via:
https://gerrit.openbmc-project.xyz/c/openbmc/openbmc/+/41108

The summary is that the "@" symbol was repaced with a "-" symbol.

Because this is a u-boot environment variable which is persistent across
code updates, there is no good way to make this backwards or forwards
compatible with the poky change. It will be up to the system owner to
manage this issue if they are utilizing this fitconfig override feature.

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ica16e333e5f9d731ccf8da0048f6d1d2c1cc3bf2

show more ...

Vpd Tool Defect.

Output from the vpd-tool for any non printable character
will be in hex.
Previously the non printable characters were represented in
unicode encoding standard.

Fixed the defect.

T

Vpd Tool Defect.

Output from the vpd-tool for any non printable character
will be in hex.
Previously the non printable characters were represented in
unicode encoding standard.

Fixed the defect.

Tested on simics for the below cases:

Case 1:
./vpd-tool -r -O /system/chassis/motherboard/ebmc_card_bmc -R VCFG -K Z0
{
"/system/chassis/motherboard/ebmc_card_bmc": {
"Z0": "0x001125c10000"
}
}

Case 2:
./vpd-tool -r -O /system/chassis/motherboard -R VSBP -K IM
{
"/system/chassis/motherboard": {
"IM": "0x50001001"
}
}

Case 3:
./vpd-tool -r -O /system/chassis/motherboard/ebmc_card_bmc -R VW10 -K DR
{
"/system/chassis/motherboard/ebmc_card_bmc": {
"DR": "EBMC VW10 "
}
}

Signed-off-by: PriyangaRamasamy <priyanga24@in.ibm.com>
Change-Id: Ia815b5818f64327eb070f21b06283bff0acd2207

show more ...

add support for rainier 1s4u

The rainier 1s4u is very similar to the standard rainier 4u. It will
have a different device tree but the only change from the 4u is two
less fans.

Tested:
- Updated IM

add support for rainier 1s4u

The rainier 1s4u is very similar to the standard rainier 4u. It will
have a different device tree but the only change from the 4u is two
less fans.

Tested:
- Updated IM keyword to that of 1s4u and re-ran system-vpd service.
Verified that u-boot fitconfig env variable was correctly set to
conf@aspeed-bmc-ibm-rainier-1s4u.dtb

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: I3507e0239283dc700bd0834b66a46ff0c6deeba7

show more ...

Unrecognised configure option fix

The keyword "buildtype" is misgiven as "build".
Jenkins treats this error as warning and continues with the default buildtype=debug;
where this error is caught whil

Unrecognised configure option fix

The keyword "buildtype" is misgiven as "build".
Jenkins treats this error as warning and continues with the default buildtype=debug;
where this error is caught while bitbaking and the openpower-vpd-parser compilation fails.

This commit fixes the issue by replacing "build" with "buildtype" keyword.

Signed-off-by: PriyangaRamasamy <priyanga24@in.ibm.com>
Change-Id: I44dc63ed18971d59961bc1e1c4f92fef0ea25cf6

show more ...

Fix build issues due to updated arm-sdk

Due to recent changes made in arm-sdk,
the FORTIFY_SOURCE security flag enables optimization level 2.

The repo has a default debug level of optimization whic

Fix build issues due to updated arm-sdk

Due to recent changes made in arm-sdk,
the FORTIFY_SOURCE security flag enables optimization level 2.

The repo has a default debug level of optimization which conflicts with
FORTIFY_SOURCE flag.

In this commit the default build type is set to debugoptimized and also made sure
to disable the FORTIFY_SOURCE when we need to build without any optimization.

Signed-off-by: PriyangaRamasamy <priyanga24@in.ibm.com>
Change-Id: Ic1a91e58253fed283f67c44989fbc9126e18b7fe

show more ...

Fix build for hardware with one ethernet interface

We have a custom `writefru.yaml` without ETHERNET1 node
as our hardware has only one ethernet interface.
And this leads to a failure during the bui

Fix build for hardware with one ethernet interface

We have a custom `writefru.yaml` without ETHERNET1 node
as our hardware has only one ethernet interface.
And this leads to a failure during the build.

This commit prevents a warning about unused arguments which interprets
as an error.

Change-Id: If4925a46ff33db5504ce7fd45bc36b0da30c44e6
Signed-off-by: Alexander Filippov <a.filippov@yadro.com>

show more ...

VPD Tool: Fix for silencing unused variable warning

Signed-off-by: PriyangaRamasamy <priyanga24@in.ibm.com>
Change-Id: I05bdf989896a983b435ceefebc482d267a9c57f8

Fix Bad VPD Handling

This commit fixes two issues discovered with handling VPD that
cannot be parsed:

* If a parser object cannot be identified, return a VPDDataException
and not a runtime_error.

Fix Bad VPD Handling

This commit fixes two issues discovered with handling VPD that
cannot be parsed:

* If a parser object cannot be identified, return a VPDDataException
and not a runtime_error.
* Fix a code bug which was causing us to run the parser twice.

Tested: Tested agsinst bad VPD data and verified that the right exception
is now thrown.

Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>
Change-Id: I5ed10519b26f16b69b4b8b3f8a6f1f4ef2fa3cdb

show more ...

Change ND1 to ND0 for expanded LocationCode

Tested-
root@rain135bmc:/tmp# ./ibm-read-vpd -f /sys/bus/i2c/drivers/at24/8-0050/eeprom
DBG: expandedLoctionCode: U78DB.ND0.WZS000G-P0
DBG: expandedLocti

Change ND1 to ND0 for expanded LocationCode

Tested-
root@rain135bmc:/tmp# ./ibm-read-vpd -f /sys/bus/i2c/drivers/at24/8-0050/eeprom
DBG: expandedLoctionCode: U78DB.ND0.WZS000G-P0
DBG: expandedLoctionCode: U78DB.ND0.WZS000G
DBG: expandedLoctionCode: U78DB.ND0.WZS000G-P0-C15
DBG: expandedLoctionCode: U78DB.ND0.WZS000G-P0-C15
DBG: expandedLoctionCode: U78DB.ND0.WZS000G-P0-C15
DBG: expandedLoctionCode: U78DB.ND0.WZS000G-P0-C24
DBG: expandedLoctionCode: U78DB.ND0.WZS000G-P0-C24
DBG: expandedLoctionCode: U78DB.ND0.WZS000G-P0-C24
DBG: expandedLoctionCode: U78DB.ND0.WZS000G-P0-C22

Change-Id: Iab53916bc95406c6e6da8dd423a008e0e370a574
Signed-off-by: Alpana Kumari <alpankum@in.ibm.com>

show more ...

Set Presence as False for all the FRUs

While priming the inventory all the frus (except the System), presence state should be false
It will be set as true when vpd collection done for that fru.

Tes

Set Presence as False for all the FRUs

While priming the inventory all the frus (except the System), presence state should be false
It will be set as true when vpd collection done for that fru.

Test-
By code I could change the value of Present

root@rain148bmc:/tmp# busctl introspect xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/pcie_cable_card8|more
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
xyz.openbmc_project.Inventory.Item interface - - -
.Present property b true emits-change writable
.PrettyName property s "DBG_TESTING" emits-change writable

root@rain148bmc:/tmp# busctl introspect xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/pcie_cable_card8
xyz.openbmc_project.Inventory.Item interface - - -
.Present property b false

root@rain147bmc:/tmp# busctl introspect xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/pcie_cable_card8
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
xyz.openbmc_project.Inventory.Item interface - - -
.Present property b false emits-change writable

root@rain147bmc:/tmp# busctl introspect xyz.openbmc_project.Inventory.Manager /xyz/openbmc_project/inventory/system/chassis/motherboard/lcd_op_panel_hill
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
xyz.openbmc_project.Inventory.Item interface - - -
.Present property b false emits-change writable

Change-Id: I8f60c453761cd5d524b5f47aaf0228f72560d6a7
Signed-off-by: Alpana Kumari <alpankum@in.ibm.com>

show more ...

Restore system VPD if EEPROM data is blank.

This commit implement changes which enables restoring system VPD.
If at the time of VPD parsing for backplane it is found that data
related to system VPD

Restore system VPD if EEPROM data is blank.

This commit implement changes which enables restoring system VPD.
If at the time of VPD parsing for backplane it is found that data
related to system VPD is blank on EEPROM but available on cache,
then the data from Dbus will be used to restore data in EEPROM.

There are another scenarios in restoring the system VPD but this
commit only implement changes to restore system VPD when the data
is available on cache but blank on EEPROM.

This commit also implements creation and logging of PEL in case blank
system VPD is found both on EEPROM and Dbus in the process of
system VPD restore.

Meson Build: OK.
Tested on Simics: OK.

Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
Change-Id: I32a872b3c3a74b79a9b8173c712b50f72fd7588c

show more ...

Enable pre and post actions

This commit enables the VPD parser to take certain
pre and post collection actions.

-- Set a GPIO in order to enable hardware paths (such as I2C)
-- Bind device drivers

Enable pre and post actions

This commit enables the VPD parser to take certain
pre and post collection actions.

-- Set a GPIO in order to enable hardware paths (such as I2C)
-- Bind device drivers to the I2C device so as to generate a udev
event.
-- Set a GPIO as a post action on failure to collect VPD.

Pre-actions are taken when collecting system VPD.
Post actions can be taken either after a failure
to bind drivers or after failing to collect/parse VPD.

Change-Id: I26754000a72db53f00a5afc4925de27e3f7c3ba8
Signed-off-by: Alpana Kumari <alpankum@in.ibm.com>

show more ...

ibm-read-vpd: Enable skipping VPD read if host is powered ON

This commit keys off of a JSON attribute on the FRU that enables the
parser code to skip reading VPD when the host is powered ON.

On IBM

ibm-read-vpd: Enable skipping VPD read if host is powered ON

This commit keys off of a JSON attribute on the FRU that enables the
parser code to skip reading VPD when the host is powered ON.

On IBM systems, certain FRU VPD is inaccessible to the BMC when the host
is powered ON. This commit enables us to skip such FRUs.

It relies on the xyz.openbmc_project.State.Chassis.CurrentPowerState
property to determine the host power state.

Tested: Tested on Rainier simulation model by manually setting the above
property and ensuring that VPD reads are skipped if the FRU contains
the "powerOffOnly" key in the JSON.

Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>
Change-Id: Iaa55d32f7b3641fa0fd41dbd79620dbff2b1673a

show more ...

Fix u-boot env var name for Rainier 2U

Change the value of the fitconfig u-boot environment
variable to 'conf@aspeed-bmc-ibm-rainier.dtb'.
This is to match the value used by u-boot to switch to the

Fix u-boot env var name for Rainier 2U

Change the value of the fitconfig u-boot environment
variable to 'conf@aspeed-bmc-ibm-rainier.dtb'.
This is to match the value used by u-boot to switch to the right
device tree for Rainier 2U.

This also adds Everest to the list of supported systems.

Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>
Change-Id: Ie52bffb1e50c0fd7d081038732e3c5676a69de03

show more ...

log entry to journal when rebooting bmc

Rebooting the BMC without user interaction is a big deal so lets log an
entry in the journal for tracking purposes when it happens

Signed-off-by: Andrew Geis

log entry to journal when rebooting bmc

Rebooting the BMC without user interaction is a big deal so lets log an
entry in the journal for tracking purposes when it happens

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ia5b44334236c65137c4465f5803561fa91b57bf1

show more ...

MAINTAINERS: Remove Deepak from the list

Signed-off-by: Deepak Kodihalli <deepak.kodihalli.83@gmail.com>
Change-Id: I0b169ccfc58aa54ffb4031af032ea1a3683cc5cd

PEL creation in case of HW/SW failure.

Creation of PEL in case the parser process fails to parse and/or publish
VPD data.
This commit handles both hardware or software failure and creates PEL
accord

PEL creation in case of HW/SW failure.

Creation of PEL in case the parser process fails to parse and/or publish
VPD data.
This commit handles both hardware or software failure and creates PEL
accordingly.

Tested on Simics.

Test procedure:
Step1 : Copy ibm_read_vpd in /tmp folder on simics
Step2 : Run ibm_read_vpd exe with a vpd file path having invalid VPD/ECC or
invalid JSON path. In this case we have given path to VPD file with
invalid VPD data.
command-> ./ibm_read_vpd --file <vpd_file_path>
Step3 : After the execution is over, look for PEL logged using command
"peltool -a"

PEL logged incase of invalid VPD:
[
{
"Private Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x4000",
"Created at": "11/27/2020 04:40:00",
"Committed at": "11/27/2020 04:40:00",
"Creator Subsystem": "BMC",
"CSSVER": "",
"Platform Log Id": "0x50000002",
"Entry Id": "0x50000002",
"BMC Event Log Id": "2"
},
"User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Log Committed by": "0x2000",
"Subsystem": "CEC Hardware: VPD Interface",
"Event Scope": "Entire Platform",
"Event Severity": "Unrecoverable Error",
"Event Type": "Not Applicable",
"Action Flags": [
"Service Action Required",
"Report Externally",
"HMC Call Home"
],
"Host Transmission": "Not Sent"
},
"Primary SRC": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x4000",
"SRC Version": "0x02",
"SRC Format": "0x55",
"Virtual Progress SRC": "False",
"I5/OS Service Event Bit": "False",
"Hypervisor Dump Initiated":"False",
"Power Control Net Fault": "False",
"Backplane CCIN": "2E2D",
"Error Details": {
"Message": "A VPD data exception occurred."
},
"Valid Word Count": "0x09",
"Reference Code": "BD554001",
"Hex Word 2": "00000055",
"Hex Word 3": "2E2D0010",
"Hex Word 4": "00000000",
"Hex Word 5": "00000000",
"Hex Word 6": "00000000",
"Hex Word 7": "00000000",
"Hex Word 8": "00000000",
"Hex Word 9": "00000000",
"Callout Section": {
"Callout Count": "1",
"Callouts": [{
"FRU Type": "Normal Hardware FRU",
"Priority": "Mandatory, replace all with this type as a unit",
"Location Code": "U78DA.ND1.1234567-P0",
"Part Number": "F191014",
"CCIN": "2E2D",
"Serial Number": "YL2E2D010000"
}]
}
},
"Extended User Header": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x2000",
"Reporting Machine Type": "9105-22A",
"Reporting Serial Number": "SIMP10R",
"FW Released Ver": "",
"FW SubSys Version": "fw1020.00-6",
"Common Ref Time": "00/00/0000 00:00:00",
"Symptom Id Len": "20",
"Symptom Id": "BD554001_2E2D0010"
},
"Failing MTMS": {
"Section Version": "1",
"Sub-section type": "0",
"Created by": "0x2000",
"Machine Type Model": "9105-22A",
"Serial Number": "SIMP10R"
},
"User Data 0": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"BMC Version ID": "fw1020.00-6-22-gbbd23f832",
"BMCState": "Ready",
"ChassisState": "Off",
"HostState": "Off",
"Process Name": "Unknown"
},
"User Data 1": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"CALLOUT_INVENTORY_PATH": "/xyz/openbmc_project/inventory/system/chassis/motherboard",
"DESCRIPTION": "Invalid VPD data"
}
}
]

Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
Change-Id: Ieb434bb45b4051d8b7b6d4c9022984d5471fc855

show more ...

Custom Exception type for openpower-vpd-parser.

This commit implements custom exception type for openpower-vpd-parser
repo.
With this runtime exceptions can be classified into categories and
appropr

Custom Exception type for openpower-vpd-parser.

This commit implements custom exception type for openpower-vpd-parser
repo.
With this runtime exceptions can be classified into categories and
appropriate actions can be taken based on their type.

Signed-off-by: Sunny Srivastava <sunnsr25@in.ibm.com>
Change-Id: Ia514141e9166a76ba43c536a2e0f1229bd544bae

show more ...

Fix some warnings

1. Enabled Meson options to treat warnings as errors.
2. Removed unused variable in vpd_tool_impl.cpp.
3. Fix for unused variable warning in vpdecc & vpd manager files.

Signed-off

Fix some warnings

1. Enabled Meson options to treat warnings as errors.
2. Removed unused variable in vpd_tool_impl.cpp.
3. Fix for unused variable warning in vpdecc & vpd manager files.

Signed-off-by: Priyanga Ramasamy <priyanga24@in.ibm.com>
Change-Id: I59fab47fe394b2934d6050d9db78c68b7e471503

show more ...

ibm-read-vpd: Switch to the right symlinked JSON

This commit:
* Makes the VPD parser use the symlinked JSON if one is setup.
For example via a system VPD service.
* Makes the vpd-tool and vpd-mana

ibm-read-vpd: Switch to the right symlinked JSON

This commit:
* Makes the VPD parser use the symlinked JSON if one is setup.
For example via a system VPD service.
* Makes the vpd-tool and vpd-manager use the symlinked JSON.

Signed-off-by: Santosh Puranik <santosh.puranik@in.ibm.com>
Change-Id: Id7f845e02917e3a66d1fa9754da71ed0005c0cb8

show more ...

support multiple device trees in the same BMC image

This commit checks for current system type and if it is changed from last boot,
it loads new/appropriate device tree and reboot the system.

Teste

support multiple device trees in the same BMC image

This commit checks for current system type and if it is changed from last boot,
it loads new/appropriate device tree and reboot the system.

Tested-
=========================================
Test Case 1: first boot when env not defined

triggerred system vpd collection-
DBG: systemType is: 50001000
DBG: newDeviceTree: fw_dt2
U-Boot environment is not set. Updating...
DBG: rebooting...
root@rainier:/tmp# Connection to rain4bmc closed by remote host.
Connection to rain4bmc closed.
========================================
Test case 2-
triggerred system vpd collection-
DBG: systemType is: 50001001
DBG: newDeviceTree: fw_dt1
U-Boot environment is not updated. Updating...
DBG: rebooting...
root@rainier:/tmp# Connection to rain4bmc closed by remote host.
Connection to rain4bmc closed.

alpana07> ssh -k root@rain4bmc
root@rain4bmc's password:
printenv
...
bootside=b
devTree=fw_dt1
root@rainier:~#
=========================================
Test case 3-
triggerred system vpd collection again-
DBG: systemType is: 50001001
DBG: newDeviceTree: fw_dt1
U-Boot environment is Updated.

root@rainier:~# fw_printenv
...
bootside=b
devTree=fw_dt1
=========================================

Change-Id: I28bce8ced4a970e1818b4f4f613bd062647a4d3a
Signed-off-by: Alpana Kumari <alpankum@in.ibm.com>

show more ...