regenerate-meson: re-run with latest from sdbusplus

The sdbus++-gen-meson has a new version, which requires regenerating
all the meson in this repository. Re-run the `regenerate-meson`
script.

Cha

regenerate-meson: re-run with latest from sdbusplus

The sdbus++-gen-meson has a new version, which requires regenerating
all the meson in this repository. Re-run the `regenerate-meson`
script.

Change-Id: I68ed0170cdab9c8bdc88f6ba2f9aa6de70351d22
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: I534f5358e7c801ad5ad2c28185ab53b683ee3097
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbus++: regenerate meson

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ida08bd9e7b9ac170164272c848f5c5d3a4801e3f

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: I2847084165c3b3299b2409e1bc28be8b78c94ccb
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Change-Id: If6caa27a8c0597732050487d30ab4e8f7a05caaa
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Request hostboot dump when Host State is 'Running'

When CurrentHostStatus is not in 'Running' state, either host is 'Off'
or current state is changed by HW dump to a state other than 'Running'
and m

Request hostboot dump when Host State is 'Running'

When CurrentHostStatus is not in 'Running' state, either host is 'Off'
or current state is changed by HW dump to a state other than 'Running'
and may have initiated/created the dump. In these cases, there is
no need to initiate hostboot dump. This commit allows initiating
hostboot dump collection when the current host state is 'Running'
and the watchdog times out.

Testing:
Run watchdog_timeout and check the following entries in the journal log:
'Running' state:
Mar 03 12:22:34 <xxxx> watchdog_timeout[3626]: Host did not respond
within watchdog timeout interval
Mar 03 12:22:34 <xxxx> watchdog_timeout[3626]: Handle Hostboot boot
failure
Mar 03 12:22:34 <xxxx> watchdog_timeout[3626]: hostboot dump
requested
Mar 03 12:23:26 <xxxx> watchdog_timeout[3626]:
/xyz/openbmc_project/dump/hostboot/entry/20000028
Mar 03 12:23:26 <xxxx> watchdog_timeout[3626]:
xyz.openbmc_project.Common.Progress.OperationStatus.Completed
Mar 03 12:23:26 <xxxx> watchdog_timeout[3626]: dump collection
completed

'Quiesced' state:
Mar 03 12:26:04 <xxxx> watchdog_timeout[3917]: Host did not respond
within watchdog timeout interval
Mar 03 12:26:04 <xxxx> watchdog_timeout[3917]: Host is not in
'Running' state. Dump maybe already occurring, skipping this dump
request...

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: I7245fef1639299bf501667eef48e275a93307c00

show more ...

Build fails for p10bmc machine type

The commit, eebcf900a23b41df24d0985240a4da83bffa8a54, to move yaml
files to a specific subdirectory caused build failure for p10bmc
mchine type.

Tested: build su

Build fails for p10bmc machine type

The commit, eebcf900a23b41df24d0985240a4da83bffa8a54, to move yaml
files to a specific subdirectory caused build failure for p10bmc
mchine type.

Tested: build succeeds with this change.

Signed-off-by: Shantappa Teekappanavar <shantappa.teekappanavar@ibm.com>
Change-Id: I52a5f3911b1bc5a96de35cc98a2a03a18c8691dd

show more ...

yaml: move to subdirectory

A pending sdbusplus change (I38b69bc67b6a3d80cda1b508a76e106a50d8ab93)
is going to require YAML to be in a specific subdirectory and not in
the root. Move here in prep fo

yaml: move to subdirectory

A pending sdbusplus change (I38b69bc67b6a3d80cda1b508a76e106a50d8ab93)
is going to require YAML to be in a specific subdirectory and not in
the root. Move here in prep for that change.

Also add in the regenerate-meson script as a helper to regenerate
the sdbusplus meson files for this repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2c9e74b85550e3e8f0f5cb56a82e85c5b13c6d00

show more ...

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1d0e71ec56f533b24d3c66120fd090a28ecbd93c

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I3be9475e7639ae8f52bceb1d5ff843a8dffde0a5

show more ...

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6e4ace04c6f63b0bc554234e812b469f15594429

show more ...

SBE watchdog times out callout support enhancement

Curently all the SBE timeout use case default callout is included
In the PEL. This commit is used to add the callout for SBE timeout
Without SBE F

SBE watchdog times out callout support enhancement

Curently all the SBE timeout use case default callout is included
In the PEL. This commit is used to add the callout for SBE timeout
Without SBE FFDC use case. If SBE provides FFDC during watchdog
Timeout case , BMC need to honour the callout provided by SBE.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: I4523d35913965e9f55c7ae28eb728e8927b650e6

show more ...

Callout support for SBE when watchdog times out

This commit provides additional callout support for SBE when the
host does not respond within watchdog timeout interval during SBE
boot window.

Testi

Callout support for SBE when watchdog times out

This commit provides additional callout support for SBE when the
host does not respond within watchdog timeout interval during SBE
boot window.

Testing:
Steps used:
1. obmcutil poweroff
2. istep -s0
3. systemctl start org.open_power.Dump.Manager.service
4. systemctl start openpower-debug-collector-watchdog@0.service
5. Check the journal log, and get the PEL id to print PEL info

PEL info:
"Callout Section": {
"Callout Count": "2",
"Callouts": [{
"FRU Type": "Maintenance Procedure Required",
"Priority": "Mandatory, replace all with this type
as a unit",
"Procedure": "BMC0002"
}, {
"FRU Type": "Normal Hardware FRU",
"Priority": "Medium Priority",
"Location Code": "xxxxxxxxxxxxx",
"Part Number": "xxxxx",
"CCIN": "xxxx",
"Serial Number": "xxxxxxx"
}
...
"User Data 2": {
"Section Version": "1",
"Sub-section type": "1",
"Created by": "0x2000",
"Data": [
{
"Priority": "H",
"Procedure": "BMC0002"
},
{
"Deconfigured": false,
"Guarded": false,
"LocationCode": "Ufcs-xx-xxx",
"Priority": "M"
}
]
}

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: I5e182cb415a807d97c98812a6713905d39fdbc9a

show more ...

Add OWNERS file

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I788ea71f5fdc9555ebf9dec550e6c09d1802f608

Watchdog timeout support in SBE boot window

Added support to handle SBE boot failure when watchdog
times out in the SBE boot window. FFDC information from SBE
is captured using libphal provided API,

Watchdog timeout support in SBE boot window

Added support to handle SBE boot failure when watchdog
times out in the SBE boot window. FFDC information from SBE
is captured using libphal provided API, and the SBE specific
PEL for a valid FFDC is created. In case the error is related
to SBE timeout or no FFDC data then SBE dump to capture additional
debug data is initiated.

Tested: verified PEL log
root@p10bmc:~# peltool -l
{
"0x50000332": {
"SRC": "BD123504",
"Message": "timeout reported during SBE boot
process",
"PLID": "0x50000332",
"CreatorID": "BMC",
"Subsystem": "Processor Chip Cache",
"Commit Time": "10/04/2021 18:25:27",
"Sev": "Unrecoverable Error",
"CompID": "0x3500"
}
}

- Verified SBE dump was collected
Steps used:
1. obmcutil poweroff
2. istep -s0
3. systemctl start org.open_power.Dump.Manager.service
4. systemctl start openpower-debug-collector-watchdog@0.service
5. Check journal log to see SBE dump requested, dump entry created
and the dump is completed
journalctl -f -t watchdog_timeout
6. Verify the SBE dump:
ls /var/lib/phosphor-debug-collector/sbedump/<dump-entry-id>

- Verified Hostboot dump was collected
Steps Used:
1. obmcutil poweroff
2. istep -s0..6
3. systemctl start org.open_power.Dump.Manager.service
4. systemctl start openpower-debug-collector-watchdog@0.service
5. Check journal log to see Hostboot dump requested, dump entry
created and the dump is completed
journalctl -f -t watchdog_timeout
6. Verify the SBE dump:
ls /var/lib/phosphor-debug-collector/hostbootdump/<dump-entry-id>

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: Ibfe7cc6619cd99f303c6106e617bc636632d0940

show more ...

Remove checks for AutoReboot in watchdog timeout

Dump collector component collects the dump depending on system dump
policy setting. If the dump policy setting is Enabled, it collects the
dump even

Remove checks for AutoReboot in watchdog timeout

Dump collector component collects the dump depending on system dump
policy setting. If the dump policy setting is Enabled, it collects the
dump even when AutoReboot property is disabled. So, removing the check
for AutoReboot which was initially used as a workaround to determine
dump collection when watchdog times out.

Tested:
Disabled AutoReboot property using busctl command, and verified that
the hostboot dump was collected.

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: Iddc67f19b70461424c696754c04e2d26434247b8

show more ...

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-

exception: switch to public sdbus exception

SdBusError was intended to be a private error type inside sdbusplus.
Switch all catch locations to use the general sdbusplus::exception type.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If105f4bf34fbfa8c1e337caf10ead322099840f3

show more ...

watchdog: Create PEL when AutoReboot is false and watchdog times out

Testing brought to light that an error should always be logged
when the host watchdog times out

Testing:
Excecuted watchdog_time

watchdog: Create PEL when AutoReboot is false and watchdog times out

Testing brought to light that an error should always be logged
when the host watchdog times out

Testing:
Excecuted watchdog_timeout command manually after setting AutoReboot
property to false, and used peltool to verify the PEL was created.

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: I8e92676021dd4243d51daca567d8dccc6c56fa7d

show more ...

Add fmtlib support

Call fmtlib functions while adding log to journal to display
additional parameters in the journal.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I357

Add fmtlib support

Call fmtlib functions while adding log to journal to display
additional parameters in the journal.

Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Change-Id: I3579529919ee6599fca3499e2e12ad656f8c402a

show more ...

watchdog: Collect hostboot dump when watchdog times out

The hostboot dump collection to be initiated by watchdog_timeout
is disabled by default. When watchdog times out, only error
message correspon

watchdog: Collect hostboot dump when watchdog times out

The hostboot dump collection to be initiated by watchdog_timeout
is disabled by default. When watchdog times out, only error
message corresponding to watchdog timeout is logged. To enable
hostboot dump collection whenever watchdog times out, the meson
option 'hostboot-dump-collection' must be enabled.

Testing - with meson option 'hostboot-dump-collection' enabled:
Ran watchdog_timeout:
case-1: CurrentHostState - off, AutoReboot - false
- Verified PEL object was not created
- Verified hostboot dump was not created
- Verified the Host State changed to Quiesce

case-2: CurrentHostState - off, AutoReboot - true
- Verified PEL object was created
- Verified hostboot dump was not created
- Verified the Host State changed to Running

case-3: CurrentHostState - Running, AutoBoot - false
- Verified PEL object was not created
- Verified hostboot dump was not created
- Verified the Host State changed to Quiesce

case-4: CurrentHostState - Running, AutoBoot - true, default timeout = 300s
- Verified PEL object was created
- Verified hostboot dump was created
- Observed Host state moving to either Running or Quiesce

case-5: CurrentHostState - Running, AutoBoot - true, specified timeout = 5s
- Verified PEL object was created
- Verified hostboot dump was created
- Observed Host state moving to either Running or Quiesce

Docker Unit test: passed

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: Ib92d0c2f282816fb742cf07c1cb876b2cc093c12

show more ...

meson: remove old automake files

Testing:
- Docker unit test run was succeesful

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: I0aff9aeeec8838bf4b97f224bce1f7469cbf831e

Build: Add support building with meson

Testing:
- Verified all code build as expected in CI and unit tests passed
- Done docker Unit testing

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.co

Build: Add support building with meson

Testing:
- Verified all code build as expected in CI and unit tests passed
- Done docker Unit testing

Signed-off-by: Shantappa Teekappanavar <sbteeks@yahoo.com>
Change-Id: Iaa296f85353ceddfd40cd860d41e0a6e3abfac49

show more ...

bootstrap: fix shellcheck warnings

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I86ef079c9632e5563a1a56d6a2e23aad59ecbc57

Update clang-format

Update to the latest OpenBMC clang-format.

Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>
Change-Id: Ic8ef12ef658f6248b2dac72d40df8c016d0fe378

Enable clang code format

Change-Id: Idbac4c9f663ba887a82a7706a2f8274e18bd747f
Signed-off-by: Jayanth Othayoth <ojayanth@in.ibm.com>