Robustness enhancements to test_ipmi_user

- Includes refactoring code from test_ipmi_user to ipmi_client,
which will allow greater reuse.

- Ipmi_client changes:
- Enhancements to keyword: Creat

Robustness enhancements to test_ipmi_user

- Includes refactoring code from test_ipmi_user to ipmi_client,
which will allow greater reuse.

- Ipmi_client changes:
- Enhancements to keyword: Create Random IPMI User
-- invokes Find Free User ID : to prevent clobbering pre-existing
IPMI userIDs;
-- invokes Wait And Confirm New User Entry : so that we have
confirmation before returning.
- In support of this:
- Add necessary Variables;
- Pull over keywords from test_ipmi_user :
-- Find Free User Id
-- Check Enabled User Count
-- Wait And Confirm New User Entry
-- Verify IPMI Username Visible.

- Test_ipmi_user changes:
- Remove unused variable (moved to ipmi_client);
- Verify IPMI User Summary : remove now redundant
Wait And Confirm New User Entry, since incorporated into
Create Random IPMI User;
- Test IPMI User Privilege : invoke the new and enhanced
Create Random IPMI User , to prevent clobbering pre-existing
IPMI userIDs and leverage the built-in confirmation;
- Remove the keywords that are being pulled over to ipmi_client.

Additional test_ipmi_user changes for robustness,
consistent with use already elsewhere in this suite:
- Verify Administrator And User Privilege For Different Channels :
Sleep 5s delay after Set Channel Access to allow privileges to set;
- Verify Operator And User Privilege For Different Channels :
Sleep 5s delay after Set Channel Access to allow privileges to set.

Tested: on x86 platforms.

Change-Id: I10548d5ad7f85542ab5b6b165dddb01089da0661
Signed-off-by: Ruud A. Haring <ruud@us.ibm.com>

show more ...

Remove unused files in test repository

Changes:
- Delete python file which is not used in the test code

Tested:
- NA

Change-Id: I79c5ccb8ccb0eb3699e897a0d9bbfad1acad6850
Signed-off-by: Geor

Remove unused files in test repository

Changes:
- Delete python file which is not used in the test code

Tested:
- NA

Change-Id: I79c5ccb8ccb0eb3699e897a0d9bbfad1acad6850
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Update README documentation

Changes:
- Remove deprecated legacy REST documentation
- Update notes

Tested:
- NA

Change-Id: I339b8b63c9fddce3a04fef19973142204239123a
Signed-off-by: Ge

Update README documentation

Changes:
- Remove deprecated legacy REST documentation
- Update notes

Tested:
- NA

Change-Id: I339b8b63c9fddce3a04fef19973142204239123a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Update template test suite

Changes:
- Remove legacy REST check test.
- Default to redfish test option
- Add tags

Tested:
- Ran from sandbox

Change-Id: I4fceecd033fa68fe6a1e7e57

Update template test suite

Changes:
- Remove legacy REST check test.
- Default to redfish test option
- Add tags

Tested:
- Ran from sandbox

Change-Id: I4fceecd033fa68fe6a1e7e57a5b54556b256d4f4
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix and move SSL test to security directory

Changes:
- Keyword 'RequestsLibrary.Get Request' is deprecated.
- tests/ directory is going to get deleted, fixing
valid test suites and mov

Fix and move SSL test to security directory

Changes:
- Keyword 'RequestsLibrary.Get Request' is deprecated.
- tests/ directory is going to get deleted, fixing
valid test suites and moving out the test.

Tested:
- Ran from sandbox.

Change-Id: Ibc6063cfeaac2f575762ea61cddaa0aa9adeb1a4
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

openbmctool deprecated code support removal

Changes:
- Remove openbmctool related codes from repository

Tested:
- For sanity, ran from sandbox HW CI test bucket

Change-Id: I0a5e3db2bcbcdbc968

openbmctool deprecated code support removal

Changes:
- Remove openbmctool related codes from repository

Tested:
- For sanity, ran from sandbox HW CI test bucket

Change-Id: I0a5e3db2bcbcdbc9680dfd69743f1d397a1f08b3
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Remove unused user credentials and variables

Changes:
- Remove variable from resource file.

Tested:
- NA

Change-Id: I3f3d54fd09e6dd60729c36a07ead2666fe1fd27b
Signed-off-by: George Keishing <

Remove unused user credentials and variables

Changes:
- Remove variable from resource file.

Tested:
- NA

Change-Id: I3f3d54fd09e6dd60729c36a07ead2666fe1fd27b
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Update SOL utils TCL script for default password

Changes:
- Remove default password in the script.

Tested:
- Ran from sandbox

Change-Id: I3f681f7e5b0c091bdbf365e66277a08d95b8d32a
Signed-of

Update SOL utils TCL script for default password

Changes:
- Remove default password in the script.

Tested:
- Ran from sandbox

Change-Id: I3f681f7e5b0c091bdbf365e66277a08d95b8d32a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add option to invalidate all the guard records

Changes:
- User driven option to invalidate all the guard records.
By default DELETE_OLD_GUARD_FILE is set to 0.

User should use ro

Add option to invalidate all the guard records

Changes:
- User driven option to invalidate all the guard records.
By default DELETE_OLD_GUARD_FILE is set to 0.

User should use robot option:
-v DELETE_OLD_GUARD_FILE:1
to call this option into force.

Tested:
- Ran from sandbox.

Change-Id: I0f3a066253d0d03d3e6d0b0733630079b85dbb5c
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Code clean up and not supported for community

Changes:
- Remove test suites from repository which is
not supported for community or incomplete
test case.

Tested:
- NA

Change-Id

Code clean up and not supported for community

Changes:
- Remove test suites from repository which is
not supported for community or incomplete
test case.

Tested:
- NA

Change-Id: I234289f8bf300a7e177ce31cc8b31d932b108a68
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Cleanup tools/ras files

Change-Id: I66c9b9aadbb0d30bd79d8b177fe1ff8a0945d6d9
Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>

IPMI: Modified Maximum Record ID script in ipmi/test_ipmi_inband_sdr.robot

Changes:
- Handled Script change for LSB and MSB for Maximum Record ID

Tested:
- Ran ipmi/test_ipmi_inband_sdr.robot

IPMI: Modified Maximum Record ID script in ipmi/test_ipmi_inband_sdr.robot

Changes:
- Handled Script change for LSB and MSB for Maximum Record ID

Tested:
- Ran ipmi/test_ipmi_inband_sdr.robot

Change-Id: Ic9c9e25275724f1a3616264aa03a701655f4c88c
Signed-off-by: Ishwarya Mathi M <ishwaryamm@ami.com>

show more ...

Added format specifier for date

Changes:
- Modified existing method so that caller can specify
a format for the date - Get Current Date from BMC

Tested:
- Dummy test

Change-Id: Iaa228e98c2015

Added format specifier for date

Changes:
- Modified existing method so that caller can specify
a format for the date - Get Current Date from BMC

Tested:
- Dummy test

Change-Id: Iaa228e98c201556359a4e442dc1038d9dced0939
Signed-off-by: Anusha Dathatri <adathatr@in.ibm.com>

show more ...

Get IPs of servers subscribed for Redfish events

Changes:
- New method - Get Destination IPs Of Event Subscriptions

Tested:
- Dummy test

Change-Id: I8c39c05a6cd3bc1221fefa025eb1da8c2d6ac28e
Sign

Get IPs of servers subscribed for Redfish events

Changes:
- New method - Get Destination IPs Of Event Subscriptions

Tested:
- Dummy test

Change-Id: I8c39c05a6cd3bc1221fefa025eb1da8c2d6ac28e
Signed-off-by: Anusha Dathatri <adathatr@in.ibm.com>

show more ...

Update IPMI password string with BMC

Changes:
- By default assign BMC password. User can key in the
IPMI password via -v option from CLI parameter to
override it.

Tested:
- Ran from

Update IPMI password string with BMC

Changes:
- By default assign BMC password. User can key in the
IPMI password via -v option from CLI parameter to
override it.

Tested:
- Ran from sandbox

Change-Id: I1e9c6d61a678192a09e50cf8f66af61b04d84a96
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Update code documentation in test files

Changes:
- Remove or replace comments from code

Tested:
- NA

Change-Id: If4513dfe85682aa836c083cf47b0adc799c8c851
Signed-off-by: George Keishing <gk

Update code documentation in test files

Changes:
- Remove or replace comments from code

Tested:
- NA

Change-Id: If4513dfe85682aa836c083cf47b0adc799c8c851
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Added new test for Expired password menu

Changes:
- Added test "Expire_And_Change_Admin_User_Password_Via_Redfish_And_Verify"
- Added keyword "Restore Default Password For Admin User"

Teste

Added new test for Expired password menu

Changes:
- Added test "Expire_And_Change_Admin_User_Password_Via_Redfish_And_Verify"
- Added keyword "Restore Default Password For Admin User"

Tested:
- Ran successfully test_bmc_expire_password.robot

Change-Id: Ie8dc0dc991e6cd1fe37e3d4a23d33cc57700c2c1
Signed-off-by: Megha G N <Megha.G.N@ibm.com>

show more ...

Remove default password hardcoding from test

Changes:
- Removed root default password from resource
file.
- QEMU test CI script changes for reference
https://gerrit.openbmc.o

Remove default password hardcoding from test

Changes:
- Removed root default password from resource
file.
- QEMU test CI script changes for reference
https://gerrit.openbmc.org/c/openbmc/openbmc-build-scripts/+/67756

Tested:
- Ran from sandbox with parameterize password input

Change-Id: I98d0fabbdf3a27a0b0298cf307ddf1f3fc0dea51
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

GUI: Added new test case for user management page

Changes:
- Added new test case to 'Test Modifying User Password Of Existing User Via GUI'.

Tested:
- Ran test case successfully in sandbox.

Ch

GUI: Added new test case for user management page

Changes:
- Added new test case to 'Test Modifying User Password Of Existing User Via GUI'.

Tested:
- Ran test case successfully in sandbox.

Change-Id: Ia76652043f8cf44562145eb9de54801259e91eb0
Signed-off-by: Nandish-Matti <nandish.matti@ibm.com>

show more ...

NETWORK: Executed nping command with root privilege test_network_nping.robot

Changes:
    - In test_network_nping.robot added "echo ${root_password} | sudo -S" to the nping command and added ${CLIEN

NETWORK: Executed nping command with root privilege test_network_nping.robot

Changes:
    - In test_network_nping.robot added "echo ${root_password} | sudo -S" to the nping command and added ${CLIENT_PASSWORD} in resource.robot
Tested:
    - Ran network/test_network_nping.robot script Successfully

Change-Id: Ie7494e63eddaa31b76872067b657ed3c7385a64b
Signed-off-by: manimozhik <manimozhik@ami.com>

show more ...

Fix more missing HTTPS_PORT references

More missing reference. note that some are skipped intentionally
because this code also uses the hostname to derive other things like IP
and to ping the box.

Fix more missing HTTPS_PORT references

More missing reference. note that some are skipped intentionally
because this code also uses the hostname to derive other things like IP
and to ping the box.

Change-Id: If3ec82f4dea4caef5b016cf52705422e4fdbb00a
Signed-off-by: Matt Fischer <matthew.fischer@hpe.com>

show more ...

REDFISH: NoAccess privilege has been removed from Redfish script

Changes:
- NoAccess privilege has been removed completely from the Community stack as per this discussion - https://gerrit.openbmc.or

REDFISH: NoAccess privilege has been removed from Redfish script

Changes:
- NoAccess privilege has been removed completely from the Community stack as per this discussion - https://gerrit.openbmc.org/c/openbmc/bmcweb/+/52365
.
- Removed NoAccess privilege from redfish/account_service/test_ipmi_redfish_user.robot and redfish/account_service/test_ldap_configuration.robot

Tested:
- Ran redfish/account_service/test_ipmi_redfish_user.robot and redfish/account_service/test_ldap_configuration.robot scripts successfully.

Change-Id: Iaa09599650a75ccf1207923fdbf744b6764ce8d9
Signed-off-by: KothaiSrini <kothais@ami.com>

show more ...

NETWORK: In network_diagnostic_report.robot mtr --report output was in bytes

Changes:

- In network_diagnostic_report.robot mtr --report command output was in bytes but script expects in string.S

NETWORK: In network_diagnostic_report.robot mtr --report output was in bytes

Changes:

- In network_diagnostic_report.robot mtr --report command output was in bytes but script expects in string.So changed the format
by adding "out_buf = out_buf.decode("utf-8")" in lib/utilities.py

Tested:

- Ran network/network_diagnostic_report.robot script Successfully

Change-Id: I8100035ef24ff654982f4b3b7462b56ae3b72fe5
Signed-off-by: manimozhik <manimozhik@ami.com>

show more ...

GUI:Fix of variable name for user privilege list

Changes:
- In gui/gui_test/security_and_access_menu/test_user_management_sub_menu.robot.
- Fixed privilege list variable name.

Tested:
-Ran ab

GUI:Fix of variable name for user privilege list

Changes:
- In gui/gui_test/security_and_access_menu/test_user_management_sub_menu.robot.
- Fixed privilege list variable name.

Tested:
-Ran above test case from sandbox successfully.

Change-Id: I431468ff85a53edd6779842c83789aaef7d68192
Signed-off-by: Nandish-Matti <nandish.matti@ibm.com>

show more ...

test_ipmi_user_robot: skip instead of fail test for short pasword.

Skip 'Verify IPMI Root User Password Change' if len(OPENBMC_PASSWORD) < 8
Aspects:
- Graceful exit (skip instead of fail) for short

test_ipmi_user_robot: skip instead of fail test for short pasword.

Skip 'Verify IPMI Root User Password Change' if len(OPENBMC_PASSWORD) < 8
Aspects:
- Graceful exit (skip instead of fail) for short OPENBMC_PASSWORD.
- Add comment to clarify reason: password < 8 chars cannot be set,
thus the restore password step in Teardown would fail.
- This affects "out-of-the-box" operation with default password 0penBmc.
- Evaluate precondition in Setup step. Skip if precondition violated.
- Make restoring pw in Teardown conditional on 'TEST STATUS' != 'SKIP'.
- For clarity, rename keyword: 'Set Default Password For IPMI Root User'
-> 'Restore Default Password For IPMI Root User'

Tested: operates as intended with both a 7-char pw and a 15-char pw.

Signed-off-by: Ruud A. Haring <ruud@us.ibm.com>
Change-Id: If3b67e9479824e5c6b6b95df366887e0af5a7cd3

show more ...