Certificate: Hardcoded keybit length was removed and an keyword was introduced to have keybit length in variables section

Changes:
- ${keybit_length} keyword was introduced in variables section.

Certificate: Hardcoded keybit length was removed and an keyword was introduced to have keybit length in variables section

Changes:
- ${keybit_length} keyword was introduced in variables section.
- keybit length(2048) declared inside test case was renamed to ${keybit_length}.
- Introduced ${keybit_length} variable in lib/certificate_utils.robot file.
- Renamed hardcoded keybit length in "Generate Certificate File Via Openssl" keyword.

Tested:
- Ran Following Scripts Successfully
- redfish/dmtf_tools/test_redfishtool_certificate.robot
- redfish/managers/test_certificate.robot

Change-Id: I9f6490acb468a61d4cd35b5082b770016f293005
Signed-off-by: ganesanb <ganesanb@ami.com>

show more ...

Redfish: Max user count was updated for redfish

Changes:
- As per discussion on discord max user count was updated for redfish

Tested:
- Ran All The Scripts Successfully

Change-Id: Ibb941

Redfish: Max user count was updated for redfish

Changes:
- As per discussion on discord max user count was updated for redfish

Tested:
- Ran All The Scripts Successfully

Change-Id: Ibb94100de2e03bf1b7162779aac6403d1aa082ae
Signed-off-by: ganesanb <ganesanb@ami.com>

show more ...

DMTF Tools: Handled DMTF Tools Download If Branch Name Was Different

Changes:

- Recently, In DMTF Tools website for few of tools repository stable branch name was changed from master to main.

DMTF Tools: Handled DMTF Tools Download If Branch Name Was Different

Changes:

- Recently, In DMTF Tools website for few of tools repository stable branch name was changed from master to main.
- Handled Download DMTF Tools keyword, to download dmtf tool from their respective stable branch.

Tested:
- Ran All The Scripts Successfully

Change-Id: I7d86799051a95df4728bd728a9c90bdbe0107dad
Signed-off-by: ganesanb <ganesanb@ami.com>

show more ...

Redfish NTP: Handled code to add ntp address and enable ntp if bmc time was 1970

Changes:
- In suite setup, add code to handle if bmc date was in 1970 ntp will be enabled
and ntp address w

Redfish NTP: Handled code to add ntp address and enable ntp if bmc time was 1970

Changes:
- In suite setup, add code to handle if bmc date was in 1970 ntp will be enabled
and ntp address will be added.
- If bmc date was not in 1970, it will continue for test execution.
- Added ${NTP_ADDRESSES} variable in lib/resource.robot to get ntp addresses as an list.

Tested:
- Ran All The Scripts Successfully

Change-Id: Ifcfdc9bf87c46150a628a537fee05de083200c6e
Signed-off-by: ganesanb <ganesanb@ami.com>

show more ...

Handled delete redfish sessions while rebooting the bmc

Changes:
- In suite setup disable the delete redfish session while reboot the bmc.
- In suite teardown enable the delete redfish sessi

Handled delete redfish sessions while rebooting the bmc

Changes:
- In suite setup disable the delete redfish session while reboot the bmc.
- In suite teardown enable the delete redfish session while reboot the bmc.

Tested:
- Ran All The Scripts Successfully

Change-Id: Icba0e9ab99142e34f4288c2c0156605b17445027
Signed-off-by: ganesanb <ganesanb@ami.com>

show more ...

Fix redfishtool automation testcase for certificate

Changes:
- Added Fix in keyword 'Verify Redfishtool Replace Certificate'

Tested:
- Ran the related test cases with fix from sandbo

Fix redfishtool automation testcase for certificate

Changes:
- Added Fix in keyword 'Verify Redfishtool Replace Certificate'

Tested:
- Ran the related test cases with fix from sandbox successfully.

Change-Id: Icc1cdab151dd6d74f0eb4a32954ddc73437124fa
Signed-off-by: manashsarma <manashsarma@in.ibm.com>

show more ...

Added new testcase to verify default status of error log.

Changes:

-Added new testcase
Verify_Default_Value_Of_Resolved_Field_Is_False_For_An_Error_Log_Via_Redfish
Tested:
- Ran above

Added new testcase to verify default status of error log.

Changes:

-Added new testcase
Verify_Default_Value_Of_Resolved_Field_Is_False_For_An_Error_Log_Via_Redfish
Tested:
- Ran above test case from sandbox successfully.

Change-Id: Ie7618bdc820029c1bdc1828133b9ba71f5262792
Signed-off-by: dnirmala <dhurgam.nirmala1@ibm.com>

show more ...

Automation CT Fix

Changes:
- Added power off as needed for the
test case requirement

Tested:
- Ran successfully
redfish/update_service/test_firmware_inventory.robot

Change-Id: I6f1

Automation CT Fix

Changes:
- Added power off as needed for the
test case requirement

Tested:
- Ran successfully
redfish/update_service/test_firmware_inventory.robot

Change-Id: I6f110e7f4325e95e41b3d7d75a8210dc6c4cb6b8
Signed-off-by: Sushil Singh <susilsi7@in.ibm.com>

show more ...

Redfish: Fix for 'Verify Error Upon Creating Same Users With Different Privileges'

Changes:
- In /redfish/account_service/test_user_account.robot
- RoleId with 'Operator' no more exist, Henc

Redfish: Fix for 'Verify Error Upon Creating Same Users With Different Privileges'

Changes:
- In /redfish/account_service/test_user_account.robot
- RoleId with 'Operator' no more exist, Hence modifying RoleId value to 'ReadOnly'.

Tested: - Verify_Error_Upon_Creating_Same_Users_With_Different_Privileges

Change-Id: I787c5f880797290c97eab94f2ed33aff155f764f
Signed-off-by: Nandish-Matti <nandish.matti@ibm.com>

show more ...

Fix BMC dump automated testcase

Changes:
- Added fix for automation test case
'Verify BMC Dump Create Errors While Another BMC Dump In Progress'.

Tested:
- Ran the test case w

Fix BMC dump automated testcase

Changes:
- Added fix for automation test case
'Verify BMC Dump Create Errors While Another BMC Dump In Progress'.

Tested:
- Ran the test case with fix from sandbox successfully.

Change-Id: Ie099a11454e02a504177c78aee2c73b55ec9ca54
Signed-off-by: manashsarma <manashsarma@in.ibm.com>

show more ...

No keyword with name 'Verify IPv6 And PrefixLength On BMC' found

Changes:
- Correct the keyword called in the test suite

Tested:
- NA

Change-Id: I001761d1615331233cf82403a49ac5de124a4002
S

No keyword with name 'Verify IPv6 And PrefixLength On BMC' found

Changes:
- Correct the keyword called in the test suite

Tested:
- NA

Change-Id: I001761d1615331233cf82403a49ac5de124a4002
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix redfishtool certificate test automation issues

Changes:
- Added fix for redfishtool certificate replacement automation test case

Tested:
- Ran the testcases with fix from sandbo

Fix redfishtool certificate test automation issues

Changes:
- Added fix for redfishtool certificate replacement automation test case

Tested:
- Ran the testcases with fix from sandbox successfully.

Change-Id: I2c0a6065311a9cde447705e4d9da3051b3392259
Signed-off-by: manashsarma <manashsarma@in.ibm.com>

show more ...

svc-restart: adapt do state service instance changes

phosphor-state-manager moved to a multi chassis and multi host design
point. This made their corresponding service files instance based.

Change-

svc-restart: adapt do state service instance changes

phosphor-state-manager moved to a multi chassis and multi host design
point. This made their corresponding service files instance based.

Change-Id: Ib28c5b0c5e6134e83ad056451029bcc132b73db0
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Add Host shutdown in some BMC dump testcases

Changes:

- Added method to shutdown host before BMC dump initiation
when host booting is not required.

Tested:

- Executed th

Add Host shutdown in some BMC dump testcases

Changes:

- Added method to shutdown host before BMC dump initiation
when host booting is not required.

Tested:

- Executed the test cases with fix from sandbox successfully.

Change-Id: I47ab3f081ec3fc79684ee3636053d76a6f6256aa
Signed-off-by: manashsarma <manashsarma@in.ibm.com>

show more ...

Added Fix for BMC dump automation testcase

Changes:
- Added fix for 'Verify BMC Dump Create Errors While Another BMC Dump In Progress'.
An extra check is added if the new dump init

Added Fix for BMC dump automation testcase

Changes:
- Added fix for 'Verify BMC Dump Create Errors While Another BMC Dump In Progress'.
An extra check is added if the new dump initiation request is accepted,then
earlier dump initiated must be completed.

Tested:
- Ran the test case with fix from sandbox successfully.

Change-Id: I48e43f774df8d7385de7d69373c954a1fdb10895
Signed-off-by: manashsarma <manashsarma@in.ibm.com>

show more ...

Update test reference documentation link

Changes:
- Find the updated link and update it.

Tested:
- NA

Change-Id: Iac663b61c24b4c17e1400a5601598b906cd533c5
Signed-off-by: George Keishing <

Update test reference documentation link

Changes:
- Find the updated link and update it.

Tested:
- NA

Change-Id: Iac663b61c24b4c17e1400a5601598b906cd533c5
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add systemd circular dependency check

It's usefull add circular dependency check for systemd units.

The error log if had circular dependency:
```
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_proje

Add systemd circular dependency check

It's usefull add circular dependency check for systemd units.

The error log if had circular dependency:
```
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found ordering cycle on xyz.openbmc_project.Software.BMC.Updater.service/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found dependency on sel-ready.target/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found dependency on xyz.openbmc_project.Logging.IPMI.service/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found dependency on xyz.openbmc_project.Logging.service/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found dependency on obmc-fru-fault-monitor.service/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found dependency on xyz.openbmc_project.AssetManager.service/start
Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Job xyz.openbmc_project.Software.BMC.Updater.service/start deleted to break ordering cycle start
Mar 10 06:20:45 g220b systemd[1]: Queued start job for default target Multi-User System.
```

I think this is good to check it in CI.

Tested:
```
~# python3 -m robot -v OPENBMC_HOST:xx.xx.xx.xx redfish/test_xit.robot

Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found ordering cycle on xyz.openbmc_project.Software.BMC.Updater.service/start
Verify No BMC Dump And Application Failures In BMC :: Verify no BM... | FAIL |
'Mar 10 06:20:45 g220b systemd[1]: xyz.openbmc_project.AssetManager.service: Found ordering cycle on xyz.openbmc_project.Software.BMC.Updater.service/start' should be empty.
------------------------------------------------------------------------------
Test Xit :: This suite is to run some test at the end of execution. | FAIL |
1 test, 0 passed, 1 failed
==============================================================================
```

Change-Id: I3288106b06399acf22fa44cba3b3d0fa69944cfc
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

Add fix for bmcdump testcase in host booting

Changes:
- Added fix for automation test case 'Verify User Initiated BMC Dump At Host Booting'.

Tested:
- Ran the test case with fix from

Add fix for bmcdump testcase in host booting

Changes:
- Added fix for automation test case 'Verify User Initiated BMC Dump At Host Booting'.

Tested:
- Ran the test case with fix from sandbox successfully.

Change-Id: Ibfde2d1186a6d2b5130a9a69642d388e1515c798
Signed-off-by: manashsarma <manashsarma@in.ibm.com>

show more ...

Code documentation and robot standard line checks

Changes:
- Too many trailing blank lines
- Line is too long (exceeds 110 characters)

Tested:
- python3 -m rflint -rA robot_standards

Code documentation and robot standard line checks

Changes:
- Too many trailing blank lines
- Line is too long (exceeds 110 characters)

Tested:
- python3 -m rflint -rA robot_standards -R robot_custom_rules.py
files checked in

Change-Id: Ic3561bd4cfe5debdd4e05769016fa81eef02eff3
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Code update new URI changes

Changes:
- Added support of new URI for code update

Tested:
- Ran Successfully
redfish/update_service/test_redfish_bmc_code_update.robot

Change-Id: I902cf074

Code update new URI changes

Changes:
- Added support of new URI for code update

Tested:
- Ran Successfully
redfish/update_service/test_redfish_bmc_code_update.robot

Change-Id: I902cf07423fb310b8a5f4c761ee764fdb32aa48c
Signed-off-by: Sushil Singh <susilsi7@in.ibm.com>

show more ...

Adding LDAP Test Cases for multiple interfaces

Changes: Adding two test cases:
- Verify LDAP Login Works When Both Interfaces Are Configured
- Verify Secure LDAP Login Works When Both In

Adding LDAP Test Cases for multiple interfaces

Changes: Adding two test cases:
- Verify LDAP Login Works When Both Interfaces Are Configured
- Verify Secure LDAP Login Works When Both Interfaces Are Configured

Tested: Ran and tested on BMC Environment.

Change-Id: I44df91152d50034ed83cec54aeb8a74fdc63e659
Signed-off-by: Sweta Potthuri <spotthur@in.ibm.com>

show more ...

Added test case to verify BMC dump with watch dog timeout

Changes:
- Added new automation test case 'Verify Core Watchdog Initiated BMC Dump'.

Tested:
- Ran the test case from sandbo

Added test case to verify BMC dump with watch dog timeout

Changes:
- Added new automation test case 'Verify Core Watchdog Initiated BMC Dump'.

Tested:
- Ran the test case from sandbox successfully.

Change-Id: I21b615766bcf78a4ed33bb94384a30948ecddd3e
Signed-off-by: manashsarma <manashsarma@in.ibm.com>

show more ...

Fix: Network: More Byte MAC Address throws Error

Changes: More Byte MAC Address throws error

Tested: Ran and Tested redfish/managers/test_bmc_network_mac.robot

Change-Id: I23b3a16196abe46f

Fix: Network: More Byte MAC Address throws Error

Changes: More Byte MAC Address throws error

Tested: Ran and Tested redfish/managers/test_bmc_network_mac.robot

Change-Id: I23b3a16196abe46f04b30f7710ab9049ede735bc
Signed-off-by: Sweta Potthuri <spotthur@in.ibm.com>

show more ...

Automated Code update scenario

Changes:
- Automated code update in progress then update
http certificate
- Added parameter that is https_certificate to
"Redfish Code Update With Diff

Automated Code update scenario

Changes:
- Automated code update in progress then update
http certificate
- Added parameter that is https_certificate to
"Redfish Code Update With Different Interrupted Operation"

Tested:
- Ran successfully
redfish/update_service/test_redfish_bmc_code_update.robot

Change-Id: Icb5410f6abea42291162771cc25b2b64b08cbae1
Signed-off-by: Sushil Singh <susilsi7@in.ibm.com>

show more ...

Added test case to verify error log and dump creation for internal error

Changes:

- Added a new automation test case to verify error log and BMC
dump creation for internal failure

Added test case to verify error log and dump creation for internal error

Changes:

- Added a new automation test case to verify error log and BMC
dump creation for internal failure.

Tested:

- Ran the test case from sandbox successfully.

Change-Id: I84428c8535428a4c5f447ca11873ab56d90803d0
Signed-off-by: manashsarma <manashsarma@in.ibm.com>

show more ...