Update code documentation and variables

Change-Id: I40a3dcfcca6be63b6ea44f935bb631948273dd82
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Add regex pattern case_insensitive param and underscore

Changes:
- Add "_" underscore in regex expression
- Add case_insensitive param to regex filtering inventory matches
Example:

Add regex pattern case_insensitive param and underscore

Changes:
- Add "_" underscore in regex expression
- Add case_insensitive param to regex filtering inventory matches
Example:
"/xyz/openbmc_project/inventory/system/chassis/motherboard/CPU_0"
"/xyz/openbmc_project/inventory/system/chassis/motherboard/cpu0"

Tested Pattern such as:
- lower case "cpu"
- upper case "CPU"
- which has underscore in the endpoint e.g. "fan"
"/xyz/openbmc_project/sensors/fan_tach/fan0_0"

Example Robot test:

Example Inventory
[Documentation] Example inventory.
[Tags] Example_Inventory

${cpu_list}= Get Endpoint Paths /xyz/openbmc_project/inventory/ cpu
Log To Console \n Lower case(cpu): ${cpu_list}
${cpu_list}= Get Endpoint Paths /xyz/openbmc_project/inventory/ CPU
Log To Console \n Upper case(CPU): ${cpu_list}
${fan_list}= Get Endpoint Paths /xyz/openbmc_project/sensors/ fan
Log To Console \n ${fan_list}

Change-Id: I2345b780ee135c753fa9aaab901866abb232d3e8
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add HWMON data collection in FFDC

Chnages:
- Added "grep -r . /sys/class/hwmon/*" command to FFDC list script.

Change-Id: Iffeadd3cb4122e13ed2fb318bbe21362a0d3ad05
Signed-off-by: George Keishin

Add HWMON data collection in FFDC

Chnages:
- Added "grep -r . /sys/class/hwmon/*" command to FFDC list script.

Change-Id: Iffeadd3cb4122e13ed2fb318bbe21362a0d3ad05
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Verify not yet valid certificates

- New test cases added
1. Verify_Not_Yet_Valid_Certificate_Install
2. Verify_Not_Yet_Valid_Certificate_Replace
Certificate types: CA, Client and Server

Signed-off-

Verify not yet valid certificates

- New test cases added
1. Verify_Not_Yet_Valid_Certificate_Install
2. Verify_Not_Yet_Valid_Certificate_Replace
Certificate types: CA, Client and Server

Signed-off-by: Anusha Dathatri <adathatr@in.ibm.com>
Change-Id: I4852118393331f399e646032cf34c918403f1569

show more ...

External interface code changes

Changes:
1. rest_client.robot:
- rename openbmc session to redfish.
- Add new keyword to perform POST request.
2. test_lock_management.robot:

External interface code changes

Changes:
1. rest_client.robot:
- rename openbmc session to redfish.
- Add new keyword to perform POST request.
2. test_lock_management.robot:
- Import redfish utils resource.
- Add suite setup and teardown.
- Replace session login with "Redfish Login" keyword.
- Split read and write locks for Reboot template.
- Cosmetic chnages to the codes alignment and dictionary.
- Add test setup "No Operation."
- Fix Reboot session for get lock list.
- Remove "Run Keyword" directive for keywords calls.
- Add Delete redfish session in strategic location.
- Re-structure keyword for keyword "Create New Session".
- Set test variable constant.
- Replace logout with "Delete All Redfish Sessions"

Tested: Ran couple of times to confirm the changes

Test Lock Management feature of Management... | PASS |
10 critical tests, 10 passed, 0 failed
10 tests total, 10 passed, 0 failed

Change-Id: I530c8a6753e7d1c105d7cb3b2fd586b2c3bb68fa
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Update community jenkins job URL page location

Changes:
- Old URL page https://openpower.xyz/job/openbmc-build/
- New URL page https://jenkins.openbmc.org/job/latest-master/

Change-Id: I70c

Update community jenkins job URL page location

Changes:
- Old URL page https://openpower.xyz/job/openbmc-build/
- New URL page https://jenkins.openbmc.org/job/latest-master/

Change-Id: I70cf48b0b4573a831afc220cbc37b39d8a89f48d
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Updated FOR loop syntax to new robot version

Signed-off-by: Marissa Garza <garzam@us.ibm.com>
Change-Id: Id543440c04974e6cfa8adbb6e8100759cd903d82

Remove comment from the code

We won't be changing or adding any new code there.

Change-Id: I282b3cc271a26f1ab18284569aa99cf9bff5976e
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Changed old for loop format to new for loop format

Change-Id: I3e73ff82e6d742608d805a72130da1db81033eff
Signed-off-by: Anves Kumar rayankula <anvesr77@in.ibm.com>

Convert HTTPS response to JSON and return

Changes:
- This is needed for test caller to be able to access to JSON
data from login session.

Example of the response:
{
'@odata.id': '/redf

Convert HTTPS response to JSON and return

Changes:
- This is needed for test caller to be able to access to JSON
data from login session.

Example of the response:
{
'@odata.id': '/redfish/v1/SessionService/Sessions/ZZNZ3SYN0i',
'@odata.type': '#Session.v1_0_2.Session',
'Description': 'Manager User Session',
'Id': 'ZZNZ3SYN0i',
'Name': 'User Session',
'Oem': {
'OpenBMC': {
'@odata.type': '#OemSession.v1_0_0.Session',
'ClientID': '123456',
'ClientOriginIP': '::ffff:xx.xx.xx.xx'
}
},
'UserName': 'root'
}

Tested:
By adding a piece of test code as
${resp}= Redfish Login kwargs= "Oem":{"OpenBMC" : {"ClientID":"123456"}}
Log To Console \n Session ID: ${resp["Id"]}
${resp}= Redfish Login
Log To Console \n Session ID: ${resp["Id"]}

Output:
Session ID: RNUnVGoyIF
Session ID: ipDXBgxDjg

Change-Id: I14ce07287ba3c30761e1c8f1a28c34a74d87e9c7
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add new Redfish Login Keyword

Changes:
- Support new Redfish login with OEM params.

Change-Id: I89579d75cb9e20dbb6e3e698297b5194d823787f
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

REST and Redfish supported driver

Changes:
- Added REDFISH_REST_SUPPORTED global var as part of the
lib/bmc_redfish_utils.py init function.
- Update boot test to select supported BMC R

REST and Redfish supported driver

Changes:
- Added REDFISH_REST_SUPPORTED global var as part of the
lib/bmc_redfish_utils.py init function.
- Update boot test to select supported BMC REST or Reddfish
fucntions to set.

There are driver still out there in community which supports both
legacy REST (/xyz/openbmc_project/) and new redfish (/redfish/v1/).
This new logic is to derieve early in the program and use in the
functional and boot test path.

Tested:
- Disable REST and test the change.
- Test the change in current latest level of driver.

Change-Id: I0e0b480b97b64df8a264a3d54e7159e90b33f4af
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Hide passwords containing regex metachars

- Created new escape_regex_metachars function.
- Had register_passwords function call new escape_regex_metachars function.

Signed-off-by: David Shaw <dlsha

Hide passwords containing regex metachars

- Created new escape_regex_metachars function.
- Had register_passwords function call new escape_regex_metachars function.

Signed-off-by: David Shaw <dlshaw@us.ibm.com>
Change-Id: Ibc1e3841cc6fac1d9c9c3529e913c786b449f751

show more ...

Support new redfish BMC and host state keywords

Changes:
- Keyword to return BMC current state.
- Keyword to return host states (power and boot progress state).

Change-Id: I2efc47bf4b56

Support new redfish BMC and host state keywords

Changes:
- Keyword to return BMC current state.
- Keyword to return host states (power and boot progress state).

Change-Id: I2efc47bf4b5659c391478097d923430ea050591c
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Remove leftover TODO: comment from gen_print.py

This todo was already done and developer neglected to remove comment.

Signed-off-by: David Shaw <dlshaw@us.ibm.com>
Change-Id: Ifc385b400d3ec50e84eae

Remove leftover TODO: comment from gen_print.py

This todo was already done and developer neglected to remove comment.

Signed-off-by: David Shaw <dlshaw@us.ibm.com>
Change-Id: Ifc385b400d3ec50e84eae9b20d2b09ffe415d7f8

show more ...

New add_tarball_tools_dir_to_path function

Change-Id: I9bd0f9b0d1504098acfa93be2576af57506bcf50
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Updated FOR loop syntax to new robot version

Signed-off-by: Marissa Garza <garzam@us.ibm.com>
Change-Id: Iad394c40eef9508db6840ed9692d102910a5c5df

Remove TODO action items from the codes

These comments are no longer valid or lost in time. The fixes
are resilience so far and changing could lead to wider impacts.
Removing them for good and we wi

Remove TODO action items from the codes

These comments are no longer valid or lost in time. The fixes
are resilience so far and changing could lead to wider impacts.
Removing them for good and we will fix as an when it is reported.

Change-Id: Ida20fa841565de63823f7066bd5106c5b68ef880
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix deprecated for loop in Delete Error Logs

Signed-off-by: David Shaw <dlshaw@us.ibm.com>
Change-Id: I5ce810ced422b90acb015768d57df31287ea7050

Cleanup redfish login and logout for session delete keyword

The required changes is already taken care at extended/standby_bmc.robot
where it is only used.

Change-Id: I9fba1ba89db84ac199a14d8d7ce32

Cleanup redfish login and logout for session delete keyword

The required changes is already taken care at extended/standby_bmc.robot
where it is only used.

Change-Id: I9fba1ba89db84ac199a14d8d7ce32aa4bd8e9ba3
Tested: By running extended/standby_bmc.robot suite.
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Remove redfish login and logout from lib code

With this change, the test script caller is expected to have the
valid session before invoking the changed keywords in library.

Changes:
- Remove

Remove redfish login and logout from lib code

With this change, the test script caller is expected to have the
valid session before invoking the changed keywords in library.

Changes:
- Remove login/logout from lib/bmc_redfish_utils.robot
for power and reset operation.
- Update impacted test suites.

Tested: To identify the impact, ran the existing test bucket and
the result is looking good.

Change-Id: I6df69d6fcc4c38470fdb2ec3b31fb28beb726d70
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Boot Test: Move Get Redfish Instance

Moved the call for getting the Redfish test library version
to the if Redfish supported section.

Change-Id: Iebe82f4c2b370f6e38e793d7252fdb98c45923ef
Signed-off

Boot Test: Move Get Redfish Instance

Moved the call for getting the Redfish test library version
to the if Redfish supported section.

Change-Id: Iebe82f4c2b370f6e38e793d7252fdb98c45923ef
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

init_robot_out_parms to return tuple

- Also, added quiet parm to robot_cmd_fnc

Change-Id: Iff0ee18716940f6388d37589ca49bbe62eb3625d
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

Fix boot test to use REST

Change-Id: I9a120d83c54e8baf35bf1d244f2101cd5b4be9e7
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Support redfish boot defaults

Changes:
- Create new keyword in lib/utils.robot.
- Remove the current redfish setting default and call the new
keyword.
- Add the new keyword in redf

Support redfish boot defaults

Changes:
- Create new keyword in lib/utils.robot.
- Remove the current redfish setting default and call the new
keyword.
- Add the new keyword in redfish default in __init__.robot

Change-Id: I886a638ca47f81f28dbf60f644c6192cfaf14376
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...