Pylint warning and error fix

Changes:
- import orders and remove unused import module
- doctring changes

Tested: python3 -m pylint lib/utilities.py
There are other warnings still.

Ch

Pylint warning and error fix

Changes:
- import orders and remove unused import module
- doctring changes

Tested: python3 -m pylint lib/utilities.py
There are other warnings still.

Change-Id: I913806ac5ae02f13068940a166405c1b9328c52d
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Update test tag and typo fixes in test scripts

Changes:
- Fix tag mismatch with test cases
- Fix typo in code documentation

Tested:
Checked with codespell and tag checker tool.

C

Update test tag and typo fixes in test scripts

Changes:
- Fix tag mismatch with test cases
- Fix typo in code documentation

Tested:
Checked with codespell and tag checker tool.

Change-Id: I4de23c9225cdd46ffa8868e94e0d8d4a410853f4
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix POST on session input data type args as JSON

Changes:
- amend arg type from data to JSON

Tested:
Ran templates/test_openbmc_setup.robot

Change-Id: Iaa7b17c6dcd19f83d68addcd7da0ff861be

Fix POST on session input data type args as JSON

Changes:
- amend arg type from data to JSON

Tested:
Ran templates/test_openbmc_setup.robot

Change-Id: Iaa7b17c6dcd19f83d68addcd7da0ff861bed1373
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Expire admin password using root privileged user

Tested:

Ran successfully redfish/update_service/
test_redfish_bmc_code_update.robot

Change-Id: I6e80e07f34df754805627a35f6c4446d85bb

Expire admin password using root privileged user

Tested:

Ran successfully redfish/update_service/
test_redfish_bmc_code_update.robot

Change-Id: I6e80e07f34df754805627a35f6c4446d85bbbfc6
Signed-off-by: Sushil Singh <susilsi7@in.ibm.com>

show more ...

pylint errors and warning fix

Changes:
- Fix comments length
- Fix import module orders

There are still other failures but this fixed few
of the fundamental warnings.

Tested:
Install p

pylint errors and warning fix

Changes:
- Fix comments length
- Fix import module orders

There are still other failures but this fixed few
of the fundamental warnings.

Tested:
Install pylint ( pip3 install pylint )
Run CLI command as bellow
python3 -m pylint lib/utils.py

Change-Id: I21f9f705f3eb58b591ecc5340aa9a8575a5d6fce
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Robotframework request package upgrade changes

Current working package version
robotframework-requests 0.7.2

To Test:
pip3 install robotframework-requests -U
or

Robotframework request package upgrade changes

Current working package version
robotframework-requests 0.7.2

To Test:
pip3 install robotframework-requests -U
or
# Once this commit is merged.
pip3 install -r requirements.txt

Version latest:
robotframework-requests 0.9.3

Refer Documentation:
https://marketsquare.github.io/robotframework-requests/doc/RequestsLibrary.html

What is not changed:
- The test cases under directory tests/ is not modified and is
deprecated but you can continue using it with older package
and configuration using

git clone -b v3.0-stable https://github.com/openbmc/openbmc-test-automation

Tested:
Upstream HW_CI test list, firmware code update and few other
test suite like ipmi, certificate, dumps, ffdc and redfish
test suites.

Note: I have not tested end to end, so it is likely there could be
grey areas where it could fail but should be minor w.r.t
response data format.

Resolves: openbmc/openbmc-test-automation#2105

Change-Id: Ie03b25ff88948bcccb09e9d82f8da86e28c92697
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

dump_utils:Trigger BMC dump and return task ID

Changes:
- New keyword added to initiate BMC dump via Redfish and return task ID.

Tested:
- Tested using a sample test

Signed-off-by: Anush

dump_utils:Trigger BMC dump and return task ID

Changes:
- New keyword added to initiate BMC dump via Redfish and return task ID.

Tested:
- Tested using a sample test

Signed-off-by: Anusha Dathatri <adathatr@in.ibm.com>
Change-Id: I59cd58a1b30eaf616183e468e0de1abecffef030

show more ...

Clean existing SNMP manager daemons before starting SNMP manager

Changes:
- Execute "killall snmptrapd" on the SNMP server.

Tested:
redfish/events/test_bmc_snmp_trap.robot

Signed-off-by: P

Clean existing SNMP manager daemons before starting SNMP manager

Changes:
- Execute "killall snmptrapd" on the SNMP server.

Tested:
redfish/events/test_bmc_snmp_trap.robot

Signed-off-by: Prashanth Katti <prkatti1@in.ibm.com>
Change-Id: Ie0b237bb456c81077a4f4b5ef9b22760febc405e

show more ...

ffdc: Extend ffdc cli to auto attempt ffdc on host os

Test:
- OPENBMC with HOST_OS not pingable
- OPENBMC with HOST_OS pingable and not ssh
- OPENBMC with HOST_OS flavors AIX, RHEL, UBUNTU

Change-I

ffdc: Extend ffdc cli to auto attempt ffdc on host os

Test:
- OPENBMC with HOST_OS not pingable
- OPENBMC with HOST_OS pingable and not ssh
- OPENBMC with HOST_OS flavors AIX, RHEL, UBUNTU

Change-Id: I93b4de2930368eaa3d16bc48e5f838051e35f8de
Signed-off-by: Peter D Phan <peterp@us.ibm.com>

show more ...

Change in Default Gateway

Changes:

- Fetch Default Gateway for eth0 and eth1

Tested:

Ran "Modify IPv4 Address And Verify on eth0 and eth1"

Change-Id: I203953b04d515cb1a3eaf270fdd87c00a14d800

Change in Default Gateway

Changes:

- Fetch Default Gateway for eth0 and eth1

Tested:

Ran "Modify IPv4 Address And Verify on eth0 and eth1"

Change-Id: I203953b04d515cb1a3eaf270fdd87c00a14d800a
Signed-off-by: Sweta Potthuri <spotthur@in.ibm.com>

show more ...

Fixed dump status value

Changes:
- Keyword was incorrectly returning None as dump status.
- Fixed the issue in 'Get Dump ID And Status' of lib/dump_utils.robot

Tested:
- Tested using

Fixed dump status value

Changes:
- Keyword was incorrectly returning None as dump status.
- Fixed the issue in 'Get Dump ID And Status' of lib/dump_utils.robot

Tested:
- Tested using a sample test

Signed-off-by: Anusha Dathatri <adathatr@in.ibm.com>
Change-Id: I48f2f65889950e251b106600b2bf1b7245d9e03a

show more ...

Test suite to verify BIOS POST code log entries

Changes:
- Create new suite to test BIOS POST codes
- Added new keywords to support clear and GET BIOS PostCode
- Added 1 test case

Test suite to verify BIOS POST code log entries

Changes:
- Create new suite to test BIOS POST codes
- Added new keywords to support clear and GET BIOS PostCode
- Added 1 test case to verify PostCode when system boots.

Note: This is just a single test and basic infrastructure to test
BIOS POST code.

Tested: Ran successfully redfish/systems/LogServices/test_post_codes.robot
Change-Id: I579daa523db2ebf18e3b527067c03d820ec068fc
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Redfish code update changes

Changes:
- Added task state in json file
data/task_state.json
- Added Keyword Create List Of Task,
Create Initiated Task State Dict,
Match Target URI

Redfish code update changes

Changes:
- Added task state in json file
data/task_state.json
- Added Keyword Create List Of Task,
Create Initiated Task State Dict,
Match Target URI,
Check Task With Match TargetUri,
Verify Task Progress State
- Added Keyword Get Task State From File

Tested:
Ran succesfully redfish/
update_service/test_redfish_bmc_code_update.robot

Change-Id: Iba2131925cb60614f456cbf5ec91b1b02bddc06b
Signed-off-by: Sushil Singh <susilsi7@in.ibm.com>

show more ...

Update logging-test file check on BMC

Changes:
- Modify BMC execute command keyword and also the
method using test binary utility command to check
logging-test file existence on B

Update logging-test file check on BMC

Changes:
- Modify BMC execute command keyword and also the
method using test binary utility command to check
logging-test file existence on BMC.

Tested:
Ran successfully
robot -v OPENBMC_HOST:xx.xx.xx.xx
-v DEBUG_TARBALL_PATH:./debug-tarball.tar.xz
redfish/systems/eventlog/test_event_logging.robot

Change-Id: If555ce6f9bbd040a75b21278bc8b506acaf45846
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

E275 missing whitespace after keyword

Changes:
- CI gerrit failed due to pycodestyle strict checking

Tested:
- CI gerrit should pass

Change-Id: I3bfcae57626fd484a9222da8532a413a0da6f610
S

E275 missing whitespace after keyword

Changes:
- CI gerrit failed due to pycodestyle strict checking

Tested:
- CI gerrit should pass

Change-Id: I3bfcae57626fd484a9222da8532a413a0da6f610
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Resource file for event notification

Changes:
- Added new keywords to get and delete subscriptions

Tested:
- Tested on sandbox with a sample test case, currently
not used anywhere.

Resource file for event notification

Changes:
- Added new keywords to get and delete subscriptions

Tested:
- Tested on sandbox with a sample test case, currently
not used anywhere.


Signed-off-by: Anusha Dathatri <adathatr@in.ibm.com>
Change-Id: I1df52f3ff8801abf43a75af240d7d7e8f45bf36a

show more ...

Added validation for power operation testcases using LDAP user.

Added code to check the host state after power operation and wait
until the host is up for power on.

Moved Redfish.Login to Test Tear

Added validation for power operation testcases using LDAP user.

Added code to check the host state after power operation and wait
until the host is up for power on.

Moved Redfish.Login to Test Teardown, to make the next testcase execute
with root user.

Added code to delete all redfish session in suite teardown.

Tested: Run robot redfish/account_service/test_ldap_configuration.robot

Signed-off-by: agarjun B <nagarjunb@ami.com>
Change-Id: Iaafe0657d41a82be067c1ea91fe02ef995567394

show more ...

Minor test case name, keyword and tagging name changes

Change-Id: If339cefe193a2da1dca73c4ec8c3634a56e5645f
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Quick certificate delete causes bmcweb to stop

bmcweb.service: Start request repeated too quickly
and hit start-limit-hit

Tested:
robot -v OPENBMC_HOST:xx.xx.xx -v wait_time:200
red

Quick certificate delete causes bmcweb to stop

bmcweb.service: Start request repeated too quickly
and hit start-limit-hit

Tested:
robot -v OPENBMC_HOST:xx.xx.xx -v wait_time:200
redfish/managers/test_certificate.robot

Change-Id: I29af1d7a9c92bfcc8b86ccc4a5b0a48d1c961dd6
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Adjust certificate install wait time to prevent bmcweb stopping

Changes:
- provision user to key in the with wait_time variable
example: -v wait_time:180

bmcweb.service: Start request

Adjust certificate install wait time to prevent bmcweb stopping

Changes:
- provision user to key in the with wait_time variable
example: -v wait_time:180

bmcweb.service: Start request repeated too quickly and hits the
limit and breaks the bmweb service until next BMC reset or restart
the bmcweb service manually.

This increases the test execution, however, there is no better way
to handle this in test cases.

Tested:
Ran successfully redfish/managers/test_certificate.robot

Change-Id: I965f8a09d95260c8c7c2f08c655125544c630251
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Changes in ipmi/test_ipmi_fru_device.robot

Added Following Test Case

- Read Fru Device configuration
- Verify Get FRU Inventory Area Info
- Verify Get FRU Inventory Area Info For Invalid Device

Changes in ipmi/test_ipmi_fru_device.robot

Added Following Test Case

- Read Fru Device configuration
- Verify Get FRU Inventory Area Info
- Verify Get FRU Inventory Area Info For Invalid Device Data
- Verify Get FRU Inventory Area Info For Invalid Data Request
- Verify IPMI Write FRU Data
- Verify IPMI Write FRU Data With BMC Reboot

Functions required are defined under lib/bmc_dbus.robot, lib/ipmi_client.robot and lib/utils.py

Request data for fru data present in data/ipmi_raw_cmd_table.py.

Read Fru Device configuration - Validates each ipmi fru device data with corresponding dbus data.

Verify Get FRU Inventory Area Info - Validates fru inventory byte size with ipmi read fru count returned.

Verify Get FRU Inventory Area Info For Invalid Device Data - Validates the response of inventory fru area info command with invalid device id.

Verify Get FRU Inventory Area Info For Invalid Data Request - Validates the response of inventory fru area info command with invalid request data by giving extra bytes.

Verify IPMI Write FRU Data - Verify write fru data with the response returned with read fru data after data is written.

Verify IPMI Write FRU Data With BMC Reboot - Verify the response of read fru data after the bmc is rebooted once the data is written to the fru device.

Signed-off-by: ganesanb <ganesanb@ami.com>
Change-Id: I2ea51ad51512ecbcc4036e2d2593cafaa40a2d3c

show more ...

Add lib keyword to get system power limit

Changes:
- Added redfish call to get the system power limit

Tested:
- Currently this code is not use, but wrote a sample test code
to call th

Add lib keyword to get system power limit

Changes:
- Added redfish call to get the system power limit

Tested:
- Currently this code is not use, but wrote a sample test code
to call this keyword and tested.

Change-Id: I2ddb7dc286f86210912e95a420b194b859de35a2
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Replaced BMC reset with PDU reset keyword in restore policy testcase
and added PDU library files for few other PDU types

Tested: Run robot redfish/extended/test_power_restore.robot

Signed-off-by: A

Replaced BMC reset with PDU reset keyword in restore policy testcase
and added PDU library files for few other PDU types

Tested: Run robot redfish/extended/test_power_restore.robot

Signed-off-by: Aravinth R <aravinthr@ami.com>
Change-Id: I4554c1b071a496feaeef65b7b9735bb97a41c7cb

show more ...

Fix synaccess response code

Changes:
- Minor changes in the REST response code checking

Tested:
robot -v OPENBMC_HOST:xx.xx.xx.xx -v PDU_IP:yy.yy.yy.yy
-v PDU_USERNAME:admin -v P

Fix synaccess response code

Changes:
- Minor changes in the REST response code checking

Tested:
robot -v OPENBMC_HOST:xx.xx.xx.xx -v PDU_IP:yy.yy.yy.yy
-v PDU_USERNAME:admin -v PDU_PASSWORD:*********
-v PDU_TYPE:synaccess -v PDU_SLOT_NO:1
redfish/extended/test_power_restore.robot

With this changes also, it is not fully working in our env.
This is more of a response changes fix for existing PDU.

Change-Id: I8ca64044d614329fb98291cad3c820d0a9a9b0d7
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add PLDM test suite to test firmware boot side

Changes:
- New PLDM test suite to test firmware boot side in loop
- Added new parameter to skip state checking post BMC reset

Tested:
ro

Add PLDM test suite to test firmware boot side

Changes:
- New PLDM test suite to test firmware boot side in loop
- Added new parameter to skip state checking post BMC reset

Tested:
robot -v OPENBMCHOST:xx.xx.xx.xx -v pldm/test_firmware_boot_side.robot

Change-Id: I6ffc639736427325e996ba993d395672a4637f82
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...