Pylint error and warning fixes

Changes:
- C0103: Variable name "ix" doesn't conform to snake_case naming style (invalid-name)
- W0612: Unused variable 'ix' (unused-variable)
- W0611:

Pylint error and warning fixes

Changes:
- C0103: Variable name "ix" doesn't conform to snake_case naming style (invalid-name)
- W0612: Unused variable 'ix' (unused-variable)
- W0611: Unused gen_print imported as gp (unused-import)

Tested: - python3 -m pylint lib/jobs_processing.py
Change-Id: I66d1644e8d31549f4f49ef07747504597c159d72
Signed-off-by: Sandhya Somashekar <sansomas@in.ibm.com>

show more ...

PEL:Get latest PELs

Changes:
Added new method - get_latest_pels in pel_utils.py
Fixed errors reported by pylint

Tested:
Dummy test

Change-Id: I90ccbad31b66b8ee0f121c1ce88a87694220b388
Signed-of

PEL:Get latest PELs

Changes:
Added new method - get_latest_pels in pel_utils.py
Fixed errors reported by pylint

Tested:
Dummy test

Change-Id: I90ccbad31b66b8ee0f121c1ce88a87694220b388
Signed-off-by: Anusha Dathatri <adathatr@in.ibm.com>

show more ...

Fail to perform firmware update

Changes:
- Verify Code Update Fails When Kernel Panic Occur

Tested:
- Ran successfully
redfish/update_service/
test_redfish_bmc_code_update.robot

Ch

Fail to perform firmware update

Changes:
- Verify Code Update Fails When Kernel Panic Occur

Tested:
- Ran successfully
redfish/update_service/
test_redfish_bmc_code_update.robot

Change-Id: Iae19c360248739ca94151e80e6904d8f1bec984e
Signed-off-by: Sushil Singh <susilsi7@in.ibm.com>

show more ...

Moving Redfish BMC match states keyword to another
library

Change-Id: I837a17f4155c34e7474112ea9e7011f3305b134a
Signed-off-by: Sushil Singh <susilsi7@in.ibm.com>

Fix CI pylint failure for python code

Changes:
- Spacing error reported for strings entries.

Tested:
- NA

Change-Id: I93b33036e0e1b21e63ed2e4b019b84a269d3fb83
Signed-off-by: George Keish

Fix CI pylint failure for python code

Changes:
- Spacing error reported for strings entries.

Tested:
- NA

Change-Id: I93b33036e0e1b21e63ed2e4b019b84a269d3fb83
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Keyword for checking Host state

Changes:
- Added a new keyword to check the host state

Tested:
- Tested on sandbox with changes to check the state.


Change-Id: Ic7c6d7cdf1e3ab3c627a0067969

Keyword for checking Host state

Changes:
- Added a new keyword to check the host state

Tested:
- Tested on sandbox with changes to check the state.


Change-Id: Ic7c6d7cdf1e3ab3c627a00679694cc7d43b339be
Signed-off-by: Sagar Anand <sagaranand@in.ibm.com>

show more ...

Added new SNMP testcase to settings menu

Changes :

Added test to check SNMP manager with less octet ip

Tested :

Ran Successfully gui/gui_test/settings_menu/test_snmp_alerts_sub_menu.robot

Added new SNMP testcase to settings menu

Changes :

Added test to check SNMP manager with less octet ip

Tested :

Ran Successfully gui/gui_test/settings_menu/test_snmp_alerts_sub_menu.robot
Ran Successfully lib/snmp/resource.robot

Change-Id: I72b57bffd345e74b701e2ed8410197137893c47b
Signed-off-by: Megha G N <Megha.G.N@ibm.com>

show more ...

Redfish: Specify which library to use for 'Get Redfish session info'

Changes:
- Specify that Keyword 'Get Redfish Session Info' is called from Library Redfish_Utils

Tested:
- The Keyword 'Delete

Redfish: Specify which library to use for 'Get Redfish session info'

Changes:
- Specify that Keyword 'Get Redfish Session Info' is called from Library Redfish_Utils

Tested:
- The Keyword 'Delete All Redfish Sessions' is called from the test suite.

Change-Id: I0811910e4e2606f9bd235c17396328073990abf5
Signed-off-by: Sagar Anand <sagaranand@in.ibm.com>

show more ...

Redfish service validator error checking

Changes:
- Added messsage checking from output due to redfish
retry error when server failed to respond

Tested:
- Ran test with error and wi

Redfish service validator error checking

Changes:
- Added messsage checking from output due to redfish
retry error when server failed to respond

Tested:
- Ran test with error and without to ensure it catches
the failure.

Change-Id: I5a29e0f40dc4fa4d0448bd63d2c54d0dc453f676
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix for SRC validation for L2FIR error injects

Change-Id: I9c26a468cba7bb50b0055e970e7de0eb58d299ef
Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>

Fix warning and errors CI

Change-Id: I00689763f9128229382a389826336eb5cd99662d
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Test documentation typo fixes using codespell tool

Changes:
- Fix typo in code documentation and test name

Tested: - Using codespell tool.

Change-Id: Ia1b65bddc01a4b1c103af9f2094d87da11c8895

Test documentation typo fixes using codespell tool

Changes:
- Fix typo in code documentation and test name

Tested: - Using codespell tool.

Change-Id: Ia1b65bddc01a4b1c103af9f2094d87da11c88953
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Amend BIOS firmware boot side keyword

Changes:
- Tweak code to handle side switch based on the user input
and current system BIOS value set.

Tested: - Tested in the sandbox using sample

Amend BIOS firmware boot side keyword

Changes:
- Tweak code to handle side switch based on the user input
and current system BIOS value set.

Tested: - Tested in the sandbox using sample test code

Change-Id: I055ea962717b9688b894b589a3f8556e9994f88b
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix CI code format error

Changes:
- Remove unused import
- Fix the syntax format

Tested:
- CI will catch the error if not correct

Change-Id: I00c5d7d06849cd68d52ed82c8afc7da722dbea63
S

Fix CI code format error

Changes:
- Remove unused import
- Fix the syntax format

Tested:
- CI will catch the error if not correct

Change-Id: I00c5d7d06849cd68d52ed82c8afc7da722dbea63
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: Ib5b60110da4a680

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: Ib5b60110da4a680472d7fc9a0d580dd88c7437e5
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Compare PEL, Redfish event log and verify PEL log

Changes:
- Added code
"verify_no_pel_exists_on_bmc"
"compare_pel_and_redfish_log"

Tested: - Ran successfully
"verify_no_pel_exist

Compare PEL, Redfish event log and verify PEL log

Changes:
- Added code
"verify_no_pel_exists_on_bmc"
"compare_pel_and_redfish_log"

Tested: - Ran successfully
"verify_no_pel_exists_on_bmc"
"compare_pel_and_redfish_log"

Change-Id: I39ed987814b83018164c2ec3e3b8228367a02517
Signed-off-by: Sushil Singh <susilsi7@in.ibm.com>

show more ...

openpower: Support sensors DBUS path check at runtime

Changes:
- Added code support keywords to fetch DBUS sensor
path information
- Added code support keyword to verify runtime and

openpower: Support sensors DBUS path check at runtime

Changes:
- Added code support keywords to fetch DBUS sensor
path information
- Added code support keyword to verify runtime and
pre-define template or user defined DBUS JSON data

Tested:
- Wrote test suite code to call the keyword and verified.

Change-Id: Iaf66e46f0144b35687a5c250ab66da5cf27919db
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Added test to verify error while initiating BMC dump

Changes:

- Added a new automation test case to verify errors while
initiating BMC dump during the dumping state.
- Added an argume

Added test to verify error while initiating BMC dump

Changes:

- Added a new automation test case to verify errors while
initiating BMC dump during the dumping state.
- Added an argument to skip BMC dump completion in create
dump keyword

Tested:

- Ran Verify_Error_While_Initiating_BMC_Dump_During_Dumping_State
the test case from the sandbox successfully.

Change-Id: Ifb487a5d299d870f51ddca270f86aea02597c179
Signed-off-by: manashsarma <manashsarma@in.ibm.com>

show more ...

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Will

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I944f1915ece753f72a3fa654902d445a9749d0f9

show more ...

Added new test case to SNMP-Alerts submenu

Changes:
- Added test to configure SNMP manager with empty IP,
negative IPand alphanumeric port and verify

Tested:
- Ran successfully test_s

Added new test case to SNMP-Alerts submenu

Changes:
- Added test to configure SNMP manager with empty IP,
negative IPand alphanumeric port and verify

Tested:
- Ran successfully test_snmp_alerts_sub_menu.robot

Change-Id: I4a8be9c63e426d22e131216c1817a3b83a2d5e9d
Signed-off-by: Megha G N <Megha.G.N@ibm.com>

show more ...

pycodestyle: Module level import not at top of file

Changes:
- Added NOQA on python files import to skip CI
- Fix import order reported by CI.

Tested:
- CI will catch this if there i

pycodestyle: Module level import not at top of file

Changes:
- Added NOQA on python files import to skip CI
- Fix import order reported by CI.

Tested:
- CI will catch this if there is error

Change-Id: I39a11d3e815a08488671ed948f073828e19aee37
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Revert "Fix for module level import not at top of file"

This reverts commit 47375aa789dcb11ba969895f61dfb12a773e2164.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Icc40562b861262

Revert "Fix for module level import not at top of file"

This reverts commit 47375aa789dcb11ba969895f61dfb12a773e2164.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Icc40562b861262d8fb72d68b43654334985eea4d

show more ...

Revert "black: re-format"

This reverts commit 5731818de0ce446ceaafc7e75ae39da1b69942ae.

Signed-off-by: George Keishing <gkeishin@in.ibm.com>
Change-Id: Ie61cdc8c7f2825b0d9d66be87a6a3a058de2b372

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d413

black: re-format

black and isort are enabled in the openbmc-build-scripts on Python files
to have a consistent formatting. Re-run the formatter on the whole
repository.

Change-Id: If1010ead857d41364c024bf8145a979a9377d382
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Fix for module level import not at top of file

Change-Id: I1994b58a027cdac3bf4084b77db61bc646aaaba6
Signed-off-by: Sridevi Ramesh <sridevra@in.ibm.com>