Plugin Error response type check

Tested:
- Timedout and expect return
- wrong data type return
- Correct return data type

Change-Id: If55150221037550e34d806eb2533f1a012c1ebe4
S

Plugin Error response type check

Tested:
- Timedout and expect return
- wrong data type return
- Correct return data type

Change-Id: If55150221037550e34d806eb2533f1a012c1ebe4
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

ffdc: Trigger Paramiko exec_command() timeout

Read stderr instead of stdout to trigger Paramiko exec_command() timout mechanism.
This fix timeing issue with previous patch.

Test:
- Regression test

ffdc: Trigger Paramiko exec_command() timeout

Read stderr instead of stdout to trigger Paramiko exec_command() timout mechanism.
This fix timeing issue with previous patch.

Test:
- Regression test to openbmc, ubuntu, rhel with standard config and plugins

Signed-off-by: Peter D Phan <peterp@us.ibm.com>
Change-Id: I793ba98e638fcdf8214e491760d8a94af714a41a

show more ...

Plugin: Add date time util module

Change-Id: I6ab1d8bb8df63b8590ce7800e60415d90ea3bad3
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

ffdc: Trigger paramiko exec_command() timeout mechanism

Add data read/write operation to trigger paramiko exec_command() timeout mechanism.
Reading channel status does not activate the timeout mecha

ffdc: Trigger paramiko exec_command() timeout mechanism

Add data read/write operation to trigger paramiko exec_command() timeout mechanism.
Reading channel status does not activate the timeout mechanism.

Test:
- Regression test to openbmc, ubuntu, rhel with standard config and plugins

Change-Id: Ib65304dbbfc1f2df592296e5b5025c928cef86d4
Signed-off-by: Peter D Phan <peterp@us.ibm.com>

show more ...

Add log collector YAML sysntax and rules documentation

Change-Id: I481d5e491c859b144a816567b6b0e589d63f5737
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Update plugin print statement

Change-Id: I57c37f7132084246fef5ad8cec673305157d0e0a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Update YAML for SCP block

With latest code, the FILES directive is not required
for SCP log collection.

Change-Id: I2fd1d8966fcc9b66b675ae59747341036a18febe
Signed-off-by: George Keishing <gkeishin

Update YAML for SCP block

With latest code, the FILES directive is not required
for SCP log collection.

Change-Id: I2fd1d8966fcc9b66b675ae59747341036a18febe
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Update log collector plugin documentation

Change-Id: I110ef4fd199dbcb924c2c42363fe16b1204bbe3d
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Add support to walk through /redfish/v1 using plugin

Changes:
- Add check for plugin response if dictionary
- Add new redfish plugin module
- Add entry in the YAML

Tested:
- Wi

Add support to walk through /redfish/v1 using plugin

Changes:
- Add check for plugin response if dictionary
- Add new redfish plugin module
- Add entry in the YAML

Tested:
- With plugin
- Generic existing testing

Change-Id: I71291e337d0a064bbe024fbef193380ec3cfb8ad
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add PLDM flight recorder log collection

Change-Id: I08903250d0e92a44b4a369d3cc457eb532708eb9
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Fix python plugin path

Change-Id: I3c5212389ec69bb3d9eb42cda0b99a5e64e036b6
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Update plugin documentation with ERROR directive support

Change-Id: I57eadb5cdc56c379160f94e5708040af5c46de97
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Add plugin block error state and checking

Changes:
- Add plugin error checking function
- Add check to pre-lookup before executiong plugin block

New plugin directive for error checking in

Add plugin block error state and checking

Changes:
- Add plugin error checking function
- Add check to pre-lookup before executiong plugin block

New plugin directive for error checking in YAML:
- plugin_error: exit_on_error
- plugin_error: continue_on_error

Tested:
- exit_on_error
- continue_on_error

Change-Id: I5e299d7160a83d58d09c2ef1a68e48c33b8c97cd
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

ffdc: Better handle user telnet command timeout.

Set 1: Exit output read loop when there is no more data,
even if user specified timer value has not expired.

Set 2: Redesign: use user input wait-fo

ffdc: Better handle user telnet command timeout.

Set 1: Exit output read loop when there is no more data,
even if user specified timer value has not expired.

Set 2: Redesign: use user input wait-for-execution time, if one is provided.
Else, use the default value of 120 sec

Test:
- Set 1: Remote systems with telnet server.
- Set 2: Remote systems with telnet server.

Signed-off-by: Peter D Phan <peterp@us.ibm.com>
Change-Id: I9d16eb2cf1d967d1e0acd47f2d316a192f1a7ecf

show more ...

Update SCP files logic to handle multiple file listing or find

Change-Id: I6fe94c243958251df52f22aa91e7bc38df920334
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Enhance FFDC plugin to handle data types return from plugins

Changes:
- Add more validation to check data types
- Introduce plugin name global list for list,dict data types

Change-Id: Ica

Enhance FFDC plugin to handle data types return from plugins

Changes:
- Add more validation to check data types
- Introduce plugin name global list for list,dict data types

Change-Id: Icaba80f2eed8a5ff7aeeeafe99e78ffadc40555a
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

ffdc: Add scp plugin.

- Set 1: Initial code
- Set 2: Expand comments
- Set 2: Allow filename to be either list-of-filenames or just filename

Test:
- Tested standalone plugin to SSH/SCP remote hosts

ffdc: Add scp plugin.

- Set 1: Initial code
- Set 2: Expand comments
- Set 2: Allow filename to be either list-of-filenames or just filename

Test:
- Tested standalone plugin to SSH/SCP remote hosts.

Signed-off-by: Peter D Phan <peterp@us.ibm.com>
Change-Id: If85d4b06b5da05f7403a3af28fa15a6d7f6c5925

show more ...

Add list data return from SSH response

Changes:
- Add new parameter in SSH to accept type
- Support ONLY string and list

Change-Id: I579ebb98a1bc633e682471e124030330a0a775ae
Signed-off-by

Add list data return from SSH response

Changes:
- Add new parameter in SSH to accept type
- Support ONLY string and list

Change-Id: I579ebb98a1bc633e682471e124030330a0a775ae
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Add support to write plugin response datat to file

Rules:
if in FILES directive
- 'name.txt'
plugin response if any are written to name.txt file.
- None
plugin response are

Add support to write plugin response datat to file

Rules:
if in FILES directive
- 'name.txt'
plugin response if any are written to name.txt file.
- None
plugin response are skipped and not written to any file.

Testing:
- Using plugin module
- Using named file
- Using None directive

Change-Id: If7de4883ef6f9ff2f753b024b2d68e7d1de86eb9
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Update Plugin documentation for log collector

Change-Id: Ice428db85f8a9f1c7d34e5b1affeeeb0948c3a45
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

ffdc: Convert paramiko return values to string.

Convert paramiko return stdout and stderr from list of strings
to one string for processing.

Test:
- Regression test to SSH Servers.

Signed-off-by:

ffdc: Convert paramiko return values to string.

Convert paramiko return stdout and stderr from list of strings
to one string for processing.

Test:
- Regression test to SSH Servers.

Signed-off-by: Peter D Phan <peterp@us.ibm.com>
Change-Id: I74afdeb268cad5c70db8422bef7d7118f0d9e8d9

show more ...

Fix command parsing for SHELL, IPMI and REDFISH

Change-Id: Ic9f0b3593b187f91cf9c878608b7dec03d99e2d0
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

ffdc: Convert telnet return data to ASCII string.

telnetlib return data as a binary list.
Convert return data to ASCII string for processing.

Test:
- Regression test to telnet servers.

Signed-off-

ffdc: Convert telnet return data to ASCII string.

telnetlib return data as a binary list.
Convert return data to ASCII string for processing.

Test:
- Regression test to telnet servers.

Signed-off-by: Peter D Phan <peterp@us.ibm.com>
Change-Id: I3ed066556a026370ea2e4a641d64bea90f9c5124

show more ...

Parse SHELL / IPMI files and replace if env exist

Change-Id: Id2de75c21108de67703d69d8d4ba254233ca6200
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Add YAML parsing to update env vars for SCP

Change-Id: I28419842547f6744f6558a71201d9814baf7712f
Signed-off-by: George Keishing <gkeishin@in.ibm.com>