userid-validation: add microsoft

CLA out at:
https://drive.google.com/drive/folders/1VJbxFhwUEY96jCmzBkzkXFMJ0yRQw9wS

Change-Id: If396584ac80d03d2eebe9f88c1f5ea4ad4d8e208
Signed-off-by: Andrew Geis

userid-validation: add microsoft

CLA out at:
https://drive.google.com/drive/folders/1VJbxFhwUEY96jCmzBkzkXFMJ0yRQw9wS

Change-Id: If396584ac80d03d2eebe9f88c1f5ea4ad4d8e208
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Update robotframework-requests package

Changes:
- Requires this build script changes and code from test code
https://gerrit.openbmc.org/c/openbmc/openbmc-test-automation/+/56052
- Github

Update robotframework-requests package

Changes:
- Requires this build script changes and code from test code
https://gerrit.openbmc.org/c/openbmc/openbmc-test-automation/+/56052
- Github task openbmc/openbmc-test-automation#2105
- add robotframework-jsonlibrary package to replace deprecated
keyword To JSON in test suites and resource files.

Tested: HW Jenkins test CI, code update, ffdc and few other test suites
which are impacted due to this changes.

Change-Id: I73634fc3fd12ddd817d6016ebf156118d407fb24
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

spelling: add ignore list

Thu Ba reported that their name is getting rejected as a spelling
mistake in their Signed-off-by. Add capability to ignore words
from the primary dictionaries and add 'ba'

spelling: add ignore list

Thu Ba reported that their name is getting rejected as a spelling
mistake in their Signed-off-by. Add capability to ignore words
from the primary dictionaries and add 'ba' to the ignore list.

Tested:

Before change, manually running codespell results in:
```
./config/openbmc-spelling-ignore.txt:1: Ba ==> By, be
```
Manually running codespell with ignore-list option removes this.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I33134e519e28024926b6da00340d2d52e2e884bd

show more ...

MAINTAINERS: remove file

The MAINTAINERS file is deprecated in favor of OWNERS.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I66814b18521f67416401de0a2b6ad8690bf7360f

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have

OWNERS: switch 'matches' to 'matchers'

The original OWNERS template had a mistake which used 'matches' instead
of the field supported by the Gerrit plugin 'matchers'. Update the
OWNERS file to have the correct field.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I22728ed1653e74490c78e0664aae34c8b32e488b

show more ...

tools: owners: support recursive OWNERS

Search for any OWNERS files anywhere in the repository, rather than
just at the root, and incorporate their information into the
review-set.

Tested: Modified

tools: owners: support recursive OWNERS

Search for any OWNERS files anywhere in the repository, rather than
just at the root, and incorporate their information into the
review-set.

Tested: Modified meta-aspeed/recipes-bsp/u-boot/u-boot-aspeed.inc
and observed additional reviewers as expected.

```
$ tools/owners --path $(wd path lfopenbmc) reviewers
{"reviewer": "bradleyb@fuzziesquirrel.com", "state": "REVIEWER", "notify": "NONE", "notify_details": {"TO": {"accounts": ["bradleyb@fuzziesquirrel.com"]}}}
{"reviewer": "edtanous@google.com", "state": "REVIEWER", "notify": "NONE", "notify_details": {"TO": {"accounts": ["edtanous@google.com"]}}}
{"reviewer": "geissonator@yahoo.com", "state": "REVIEWER", "notify": "NONE", "notify_details": {"TO": {"accounts": ["geissonator@yahoo.com"]}}}
{"reviewer": "joel@jms.id.au", "state": "REVIEWER", "notify": "NONE", "notify_details": {"TO": {"accounts": ["joel@jms.id.au"]}}}
{"reviewer": "patrick@stwcx.xyz", "state": "REVIEWER", "notify": "NONE", "notify_details": {"TO": {"accounts": ["patrick@stwcx.xyz"]}}}
{"reviewer": "chiawei_wang@aspeedtech.com", "state": "CC", "notify": "NONE", "notify_details": {"TO": {"accounts": ["chiawei_wang@aspeedtech.com"]}}}
{"reviewer": "zweiss@equinix.com", "state": "CC", "notify": "NONE", "notify_details": {"TO": {"accounts": ["zweiss@equinix.com"]}}}
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I08775e3975897066d79c22ba38f0fdef364ed708

show more ...

tools: owners: reduce notify spam from Jenkins

By default, the Gerrit 'reviewers' API will notify everyone of
the change to add a new reviewer. When adding reviewers automatically
from Jenkins this

tools: owners: reduce notify spam from Jenkins

By default, the Gerrit 'reviewers' API will notify everyone of
the change to add a new reviewer. When adding reviewers automatically
from Jenkins this can cause quite a bit of spam. Adjust the 'notify'
fields of the API call so that only the newly-added reviewer is
notified.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib992284918145a31c9ff749737b3ae09f4d5ef0e

show more ...

scripts/unit-test.py: Fix an indent issue

The indent is incorrect and is fixed by autopep8

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I2d91c2bd3c32e2fc495eca137406fe234726a105

run-unit-test-docker: Support http_proxy env

If http_proxy env is set, add proxy related env into docker container so
that the unit test could be run in a proxy environment.

This could be useful fo

run-unit-test-docker: Support http_proxy env

If http_proxy env is set, add proxy related env into docker container so
that the unit test could be run in a proxy environment.

This could be useful for repo like bmcweb that downloads extra content
during build and test.

Tested: Verify the bmcweb repo CI could use the proxy to download the
DSP8010 schema zip.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I8970c5eec76adaa096af127c93c409de55221181

show more ...

jenkins: add owners tool to userid-validation flow

Run the 'owners' tool during the userid-validation so that
owners and reviewers are automatically added by Jenkins.

Fix a few minor issues with th

jenkins: add owners tool to userid-validation flow

Run the 'owners' tool during the userid-validation so that
owners and reviewers are automatically added by Jenkins.

Fix a few minor issues with the 'owners' tool:

- Switch the 'push-args' option from BooleanOptionalAction since
this isn't supported in the Python version on the Jenkins
controller.

- Handle empty 'matchers' statements.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ib496c5874a532299ecf821345c8c25d87a21f3f1

show more ...

stdplus: Depend on googletest for support lib

This now provides some additional test case routines that require
googletest to build

Change-Id: I191705fa1b65e731308946c1eb72edc09b189bee
Signed-off-b

stdplus: Depend on googletest for support lib

This now provides some additional test case routines that require
googletest to build

Change-Id: I191705fa1b65e731308946c1eb72edc09b189bee
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Improve cppcheck results and calling code

In the ideal case, cppcheck would have an option where it could be
enforcing in the future. This commit works toward that goal, but
doesn't quite get there

Improve cppcheck results and calling code

In the ideal case, cppcheck would have an option where it could be
enforcing in the future. This commit works toward that goal, but
doesn't quite get there.

First, it updates cppcheck to the latest copy from github, instead of
pulling through apt sources. This is done because the current cppcheck
has an issue with std::string_view, and erroneously believes that it
should be passed by reference. The master branch has a fix for this.

Next, it modifies the call of cppcheck in a couple ways, first, to rely
on compile_commands.json from the build step, rather than attempting to
build a list of files itself. This is less error prone, and allows
"whole binary" scans with cppcheck, which leads to fewer false
positives. On the negative side, this means that non-meson/non-cmake
projects will no longer get scanned, which, considering that meson is
what we're converging on, and for any given project a meson port should
probably take priority over cppcheck improvements, this seems
reasonable.

Because of the previous change, the use of popen and communicate() can
be replaced with our more normal methods for calling commands, which
cleans up the code quite a bit.

Adds a cppcheck-temp folder as recommended by the cppcheck docs for
storing intermediate results. This decreases the amount of time
cppcheck takes to run when scanning the same code multiple times.

After that, some argument changes are done to suppress checks that are
noisy, and the project doesn't currently have a way to make pass.

useStlAlgorithm this is just a suggestion, and not always correct, so
it's difficult to make it enforcing. Also, as a project, we tend to not
optimize for std::algorithms as much as we could. At some point in the
future we could turn this back on and make the project have a stronger
opinion on this style, but for the moment, this seems like something to
tackle later.
unusedStructMember this appears to either have bugs, or not understand
when a public struct member is used outside of the compile unit. It
leads to significant noise for things that are actually used, but get
marked unused because they're not used in every compile unit.
postfixOperator use of prefix increment indead of postfix on iterators
is not generally something we enforce on the project, and doesn't seem
like it improves in either the readability or the code, as well as leads
to a lot of noise. Disable for the moment.
unreadVariable Similar to unusedStructMember, this check seems to not be
able to see all possible ifdefs in a section of code, and leads to many
false positives.
knownConditionTrueFalse is supressed because apparently cppcheck isn't
able to read macros, so this flags significant portions of code behind
ifdefs. More investigation is warranted here, but for the moment,
disabling the check gets us closer to the goal

A patch series getting bmcweb code to the point where it's 100% passing
is here, if you want to see the types of changes that cppcheck proposes.
For all the non-disabled checks, cppcheck seems accurate, with no false
positives that I could find, although some slightly pedantic
suggestions.

https://gerrit.openbmc.org/c/openbmc/bmcweb/+/55001

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I7730cc69ad1817cb7d75c04be3b7d1da6c1030d4

show more ...

Update boost to 1.79

Same as yocto is using.

Tested: Built dbus-sensors uring patches (which require 1.79) and they
built correctly.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ic83a

Update boost to 1.79

Same as yocto is using.

Tested: Built dbus-sensors uring patches (which require 1.79) and they
built correctly.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ic83a5ccb940fbc3bce4f8abedce1087e5cdfc102

show more ...

userid-validation: add Phytium Technology

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic0197f6e40e5bbe71848a1d8e6dd96c4d479373b

build-qemu-robot-docker: update to jammy

The HEAD of the OpenBMC now builds the QEMU binary with GLIbc_2.33. But
this QEMU-Robot-docker still uses GLIbc_2.31, which causes
run-qemu-robot to fail.

T

build-qemu-robot-docker: update to jammy

The HEAD of the OpenBMC now builds the QEMU binary with GLIbc_2.33. But
this QEMU-Robot-docker still uses GLIbc_2.31, which causes
run-qemu-robot to fail.

The fix is to simply update the base image to jammy which has a newer
version of glibc.

This commit also fixed imcompatible packages in the build script:
python2.

Tested: run-robot-test-qemu worked on the Romulus image built from HEAD

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I4d8b63dddced1e33eb4073b4f4471220ed7e76da

show more ...

tools: owners: handle matchers

Enhance the owners tool to parse the 'matchers' directives in order
to add additional owners and reviewers.

Tested:

* Created a bogus commit in 'docs' to detect GPIO

tools: owners: handle matchers

Enhance the owners tool to parse the 'matchers' directives in order
to add additional owners and reviewers.

Tested:

* Created a bogus commit in 'docs' to detect GPIO and MCTP matchers.
* Created a bogus commit in 'smbios-mdr' to detect change to
speed_select.hpp.

```
$ tools/owners --path ../docs reviewers && echo "..." && tools/owners --path ../smbios-mdr reviewers
{"reviewer": "bradleyb@fuzziesquirrel.com", "state": "REVIEWER"}
{"reviewer": "patrick@stwcx.xyz", "state": "REVIEWER"}
{"reviewer": "andrew@aj.id.au", "state": "CC"}
{"reviewer": "anoo@us.ibm.com", "state": "CC"}
{"reviewer": "gmills@linux.vnet.ibm.com", "state": "CC"}
{"reviewer": "jk@ozlabs.org", "state": "CC"}
{"reviewer": "joel@jms.id.au", "state": "CC"}
...
{"reviewer": "jonathan.doman@intel.com", "state": "REVIEWER"}
{"reviewer": "kuiying.wang@intel.com", "state": "REVIEWER"}
{"reviewer": "yugang.chen@linux.intel.com", "state": "REVIEWER"}
{"reviewer": "zhikui.ren@intel.com", "state": "REVIEWER"}
```

Change-Id: Idda5e344c1d061d1ceaef35b65d546b3b679b382
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

Upgrade clang-tidy version to 14.0.0

Fix a clang issue appearing in clang-tidy-13.0.1
Details refer to: https://reviews.llvm.org/rG1f2d40c47f5f8fd01d91d73a1f52044fe1c83225
[clang-tidy] fix duplicate

Upgrade clang-tidy version to 14.0.0

Fix a clang issue appearing in clang-tidy-13.0.1
Details refer to: https://reviews.llvm.org/rG1f2d40c47f5f8fd01d91d73a1f52044fe1c83225
[clang-tidy] fix duplicate '{}' in cppcoreguidelines-pro-type-member-init

Issue: The overload of the constructor will repeatedly fix the member
variables that need to be initialized, Removed the duplicate '{}'.

In current ubuntu:jammy, clang version 14.0.0 is available, so we can use
clang-tidy 14.0.0 to fix the clang issue.

Change-Id: I312888b13ed0ed39e0edf502eca46b11b9e9a62f
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

run-unit-test-docker: add comment for TEST_ONLY

The NO_FORMAT_CODE option is in the comment block. It also makes sense
to add the TEST_ONLY option to that comment block.

Tested: tested locally thou

run-unit-test-docker: add comment for TEST_ONLY

The NO_FORMAT_CODE option is in the comment block. It also makes sense
to add the TEST_ONLY option to that comment block.

Tested: tested locally though it only changes a comment.

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I49f48e813c633bd89b9c82df128e84e3c59c8993

show more ...

tools: owners: initial parsing of OWNERS file

Tested:

```
$ tools/owners reviewers
{"reviewer": "geissonator@yahoo.com", "state": "REVIEWER"}
{"reviewer": "joel@jms.id.au", "state": "REVIEWER"}
{"r

tools: owners: initial parsing of OWNERS file

Tested:

```
$ tools/owners reviewers
{"reviewer": "geissonator@yahoo.com", "state": "REVIEWER"}
{"reviewer": "joel@jms.id.au", "state": "REVIEWER"}
{"reviewer": "patrick@stwcx.xyz", "state": "REVIEWER"}
{"reviewer": "andrew@aj.id.au", "state": "CC"}

$ tools/owners reviewers --push-args
r=geissonator@yahoo.com,r=joel@jms.id.au,r=patrick@stwcx.xyz,cc=andrew@aj.id.au
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I145bd065dff101776c733fddb26fea4f324dd100

show more ...

run-unit-test-docker.sh: add INTERACTIVE option

This allows running an interactive bash shell instead of the default
unit testing script.

Tested: Ran with and without "INTERACTIVE=true"

Signed-off

run-unit-test-docker.sh: add INTERACTIVE option

This allows running an interactive bash shell instead of the default
unit testing script.

Tested: Ran with and without "INTERACTIVE=true"

Signed-off-by: Benjamin Fair <benjaminfair@google.com>
Change-Id: Ifaee7d0dd705466ce70ad49aae48ac9a4a7ab522

show more ...

userid-validation: move to python3

Change-Id: Ib7e8e179f6f3992f700a186e8077fed9e068254b
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

move all build scripts to gerrit.openbmc.org

OpenBMC has transitioned the gerrit server to the openbmc.org domain

Change-Id: Ia65d5f968a4ffcf3bc65536148e90e42725c86aa
Signed-off-by: Andrew Geissler

move all build scripts to gerrit.openbmc.org

OpenBMC has transitioned the gerrit server to the openbmc.org domain

Change-Id: Ia65d5f968a4ffcf3bc65536148e90e42725c86aa
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

unit-test.py: Format with autopep8

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: If2af9b695ec6325aebf7fafb9f5ef17e43a52c40

run-ci: remove --network=host

There shouldn't be any reason to expose the Docker container
directly on the host network. The default in Docker is 'bridge'.

This was originally introduced in a comm

run-ci: remove --network=host

There shouldn't be any reason to expose the Docker container
directly on the host network. The default in Docker is 'bridge'.

This was originally introduced in a commit that added CMake support
back in 2017 but with no explanation. Removing it now...

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6f7f218cd23b86d62efdadafa8e75c8a8615b4da

show more ...

build-unit-test-docker: Don't generate markdown for PDI

Not used in the unit test container.

Change-Id: I19c053bf73cd08b19f30c855191f1f087f8bca1c
Signed-off-by: William A. Kennington III <wak@googl

build-unit-test-docker: Don't generate markdown for PDI

Not used in the unit test container.

Change-Id: I19c053bf73cd08b19f30c855191f1f087f8bca1c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...