Update boost 1.81 -> 1.82

The latest yocto update pulled in the new boost version. Update it.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Idb39a2ac496b6c1e54cd6c87682c7847e7f848a8

jenkins: add vaisala/ci-authorized

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2fc1a8766ddc42fdd6f75c6f9aee77e9d5880e5f

build-unit-test-docker: move homedir with usermod

When the uid already exists, we do a usermod instead of a useradd,
but this does not create the new home directory. We need to pass
the `-m` argume

build-unit-test-docker: move homedir with usermod

When the uid already exists, we do a usermod instead of a useradd,
but this does not create the new home directory. We need to pass
the `-m` argument in order to move the old home directory to the
new location.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9f2cabe982af0b09d3c3f65dcd3a0acb6b8f3591

show more ...

build-unit-test-docker: Use curl for getting keys

apt-key fails to get keys when behind a firewall. Use curl to
get keys via http proxy and add them using apt-key add.

Tested: docker build and run

build-unit-test-docker: Use curl for getting keys

apt-key fails to get keys when behind a firewall. Use curl to
get keys via http proxy and add them using apt-key add.

Tested: docker build and run using "scripts/build-unit-test-docker".

Change-Id: I3fa3e4cdd326681b72a77ac251de76a9359ce706
Signed-off-by: Jagpal Singh Gill <paligill@gmail.com>

show more ...

jenkins: add equinix/ci-authorized

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I2d48b53e6ec720b1f89e61fdd91082b408a05779

unit-test: Make UBSAN kill tests

Continuing to exploit the runtime library means we get useful
diagnostics printed rather than just the application generating a core.

Change-Id: I0b93e61bbca48eb5a7

unit-test: Make UBSAN kill tests

Continuing to exploit the runtime library means we get useful
diagnostics printed rather than just the application generating a core.

Change-Id: I0b93e61bbca48eb5a79ba6fa9228431d36504f64
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

unit-test: add meson version check for get_variable

Some repositories are using the newer `get_variable` call in meson
without a keyword argument. This requires meson 0.58 or later. I've
contribut

unit-test: add meson version check for get_variable

Some repositories are using the newer `get_variable` call in meson
without a keyword argument. This requires meson 0.58 or later. I've
contributed fixes for all repositories under the
`meson_deprecated_pkgconfig` topic and so am also adding a CI catch
to prevent future regressions.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9465c3946825ec96d0c934635685e85d74fdf4ee

show more ...

build-unit-test-docker: switch to ubuntu:lunar

Besides the usual changes, upgrade requires the following:

- remove liburing2-dbgsym - package no longer exists
- pip3 add `--break-system-packages` -

build-unit-test-docker: switch to ubuntu:lunar

Besides the usual changes, upgrade requires the following:

- remove liburing2-dbgsym - package no longer exists
- pip3 add `--break-system-packages` - pip3 will no longer install
content at the system level without this.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic84e19c7c0f0e3be0057126d562b4aab00392aaf

show more ...

build-unit-test-docker: handle existing user/group

Ubuntu Lunar docker images contain a 'ubuntu' user and group by
default at 1000. The current code will skip creating a user if
the gid/uid already

build-unit-test-docker: handle existing user/group

Ubuntu Lunar docker images contain a 'ubuntu' user and group by
default at 1000. The current code will skip creating a user if
the gid/uid already exist but then attempt to `chown` a path to
the `{username}:{username}` that it didn't create (which fails).

Rather than do-nothing if the gid/uid already exist, use groupmod
and usermod to modify those as appropriate.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie07146be1bd2ce9bce2aac818da2f01665dba890

show more ...

build-unit-test-docker: update meson to 1.0.1

The version in poky is currently 1.0.1, so upgrade to that for
consistency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I39cae4bcb0c

build-unit-test-docker: update meson to 1.0.1

The version in poky is currently 1.0.1, so upgrade to that for
consistency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I39cae4bcb0cb8578fe621851597cb467d8055d4f

show more ...

build-unit-test-docker: turn 'pip3 install' calls into one invocation

Future Ubuntu is going to require us to pass in a parameter to
`pip3 install`. Reduce the number of RUN commands to simplify th

build-unit-test-docker: turn 'pip3 install' calls into one invocation

Future Ubuntu is going to require us to pass in a parameter to
`pip3 install`. Reduce the number of RUN commands to simplify that
future invocation.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9f5d4d6b43c637dbfeb6beaadfb5bf80f82cefc3

show more ...

boot-qemu: shellcheck fix

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic13f10cf1393cb3d55e2f33c49abdf5918892832

build-unit-test-docker: remove openbmc/linux dependency

Downloading the entire openbmc/linux repository is pretty slow
due to the way the Github CDN works on these kinds of files (and
how large it i

build-unit-test-docker: remove openbmc/linux dependency

Downloading the entire openbmc/linux repository is pretty slow
due to the way the Github CDN works on these kinds of files (and
how large it is). On my home connection I typically see ~100kbps
on this download, which would equate to over 15 minutes of a download.

This was originally done so that we could get kernel headers for
interfaces that we didn't have upstreamed yet but everything is now
upstreamed so this is not necessary.

If this becomes necessary again in the future, it would be better
to explicitly download specific headers from the respository instead
of attempting to get the entire thing.

Tested:

The necessary headers are now provided by `linux-libc-dev`:
```
$ docker run --rm -it openbmc/ubuntu-unit-test:2023-W15-c977bb8f48b9ee3b
root@e20efded42fb:/# dpkg -S /usr/include/linux/ipmi_bmc.h
linux-libc-dev:amd64: /usr/include/linux/ipmi_bmc.h
root@e20efded42fb:/# dpkg -S /usr/include/linux/bt-bmc.h
linux-libc-dev:amd64: /usr/include/linux/bt-bmc.h
```

Also manually ran `btbridge` and `ipmbbridge` under the
`run-unit-test-docker.sh` with successful results.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I7689c59e6cb290ac1a703cbf7994d2d9b6434482

show more ...

run-unit-test-docker: support podman

podman requires this env variable be set in order to have the correct
permissions to mount your home filesystem.

Tested:
- Verified after the latest sdbusplus u

run-unit-test-docker: support podman

podman requires this env variable be set in order to have the correct
permissions to mount your home filesystem.

Tested:
- Verified after the latest sdbusplus updates that this script can now
run on a POWER9 based server using RH8 + podman

Change-Id: I32a9e68f8cfc5df1d4489a2e089ab3ba92558cc9
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Add libaudit-dev package to the base container

There has been work going on in bmcweb to leverage linux
libaudit framework for auditlogging. The idea behind this
commit is to add the libaudit-dev pa

Add libaudit-dev package to the base container

There has been work going on in bmcweb to leverage linux
libaudit framework for auditlogging. The idea behind this
commit is to add the libaudit-dev package into the CI base
container to let the bmcweb commits pass CI.

libaudit-dev package contains the header files & static library
for security auditing.

Change-Id: Iac7b5089aa8788dabb1554c01cb4dcf12bb44ac9
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

docker:buildkit: ensure container build output is generated

Some newer distributions are moving to buildkit which is an improved
backend to docker that replaces the legacy builder. This new backend

docker:buildkit: ensure container build output is generated

Some newer distributions are moving to buildkit which is an improved
backend to docker that replaces the legacy builder. This new backend
builder has different rules on what it outputs to the console as it
builds an image.

To ensure we get the normal verbose output we're used to, set the
BUILDKIT_PROGRESS env variable.

There's also a parameter you can pass to docker build (--progress) but
it doesn't appear in the --help of older docker build commands so it's
best to just utilize the env variable option.

Change-Id: I520c0b933f920b05937e68a76fb7bd02ff889bc4
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-setup: support podman

We have some Redhat servers I'm interested in using for OpenBMC builds.
With just the minor change in this commit, I was able to get openbmc to
successfully build on a RH

build-setup: support podman

We have some Redhat servers I'm interested in using for OpenBMC builds.
With just the minor change in this commit, I was able to get openbmc to
successfully build on a RH8 system which points "docker" to the podman
executable.

The failure without this commit is the following:
```
Error: runc: runc create failed: unable to start container process: exec: "/home/geissonator/89239843/build.sh": stat /home/geissonator/89239843/build.sh: permission denied: OCI permission denied
```

Some online searching brought me to this --userns parameter. Setting
this env variable fixed the issues on the RH8 system.

Tested:
- Confirmed openbmc will build on RH8 system with podman
- Confirmed openbmc still builds on Ubuntu system

Change-Id: I3d1127c25dd08a1c8748943f8f3a1add11fe12ee
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

cppcheck: enable inline-suppr

Allow inline suppression of cppcheck errors for special cases. Some
example use cases might be:

- suppress accessMoved in a unit test for a move constructor (ensuring

cppcheck: enable inline-suppr

Allow inline suppression of cppcheck errors for special cases. Some
example use cases might be:

- suppress accessMoved in a unit test for a move constructor (ensuring
the moved from object is in the expected state).
- suppress noExplicitConstructor for RAII types where implicit
conversion is intentional and desired.

Change-Id: I560d780fdf9266dc54662a9eeb6ed6986fc271a8
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

run-unit-test-docker.sh: add extra docker run args

It can be useful to provide docker run with additional command line
arguments, such as --volume.

Consider a filesystem with git repositories:
~/gi

run-unit-test-docker.sh: add extra docker run args

It can be useful to provide docker run with additional command line
arguments, such as --volume.

Consider a filesystem with git repositories:
~/git/openbmc/bmcweb

And git worktrees for those repositories outside of the ~/git/openbmc
namespace:

~/worktrees/worktree-a/bmcweb
~/worktrees/worktree-b/bmcweb

and then using EXTRA_DOCKER_RUN_ARGS="--volume $HOME/git:$HOME/git" it
becomes possible to run the unit tests with such a layout.

Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>
Change-Id: I5524e4d369f98229180b2e1beaf322381ca814c7

show more ...

userid-validation: add Ufispace

CLA is accepted. Add Ufispace.

Change-Id: Idc97459a0cf836115c02c2458b2bfbc2872680c3
Signed-off-by: Jordan Chang <jordan.chang@ufispace.com>

Run clang-tidy in meson

Meson has built in functionality for running clang-tidy. It improves on
run-clang-tidy because it will also run each header file individually,
rather than relying on their #

Run clang-tidy in meson

Meson has built in functionality for running clang-tidy. It improves on
run-clang-tidy because it will also run each header file individually,
rather than relying on their #inclusion into a src file, which can find
far more missing #includes, and seems to find more issues in complex
source files (unclear why).

Tested: I've walked through all the repos that have a .clang-tidy, and
I've systematically fixed the issues, so hopefully this change has no
impact. I have yet to see this cause any functional impact.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I62520056192d876938ddab4d7cdafc954fa1806d

show more ...

black: remove --preview

The --preview option is more likely to cause churn in our Python
formatting. Disable it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I96e6e7fbd6607c478ca

black: remove --preview

The --preview option is more likely to cause churn in our Python
formatting. Disable it.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I96e6e7fbd6607c478ca38c5de8a0db0c30b180a5

show more ...

build-unit-test-docker: update per new format rules

New formatting rules require this change

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ieef4c1359d065daa5c636c42cc0618b287285

build-unit-test-docker: update per new format rules

New formatting rules require this change

Signed-off-by: Andrew Geissler <geissonator@yahoo.com>
Change-Id: Ieef4c1359d065daa5c636c42cc0618b287285307

show more ...

build-seed: add ahe50dc and romed8hm3

Two new systems added per request from Equinix

Change-Id: I24d04e4626aee54ad579202464035bcca48bb8ad
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

build-seed: update with new systems

Brings the script up to date with the system we build in ci-openbmc
jenkins job.

- bletchley
- e3c246d4i

Change-Id: I2e488f4bd67dcef585f9888222b1031411dbf690
Si

build-seed: update with new systems

Brings the script up to date with the system we build in ci-openbmc
jenkins job.

- bletchley
- e3c246d4i

Change-Id: I2e488f4bd67dcef585f9888222b1031411dbf690
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...