build-unit-test-docker: add nlohmann-json dep to sdbusplus

Pending commit[1] adds nlohmann-json usage in sdbusplus;
update docker dependencies to reflect that.

[1]: https://gerrit.openbmc.org/c/ope

build-unit-test-docker: add nlohmann-json dep to sdbusplus

Pending commit[1] adds nlohmann-json usage in sdbusplus;
update docker dependencies to reflect that.

[1]: https://gerrit.openbmc.org/c/openbmc/sdbusplus/+/74858

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I9027c06877c35ae9c5b130d1ce0bec881060b5d7

show more ...

Update robot framework version

Change:
- Update robot version from 7.0 to 7.0.1 for
more robot fixes.

Tested:
- Tested on sandbox

Change-Id: Ib114d58f600a99c74dc6cf2cb0177edadb19dfa2

Update robot framework version

Change:
- Update robot version from 7.0 to 7.0.1 for
more robot fixes.

Tested:
- Tested on sandbox

Change-Id: Ib114d58f600a99c74dc6cf2cb0177edadb19dfa2
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

test-qemu: Use romulus instead of witherspoon for AST2500

Witherspoon's UBI support seems to be broken. However, Romulus is also
used by CI as a smoke test, so it makes sense to check that anyway.

test-qemu: Use romulus instead of witherspoon for AST2500

Witherspoon's UBI support seems to be broken. However, Romulus is also
used by CI as a smoke test, so it makes sense to check that anyway.

Change-Id: I4c20f1e800b43ff5614cb34388149657529a5130
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

build-unit-test-docker: update googletest

Googletest 1.14 has issues with clang-18. Update to 1.15.2 which
seems to no longer have the issues.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
C

build-unit-test-docker: update googletest

Googletest 1.14 has issues with clang-18. Update to 1.15.2 which
seems to no longer have the issues.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic31cd021ea17ba6d1a9f81399f8deaa86bdb5900

show more ...

build-unit-test-docker: use LLVM APT repos

The latest version of clang-18 from ubuntu's apt is 18.1.3,
but the latest stable release is 18.1.8. These two versions have
different output on some repo

build-unit-test-docker: use LLVM APT repos

The latest version of clang-18 from ubuntu's apt is 18.1.3,
but the latest stable release is 18.1.8. These two versions have
different output on some repositories when using clang-format. Switch
to using the apt.llvm.org packages so we get the latest stable versions.

The LLVM apt install tool needed a few additional packages to be
installed, so add those to the base apt-get.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I139cb040b95793ef8e7034d49296a2a5ea3bbac3

show more ...

build-unit-test-docker: update to clang-18

Update the CI docker container to use clang-18.

Change-Id: Iea0776aaa7edd483fa395e23de25ebf5a6288f71
Signed-off-by: Ed Tanous <ed@tanous.net>
Signed-off-b

build-unit-test-docker: update to clang-18

Update the CI docker container to use clang-18.

Change-Id: Iea0776aaa7edd483fa395e23de25ebf5a6288f71
Signed-off-by: Ed Tanous <ed@tanous.net>
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

UT: disable code coverage support for autotools

Since lcov was removed in the previous commit [1], CI script
execution failed to support autotools projects (such as libmctp):
```
checking for genhtm

UT: disable code coverage support for autotools

Since lcov was removed in the previous commit [1], CI script
execution failed to support autotools projects (such as libmctp):
```
checking for genhtml... no
configure: error: To enable code coverage reporting you must have lcov installed
```

This commit only disables code coverage support for autotools-based
projects.

Refer: https://github.com/openbmc/openbmc-build-scripts/issues/37

[1]: https://gerrit.openbmc.org/c/openbmc/openbmc-build-scripts/+/72544

Signed-off-by: George Liu <liuxiwei@ieisystem.com>
Change-Id: Ib62a5f3092d8c6933f3b9ca00d08dbb38d91ce3a

show more ...

build-unit-test-docker: remove old dependencies

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I433fa21559a54684992eed92fc4ac8b69d66092e

unit-test: Support for valgrind on boost

When UTs, which are run under valgrind, utilize boost coroutines, there
might occur errors during stack switching. Boost has prepared an option
to suppress t

unit-test: Support for valgrind on boost

When UTs, which are run under valgrind, utilize boost coroutines, there
might occur errors during stack switching. Boost has prepared an option
to suppress these errors with build option `valgrind=on`, combined with
compile flag `BOOST_USE_VALGRIND` [1]. This patch implements these
options into boost package and CMake/Meson project configurations.

Tested:
On a change where CI are failing due to valgrind errors [2]. When using
container from this patch, these errors stop appearing and CI ends with
success.

[1] https://www.boost.org/doc/libs/1_82_0/libs/context/doc/html/context/stack/valgrind.html
[2] https://gerrit.openbmc.org/c/openbmc/jsnbd/+/59600/11

Change-Id: I183eaf7c15ac9cc2799f446fe7fb933d957fac21
Signed-off-by: Michal Orzel <michalx.orzel@intel.com>

show more ...

build-unit-test-docker: Replace lcov with gcovr

Resolves openbmc/openbmc-build-scripts#37

Tested: run-unit-test-docker.sh runs correctly and coverage report
generated by gcovr is present

Change-Id

build-unit-test-docker: Replace lcov with gcovr

Resolves openbmc/openbmc-build-scripts#37

Tested: run-unit-test-docker.sh runs correctly and coverage report
generated by gcovr is present

Change-Id: I60134758477cb8f2f5deb94c26eca515d48199f2
Signed-off-by: Ewelina Walkusz <ewelinax.walkusz@intel.com>

show more ...

Robot Framework 7.0 changes for HW CI build script

Changes:
- Update robot package version to 7.0

Tested:
- Tested on sandbox.
- Tested on jenkins setup for HW CI

Change-Id: Ie51df

Robot Framework 7.0 changes for HW CI build script

Changes:
- Update robot package version to 7.0

Tested:
- Tested on sandbox.
- Tested on jenkins setup for HW CI

Change-Id: Ie51df09dc11585c91856eadc2dba05b09e11543c
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://githu

Fix spelling mistakes using codespell

This commit corrects various spelling mistakes throughout the
repository. The corrections were made automatically using `codespell`[1]
tool.

[1]: https://github.com/codespell-project/codespell

Change-Id: Ia6b70713d3e9b77d6fd2d9400489ef7f02360364
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>

show more ...

build-unit-test-docker: ensure we stop on first branch

Ran into an issue where we were creating our root branch (i.e. 1110) and
then creating some snapshot branches (i.e. 1110-snapshot-xyz). The
scr

build-unit-test-docker: ensure we stop on first branch

Ran into an issue where we were creating our root branch (i.e. 1110) and
then creating some snapshot branches (i.e. 1110-snapshot-xyz). The
script would end up using that snapshot branch.

Lots of potential discussion to be had on our branch creations decisions
but either way, best to make sure we match with the exact branch
being passed in.

Tested:
- Confirmed over in ibm-openbmc/openbmc that we pick up expected
branches now.

Change-Id: I71099f42ca40bfd9fe719a550349eba82000133d
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: Add socat

Adding possibility to use socat in the SSH configuration.

Resolves openbmc/openbmc-build-scripts#36

Tested:
run-unit-test-docker.sh runs with EXTRA_DOCKER_RUN_ARG

build-unit-test-docker: Add socat

Adding possibility to use socat in the SSH configuration.

Resolves openbmc/openbmc-build-scripts#36

Tested:
run-unit-test-docker.sh runs with EXTRA_DOCKER_RUN_ARGS=
"-v /home/user/.gitconfig:/home/user/.gitconfig
-v /home/user/.ssh:/home/user/.ssh"

Change-Id: I45e9279c5e3bd3bfc59113bc41ba2abfd7eb1bfa
Signed-off-by: Ewelina Walkusz <ewelinax.walkusz@intel.com>

show more ...

build-unit-test-docker: eslint-plugin-json: pin to v3.1.0

The new v4.0.0 release does not work with an error like this:
```
Error: ESLint configuration in --config » plugin:json/recommended-with-com

build-unit-test-docker: eslint-plugin-json: pin to v3.1.0

The new v4.0.0 release does not work with an error like this:
```
Error: ESLint configuration in --config » plugin:json/recommended-with-comments is invalid:
- Unexpected top-level property "files".
```
Pin eslint-plugin-json to v3.1.0 to solve this.

Change-Id: I773c9c0bda3b87cca92e69089ea37fb20f563ab9
Signed-off-by: Xinnan Xie <xiexinnan@bytedance.com>

show more ...

scripts: unit-test: Make valgrind exit failure on error

By default valgrind exits with the exit status of the process under
examination. From the manual[1]:

> --error-exitcode=<number> [default: 0

scripts: unit-test: Make valgrind exit failure on error

By default valgrind exits with the exit status of the process under
examination. From the manual[1]:

> --error-exitcode=<number> [default: 0]
>
> Specifies an alternative exit code to return if Valgrind reported any
> errors in the run. When set to the default value (zero), the return
> value from Valgrind will always be the return value of the process
> being simulated. When set to a nonzero value, that value is returned
> instead, if Valgrind detects any errors. This is useful for using
> Valgrind as part of an automated test suite, since it makes it easy
> to detect test cases for which Valgrind has reported errors, just
> by inspecting return codes. When set to a nonzero value and Valgrind
> detects no error, the return value of Valgrind will be the return
> value of the program being simulated.

[1]: https://valgrind.org/docs/manual/manual-core.html#manual-core.options

The default value of 0 is not actually useful for CI, where we want it
to bubble up a failure if poor behavior is detected.

Change-Id: I6e7c56b9ccee5c8f9c5234df19ab84009868ff88
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

scripts: unit-test: Constrain test setups to current project

self.package now reflects the top-level meson project name. Using this,
prevent incorrect propagation of configuration into subprojects u

scripts: unit-test: Constrain test setups to current project

self.package now reflects the top-level meson project name. Using this,
prevent incorrect propagation of configuration into subprojects using
the usual meson scope syntax.

Further, now that we're using the scope syntax, meson outputs a
different error message:

```
$ meson test --setup=stdplus:__likely_not_a_setup__ -C build __likely_not_a_test__
Unknown test setup 'stdplus:__likely_not_a_setup__'.
```

Adjust the regex that performs the setup error test.

Change-Id: Ia15c0406323f025fff318cb1c1e4a92605d19c96
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

scripts: unit-test: Replace outdated timeout logic

Back in 2019 William added a new code-path for exploiting a meson
project's 'valgrind' test setup, if one existed[1]:

[1]: https://github.com/open

scripts: unit-test: Replace outdated timeout logic

Back in 2019 William added a new code-path for exploiting a meson
project's 'valgrind' test setup, if one existed[1]:

[1]: https://github.com/openbmc/openbmc-build-scripts/commit/49d4e594e8959cd8764

At the time, the behavior of `meson test -t 0 ...` was to immediately
terminate. This was useful in the context of testing whether a project
provided the a particular test setup, as we could invoke `meson test -t
0 --setup=<name>` without any significant impact on CI execution time.

However, as of meson 0.57.0 the behavior of `meson test -t 0`
changed[2]:

> test() timeout and timeout_multiplier value <= 0
>
> test(..., timeout: 0), or negative value, used to abort the test
> immediately but now instead allow infinite duration. Note that
> omitting the timeout keyword argument still defaults to 30s timeout.
>
> Likewise, add_test_setup(..., timeout_multiplier: 0), or meson test
> --timeout-multiplier 0, or negative value, disable tests timeout.

[2]: https://mesonbuild.com/Release-notes-for-0-57-0.html#test-timeout-and-timeout_multiplier-value-0

The consequence of the change is that the test for the existence of the
named setup in the project now executes the test suite with timeouts
disabled when the named setup is provided by the project at hand.

Further, having established that the named setup is supported by the
project, the script then executes the test suite _again_[^1].

A useful observation at this point is the the output from the following
set of commands, using stdplus[3] as an example:

```
$ meson test --setup=__likely_not_a_setup__ -C build __likely_not_a_test__
Test setup '__likely_not_a_setup__' not found from project 'stdplus'.
$ meson test --setup=valgrind -C build __likely_not_a_test__
ERROR: *:__likely_not_a_test__ test name does not match any test
```

[3]: https://github.com/openbmc/stdplus

Using an unlikely test name we make it likely that we error out in the
case where the named test setup is supported by the project. We use this
as a substitute for the old behavior of `-t 0`.

[^1]: Though at least it sets a timeout multiplier of 10, rather than
disabling the timeout.

Tested: Ran the CI container against:

- entity-manager, which does not define a 'valgrind' test setup
- stdplus, which does define a 'valgrind' test setup

Verified that `meson test` was invoked with `--wrapper valgrind` for
entity-manager, and `--setup valgrind` for stdplus.

Change-Id: I78090716dd2842e6f4485a69f353d15ca11b62d1
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

scripts: unit-test: Derive package name from meson.build

The implementation for package name derivation implemented in
BuildSystem.__init__() simply takes the basename of the directory
containing th

scripts: unit-test: Derive package name from meson.build

The implementation for package name derivation implemented in
BuildSystem.__init__() simply takes the basename of the directory
containing the source code if another name isn't supplied.

For meson builds we can make a smarter choice, and the result is that
we can lift the requirement that the directory be named after the
project. This is helpful for some workflows where the CI container is
run locally.

By introspecting the build configuration we can extract the meson
project name. Defining the package name as the project name is useful
for meson command invocations. For example, the project name can be used
to specify constraints on build variables (`-D<project>:werror=false`)
and test setups (`--setup=<project>:valgrind`), preventing configuration
from incorrectly propagating into other (sub)projects.

Override the package name once the build configuration is available.

Change-Id: I52dc03253a54589cba0ff2fae5ddba2a74d458ba
Signed-off-by: Andrew Jeffery <andrew@codeconstruct.com.au>

show more ...

Capture stderr from docker build

BuildKit sends build messages to stderr and python `sh` does nothing
with it. Redirect stderr to our custom printer function to put
everything in the same stream.

C

Capture stderr from docker build

BuildKit sends build messages to stderr and python `sh` does nothing
with it. Redirect stderr to our custom printer function to put
everything in the same stream.

Change-Id: Id862154be7ef845a758c5f2248f47a8c6d4de7e2
Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>

show more ...

Update nghttp2 1.57->1.61

Change-Id: I8491dd58fb4f197c127624119a67ee0814363935
Signed-off-by: Ed Tanous <ed@tanous.net>

build-unit-test-docker:eslint: pin to v8.56.0

The new v9.0 release change the API and our existing use of it no longer
works with an error like this:

```
Invalid option '--eslintrc' - perhaps you m

build-unit-test-docker:eslint: pin to v8.56.0

The new v9.0 release change the API and our existing use of it no longer
works with an error like this:

```
Invalid option '--eslintrc' - perhaps you meant '--ignore'?
```

Until we have some time to sort this out, move us back to the previous
release.

Change-Id: Ieed62b82bb3870c22bb377f562fb75b148395cee
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

build-unit-test-docker: Protobuf versions should match

The python protobuf version should match the compiler and library
version, or else we will run into API issues.

Change-Id: Iba9472123734cb1015

build-unit-test-docker: Protobuf versions should match

The python protobuf version should match the compiler and library
version, or else we will run into API issues.

Change-Id: Iba9472123734cb1015c0d2f0dc72bd18be660355
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Remove valgrind-dbgsym

This package doesn't seem to exist anymore and results in

```base: E: Unable to locate package valgrind-dbgsym```

when trying to build.

From the ubuntu maintainers, this do

Remove valgrind-dbgsym

This package doesn't seem to exist anymore and results in

```base: E: Unable to locate package valgrind-dbgsym```

when trying to build.

From the ubuntu maintainers, this doesn't seem necessary anymore

```
If you are on Ubuntu Jammy (22.04) or later, you do not need to
worry about installing debug symbol packages anymore. The
Ubuntu project maintains a Debuginfod server, and GDB and other
debuginfo-consumer applications support it out of the box. For
more information about it, please refer to this page.

If you are on Ubuntu Noble (24.04) or later, Debuginfod is the
preferred method as the following information is outdated and, due
to a new format for the sources.list entries being moved to the
deb822 format.

https://wiki.ubuntu.com/Debug%20Symbol%20Packages#Debuginfod
```

Change-Id: Ib7d221763b30d433c19cfad7fe3b8462ffcb7383
Signed-off-by: Ed Tanous <ed@tanous.net>
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Adding libdbus-glib-1-2 install to fix Firefox installation issue

Installing libdbus-glib-1-2 facilitates a smooth and functional
Firefox experience on Linux systems. With this change robot
GUI test

Adding libdbus-glib-1-2 install to fix Firefox installation issue

Installing libdbus-glib-1-2 facilitates a smooth and functional
Firefox experience on Linux systems. With this change robot
GUI test cases would again start working fine.

Change-Id: I808a54d75e3b6b92f284920ba2cf5fad648dee22
Signed-off-by: Rahul Maheshwari <rahulmaheshwari@in.ibm.com>

show more ...