unit-test.py: capture and forward failure

A failure in the make will be caught and dropped as far as
the CI is concerned. This will pass that failure onto the CI.

Change-Id: I9b36c3128176261344cb0

unit-test.py: capture and forward failure

A failure in the make will be caught and dropped as far as
the CI is concerned. This will pass that failure onto the CI.

Change-Id: I9b36c3128176261344cb0e4e8827de174a482170
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

Set artful as default Ubuntu for robot/qemu

While setting up a new system for CI, it was found that ubuntu:latest
now points to 18.04. There are issues with pip and ubuntu 18.04. There
are some work

Set artful as default Ubuntu for robot/qemu

While setting up a new system for CI, it was found that ubuntu:latest
now points to 18.04. There are issues with pip and ubuntu 18.04. There
are some workarounds but lets wait for the bugs to settle before doing
too much work here.

Here are some references on this issue:
https://github.com/pypa/pipenv/issues/2122
https://bugs.launchpad.net/ubuntu/+source/python-pip/+bug/1772746

Testing: Verified this now builds correctly on old and new systems

Change-Id: Ifed8b460f3df14aec7ba8f566291af87803c1e26
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

scripts/format-code.sh: Immediately exit on bad exit status

Shell scripts exit with the exit status of the last command if `set -e`
is not in use. Adding code to the end of the script to support the

scripts/format-code.sh: Immediately exit on bad exit status

Shell scripts exit with the exit status of the last command if `set -e`
is not in use. Adding code to the end of the script to support the local
format-code.sh meant that `git --no-pager diff --exit-code` was not
necessarily the last command to be executed by the script, and therefore
the script's exit code did not necessarily reflect the presence of badly
formatted code.

Fixes openbmc/openbmc#3125

Change-Id: Icefad5b81b420c364022075face7c4027d8af4e6
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

scripts/unit-test.py: Test alternative paths to test-suite.log

Change-Id: I75b046af8e4c287f6e96e5926e728f2307c53852
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

build-qemu-robot-docker.sh: Install potential qemu dependencies

On my Ubuntu Artful system, qemu-system-arm is built to link against the
following shared libraries:

$ ldd ./tmp/sysroots-components/

build-qemu-robot-docker.sh: Install potential qemu dependencies

On my Ubuntu Artful system, qemu-system-arm is built to link against the
following shared libraries:

$ ldd ./tmp/sysroots-components/x86_64/qemu-native/usr/bin/qemu-system-arm
linux-vdso.so.1 => (0x00007ffdfa1c1000)
libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007fcddcb89000)
libpixman-1.so.0 => /usr/lib/x86_64-linux-gnu/libpixman-1.so.0 (0x00007fcddc8e3000)
libutil.so.1 => /lib/x86_64-linux-gnu/libutil.so.1 (0x00007fcddc6df000)
libasound.so.2 => /usr/lib/x86_64-linux-gnu/libasound.so.2 (0x00007fcddc3d7000)
libfdt.so.1 => /usr/lib/x86_64-linux-gnu/libfdt.so.1 (0x00007fcddc1cf000)
libglib-2.0.so.0 => /lib/x86_64-linux-gnu/libglib-2.0.so.0 (0x00007fcddbebb000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fcddbcb3000)
libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fcddb92d000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fcddb5d7000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fcddb3c0000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fcddb1a1000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fcddadc1000)
/lib64/ld-linux-x86-64.so.2 (0x00007fcddde5a000)
libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fcddabbd000)
libpcre.so.3 => /lib/x86_64-linux-gnu/libpcre.so.3 (0x00007fcdda94b000)

Launching the binary in the container failed due to missing shared
libaries, so lets include them. We were missing at least libasound2 and
libfdt1, and I threw in libpcre3 to be explicit about the dependency.

Change-Id: I1ba31cba090099184dd1e13a0fa54f3de8637518
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

scripts/unit-test.py: Add ibm-dbus-interfaces

Add ibm-dbus-interfaces as a PKG_CHECK_MODULES
dependency.

Change-Id: Icfd5c3045f6b8b6895bdd4b968f92517eeab2875
Signed-off-by: Matt Spinler <spinler@us

scripts/unit-test.py: Add ibm-dbus-interfaces

Add ibm-dbus-interfaces as a PKG_CHECK_MODULES
dependency.

Change-Id: Icfd5c3045f6b8b6895bdd4b968f92517eeab2875
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

format-code.sh: Allow some flexibility when formatting

clang-format doesn't allow us to differentiate between C and C++ styles,
they are both lumped under the 'Language: Cpp' directive.

This doesn'

format-code.sh: Allow some flexibility when formatting

clang-format doesn't allow us to differentiate between C and C++ styles,
they are both lumped under the 'Language: Cpp' directive.

This doesn't work when you have different styles for each language, for
example in the phosphor-mboxd repository (C in kernel style, C++ in
OpenBMC style, due to history).

phosphor-mboxd ships its own format-code.sh script which deals with its
specific requirements, so lets execute that.

Change-Id: I2bb4a5ffd940dcaac95481c2baf23823dba005ee
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

Added sshpass to docker image

The sshpass command is needed for programs that wish to ssh from a shell
command line. When running from a program, it is undesirable to be
prompted for a password.

C

Added sshpass to docker image

The sshpass command is needed for programs that wish to ssh from a shell
command line. When running from a program, it is undesirable to be
prompted for a password.

Change-Id: Ibb303576e717b1989f5d58b6e2b7cf8d13655c7c
Signed-off-by: Michael Walsh <micwalsh@us.ibm.com>

show more ...

Enable robot tests against QEMU

Change-Id: I38389b4ceb7ca8facf3c93345af0fa76c45a8b55
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

Add pysnmp module to build-qemu-robot-docker.sh

Need this package and other packages listed in
build-qemu-robot-docker.sh to run a script which
power cycle's a system via PDU's SNMP interface.

Chan

Add pysnmp module to build-qemu-robot-docker.sh

Need this package and other packages listed in
build-qemu-robot-docker.sh to run a script which
power cycle's a system via PDU's SNMP interface.

Change-Id: If34ec35065ab988f68c2bbe1fd9b531edc083005
Signed-off-by: Sunil M <sunilmam@us.ibm.com>

show more ...

scripts/unit-test.py: Add ability to run `make check` N times

This is useful for catching intermittent failures in test suites when
doing manual (non-CI) runs.

Tested: Reworked run-unit-test-docker

scripts/unit-test.py: Add ability to run `make check` N times

This is useful for catching intermittent failures in test suites when
doing manual (non-CI) runs.

Tested: Reworked run-unit-test-docker.sh, ran and observed multiple runs
of `make check`.

Change-Id: Idf4d81a27b59cc377b2fdc0a672490befbdc4816
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

scripts/unit-test.py: Dump the test log if tests fail

Also clean up the redundant handling of the make invocation. If we want
to control make's behaviour, set MAKEFLAGS when calling the script.

Tes

scripts/unit-test.py: Dump the test log if tests fail

Also clean up the redundant handling of the make invocation. If we want
to control make's behaviour, set MAKEFLAGS when calling the script.

Tested: Ran run-unit-test-docker.sh, confirmed log dump on test failure

Change-Id: Ibbc58a2ccfbe92c2e80db82a9ed91a61c7496131
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

scripts/unit-test.py: Don't build repositories already present

The previous change enhances the docker build script to bake some
heavily-used repositories straight into the docker image as a way to

scripts/unit-test.py: Don't build repositories already present

The previous change enhances the docker build script to bake some
heavily-used repositories straight into the docker image as a way to
save time.

We use a file at the magic path /root/.depcache to hold a
comma-separated list of of $PACKAGE:$COMMIT_ID pairs, where $COMMIT_ID
represents the commit at the tip of the master branch of the associated
$PACKAGE (from https://github.com/openbmc/) built into the Docker image.

We can skip building any package listed in /root/.depcache as it's
already present, so don't add it to the dependency graph.

Tested: Ran run-unit-test-docker.sh, confirmed no unnecessary building
of packages.

Change-Id: If59a2813b8e7331b1706e4c09ee7080d72b95e3c
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

scripts/unit-test.py: Rework handling of directories in clone_pkg()

This makes things a bit neater and accounts for directories that might
already exist as a result of the docker build process.

Tes

scripts/unit-test.py: Rework handling of directories in clone_pkg()

This makes things a bit neater and accounts for directories that might
already exist as a result of the docker build process.

Tested: Ran run-unit-test-docker.sh, confirmed expected functionality

Change-Id: Ieebd63da0383e4431ae9cdf972e8905aff96f175
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>

show more ...

Add port 2200 and 623/664 to export list for QEMU

OpenBMC test automation requires the host SOL port (2200)
and IPMI port (623,664) be available

Change-Id: I2bf42aa1a60493d7d9bb33cb96076894020fd226

Add port 2200 and 623/664 to export list for QEMU

OpenBMC test automation requires the host SOL port (2200)
and IPMI port (623,664) be available

Change-Id: I2bf42aa1a60493d7d9bb33cb96076894020fd226
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Exit without error in CI if not Automake

Now that CI supports C++ and python format validation,
need to allow repos that aren't built using Automake
to still be able to run through CI so that they c

Exit without error in CI if not Automake

Now that CI supports C++ and python format validation,
need to allow repos that aren't built using Automake
to still be able to run through CI so that they can
do the code style format checking.

Resolves openbmc/openbmc#2856

Change-Id: I84cd23969115ec36829a5ee5ec00cbfa4622cd0c
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Launch appropriate QEMU based on input image

The openbmc servers will use the new QEMU binary and
require different parameters then the default QEMU
image.

This commit gets the end to end function

Launch appropriate QEMU based on input image

The openbmc servers will use the new QEMU binary and
require different parameters then the default QEMU
image.

This commit gets the end to end function of being able
to run the qemu regression against systems like witherspoon,
romulus, and palmetto while also keeping the legacy support
in.

Resolves openbmc/openbmc#2272

Change-Id: I2bcd10752e5e20fe0546e674335cff46618b2d82
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Look for the correct image to boot from dynamically

openbmc supports three different types of image to boot from
- UBI based image
- static MTD image
- rootfs.ext image

This commit enables boot-qem

Look for the correct image to boot from dynamically

openbmc supports three different types of image to boot from
- UBI based image
- static MTD image
- rootfs.ext image

This commit enables boot-qemu.sh to dynamically discover the
appropriate one and use it.

Change-Id: I52d834f118d1e731740e9e3a1573cc6668f5cef0
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Allow a different qemu-system-arm to be passed to test scripts

The default qemu-system-arm used within the test automation pipeline
is currently hard coded to use the one within the bitbake image
un

Allow a different qemu-system-arm to be passed to test scripts

The default qemu-system-arm used within the test automation pipeline
is currently hard coded to use the one within the bitbake image
under test. This commit allows more flexibility with the qemu tool
used.

Future commits will build upon this to allow using a
qemu-system-arm version which supports witherspoon and therefore
will enable regression testing of the witherspoon and other openbmc
platforms within QEMU.

There's a long term goal to ensure the bitbake image builds the
appropriate qemu-system-arm into itself but there are some complexities
with that.

Change-Id: I93d39bf8482acb8adbc2b1da2d805448af2bcf75
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

format-code.sh: Add pycodestyle (pep8) check

Check pycodestyle (former pep8) and exit if there are any
errors.

Also move the checking of the formatting files to the
format-code.sh file.

Change-Id:

format-code.sh: Add pycodestyle (pep8) check

Check pycodestyle (former pep8) and exit if there are any
errors.

Also move the checking of the formatting files to the
format-code.sh file.

Change-Id: Idca20d145e36a471634666aa39c968d3542886d8
Signed-off-by: Adriana Kobylak <anoo@us.ibm.com>

show more ...

Validate code formatting when CI job runs

This will execute the format-code.sh script from
within the docker container that runs the per repo
CI job

Change-Id: I50321ddad1d664fcae0f168ba973ab23cf3c

Validate code formatting when CI job runs

This will execute the format-code.sh script from
within the docker container that runs the per repo
CI job

Change-Id: I50321ddad1d664fcae0f168ba973ab23cf3c6f32
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Simple bash script to validate no code format violation

Originally written by Ed Tanous in sdbusplus repo

Change-Id: Ifca9862472d0c2d813e54af6dceddc3de244e5a3
Signed-off-by: Andrew Geissler <geisso

Simple bash script to validate no code format violation

Originally written by Ed Tanous in sdbusplus repo

Change-Id: Ifca9862472d0c2d813e54af6dceddc3de244e5a3
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I75e60

Spelling fixes

Spelling errors found using github.com/lucasdemarchi/codespell
A tool to fix common misspellings.
This tool is licensed under GNU General Public License, version 2.

Change-Id: I75e60b1ccb683cb34118bfffc327ec7fc8573e06
Signed-off-by: Gunnar Mills <gmills@us.ibm.com>

show more ...

Updated from deprecated -redir

The option -redir was deprecated, and no longer works with the QEMU
command. Updating it to use the -netdev user option that then specifies
the updated hostfwd specifi

Updated from deprecated -redir

The option -redir was deprecated, and no longer works with the QEMU
command. Updating it to use the -netdev user option that then specifies
the updated hostfwd specification. When run in a container the IP that
is specified will be pulled from the /etc/hosts file. If the IP that is
pulled from there is invalid then localhost (127.0.0.1) will be used
instead.

Change-Id: I582a66422e3de38dd9613cc443ac52aa1420f76d
Signed-off-by: Alanny Lopez <alanny.lopez@ibm.com>

show more ...

Updated QEMU run command and header

QEMU was not launching before, the changes in this commit have allowed
for the QEMU container to launch and allow user login. Also updated the
header to be more d

Updated QEMU run command and header

QEMU was not launching before, the changes in this commit have allowed
for the QEMU container to launch and allow user login. Also updated the
header to be more descriptive.

Change-Id: I5f419d29c8135ff70110c0295a5a8734891c14af
Signed-off-by: Alanny Lopez <alanny.lopez@ibm.com>

show more ...