Fix format-code clang-format regex

Only format code that belongs to repo.

Tested: Found bad formatted cpp files.
And it handles the files that has spaces in the file name.
Verified

Fix format-code clang-format regex

Only format code that belongs to repo.

Tested: Found bad formatted cpp files.
And it handles the files that has spaces in the file name.
Verified ignoring directories and filenames works.

Change-Id: I8d027a6140bf5708ba1e8f8f1c185e5db05f081a
Signed-off-by: James Feist <james.feist@linux.intel.com>
Signed-off-by: Lei YU <mine260309@gmail.com>

show more ...

meson: debug output on unit test failures

Ensure the testlog.txt file is output to the console if any unit tests
fail. This will help with debug of CI failures in jenkins where only the
console log

meson: debug output on unit test failures

Ensure the testlog.txt file is output to the console if any unit tests
fail. This will help with debug of CI failures in jenkins where only the
console log is available.

Testing: Verified file is output to console on a failure

Change-Id: I4978d676c744c8cd52ff89d316ba7b7fb15674cd
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Add --noformat option for unit test

The run-unit-test-docker.sh and unit-test.py will run format-code.sh to
check the code format, and break when the code is not formatted
correctly.

For local-ci,

Add --noformat option for unit test

The run-unit-test-docker.sh and unit-test.py will run format-code.sh to
check the code format, and break when the code is not formatted
correctly.

For local-ci, this is unecessary because the code not "git add" or not
committed is treated as not-formatted and will break.

Adding NO_FORMAT_CODE option to make the unit test skip formatting the
code, so that one could write code in local repo, run the local-ci
without having to git add ro commit the changes.

Tested: Run run-unit-test-docker.sh as before, verify the format-code.sh
is invoked;
Run 'NO_FORMAT_CODE=1 run-unit-test-docker.sh', verify the
format-code.sh is not invoked.

Signed-off-by: Lei YU <mine260309@gmail.com>
Change-Id: Ib3b6cf34390c91d551bc14613e925b8e51a3065f

show more ...

unit-test: Run repo specific CI scripts

Allow repositories to have custom CI tests that aren't based on C++ unit
tests by finding and running any 'run-ci.sh' scripts found in the
repository. A nonz

unit-test: Run repo specific CI scripts

Allow repositories to have custom CI tests that aren't based on C++ unit
tests by finding and running any 'run-ci.sh' scripts found in the
repository. A nonzero exit status will fail the test.

The script will be run with the 'sh' command with the base directory of
the repository as the current working directory.

Change-Id: I87db4d34b6e1db9472c9b97241ce771eeab3fa7c
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

meson: Upgdate 0.50.1 -> 0.52.0

Our bitbake tree already has this version, bump our script version to
match.

The way scan-build is detected has changed. We no longer need to pass
our custom version

meson: Upgdate 0.50.1 -> 0.52.0

Our bitbake tree already has this version, bump our script version to
match.

The way scan-build is detected has changed. We no longer need to pass
our custom version of scan-build since it will now be autodetected at
the highest version correctly.

Change-Id: I248875292a385ae05d27f50e2de2e14c0e848aff
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

Add pip3 install redfish_utilities for DMTF Redfish-Usecase-Checkers

Reference https://github.com/DMTF/Redfish-Usecase-Checkers#prerequisites

Change-Id: I913bfd77c00e6c539d6909f7e31d057f3db1fc08
Si

Add pip3 install redfish_utilities for DMTF Redfish-Usecase-Checkers

Reference https://github.com/DMTF/Redfish-Usecase-Checkers#prerequisites

Change-Id: I913bfd77c00e6c539d6909f7e31d057f3db1fc08
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Correct websocket install

The websocket-client package is the correct python package needed for
the robot framework websocket tests.

Change-Id: I7cd4ce70ada67e92bdc5ad8fc7edbfbc2ac11319
Signed-off-

Correct websocket install

The websocket-client package is the correct python package needed for
the robot framework websocket tests.

Change-Id: I7cd4ce70ada67e92bdc5ad8fc7edbfbc2ac11319
Signed-off-by: Matthew Barth <msbarth@us.ibm.com>

show more ...

Add websocket to pip3 install

Required for automated websocket test, which uses Python and Robot
Framework.

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: I3eae6443943f11af8e2c78d4751

Add websocket to pip3 install

Required for automated websocket test, which uses Python and Robot
Framework.

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: I3eae6443943f11af8e2c78d4751fefa087ec87ea

show more ...

Add retrying to pip3 install

To enable Python usage of "from retrying import retry" for network
connectivity retries. Utilized in websocket test.

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
C

Add retrying to pip3 install

To enable Python usage of "from retrying import retry" for network
connectivity retries. Utilized in websocket test.

Signed-off-by: Michael Shepos <shepos@us.ibm.com>
Change-Id: Ic64bee439b1f07103960ab9bda66e7383ba227ea

show more ...

unit-test: clang tools 6.0 -> 8

Change-Id: I80be4738f012423e94686e0442055e54fd84a807
Signed-off-by: William A. Kennington III <wak@google.com>

docker: Update QEMU/Robot docker to bionic

Artful has gone end of release and will no longer build in docker due to
this. Update to the LTS.
easy_install was deprecated in bionic so use pip3 for all

docker: Update QEMU/Robot docker to bionic

Artful has gone end of release and will no longer build in docker due to
this. Update to the LTS.
easy_install was deprecated in bionic so use pip3 for all package
installations now.
The latest robot uses python3 so adjust our call to use that.
ipmitool in bionic is at 1.8.18 and I verified it works against our
latest master code on witherspoon so just apt-get that package.

Testing:
Ran through run-qemu-robot-test.sh and verified it passed. Did get some
warnings the test team will need to look into but everything still
passed:

Error in file '/tmp/root/11554/obmc-robot/tests/ipmi/test_fru.robot': Escaping empty cells with '\' before line continuation marker '...' is deprecated. Remove escaping before Robot Framework 3.2.

Change-Id: I16268b4042c31ca71cf6db9f37c85f66f65d4606
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

scripts/unit-test: Add new valgrind checks

These cause spurious failures on powerpc systems currently, so we should
skip valgrind if they don't work in the trivial expected working case.

==5266== C

scripts/unit-test: Add new valgrind checks

These cause spurious failures on powerpc systems currently, so we should
skip valgrind if they don't work in the trivial expected working case.

==5266== Conditional jump or move depends on uninitialised value(s)^M
==5266== at 0x4E92764: __dcigettext (dcigettext.c:697)^M
==5266== by 0x4E900E7: dcgettext (dcgettext.c:47)^M
==5266== by 0x4F08AC7: strerror_r (_strerror.c:71)

Change-Id: Ib94c19688b446bc9cf780571260d5f6c922e6fb8
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

unit-test.py: Remove objmgr workaround

As was done in build-unit-test-docker.sh, this commit removes
a phosphor-objmgr workaround that was needed due to a systemd
dependency that doesn't exist anymo

unit-test.py: Remove objmgr workaround

As was done in build-unit-test-docker.sh, this commit removes
a phosphor-objmgr workaround that was needed due to a systemd
dependency that doesn't exist anymore.

Tested: Ran run-unit-test-docker.sh.

Change-Id: Ica85023330a4e102f0ecc7e8b7b1c8bb411fb1e8
Signed-off-by: Matt Spinler <spinler@us.ibm.com>

show more ...

DMTF Usecase checker tool requirement package

Refer https://github.com/DMTF/Redfish-Usecase-Checkers#prerequisites

Change-Id: I9851e918a0ac35dc3a1ae4dd44c021cc84a4fedf
Signed-off-by: George Keishin

DMTF Usecase checker tool requirement package

Refer https://github.com/DMTF/Redfish-Usecase-Checkers#prerequisites

Change-Id: I9851e918a0ac35dc3a1ae4dd44c021cc84a4fedf
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

unit-test: meson: allow missing meson-options.txt

meson-options.txt is not required, so avoid an ENOENT exception and
proceed with an empty set of options when meson-options.txt doesn't
exist.

Test

unit-test: meson: allow missing meson-options.txt

meson-options.txt is not required, so avoid an ENOENT exception and
proceed with an empty set of options when meson-options.txt doesn't
exist.

Tested: Sucessfully ran run-unit-test-docker.sh against
https://gerrit.openbmc-project.xyz/c/openbmc/obmc-ikvm/+/19893/1

Change-Id: Ie063df12aa511f43f347db277858075bcecad024
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

scripts/unit-test: Add stdplus

stdplus was added to the unit test docker but our unit-test script
should know how to recognize it even if it isn't in the caches.

Change-Id: I62dc94eb393d9749a1b51e8

scripts/unit-test: Add stdplus

stdplus was added to the unit test docker but our unit-test script
should know how to recognize it even if it isn't in the caches.

Change-Id: I62dc94eb393d9749a1b51e80354a64fadbbc3393
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

unit-test: add ipmiblob library lookup

To resolve this library dependency, add a lookup given the expected
pkg-config.

Change-Id: Icb235bdb33742e4ee3f9f80eae26799b2f56f998
Signed-off-by: Patrick Ve

unit-test: add ipmiblob library lookup

To resolve this library dependency, add a lookup given the expected
pkg-config.

Change-Id: Icb235bdb33742e4ee3f9f80eae26799b2f56f998
Signed-off-by: Patrick Venture <venture@google.com>

show more ...

DMTF Redfish-JsonSchema-ResponseValidator package install

Changes:
- Refer: https://github.com/DMTF/Redfish-JsonSchema-ResponseValidator
pip3 install jsonschema

Change-Id: If859c532a97f1e37

DMTF Redfish-JsonSchema-ResponseValidator package install

Changes:
- Refer: https://github.com/DMTF/Redfish-JsonSchema-ResponseValidator
pip3 install jsonschema

Change-Id: If859c532a97f1e375a1a5e5a04ad11839bc692cb
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

Python3.x bs4 package for redfish validator via pip3

Change-Id: I15fa62b060378b71be9c74e3fc0899ef59a33712
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

Package installation required for DTMF Redfish-Service-Validator

Refer: https://github.com/DMTF/Redfish-Service-Validator/blob/master/requirements.txt

Change-Id: Id390becccc20dc44c0a8224dd494477868

Package installation required for DTMF Redfish-Service-Validator

Refer: https://github.com/DMTF/Redfish-Service-Validator/blob/master/requirements.txt

Change-Id: Id390becccc20dc44c0a8224dd49447786863d369
Signed-off-by: George Keishing <gkeishin@in.ibm.com>

show more ...

scripts/unit-test: Make skipped steps more verbose

We want it to be obvious we are skipping validation steps when a
platform doesn't have support for it.

Change-Id: I2bf3fe7517a8f6e088b5ce0efc3ffbd

scripts/unit-test: Make skipped steps more verbose

We want it to be obvious we are skipping validation steps when a
platform doesn't have support for it.

Change-Id: I2bf3fe7517a8f6e088b5ce0efc3ffbd7f790bb0e
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

scripts/unit-test: Detect problematic sanitizers

Instead of permanently blacklisting sanitizers from running in our unit
test environment for all powerpc platforms, run a problematic test case
to de

scripts/unit-test: Detect problematic sanitizers

Instead of permanently blacklisting sanitizers from running in our unit
test environment for all powerpc platforms, run a problematic test case
to determine if we can use the sanitizers or not.

Tested:
Ran on amd64 and ppc64el to verify that sanitizers are still run on
the currently working amd64 and not on the currently broken ppc64el.

Change-Id: If26e8a3b8d88c579556d30508b69a11d08ed5b5c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

scripts/unit-test: Detect problematic valgrind

Instead of permanently blacklisting valgrind from running in our unit
test environment for all powerpc platforms, run a problematic test case
to determ

scripts/unit-test: Detect problematic valgrind

Instead of permanently blacklisting valgrind from running in our unit
test environment for all powerpc platforms, run a problematic test case
to determine if we can use valgrind or not.

Tested:
Ran on amd64 and ppc64el to verify that valgrind is still run on the
currently working amd64 and not on the currently broken ppc64el.

Change-Id: Ie028a5cc9ec9138c78a87f58c70af274adca2c95
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

scripts/unit-test: meson: Support custom valgrind setup

This makes it possible for the build to specify custom wrapper
parameters and timeout values using the
add_test_setup('valgrind', ...) infrast

scripts/unit-test: meson: Support custom valgrind setup

This makes it possible for the build to specify custom wrapper
parameters and timeout values using the
add_test_setup('valgrind', ...) infrastructure in meson.

Tested:
Using the meson enabled sdeventplus build and manually added special
parameters for the test suite.

Change-Id: I25df040463433cf2d91b416eaaa159cef9ba8235
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

scripts/unit-test: Rename maybe_run* to maybe_make*

This will be nice to distinguish between a make execution and the
possible execution of valgrind enabled tests under meson.

Change-Id: Ice35abdcf

scripts/unit-test: Rename maybe_run* to maybe_make*

This will be nice to distinguish between a make execution and the
possible execution of valgrind enabled tests under meson.

Change-Id: Ice35abdcf95bc96d4adb50e3a996688e57619f5a
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...