unit-test.py: Add phosphor-ipmi-blobs to PKG_CHECK_MODULES

With a pkgconfig file added to the phosphor-ipmi-blobs package, the
entry is added to PKG_CHECK_MODULES in the unit-test.py script so
that

unit-test.py: Add phosphor-ipmi-blobs to PKG_CHECK_MODULES

With a pkgconfig file added to the phosphor-ipmi-blobs package, the
entry is added to PKG_CHECK_MODULES in the unit-test.py script so
that Meson builds using the phosphor-ipmi-blobs package can find
phosphor-ipmi-blobs and pass.

Tested by running CI with a library that has phosphor-ipmi-blobs as
dependency.

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: I27be450bb5cb4075ede2102b08fc93ec68cf29e9

show more ...

run-robot: do not exit script on error

This script is running the robot test framework. Errors are expected
from the ROBOT_TEST_CMD at times when it finds regressions. Need to
ensure the script keep

run-robot: do not exit script on error

This script is running the robot test framework. Errors are expected
from the ROBOT_TEST_CMD at times when it finds regressions. Need to
ensure the script keeps running after that so it copies the needed log
files out of the docker container to the persistent directory.

Tested:
Verified that when robot tests fail we now get the test results and FFDC
in the jenkins job running it

Change-Id: Ieb87aba59402734837efb597aafd6dee434ce370
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

run-robot.sh: correct invalid variable execution

Commit 384d741 attempted to clean up some issues reported by shellcheck
and ended up causing this script to fail execution. The previous
variable ex

run-robot.sh: correct invalid variable execution

Commit 384d741 attempted to clean up some issues reported by shellcheck
and ended up causing this script to fail execution. The previous
variable expansion was non-obvious and warned by shellcheck. Replaced
with an 'eval' call which seems to behave correctly and not be warned.

Tested:

Confirmed correct execution and error codes from the below executions.

```
ROBOT_TEST_CMD="echo this should pass && echo this also" \
./scripts/run-reboot.sh
ROBOT_TEST_CMD="echo this should pass && echo this also && false" \
./scripts/run-robot.sh
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic4cb55c929511353d3e055d5238c0bcd520a4641

show more ...

shellcheck: clean up shellcheck warnings and enable

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ibc843b98c0fea97a31d3d15b556a32f091bf8e47

Fix clang-tidy support in CI for meson builds

- As clang and gcc flags have diverged over the years, clang-tidy
requires clang flags to be present in compile-commands.json
which can be generated

Fix clang-tidy support in CI for meson builds

- As clang and gcc flags have diverged over the years, clang-tidy
requires clang flags to be present in compile-commands.json
which can be generated via a meson build with clang compiler.

- In the current state, the build directory is already created with
gcc, so for a repo with .clang-tidy file, we get a lot of errors
about unknown warning flags[clang-diagnostic-unknown-warning-option]

- This commit would change the compiler to clang++, and would create
another build directory for clang builds, and use that configuration
for clang-tidy.

- This would not harm later builds in the CI sequnce, as they are doing
a meson configure[in build directory] which would not change the
compiler.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I8de5a53229bef1dd9b774597d09d39e34e168cdb

show more ...

Include update alternatives for clang

Also, clean up some of the possible errors in the tidy process to make
sure that things like CD are cleaned up properly.

Tested:
I wish I knew why my docker en

Include update alternatives for clang

Also, clean up some of the possible errors in the tidy process to make
sure that things like CD are cleaned up properly.

Tested:
I wish I knew why my docker environment seems to be different than when
jenkins runs it, but alas, this continues to pass on my machine when I
run it against a bmcweb tree with a clang-tidy file in it.

Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: Ic88fd9ef3227b21c0d60d2c2d68d21ef15e3bd40

show more ...

Run clang-tidy builds on clang

As-is, clang-tidy uses the default compile-commands.json from the gcc
build. Unfortunately, gcc implements different flags than clang these
days, and clang-tidy requi

Run clang-tidy builds on clang

As-is, clang-tidy uses the default compile-commands.json from the gcc
build. Unfortunately, gcc implements different flags than clang these
days, and clang-tidy requires the clang flags. Because of that, we need
to use a clang-specific compile-commands.json.

This commit adds a new build dir named tidy-build, and runs the cmake
configure task in it against the clang compilers.

Note, the hope is that this change allows something like this:
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/36888

To succeed in CI.

Having this build run correctly will help me as a maintainer. I'm
guessing that clang-tidy will correctly flag 50% of the common mistakes
people make in bmcweb. I intend to get this running on entity-manager
and dbus-sensors repos as well.

Tested:
Ran ./openbmc-build-scripts/run-unit-test-docker.sh against this
patchset: https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/36888

... and observed clang-tidy run correctly. clang-tidy did not pass
because of actual found issues (most of which are in review to be
fixed), but correctly ran clang-tidy, and identified a bunch of issues,
which is glorious.

Signed-off-by: Ed Tanous <ed@tanous.net>
Change-Id: I0f0754f2026e1cf2ae9ca7df868f9022d6585c32

show more ...

unit-test: Use project defined b_lundef

The unit-test.py was setting b_lundef=false for address santinizer, and
setting b_lundef=true afterwards.

For a project generating shared library that invoke

unit-test: Use project defined b_lundef

The unit-test.py was setting b_lundef=false for address santinizer, and
setting b_lundef=true afterwards.

For a project generating shared library that invokes a function that is
implemented in other components, e.g. an OEM ipmi plugin, b_lundef=true
will cause the link failure with undefined reference.

For such projects, the meson.build will set b_lundef=false by default,
and the unit-test.py shall respect the project's setting or use the
default value, which is b_lundef=true.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I42a117819b18573dc47bfc4d807a65410bfbdde2

show more ...

unit-test.py: Test PDI with additional options

When phosphor-dbus-interfaces is under test, enable the org.open_power
and com.ibm interfaces so they get built as well.

Just did this for meson since

unit-test.py: Test PDI with additional options

When phosphor-dbus-interfaces is under test, enable the org.open_power
and com.ibm interfaces so they get built as well.

Just did this for meson since both meson and autotools run under CI and
the results should be the same, plus the autotools build may soon go
away.

Signed-off-by: Matt Spinler <spinler@us.ibm.com>
Change-Id: If3a9e09ebc788dc14a3379b1178871c7cee47c1e

show more ...

unit-test.py: implement repeat for meson

The script takes a repeat argument -r but the value wasn't being
forwarded when invoking meson.

Change-Id: Ib813449c7b52914309050179ef53b11e48d6be4a
Signed-

unit-test.py: implement repeat for meson

The script takes a repeat argument -r but the value wasn't being
forwarded when invoking meson.

Change-Id: Ib813449c7b52914309050179ef53b11e48d6be4a
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com>

show more ...

cppcheck : Add googletest library while running cppcheck

- cppcheck shows a syntaxerror while parsing TEST & TEST_F
macros in the repo's test files, as cppcheck cannot understand
how a TEST or a

cppcheck : Add googletest library while running cppcheck

- cppcheck shows a syntaxerror while parsing TEST & TEST_F
macros in the repo's test files, as cppcheck cannot understand
how a TEST or a TEST_F works.

Example:
When repo specific CI is run on phosphor-networkd, it throws following
errors:

test/test_ethernet_interface.cpp:108:1: error: syntax error [syntaxError]
TEST_F(TestEthernetInterface, NoIPaddress)
^
test/test_neighbor.cpp:35:1: error: syntax error [syntaxError]
TEST(ParseNeighbor, SmallMsg)
^

- This commit would load googletest.cfg that contains information
about google test types and functions. With such information
Cppcheck understands the code better and therefore get better
results.

TestedBy:

- Had run docker CI against the networkd, and the above mentioned errors
are gone.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: If72edd4e734fb201e8a2a937fdfe8bc62dfb5f4b

show more ...

shellcheck: enable shell linting

Add to the `format-code.sh` optional support for linting shell scripts
using `shellcheck`. All repositories will have this ran, but only
repositories with a `.shell

shellcheck: enable shell linting

Add to the `format-code.sh` optional support for linting shell scripts
using `shellcheck`. All repositories will have this ran, but only
repositories with a `.shellcheck` file in the root of the repository
will stop on error.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie25c27cffc96b7fa66291abef1b0f90a0f1862ed

show more ...

Meson dependencies pattern should pick list items.

The patten "dependency\('([^']*)'.*?\)\n" fails to match dependencies declared in a list, for example,

some_deps = [
dependency('lib1'),
depen

Meson dependencies pattern should pick list items.

The patten "dependency\('([^']*)'.*?\)\n" fails to match dependencies declared in a list, for example,

some_deps = [
dependency('lib1'),
dependency('lib2'),
]

Changed it to "dependency\('([^']*)'.*?\),?\n".

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: If5f9c8c24a5db881625d499181ac474758fc2544

show more ...

dbus-interfaces: remove unused packages

phosphor-dbus-interfaces contains all of the com.ibm and org.open_power
interfaces now. Remove those dependencies from the CI scripts so that
any repository

dbus-interfaces: remove unused packages

phosphor-dbus-interfaces contains all of the com.ibm and org.open_power
interfaces now. Remove those dependencies from the CI scripts so that
any repository still referencing them fails until modified to point at
the correct dependency.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If306d060984bef14902976e29c6415194d9af940

show more ...

Give Meson first preference for CI Jobs

- Now that a lot of repos are being migrated to meson , it
would be good to check for meson first, so that if meson
changes are good, then we can remove t

Give Meson first preference for CI Jobs

- Now that a lot of repos are being migrated to meson , it
would be good to check for meson first, so that if meson
changes are good, then we can remove the autotools or cmake
files.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I9428d2302560e86083001c256165888a94f1787b

show more ...

scripts/unit-test: Autodetect meson option types

This will allow us to use booleans or feature type values for examples
and tests.

Change-Id: Ib2a51ef5491db8be5fdc26ad1afca687b4fc68cb
Signed-off-by

scripts/unit-test: Autodetect meson option types

This will allow us to use booleans or feature type values for examples
and tests.

Change-Id: Ib2a51ef5491db8be5fdc26ad1afca687b4fc68cb
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

scripts/unit-test: Use the meson option parser

This will make parsing more consistent with meson itself and allow us
to extract other data about options for a build.

Change-Id: Ifac630be74345373914

scripts/unit-test: Use the meson option parser

This will make parsing more consistent with meson itself and allow us
to extract other data about options for a build.

Change-Id: Ifac630be74345373914ed585e017c67df422ef27
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

build-qemu-robot-docker: Use pip mirror

When PIP_MIRROR env is set, setup the pip mirror in $HOME/.pip/pip.conf
to speedup the pip download.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id

build-qemu-robot-docker: Use pip mirror

When PIP_MIRROR env is set, setup the pip mirror in $HOME/.pip/pip.conf
to speedup the pip download.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: I4bac9faafbad375772f911eb0675522215f62405

show more ...

build-qemu-robot-docker: Use apt mirror

When UBUNTU_MIRROR is set, use apt mirror to speed up the apt downloads.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: Ie2ae670a2f0c019c082e87f55

build-qemu-robot-docker: Use apt mirror

When UBUNTU_MIRROR is set, use apt mirror to speed up the apt downloads.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: Ie2ae670a2f0c019c082e87f55c3e3b8eddd4e8d0

show more ...

build-qemu-robot-docker: Support proxy

Make build-qemu-robot-docker.sh support proxy.

Signed-off-by: Lei YU <yulei.sh@bytedance.com>
Change-Id: Id15b9c0273f8721c97556b166e4184c5bd7840d3

clang: upgrade to clang-10

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I53413a2c857a7f6b4a32694d308e7d357e92dc18

python3: convert dbus-unit-test.py

The latest Ubuntu release (focal) no longer installs a default "python"
in the filesystem. The only issue found converting this script over to
python3 was that spl

python3: convert dbus-unit-test.py

The latest Ubuntu release (focal) no longer installs a default "python"
in the filesystem. The only issue found converting this script over to
python3 was that splitlines() now returns a bytes string. os.environ did
not like that so explicitly convert the byte string to a normal string.

Change-Id: I05f4c8a8090074c71c9afd156f5963b6f6668884
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

sdbusplus: remove deprecated --enable-transaction

sdbusplus removed support for disabling transaction IDs and
deprecated the --enable-transaction configure flag. Remove
it here as well.

Signed-off

sdbusplus: remove deprecated --enable-transaction

sdbusplus removed support for disabling transaction IDs and
deprecated the --enable-transaction configure flag. Remove
it here as well.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic6939d18adc5ae892d6fad9b3286a4cd979b7cdf

show more ...

unit-test.py: define hei pkg-config association

Associate hei pkg-config module with openpower-libhei so that the hei
library will be installed and availble as a build time dependency.

Signed-off-b

unit-test.py: define hei pkg-config association

Associate hei pkg-config module with openpower-libhei so that the hei
library will be installed and availble as a build time dependency.

Signed-off-by: Ben Tyner <ben.tyner@ibm.com>
Change-Id: I450026c64fab6c08dd299fd43ed1ad2f91373ec2

show more ...

Enabled UT report generation for given repositories

Change-Id: I2d6b9a86e69f85a6c61ec0434b9b09922cad73a6
Signed-off-by: Anusha Dathatri <adathatr@in.ibm.com>