phosphor-logging: fix yaml option

The meson option in the repository is 'yamldir' and not 'yaml_dir'.
Fix this since later versions of Meson complain about an unknown
option being passed.

Signed-of

phosphor-logging: fix yaml option

The meson option in the repository is 'yamldir' and not 'yaml_dir'.
Fix this since later versions of Meson complain about an unknown
option being passed.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4241745e6cafe310152e8d8235db012af447a167

show more ...

autoconf-archive: manually patch C++20 support

autoconf-archive added support for C++20 finally in v2022.02.11
but none of the Ubuntu distro versions have picked this up
yet (checked impish and jamm

autoconf-archive: manually patch C++20 support

autoconf-archive added support for C++20 finally in v2022.02.11
but none of the Ubuntu distro versions have picked this up
yet (checked impish and jammy). Manually patch the file so that
we can upgrade our autoconf-based C++ repositories to use C++20.

The v2022.02.11 version is already included in Yocto.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ied06de39741379689db153896a9a497cb6df229c

show more ...

unit-test: Update gtest source rev to fix std::span issue

The std::span does not support some gtest MACROS and is fixed in
https://github.com/google/googletest/pull/3195 and
https://github.com/googl

unit-test: Update gtest source rev to fix std::span issue

The std::span does not support some gtest MACROS and is fixed in
https://github.com/google/googletest/pull/3195 and
https://github.com/google/googletest/commit/e4717df71a4f45bf9f0ac88c6cd9846a0bc248dd

Including the fixes to support std::span in gtests.

Match the openembedded gtest version in
https://github.com/openembedded/meta-openembedded/pull/564

Change-Id: Ia0171160ee7a0a36c2fb27eb441e25cdec9ba9f1
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Use well-known passwd constants if user root

If the intended user is root, use well-known constants for UID, GID,
and home directory, to avoid wrongly using those of the normal user
running this scr

Use well-known passwd constants if user root

If the intended user is root, use well-known constants for UID, GID,
and home directory, to avoid wrongly using those of the normal user
running this script.

Using -f flag for groupadd, to avoid erroring out if group name
already exists for this user name.

Tested: No longer fails with weird groupadd errors if
run-unit-test-docker.sh command line contains USER="root" setting.

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Idc6158386ce96a6e2fa97dd0eb56b928f18e7a35

show more ...

update python path to 3.9 for site-packages

Been having issues getting this to build on Ubuntu 20 and this change
got it working. I don't remember the details on why we need this but we
are now inst

update python path to 3.9 for site-packages

Been having issues getting this to build on Ubuntu 20 and this change
got it working. I don't remember the details on why we need this but we
are now installing python3.9 in our CI images so make it match.

Change-Id: Ic72d32a612d186359b78d098697477db9132c8ad
Signed-off-by: Andrew Geissler <geissonator@yahoo.com>

show more ...

Let eslint use .gitignore file

There is a well documented issue when using eslint with a folder that
already has subprojects checked out. A quick perusing of the eslint
documentation shows that the

Let eslint use .gitignore file

There is a well documented issue when using eslint with a folder that
already has subprojects checked out. A quick perusing of the eslint
documentation shows that the eslintignore files happily accept a
.gitignore file as its input. Considering there might be repos that
already have put a .eslintignore file in place, rely on that if it
exists, if it doesn't, fall back to .gitignore if it exists.

While here, this exposed another issue that we were missing the
--format=json command, and there were cases where eslint would make a
mistake.

Tested:
Ran on bmcweb repo with subprojects checked out. Observed build
succeeded.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Iafab1d4d9e80a093a13b4c5a758a1f68bc37138c

show more ...

phosphor-dbus-interfaces: remove unnecessary config flags

With Ibb65eddd6c3a3e32f64f4ddf7ac5da4526cab2b7, the PDI repo
enables all interfaces by default, so explicitly enabling some
of them is not n

phosphor-dbus-interfaces: remove unnecessary config flags

With Ibb65eddd6c3a3e32f64f4ddf7ac5da4526cab2b7, the PDI repo
enables all interfaces by default, so explicitly enabling some
of them is not necessary. Remove the config_flags.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ie7954198d9475198cbb0f85dc7f4d0b5dc378480

show more ...

scripts/build-unit-test-docker: Update googletest to match openembedded

Promote `googletest` to v1.11 to match openembedded.
See https://github.com/openembedded/meta-openembedded/blob/master/meta-oe

scripts/build-unit-test-docker: Update googletest to match openembedded

Promote `googletest` to v1.11 to match openembedded.
See https://github.com/openembedded/meta-openembedded/blob/master/meta-oe/recipes-test/googletest/googletest_git.bb#L7

Signed-off-by: Michael Shen <gpgpgp@google.com>
Change-Id: I19d315cffc6b7fffaddba7b07a4bd9c7d7533b8d

show more ...

Disable colored output in shellcheck

shellcheck defaults to using colors in its output. Unfortunately,
jenkins is unable to process bash-style colors in the console log, so in
practice, when colors

Disable colored output in shellcheck

shellcheck defaults to using colors in its output. Unfortunately,
jenkins is unable to process bash-style colors in the console log, so in
practice, when colors are used, the jenkins logs end up like:

[1mIn jenkins/userid-validation line 25:[0m
[0mif [ "x${COMMITTER_EMAIL}" == "x" ]; then[0m
[32m ^-------------------^ SC2268 (style): Avoid x-prefix in comparisons as it no longer serves a purpose.[0m

[1mDid you mean: [0m
if [ "${COMMITTER_EMAIL}" == "" ]; then

With lots of control characters. This is annoying to review in build
scripts, which are primarily being read from disk somewhere.

The above log was pulled from the review here:
https://jenkins.openbmc.org/job/CI-MISC/job/ci-openbmc-build-scripts/455/console

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ibc827039150f7018b31a63ac11fa7c19776414c9

show more ...

Add python requests to CI

There are some scripts in bmcweb that we'd like to be able to run during
CI. They rely on requests to compare the standards driven files against
what exists in the codebas

Add python requests to CI

There are some scripts in bmcweb that we'd like to be able to run during
CI. They rely on requests to compare the standards driven files against
what exists in the codebase to make sure that people haven't edited by
hand.

To do this, add the requests dependency.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Idbb06d6ba992244c652094040849787bb1487805

show more ...

obmc-build-script: Update fmt to `8.1.1`

Match the version in
https://github.com/openbmc/openbmc/blob/595f63084d313c9708cb435470e6c6dcbbbbe646/meta-openembedded/meta-oe/recipes-support/fmt/fmt_8.1.1

obmc-build-script: Update fmt to `8.1.1`

Match the version in
https://github.com/openbmc/openbmc/blob/595f63084d313c9708cb435470e6c6dcbbbbe646/meta-openembedded/meta-oe/recipes-support/fmt/fmt_8.1.1.bb

Change-Id: Ib647c4f54dfb1a6e619200247a6c4a9f95037140
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Upgrade boost to 1.78

Latest subtree update pulled this in, and boost-url requires it.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ice62443b588fae07bc7bebb4085c13a8373f9515

Update boost url

The latest subtree update pulled in new boost url, and JOY! is API
incompatible with new boost-url. We need the new boost-url in CI, then
this needs to be syncronized with

https:/

Update boost url

The latest subtree update pulled in new boost url, and JOY! is API
incompatible with new boost-url. We need the new boost-url in CI, then
this needs to be syncronized with

https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/50916

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I8e147370cb787706270d49344e870da26e274aa0

show more ...

qemu robot test: allow specifying IMAGE_LOC

The existing script assumes qemuarm and the MACHINE under test are
in the same folder. This change adds an option to specify a
different location for the

qemu robot test: allow specifying IMAGE_LOC

The existing script assumes qemuarm and the MACHINE under test are
in the same folder. This change adds an option to specify a
different location for the MACHINE image.

Tested:
UPSTREAM_WORKSPACE=/home/nanzhou_google_com/openbmc
DEFAULT_IMAGE_LOC=./build/romulus/tmp/deploy/images
QEMU_BIN=./qemuarm/tmp/sysroots/x86_64/usr/bin/qemu-system-arm
MACHINE=romulus ./openbmc-build-scripts/run-qemu-robot
-test.sh

I cloned the openbmc distro in my home dir. Then source setup
qemuarm and romulus separately, and finished the builds.

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I37800de63fe9d64dd28ffc6c5a4d3c0ea181a597

show more ...

build qemu: fix docker hangs with large UID

Docker build hangs when the user has a large UID. As suggested in
https://github.com/moby/moby/issues/5419, -l or --no-log-init is
a workaround.

Signed-o

build qemu: fix docker hangs with large UID

Docker build hangs when the user has a large UID. As suggested in
https://github.com/moby/moby/issues/5419, -l or --no-log-init is
a workaround.

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: I1f8cc43a14e146675a8c53d353d5126e39c009e0

show more ...

Make clang-tidy propose diffs

clang-tidy supports a -fix option, which will directly apply the diffs
that it's able to do automatically to the tree. This is advantageous
for developers, because it

Make clang-tidy propose diffs

clang-tidy supports a -fix option, which will directly apply the diffs
that it's able to do automatically to the tree. This is advantageous
for developers, because it gives them a quick way to "do as the robot
commands" when run locally, and makes it more obvious in the output
exactly what's being asked for in a changeset.

Unfortunately, to use this feature, the run-clang-tidy script needs to
be run from the build folder directly, which involves a cd into the
directory. We actually already had to do this for cmake elsewhere in
this file, but it didn't get propagated to meson builds.

At the same time, when run-clang-tidy fails to run, catch the error and
run the same "git diff" procedure that we run elsewhere such that the
diff is printed to the console.

Tested:
Updated clang-tidy to include a new check for
https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/50660

and ran run-unit-test-docker.sh, and observed that both the bmcweb tree
had been updated locally, and the diff was printed to the console
output.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I04ef8c136c8e72e7787cebe018cfe2289d7f2c59

show more ...

Check the result of formatting the code

The old format-code.sh script used to run git diff to determine if any
files had been reformatted in the commit. The "new" way should do the
same.

Tested:
R

Check the result of formatting the code

The old format-code.sh script used to run git diff to determine if any
files had been reformatted in the commit. The "new" way should do the
same.

Tested:
Ran a build on entity-manager, which includes a custom format-code
script, and saw the build pass. Backed up to the commit prior, which
included formatting violations, reran and saw the build fail.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I3697da5dbbe78bb2241bb66d2583b2c9c2f9e753

show more ...

Use native docker images for scripts on aarch64 Host OS

Commit 051b05b7 support aach64 Host OS to execute scripts. However, it
does not set DOCKER_BASE parameter which consequently uses x86_64 docke

Use native docker images for scripts on aarch64 Host OS

Commit 051b05b7 support aach64 Host OS to execute scripts. However, it
does not set DOCKER_BASE parameter which consequently uses x86_64 docker
images instead of arm64v8 image.
This commit sets DOCKER_BASE to arm64v8/ to use native docker images.

Tested:
1. Set environment variables appropriately and execute scripts. Ensure
all docker images loaded successfully and scripts can execute without
issue.

Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
Change-Id: I3c09d448dae17f290f2c2fd1d8116167510635b6

show more ...

build-unit-test-docker: add openssl-3

OpenSSL 3 introduced significant compatibility issues from OpenSSL 1
but isn't included in Ubuntu yet. Manually install it so that we can
perform CI against th

build-unit-test-docker: add openssl-3

OpenSSL 3 introduced significant compatibility issues from OpenSSL 1
but isn't included in Ubuntu yet. Manually install it so that we can
perform CI against the same APIs that will be included in Yocto.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I6f44cc1dd94f40ac1673a40453ed08c8f85f8134

show more ...

Add support aarch64 architecture

Support to run scripts in aarch64 Host Linux.

Tested: execute the scripts changed in this commit in Aarch64 Host
Ubuntu OS and check they can execute successfully

Add support aarch64 architecture

Support to run scripts in aarch64 Host Linux.

Tested: execute the scripts changed in this commit in Aarch64 Host
Ubuntu OS and check they can execute successfully

Signed-off-by: Thang Q. Nguyen <thang@os.amperecomputing.com>
Change-Id: Idde23fbd09c5000c710f4f6d88793fefbb0cb04c

show more ...

build-unit-test-docker: add libunifex

unifex is a library that sdbusplus will begin to depend on in order to
support co-routines. Add it here to match the recipe that has been
submitted upstream.

build-unit-test-docker: add libunifex

unifex is a library that sdbusplus will begin to depend on in order to
support co-routines. Add it here to match the recipe that has been
submitted upstream.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I4548813cba19822c1367c3de1b81cc2f034518c6

show more ...

scripts/build-unit-test-docker: Add libcryptsetup

Upcoming changes to the estoraged repo will start using libcryptsetup to
manage an encrypted storage device.

Signed-off-by: John Wedig <johnwedig@g

scripts/build-unit-test-docker: Add libcryptsetup

Upcoming changes to the estoraged repo will start using libcryptsetup to
manage an encrypted storage device.

Signed-off-by: John Wedig <johnwedig@google.com>
Change-Id: I88ca8dd8d55bd103f49b932d9fcc28e532cd2126

show more ...

Upgrade to boost 0.77 to match yocto

Tested:
Relying on CI.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ie84d88121f4a1c2fd8cded190c5f8dafda983456

Upgrade nlohmann

Current version of nlohmann has some issues with c++20. Upgrade it.

Tested:
Built bmcweb with
https://gerrit.openbmc-project.xyz/c/openbmc/entity-manager/+/47575 and
build succeed

Upgrade nlohmann

Current version of nlohmann has some issues with c++20. Upgrade it.

Tested:
Built bmcweb with
https://gerrit.openbmc-project.xyz/c/openbmc/entity-manager/+/47575 and
build succeeded.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: Ia8c42f8901b0e3ef613a0fe66ee92742d1680b6c

show more ...

remove ubuntu version documentation

A few of the scripts which utilize a version of an Ubuntu container when
making a dependent Docker container also document the default choice in
comments. This l

remove ubuntu version documentation

A few of the scripts which utilize a version of an Ubuntu container when
making a dependent Docker container also document the default choice in
comments. This leads to redundant, and sometimes missed, changes
whenever upgrading the underlying Ubuntu distro version. Strike them
to reduce this maintenance.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Idc64437a6c6b1f07b6d716829b41b9fd58e62cc3

show more ...