Revision tags: v3.4-rc5 |
|
#
8f177896 |
| 26-Apr-2012 |
Allan Stephens <allan.stephens@windriver.com> |
tipc: Enhance error checking of published names
Consolidates validation of scope and name sequence range values into a single routine where it applies both to local name publications and to name pub
tipc: Enhance error checking of published names
Consolidates validation of scope and name sequence range values into a single routine where it applies both to local name publications and to name publications issued by other nodes in the network. This change means that the scope value for non-local publications is now validated and the name sequence range for local publications is now validated only once. Additionally, a publication attempt that fails validation now creates an entry in the system log file only if debugging capabilities have been enabled; this prevents the system log from being cluttered up with messages caused by a defective application or network node.
Signed-off-by: Allan Stephens <allan.stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
show more ...
|
#
f7fb9d20 |
| 26-Apr-2012 |
Allan Stephens <allan.stephens@windriver.com> |
tipc: Create helper routine to delete unused name sequence structure
Replaces two identical chunks of code that delete an unused name sequence structure from TIPC's name table with calls to a new ro
tipc: Create helper routine to delete unused name sequence structure
Replaces two identical chunks of code that delete an unused name sequence structure from TIPC's name table with calls to a new routine that performs this operation.
This change is cosmetic and doesn't impact the operation of TIPC.
Signed-off-by: Allan Stephens <allan.stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
show more ...
|
Revision tags: v3.4-rc4 |
|
#
d4f5c12c |
| 17-Apr-2012 |
Allan Stephens <allan.stephens@windriver.com> |
tipc: Ensure network address change doesn't impact name table updates
Revises routines that add and remove an entry from a node's name table so that the publication scope lists are updated properly
tipc: Ensure network address change doesn't impact name table updates
Revises routines that add and remove an entry from a node's name table so that the publication scope lists are updated properly even if the node's network address is changed in mid-operation. The routines now recognize the default node address of <0.0.0> as an alias for "this node" even after a new network address has been assigned.
Signed-off-by: Allan Stephens <allan.stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
show more ...
|
#
336ebf5b |
| 17-Apr-2012 |
Allan Stephens <allan.stephens@windriver.com> |
tipc: Add routines for safe checking of node's network address
Introduces routines that test whether a given network address is equal to a node's own network address or if it lies within the node's
tipc: Add routines for safe checking of node's network address
Introduces routines that test whether a given network address is equal to a node's own network address or if it lies within the node's own network cluster, and which work properly regardless of whether the node is using the default network address <0.0.0> or a non-zero network address that is assigned later on. In essence, these routines ensure that address <0.0.0> is treated as an alias for "this node", regardless of which network address the node is actually using.
Old users of the pre-existing more strict match in_own_cluster() have been accordingly redirected to what is now called in_own_cluster_exact() --- which does not extend matching to <0,0,0>.
Signed-off-by: Allan Stephens <allan.stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
show more ...
|
Revision tags: v3.4-rc3, v3.4-rc2, v3.4-rc1, v3.3, v3.3-rc7, v3.3-rc6, v3.3-rc5, v3.3-rc4, v3.3-rc3, v3.3-rc2, v3.3-rc1, v3.2, v3.2-rc7, v3.2-rc6, v3.2-rc5, v3.2-rc4, v3.2-rc3, v3.2-rc2 |
|
#
fd6eced8 |
| 09-Nov-2011 |
Allan Stephens <allan.stephens@windriver.com> |
tipc: Don't record failed publication attempt as a success
No longer increments counter of number of publications by a node if an attempt to add a new publication fails. This prevents TIPC from inco
tipc: Don't record failed publication attempt as a success
No longer increments counter of number of publications by a node if an attempt to add a new publication fails. This prevents TIPC from incorrectly blocking future publications because the configured maximum number of publications has been reached.
Signed-off-by: Allan Stephens <allan.stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
show more ...
|
#
1110b8d3 |
| 17-Apr-2012 |
Allan Stephens <allan.stephens@windriver.com> |
tipc: Update node-scope publications when network address is assigned
Ensures that node-scope name publications that exist prior to the configuration of a node's network address are properly re-init
tipc: Update node-scope publications when network address is assigned
Ensures that node-scope name publications that exist prior to the configuration of a node's network address are properly re-initialized with that address when it is assigned. TIPC's node-scope publications are now tracked using a publications list like the lists used for cluster-scope and zone-scope publications so they can be easily updated when required.
The inclusion of node scope name publications in a conventional publication list means that they must now also be withdrawn, just like cluster and zone scope publications are currently withdrawn. So some conditional tests on scope ==/!= TIPC_NODE_SCOPE are inserted/removed accordingly.
Signed-off-by: Allan Stephens <allan.stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
show more ...
|
Revision tags: v3.2-rc1 |
|
#
bc9f8143 |
| 07-Nov-2011 |
Allan Stephens <allan.stephens@windriver.com> |
tipc: Revert name table translation optimization
Restores name table translation using a non-zero domain that is "out of scope", which was broken by an earlier commit (5d9c54c1e9ececcf7e99c4f014f9be
tipc: Revert name table translation optimization
Restores name table translation using a non-zero domain that is "out of scope", which was broken by an earlier commit (5d9c54c1e9ececcf7e99c4f014f9bec7ee3a7def). Comments have now been added to the name table translation routine to make it clear that there are actually three possible outcomes to a translation request (found/not found/deferred), rather than just two (found/not found).
Note that a straightforward revert of the earlier commit is not possible, as other changes to the name table translation logic have occurred since the incorrect optimization was made.
Signed-off-by: Allan Stephens <allan.stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
show more ...
|
#
f80c24d9 |
| 03-Nov-2011 |
Allan Stephens <allan.stephens@windriver.com> |
tipc: Add check to prevent insertion of duplicate name table entries
Adds a new check to TIPC's name table logic to reject any attempt to create a new name publication that is identical to an existi
tipc: Add check to prevent insertion of duplicate name table entries
Adds a new check to TIPC's name table logic to reject any attempt to create a new name publication that is identical to an existing one. (Such an attempt will never happen under normal circumstances, but could arise if another network node malfunctions and issues a duplicate name publication message.)
Signed-off-by: Allan Stephens <allan.stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
show more ...
|
#
c422f1bd |
| 02-Nov-2011 |
Allan Stephens <allan.stephens@windriver.com> |
tipc: Simplify enforcement of reserved name type prohibition
Streamlines the logic that prevents an application from binding a reserved TIPC name type to a port by moving the check to the code that
tipc: Simplify enforcement of reserved name type prohibition
Streamlines the logic that prevents an application from binding a reserved TIPC name type to a port by moving the check to the code that handles a socket bind() operation. This allows internal TIPC subsystems to bind a reserved name without having to set an atomic flag to gain permission to use such a name. (This simplification is now possible due to the elimination of support for TIPC's native API.)
Signed-off-by: Allan Stephens <allan.stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
show more ...
|
#
fead3909 |
| 29-Dec-2011 |
Paul Gortmaker <paul.gortmaker@windriver.com> |
tipc: rename struct subscription to struct tipc_subscription
Make this rename so that it is consistent with the majority of the other tipc structs and to assist in removing any ambiguity with other
tipc: rename struct subscription to struct tipc_subscription
Make this rename so that it is consistent with the majority of the other tipc structs and to assist in removing any ambiguity with other similar names in other subsystems.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
show more ...
|
#
4584310b |
| 29-Dec-2011 |
Paul Gortmaker <paul.gortmaker@windriver.com> |
tipc: rename struct port_list to struct tipc_port_list
Make this rename so that it is consistent with the majority of the other tipc structs and to assist in removing any ambiguity with other simila
tipc: rename struct port_list to struct tipc_port_list
Make this rename so that it is consistent with the majority of the other tipc structs and to assist in removing any ambiguity with other similar names in other subsystems.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
show more ...
|
Revision tags: v3.1, v3.1-rc10, v3.1-rc9, v3.1-rc8, v3.1-rc7, v3.1-rc6, v3.1-rc5, v3.1-rc4, v3.1-rc3, v3.1-rc2, v3.1-rc1, v3.0, v3.0-rc7, v3.0-rc6, v3.0-rc5, v3.0-rc4, v3.0-rc3, v3.0-rc2 |
|
#
8af4638a |
| 30-May-2011 |
Allan Stephens <allan.stephens@windriver.com> |
tipc: Eliminate checks for empty zone list during name translation
Gets rid of a pair of checks to see if a name sequence entry in TIPC's name table has an empty zone list. These checks are pointles
tipc: Eliminate checks for empty zone list during name translation
Gets rid of a pair of checks to see if a name sequence entry in TIPC's name table has an empty zone list. These checks are pointless since the zone list can never be empty (i.e. as soon as the list becomes empty the associated name sequence entry is deleted).
Signed-off-by: Allan Stephens <allan.stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
show more ...
|
#
f6f0a4d2 |
| 30-May-2011 |
Allan Stephens <allan.stephens@windriver.com> |
tipc: Convert name table publication lists to standard kernel lists
Modifies the main circular linked lists of publications used in TIPC's name table to use the standard kernel linked list type. Thi
tipc: Convert name table publication lists to standard kernel lists
Modifies the main circular linked lists of publications used in TIPC's name table to use the standard kernel linked list type. This change simplifies the deletion of an existing publication by eliminating the need to search up to three lists to locate the publication. The use of standard list routines also helps improve the readability of the name table code by make it clearer what each list operation being performed is actually doing.
Signed-off-by: Allan Stephens <allan.stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
show more ...
|
#
b52124a5 |
| 30-May-2011 |
Allan Stephens <allan.stephens@windriver.com> |
tipc: Partition name table instance array info into two parts
Modifies the name table array structure that contains the name sequence instances for a given name type so that the publication lists as
tipc: Partition name table instance array info into two parts
Modifies the name table array structure that contains the name sequence instances for a given name type so that the publication lists associated with a given instance are stored in a dynamically allocated structure, rather than being embedded within the array entry itself. This change is being done for several reasons:
1) It reduces the amount of data that needs to be copied whenever a given array is expanded or contracted to accommodate the first publication of a new name sequence or the removal of the last publication of an existing name sequence.
2) It reduces the amount of memory associated with array entries that are currently unused.
3) It facilitates the upcoming conversion of the publication lists from TIPC-specific circular lists to standard kernel lists. (Standard lists cannot be used with the former array structure because the relocation of array entries during array expansion and contraction would corrupt the lists.)
Note that, aside from introducing a small amount of code to dynamically allocate and free the structure that now holds publication list info, this change is largely a simple renaming exercise that replaces references to "sseq->LIST" with "sseq->info->LIST" (or "info->LIST").
Signed-off-by: Allan Stephens <allan.stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
show more ...
|
Revision tags: v3.0-rc1, v2.6.39, v2.6.39-rc7, v2.6.39-rc6, v2.6.39-rc5, v2.6.39-rc4, v2.6.39-rc3, v2.6.39-rc2, v2.6.39-rc1, v2.6.38, v2.6.38-rc8, v2.6.38-rc7, v2.6.38-rc6, v2.6.38-rc5, v2.6.38-rc4, v2.6.38-rc3, v2.6.38-rc2, v2.6.38-rc1, v2.6.37 |
|
#
a016892c |
| 31-Dec-2010 |
Allan Stephens <Allan.Stephens@windriver.com> |
tipc: remove extraneous braces from single statements
Cleans up TIPC's source code to eliminate the presence of unnecessary use of {} around single statements.
These changes are purely cosmetic and
tipc: remove extraneous braces from single statements
Cleans up TIPC's source code to eliminate the presence of unnecessary use of {} around single statements.
These changes are purely cosmetic and do not alter the operation of TIPC in any way.
Signed-off-by: Allan Stephens <Allan.Stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: David S. Miller <davem@davemloft.net>
show more ...
|
#
e3ec9c7d |
| 31-Dec-2010 |
Allan Stephens <Allan.Stephens@windriver.com> |
tipc: remove zeroing assignments to static global variables
Cleans up TIPC's source code to eliminate the needless initialization of static variables to zero.
These changes are purely cosmetic and
tipc: remove zeroing assignments to static global variables
Cleans up TIPC's source code to eliminate the needless initialization of static variables to zero.
These changes are purely cosmetic and do not alter the operation of TIPC in any way.
Signed-off-by: Allan Stephens <Allan.Stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: David S. Miller <davem@davemloft.net>
show more ...
|
#
0e65967e |
| 31-Dec-2010 |
Allan Stephens <Allan.Stephens@windriver.com> |
tipc: cleanup various cosmetic whitespace issues
Cleans up TIPC's source code to eliminate deviations from generally accepted coding conventions relating to leading/trailing white space and white sp
tipc: cleanup various cosmetic whitespace issues
Cleans up TIPC's source code to eliminate deviations from generally accepted coding conventions relating to leading/trailing white space and white space around commas, braces, cases, and sizeof.
These changes are purely cosmetic and do not alter the operation of TIPC in any way.
Signed-off-by: Allan Stephens <Allan.Stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: David S. Miller <davem@davemloft.net>
show more ...
|
#
b29f1428 |
| 31-Dec-2010 |
Allan Stephens <Allan.Stephens@windriver.com> |
tipc: remove calls to dbg() and msg_dbg()
Eliminates obsolete calls to two of TIPC's main debugging macros, as well as a pair of associated debugging routines that are no longer required.
Signed-of
tipc: remove calls to dbg() and msg_dbg()
Eliminates obsolete calls to two of TIPC's main debugging macros, as well as a pair of associated debugging routines that are no longer required.
Signed-off-by: Allan Stephens <Allan.Stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: David S. Miller <davem@davemloft.net>
show more ...
|
Revision tags: v2.6.37-rc8, v2.6.37-rc7, v2.6.37-rc6, v2.6.37-rc5 |
|
#
c8026282 |
| 30-Nov-2010 |
Allan Stephens <allan.stephens@windriver.com> |
tipc: Remove obsolete inclusions of header files
Gets rid of #include statements that are no longer required as a result of the merging of obsolete native API header file content into other TIPC inc
tipc: Remove obsolete inclusions of header files
Gets rid of #include statements that are no longer required as a result of the merging of obsolete native API header file content into other TIPC include files.
Signed-off-by: Allan Stephens <Allan.Stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: David S. Miller <davem@davemloft.net>
show more ...
|
Revision tags: v2.6.37-rc4, v2.6.37-rc3, v2.6.37-rc2, v2.6.37-rc1, v2.6.36, v2.6.36-rc8 |
|
#
7368ddf1 |
| 12-Oct-2010 |
Paul Gortmaker <paul.gortmaker@windriver.com> |
tipc: clean out all instances of #if 0'd unused code
Remove all instances of legacy, or as yet to be implemented code that is currently living within an #if 0 ... #endif block. In the rare instance
tipc: clean out all instances of #if 0'd unused code
Remove all instances of legacy, or as yet to be implemented code that is currently living within an #if 0 ... #endif block. In the rare instance that some of it be needed in the future, it can still be dragged out of history, but there is no need for it to sit in mainline.
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Acked-by: Neil Horman <nhorman@tuxdriver.com> Signed-off-by: David S. Miller <davem@davemloft.net>
show more ...
|
Revision tags: v2.6.36-rc7, v2.6.36-rc6 |
|
#
a02cec21 |
| 22-Sep-2010 |
Eric Dumazet <eric.dumazet@gmail.com> |
net: return operator cleanup
Change "return (EXPR);" to "return EXPR;"
return is not a function, parentheses are not required.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: D
net: return operator cleanup
Change "return (EXPR);" to "return EXPR;"
return is not a function, parentheses are not required.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
show more ...
|
Revision tags: v2.6.36-rc5, v2.6.36-rc4 |
|
#
5d9c54c1 |
| 03-Sep-2010 |
Allan Stephens <allan.stephens@windriver.com> |
tipc: Minor optimizations to name table translation code
Optimizes TIPC's name table translation code to avoid unnecessary manipulation of the node address field of the resulting port id when name t
tipc: Minor optimizations to name table translation code
Optimizes TIPC's name table translation code to avoid unnecessary manipulation of the node address field of the resulting port id when name translation fails. This change is possible because a valid port id cannot have a reference field of zero, so examining the reference only is sufficient to determine if the translation was successful.
Signed-off-by: Allan Stephens <allan.stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: David S. Miller <davem@davemloft.net>
show more ...
|
Revision tags: v2.6.36-rc3, v2.6.36-rc2 |
|
#
c2de5814 |
| 17-Aug-2010 |
Allan Stephens <allan.stephens@windriver.com> |
tipc: Minor enhancements to name table display format
Eliminate printing of dashes after name table column headers (to adhere more closely to the standard format used in tipc-config), and simplify n
tipc: Minor enhancements to name table display format
Eliminate printing of dashes after name table column headers (to adhere more closely to the standard format used in tipc-config), and simplify name table display logic using array lookups rather than if-then-else logic.
Signed-off-by: Allan Stephens <allan.stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: David S. Miller <davem@davemloft.net>
show more ...
|
Revision tags: v2.6.36-rc1, v2.6.35, v2.6.35-rc6, v2.6.35-rc5, v2.6.35-rc4, v2.6.35-rc3, v2.6.35-rc2, v2.6.35-rc1, v2.6.34 |
|
#
c68ca7b7 |
| 11-May-2010 |
Allan Stephens <allan.stephens@windriver.com> |
tipc: add tipc_ prefix to fcns targeted for un-inlining
These functions have enough code in them such that they seem like sensible targets for un-inlining. Prior to doing that, this adds the tipc_
tipc: add tipc_ prefix to fcns targeted for un-inlining
These functions have enough code in them such that they seem like sensible targets for un-inlining. Prior to doing that, this adds the tipc_ prefix to the functions, so that in the event of a panic dump or similar, the subsystem from which the functions come from is immediately clear.
Signed-off-by: Allan Stephens <allan.stephens@windriver.com> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: David S. Miller <davem@davemloft.net>
show more ...
|
Revision tags: v2.6.34-rc7, v2.6.34-rc6, v2.6.34-rc5, v2.6.34-rc4, v2.6.34-rc3, v2.6.34-rc2, v2.6.34-rc1, v2.6.33, v2.6.33-rc8, v2.6.33-rc7, v2.6.33-rc6, v2.6.33-rc5, v2.6.33-rc4, v2.6.33-rc3, v2.6.33-rc2, v2.6.33-rc1, v2.6.32, v2.6.32-rc8, v2.6.32-rc7, v2.6.32-rc6, v2.6.32-rc5, v2.6.32-rc4, v2.6.32-rc3, v2.6.32-rc1, v2.6.32-rc2, v2.6.31, v2.6.31-rc9, v2.6.31-rc8, v2.6.31-rc7, v2.6.31-rc6, v2.6.31-rc5, v2.6.31-rc4, v2.6.31-rc3, v2.6.31-rc2, v2.6.31-rc1, v2.6.30, v2.6.30-rc8, v2.6.30-rc7, v2.6.30-rc6, v2.6.30-rc5, v2.6.30-rc4, v2.6.30-rc3, v2.6.30-rc2, v2.6.30-rc1, v2.6.29, v2.6.29-rc8, v2.6.29-rc7, v2.6.29-rc6, v2.6.29-rc5, v2.6.29-rc4, v2.6.29-rc3, v2.6.29-rc2, v2.6.29-rc1, v2.6.28, v2.6.28-rc9, v2.6.28-rc8, v2.6.28-rc7, v2.6.28-rc6, v2.6.28-rc5, v2.6.28-rc4 |
|
#
f574179b |
| 08-Nov-2008 |
Harvey Harrison <harvey.harrison@gmail.com> |
tipc: trivial endian annotation in debug statement
Use htonl rather than ntohl on a u32. net/tipc/name_table.c:557:2: warning: cast to restricted __be32
Signed-off-by: Harvey Harrison <harvey.harri
tipc: trivial endian annotation in debug statement
Use htonl rather than ntohl on a u32. net/tipc/name_table.c:557:2: warning: cast to restricted __be32
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
show more ...
|