#
ad7a60de |
| 14-Aug-2013 |
Li Wang <liwang@ubuntukylin.com> |
ceph: punch hole support
This patch implements fallocate and punch hole support for Ceph kernel client.
Signed-off-by: Li Wang <liwang@ubuntukylin.com> Signed-off-by: Yunchuan Wen <yunchuanwen@ubun
ceph: punch hole support
This patch implements fallocate and punch hole support for Ceph kernel client.
Signed-off-by: Li Wang <liwang@ubuntukylin.com> Signed-off-by: Yunchuan Wen <yunchuanwen@ubuntukylin.com>
show more ...
|
Revision tags: v3.11-rc5, v3.11-rc4, v3.11-rc3, v3.11-rc2 |
|
#
73d9f7ee |
| 16-Jul-2013 |
majianpeng <majianpeng@gmail.com> |
libceph: unregister request in __map_request failed and nofail == false
For nofail == false request, if __map_request failed, the caller does cleanup work, like releasing the relative pages. It doe
libceph: unregister request in __map_request failed and nofail == false
For nofail == false request, if __map_request failed, the caller does cleanup work, like releasing the relative pages. It doesn't make any sense to retry this request.
CC: stable@vger.kernel.org Signed-off-by: Jianpeng Ma <majianpeng@gmail.com> Reviewed-by: Sage Weil <sage@inktank.com>
show more ...
|
Revision tags: v3.11-rc1, v3.10 |
|
#
61c5d6bf |
| 24-Jun-2013 |
Yan, Zheng <zheng.z.yan@intel.com> |
libceph: call r_unsafe_callback when unsafe reply is received
We can't use !req->r_sent to check if OSD request is sent for the first time, this is because __cancel_request() zeros req->r_sent when
libceph: call r_unsafe_callback when unsafe reply is received
We can't use !req->r_sent to check if OSD request is sent for the first time, this is because __cancel_request() zeros req->r_sent when OSD map changes. Rather than adding a new variable to struct ceph_osd_request to indicate if it's sent for the first time, We can call the unsafe callback only when unsafe OSD reply is received. If OSD's first reply is safe, just skip calling the unsafe callback.
The purpose of unsafe callback is adding unsafe request to a list, so that fsync(2) can wait for the safe reply. fsync(2) doesn't need to wait for a write(2) that hasn't returned yet. So it's OK to add request to the unsafe list when the first OSD reply is received. (ceph_sync_write() returns after receiving the first OSD reply)
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> Reviewed-by: Sage Weil <sage@inktank.com>
show more ...
|
Revision tags: v3.10-rc7, v3.10-rc6, v3.10-rc5 |
|
#
ccca4e37 |
| 02-Jun-2013 |
Yan, Zheng <zheng.z.yan@intel.com> |
libceph: fix truncate size calculation
check the "not truncated yet" case
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> Reviewed-by: Sage Weil <sage@inktank.com>
|
Revision tags: v3.10-rc4 |
|
#
eb845ff1 |
| 31-May-2013 |
Yan, Zheng <zheng.z.yan@intel.com> |
libceph: fix safe completion
handle_reply() calls complete_request() only if the first OSD reply has ONDISK flag.
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> Reviewed-by: Sage Weil <sage@inkt
libceph: fix safe completion
handle_reply() calls complete_request() only if the first OSD reply has ONDISK flag.
Signed-off-by: Yan, Zheng <zheng.z.yan@intel.com> Reviewed-by: Sage Weil <sage@inktank.com>
show more ...
|
#
4974341e |
| 29-May-2013 |
Alex Elder <elder@inktank.com> |
libceph: print more info for short message header
If an osd client response message arrives that has a front section that's too big for the buffer set aside to receive it, a warning gets reported an
libceph: print more info for short message header
If an osd client response message arrives that has a front section that's too big for the buffer set aside to receive it, a warning gets reported and a new buffer is allocated.
The warning says nothing about which connection had the problem. Add the peer type and number to what gets reported, to be a bit more informative.
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
Revision tags: v3.10-rc3 |
|
#
96e4dac6 |
| 22-May-2013 |
Alex Elder <elder@inktank.com> |
libceph: add lingering request reference when registered
When an osd request is set to linger, the osd client holds onto the request so it can be re-submitted following certain osd map changes. The
libceph: add lingering request reference when registered
When an osd request is set to linger, the osd client holds onto the request so it can be re-submitted following certain osd map changes. The osd client holds a reference to the request until it is unregistered. This is used by rbd for watch requests.
Currently, the reference is taken when the request is marked with the linger flag. This means that if an error occurs after that time but before the the request completes successfully, that reference is leaked.
There's really no reason to take the reference until the request is registered in the the osd client's list of lingering requests, and that only happens when the lingering (watch) request completes successfully.
So take that reference only when it gets registered following succesful completion, and drop it (as before) when the request gets unregistered. This avoids the reference problem on error in rbd.
Rearrange ceph_osdc_unregister_linger_request() to avoid using the request pointer after it may have been freed.
And hold an extra reference in kick_requests() while handling a linger request that has not yet been registered, to ensure it doesn't go away.
This resolves: http://tracker.ceph.com/issues/3859
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
Revision tags: v3.10-rc2 |
|
#
14d2f38d |
| 15-May-2013 |
Alex Elder <elder@inktank.com> |
libceph: must hold mutex for reset_changed_osds()
An osd client has a red-black tree describing its osds, and occasionally we would get crashes due to one of these trees tree becoming corrupt someho
libceph: must hold mutex for reset_changed_osds()
An osd client has a red-black tree describing its osds, and occasionally we would get crashes due to one of these trees tree becoming corrupt somehow.
The problem turned out to be that reset_changed_osds() was being called without protection of the osd client request mutex. That function would call __reset_osd() for any osd that had changed, and __reset_osd() would call __remove_osd() for any osd with no outstanding requests, and finally __remove_osd() would remove the corresponding entry from the red-black tree. Thus, the tree was getting modified without having any lock protection, and was vulnerable to problems due to concurrent updates.
This appears to be the only osd tree updating path that has this problem. It can be fairly easily fixed by moving the call up a few lines, to just before the request mutex gets dropped in kick_requests().
This resolves: http://tracker.ceph.com/issues/5043
Cc: stable@vger.kernel.org # 3.4+ Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Sage Weil <sage@inktank.com>
show more ...
|
Revision tags: v3.10-rc1 |
|
#
c10ebbf5 |
| 09-May-2013 |
Alex Elder <elder@inktank.com> |
libceph: init sent and completed when starting
The rbd code has a need to be able to restart an osd request that has already been started and completed once before. This currently wouldn't work rig
libceph: init sent and completed when starting
The rbd code has a need to be able to restart an osd request that has already been started and completed once before. This currently wouldn't work right because the osd client code assumes an osd request will be started exactly once Certain fields in a request are never cleared and this leads to trouble if you try to reuse it.
Specifically, the r_sent, r_got_reply, and r_completed fields are never cleared. The r_sent field records the osd incarnation at the time the request was sent to that osd. If that's non-zero, the message won't get re-mapped to a target osd properly, and won't be put on the unsafe requests list the first time it's sent as it should. The r_got_reply field is used in handle_reply() to ensure the reply to a request is processed only once. And the r_completed field is used for lingering requests to avoid calling the callback function every time the osd client re-sends the request on behalf of its initiator.
Each osd request passes through ceph_osdc_start_request() when responsibility for the request is handed over to the osd client for completion. We can safely zero these three fields there each time a request gets started.
One last related change--clear the r_linger flag when a request is no longer registered as a linger request.
This resolves: http://tracker.ceph.com/issues/5026
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
#
5522ae0b |
| 01-May-2013 |
Alex Elder <elder@inktank.com> |
libceph: use slab cache for osd client requests
Create a slab cache to manage allocation of ceph_osdc_request structures.
This resolves: http://tracker.ceph.com/issues/3926
Signed-off-by: Alex
libceph: use slab cache for osd client requests
Create a slab cache to manage allocation of ceph_osdc_request structures.
This resolves: http://tracker.ceph.com/issues/3926
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
Revision tags: v3.9 |
|
#
9ef1ee5a |
| 21-Apr-2013 |
Alex Elder <elder@inktank.com> |
libceph: fix byte order mismatch
A WATCH op includes an object version. The version that's supplied is incorrectly byte-swapped osd_req_op_watch_init() where it's first assigned (it's been this way
libceph: fix byte order mismatch
A WATCH op includes an object version. The version that's supplied is incorrectly byte-swapped osd_req_op_watch_init() where it's first assigned (it's been this way since that code was first added).
The result is that the version sent to the osd is wrong, because that value gets byte-swapped again in osd_req_encode_op(). This is the source of a sparse warning related to improper byte order in the assignment.
The approach of using the version to avoid a race is deprecated (see http://tracker.ceph.com/issues/3871), and the watch parameter is no longer even examined by the osd. So fix the assignment in osd_req_op_watch_init() so it no longer does the byte swap.
This resolves: http://tracker.ceph.com/issues/3847
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
Revision tags: v3.9-rc8 |
|
#
6c57b554 |
| 19-Apr-2013 |
Alex Elder <elder@inktank.com> |
libceph: support pages for class request data
Add the ability to provide an array of pages as outbound request data for object class method calls.
Signed-off-by: Alex Elder <elder@inktank.com> Revi
libceph: support pages for class request data
Add the ability to provide an array of pages as outbound request data for object class method calls.
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
Revision tags: v3.9-rc7, v3.9-rc6, v3.9-rc5, v3.9-rc4, v3.9-rc3, v3.9-rc2, v3.9-rc1, v3.8 |
|
#
49719778 |
| 11-Feb-2013 |
Alex Elder <elder@inktank.com> |
libceph: support raw data requests
Allow osd request ops that aren't otherwise structured (not class, extent, or watch ops) to specify "raw" data to be used to hold incoming data for the op. Make u
libceph: support raw data requests
Allow osd request ops that aren't otherwise structured (not class, extent, or watch ops) to specify "raw" data to be used to hold incoming data for the op. Make use of this capability for the osd STAT op.
Prefix the name of the private function osd_req_op_init() with "_", and expose a new function by that (earlier) name whose purpose is to initialize osd ops with (only) implied data.
For now we'll just support the use of a page array for an osd op with incoming raw data.
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
#
863c7eb5 |
| 15-Apr-2013 |
Alex Elder <elder@inktank.com> |
libceph: clean up osd data field access functions
There are a bunch of functions defined to encapsulate getting the address of a data field for a particular op in an osd request. They're all defined
libceph: clean up osd data field access functions
There are a bunch of functions defined to encapsulate getting the address of a data field for a particular op in an osd request. They're all defined the same way, so create a macro to take the place of all of them.
Two of these are used outside the osd client code, so preserve them (but convert them to use the new macro internally). Stop exporting the ones that aren't used elsewhere.
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
#
406e2c9f |
| 15-Apr-2013 |
Alex Elder <elder@inktank.com> |
libceph: kill off osd data write_request parameters
In the incremental move toward supporting distinct data items in an osd request some of the functions had "write_request" parameters to indicate,
libceph: kill off osd data write_request parameters
In the incremental move toward supporting distinct data items in an osd request some of the functions had "write_request" parameters to indicate, basically, whether the data belonged to in_data or the out_data. Now that we maintain the data fields in the op structure there is no need to indicate the direction, so get rid of the "write_request" parameters.
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
#
26be8808 |
| 15-Apr-2013 |
Alex Elder <elder@inktank.com> |
libceph: change how "safe" callback is used
An osd request currently has two callbacks. They inform the initiator of the request when we've received confirmation for the target osd that a request w
libceph: change how "safe" callback is used
An osd request currently has two callbacks. They inform the initiator of the request when we've received confirmation for the target osd that a request was received, and when the osd indicates all changes described by the request are durable.
The only time the second callback is used is in the ceph file system for a synchronous write. There's a race that makes some handling of this case unsafe. This patch addresses this problem. The error handling for this callback is also kind of gross, and this patch changes that as well.
In ceph_sync_write(), if a safe callback is requested we want to add the request on the ceph inode's unsafe items list. Because items on this list must have their tid set (by ceph_osd_start_request()), the request added *after* the call to that function returns. The problem with this is that there's a race between starting the request and adding it to the unsafe items list; the request may already be complete before ceph_sync_write() even begins to put it on the list.
To address this, we change the way the "safe" callback is used. Rather than just calling it when the request is "safe", we use it to notify the initiator the bounds (start and end) of the period during which the request is *unsafe*. So the initiator gets notified just before the request gets sent to the osd (when it is "unsafe"), and again when it's known the results are durable (it's no longer unsafe). The first call will get made in __send_request(), just before the request message gets sent to the messenger for the first time. That function is only called by __send_queued(), which is always called with the osd client's request mutex held.
We then have this callback function insert the request on the ceph inode's unsafe list when we're told the request is unsafe. This will avoid the race because this call will be made under protection of the osd client's request mutex. It also nicely groups the setup and cleanup of the state associated with managing unsafe requests.
The name of the "safe" callback field is changed to "unsafe" to better reflect its new purpose. It has a Boolean "unsafe" parameter to indicate whether the request is becoming unsafe or is now safe. Because the "msg" parameter wasn't used, we drop that.
This resolves the original problem reportedin: http://tracker.ceph.com/issues/4706
Reported-by: Yan, Zheng <zheng.z.yan@intel.com> Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Yan, Zheng <zheng.z.yan@intel.com> Reviewed-by: Sage Weil <sage@inktank.com>
show more ...
|
#
04017e29 |
| 05-Apr-2013 |
Alex Elder <elder@inktank.com> |
libceph: make method call data be a separate data item
Right now the data for a method call is specified via a pointer and length, and it's copied--along with the class and method name--into a pagel
libceph: make method call data be a separate data item
Right now the data for a method call is specified via a pointer and length, and it's copied--along with the class and method name--into a pagelist data item to be sent to the osd. Instead, encode the data in a data item separate from the class and method names.
This will allow large amounts of data to be supplied to methods without copying. Only rbd uses the class functionality right now, and when it really needs this it will probably need to use a page array rather than a page list. But this simple implementation demonstrates the functionality on the osd client, and that's enough for now.
This resolves: http://tracker.ceph.com/issues/4104
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
#
90af3602 |
| 05-Apr-2013 |
Alex Elder <elder@inktank.com> |
libceph: add, don't set data for a message
Change the names of the functions that put data on a pagelist to reflect that we're adding to whatever's already there rather than just setting it to the o
libceph: add, don't set data for a message
Change the names of the functions that put data on a pagelist to reflect that we're adding to whatever's already there rather than just setting it to the one thing. Currently only one data item is ever added to a message, but that's about to change.
This resolves: http://tracker.ceph.com/issues/2770
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
#
5476492f |
| 05-Apr-2013 |
Alex Elder <elder@inktank.com> |
libceph: kill off osd request r_data_in and r_data_out
Finally! Convert the osd op data pointers into real structures, and make the switch over to using them instead of having all ops share the in
libceph: kill off osd request r_data_in and r_data_out
Finally! Convert the osd op data pointers into real structures, and make the switch over to using them instead of having all ops share the in and/or out data structures in the osd request.
Set up a new function to traverse the set of ops and release any data associated with them (pages).
This and the patches leading up to it resolve: http://tracker.ceph.com/issues/4657
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
#
ec9123c5 |
| 05-Apr-2013 |
Alex Elder <elder@inktank.com> |
libceph: set the data pointers when encoding ops
Still using the osd request r_data_in and r_data_out pointer, but we're basically only referring to it via the data pointers in the osd ops. And we'
libceph: set the data pointers when encoding ops
Still using the osd request r_data_in and r_data_out pointer, but we're basically only referring to it via the data pointers in the osd ops. And we're transferring that information to the request or reply message only when the op indicates it's needed, in osd_req_encode_op().
To avoid a forward reference, ceph_osdc_msg_data_set() was moved up in the file.
Don't bother calling ceph_osd_data_init(), in ceph_osd_alloc(), because the ops array will already be zeroed anyway.
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
#
a4ce40a9 |
| 05-Apr-2013 |
Alex Elder <elder@inktank.com> |
libceph: combine initializing and setting osd data
This ends up being a rather large patch but what it's doing is somewhat straightforward.
Basically, this is replacing two calls with one. The fir
libceph: combine initializing and setting osd data
This ends up being a rather large patch but what it's doing is somewhat straightforward.
Basically, this is replacing two calls with one. The first of the two calls is initializing a struct ceph_osd_data with data (either a page array, a page list, or a bio list); the second is setting an osd request op so it associates that data with one of the op's parameters. In place of those two will be a single function that initializes the op directly.
That means we sort of fan out a set of the needed functions: - extent ops with pages data - extent ops with pagelist data - extent ops with bio list data and - class ops with page data for receiving a response
We also have define another one, but it's only used internally: - class ops with pagelist data for request parameters
Note that we *still* haven't gotten rid of the osd request's r_data_in and r_data_out fields. All the osd ops refer to them for their data. For now, these data fields are pointers assigned to the appropriate r_data_* field when these new functions are called.
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
#
39b44cbe |
| 05-Apr-2013 |
Alex Elder <elder@inktank.com> |
libceph: set message data when building osd request
All calls of ceph_osdc_start_request() are preceded (in the case of rbd, almost) immediately by a call to ceph_osdc_build_request().
Move the bui
libceph: set message data when building osd request
All calls of ceph_osdc_start_request() are preceded (in the case of rbd, almost) immediately by a call to ceph_osdc_build_request().
Move the build calls at the top of ceph_osdc_start_request() out of there and into the ceph_osdc_build_request(). Nothing prevents moving these calls to the top of ceph_osdc_build_request(), either (and we're going to want them there in the next patch) so put them at the top.
This and the next patch are related to: http://tracker.ceph.com/issues/4657
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
#
e65550fd |
| 05-Apr-2013 |
Alex Elder <elder@inktank.com> |
libceph: move ceph_osdc_build_request()
This simply moves ceph_osdc_build_request() later in its source file without any change. Done as a separate patch to facilitate review of the change in the n
libceph: move ceph_osdc_build_request()
This simply moves ceph_osdc_build_request() later in its source file without any change. Done as a separate patch to facilitate review of the change in the next patch.
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
#
5f562df5 |
| 05-Apr-2013 |
Alex Elder <elder@inktank.com> |
libceph: format class info at init time
An object class method is formatted using a pagelist which contains the class name, the method name, and the data concatenated into an osd request's outbound
libceph: format class info at init time
An object class method is formatted using a pagelist which contains the class name, the method name, and the data concatenated into an osd request's outbound data.
Currently when a class op is initialized in osd_req_op_cls_init(), the lengths of and pointers to these three items are recorded. Later, when the op is getting formatted into the request message, a new pagelist is created and that is when these items get copied into the pagelist.
This patch makes it so the pagelist to hold these items is created when the op is initialized instead.
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|
#
c99d2d4a |
| 05-Apr-2013 |
Alex Elder <elder@inktank.com> |
libceph: specify osd op by index in request
An osd request now holds all of its source op structures, and every place that initializes one of these is in fact initializing one of the entries in the
libceph: specify osd op by index in request
An osd request now holds all of its source op structures, and every place that initializes one of these is in fact initializing one of the entries in the the osd request's array.
So rather than supplying the address of the op to initialize, have caller specify the osd request and an indication of which op it would like to initialize. This better hides the details the op structure (and faciltates moving the data pointers they use).
Since osd_req_op_init() is a common routine, and it's not used outside the osd client code, give it static scope. Also make it return the address of the specified op (so all the other init routines don't have to repeat that code).
Signed-off-by: Alex Elder <elder@inktank.com> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
show more ...
|