#
420b9e5e |
| 31-Jul-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Tidy up in various files
Tidy up some files and remove an unused routine in meta_io.h. Also added a bit of extra debugging in meta_io.h.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
|
#
b2a580d8 |
| 10-Jul-2006 |
Abhijith Das <adas@redhat.com> |
[PATCH] patch to init di_payload_format field in gfs2_dinode
A missing initialisation when creating a new on disk inode.
Signed-off-by: Abhijith Das <adas@redhat.com> Signed-off-by: Steven Whitehou
[PATCH] patch to init di_payload_format field in gfs2_dinode
A missing initialisation when creating a new on disk inode.
Signed-off-by: Abhijith Das <adas@redhat.com> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
4340fe62 |
| 11-Jul-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Add generation number
This adds a generation number for the eventual use of NFS to the ondisk inode. Its backward compatible with the current code since it doesn't really matter what the gene
[GFS2] Add generation number
This adds a generation number for the eventual use of NFS to the ondisk inode. Its backward compatible with the current code since it doesn't really matter what the generation number is to start with, and indeed since its set to zero, due to it being taken from padding in both the inode and rgrp header, it should be fine.
The eventual plan is to use this rather than no_formal_ino in the NFS filehandles. At that point no_formal_ino will be unused.
At the same time we also add a releasepages call back to the "normal" address space for gfs2 inodes. Also I've removed a one-linrer function thats not required any more.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
29937ac6 |
| 06-Jul-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Fixes to scanning of glocks (again)
This really is the correct fix this time. We just ignore all glocks associated with inodes until the inodes are pushed from the inode cache. At that point
[GFS2] Fixes to scanning of glocks (again)
This really is the correct fix this time. We just ignore all glocks associated with inodes until the inodes are pushed from the inode cache. At that point the glocks are queued for reclaim, so we don't need to do it here.
Also fix one or two other minor bugs.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
bdd512ae |
| 22-Jun-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Remove unused flag
The flag GIF_MIN_INIT is no longer used or required.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
|
#
faf450ef |
| 22-Jun-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Remove gfs2_repermission
gfs2_repermission is just a wrapper for permission, so remove it and call permission directly where required.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
|
#
feaa7bba |
| 14-Jun-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Fix unlinked file handling
This patch fixes the way we have been dealing with unlinked, but still open files. It removes all limits (other than memory for inodes, as per every other filesyste
[GFS2] Fix unlinked file handling
This patch fixes the way we have been dealing with unlinked, but still open files. It removes all limits (other than memory for inodes, as per every other filesystem) on numbers of these which we can support on GFS2. It also means that (like other fs) its the responsibility of the last process to close the file to deallocate the storage, rather than the person who did the unlinking. Note that with GFS2, those two events might take place on different nodes.
Also there are a number of other changes:
o We use the Linux inode subsystem as it was intended to be used, wrt allocating GFS2 inodes o The Linux inode cache is now the point which we use for local enforcement of only holding one copy of the inode in core at once (previous to this we used the glock layer). o We no longer use the unlinked "special" file. We just ignore it completely. This makes unlinking more efficient. o We now use the 4th block allocation state. The previously unused state is used to track unlinked but still open inodes. o gfs2_inoded is no longer needed o Several fields are now no longer needed (and removed) from the in core struct gfs2_inode o Several fields are no longer needed (and removed) from the in core superblock
There are a number of future possible optimisations and clean ups which have been made possible by this patch.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
320dd101 |
| 18-May-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] glock debugging and inode cache changes
This adds some extra debugging to glock.c and changes inode.c's deallocation code to call the debugging code at a suitable moment. I'm chasing down a p
[GFS2] glock debugging and inode cache changes
This adds some extra debugging to glock.c and changes inode.c's deallocation code to call the debugging code at a suitable moment. I'm chasing down a particular bug to do with deallocation at the moment and the code can go again once the bug is fixed.
Also this includes the first part of some changes to unify the Linux struct inode and GFS2's struct gfs2_inode. This transformation will happen in small parts over the next short period.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
3a8a9a10 |
| 18-May-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Update copyright date to 2006
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
|
#
bd896801 |
| 18-May-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Remove semaphore.h from C files
We no longer use semaphores, everything has been converted to mutex or rwsem, so we don't need to include this header any more.
Signed-off-by: Steven Whitehou
[GFS2] Remove semaphore.h from C files
We no longer use semaphores, everything has been converted to mutex or rwsem, so we don't need to include this header any more.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
64c14ea7 |
| 16-May-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Fix ref count bug that used to bite us on umount
The ref count of certain glock's got elevated too far during unlink which caused umount to fail. This fixes it.
Signed-off-by: Steven Whiteho
[GFS2] Fix ref count bug that used to bite us on umount
The ref count of certain glock's got elevated too far during unlink which caused umount to fail. This fixes it.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
9801f646 |
| 12-May-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Remove incorrect initialisation of gh_owner
The gh_owner field shouldn't be set or reset outside the glock code. These were left over from when recursive locking was allowed. It isn't any mor
[GFS2] Remove incorrect initialisation of gh_owner
The gh_owner field shouldn't be set or reset outside the glock code. These were left over from when recursive locking was allowed. It isn't any more, so they are not needed.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
fd88de56 |
| 05-May-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Readpages support
This adds readpages support (and also corrects a small bug in the readpage error path at the same time). Hopefully this will improve performance by allowing GFS to submit la
[GFS2] Readpages support
This adds readpages support (and also corrects a small bug in the readpage error path at the same time). Hopefully this will improve performance by allowing GFS to submit larger lumps of I/O at a time.
In order to simplify the setting of BH_Boundary, it currently gets set when we hit the end of a indirect pointer block. There is always a boundary at this point with the current allocation code. It doesn't get all the boundaries right though, so there is still room for improvement in this.
See comments in fs/gfs2/ops_address.c for further information about readpages with GFS2.
Signed-off-by: Steven Whitehouse
show more ...
|
#
36327521 |
| 28-Apr-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Reordering in deallocation to avoid recursive locking
Despite my earlier careful search, there was a recursive lock left in the deallocation code. This removes it. It also should speed up dea
[GFS2] Reordering in deallocation to avoid recursive locking
Despite my earlier careful search, there was a recursive lock left in the deallocation code. This removes it. It also should speed up deallocation be reducing the number of locking operations which take place by using two "try lock" operations on the two locks involved in inode deallocation which allows us to grab the locks out of order (compared with NFS which grabs the inode lock first and the iopen lock later). It is ok for us to fail while doing this since if it does fail it means that someone else is still using the inode and thus it wouldn't be possible to deallocate anyway.
This fixes the bug reported to me by Rob Kenna.
Cc: Rob Kenna <rkenna@redhat.com> Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
190562bd |
| 20-Apr-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Fix a bug: scheduling under a spinlock
At some stage, a mutex was added to gfs2_glock_put() without checking all its call sites. Two of them were called from under a spinlock causing random d
[GFS2] Fix a bug: scheduling under a spinlock
At some stage, a mutex was added to gfs2_glock_put() without checking all its call sites. Two of them were called from under a spinlock causing random delays at various points and crashes.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
71b86f56 |
| 28-Mar-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Further updates to dir and logging code
This reduces the size of the directory code by about 3k and gets readdir() to use the functions which were introduced in the previous directory code up
[GFS2] Further updates to dir and logging code
This reduces the size of the directory code by about 3k and gets readdir() to use the functions which were introduced in the previous directory code update.
Two memory allocations are merged into one. Eliminates zeroing of some buffers which were never used before they were initialised by other data.
There is still scope for further improvement in the directory code.
On the logging side, a hand created mutex has been replaced by a standard Linux mutex in the log allocation code.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
c752666c |
| 20-Mar-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Fix bug in directory code and tidy up
Due to a typo, the dir leaf split operation was (for the first split in a directory) writing the new hash vaules at the wrong offset. This is now fixed.
[GFS2] Fix bug in directory code and tidy up
Due to a typo, the dir leaf split operation was (for the first split in a directory) writing the new hash vaules at the wrong offset. This is now fixed.
Also some other tidy ups are included:
- We use GFS2's hash function for dentries (see ops_dentry.c) so that we don't have to keep recalculating the hash values. - A lot of common code is eliminated between the various directory lookup routines. - Better error checking on directory lookup (previously different routines checked for different errors) - The leaf split operation has a couple of redundant operations removed from it, so it should be faster.
There is still further scope for further clean ups in the directory code, and readdir in particular could do with slimming down a bit.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
c9fd4307 |
| 01-Mar-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Tidy up mount code.
We no longer lookup ".gfs2_admin" in the root directory in order to find it, but instead use the inode number given in the superblock. Both the root directory and the admi
[GFS2] Tidy up mount code.
We no longer lookup ".gfs2_admin" in the root directory in order to find it, but instead use the inode number given in the superblock. Both the root directory and the admin directory are now looked up using the same routine, so the redundant code is removed.
Also, there is no longer a reference to the root inode in the GFS2 super block. When required this can be retreived via sb->s_root->d_inode instead.
Assuming that we introduce a metadata filesystem type for GFS, then this is a first step towards that goal.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
5c676f6d |
| 27-Feb-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Macros removal in gfs2.h
As suggested by Pekka Enberg <penberg@cs.helsinki.fi>.
The DIV_RU macro is renamed DIV_ROUND_UP and and moved to kernel.h The other macros are gone from gfs2.h as (a
[GFS2] Macros removal in gfs2.h
As suggested by Pekka Enberg <penberg@cs.helsinki.fi>.
The DIV_RU macro is renamed DIV_ROUND_UP and and moved to kernel.h The other macros are gone from gfs2.h as (although not requested by Pekka Enberg) are a number of included header file which are now included individually. The inode number comparison function is now an inline function.
The DT2IF and IF2DT may be addressed in a future patch.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
568f4c96 |
| 27-Feb-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] 80 Column audit of GFS2
Requested by: Prarit Bhargava <prarit@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
|
#
f55ab26a |
| 21-Feb-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Use mutices rather than semaphores
As well as a number of minor bug fixes, this patch changes GFS to use mutices rather than semaphores. This results in better information in case there are a
[GFS2] Use mutices rather than semaphores
As well as a number of minor bug fixes, this patch changes GFS to use mutices rather than semaphores. This results in better information in case there are any locking problems.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
7359a19c |
| 13-Feb-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Fix for root inode ref count bug
Umount is now working correctly again. The bug was due to not getting an extra ref count when mounting the fs. We should have bumped it by two (once for the i
[GFS2] Fix for root inode ref count bug
Umount is now working correctly again. The bug was due to not getting an extra ref count when mounting the fs. We should have bumped it by two (once for the internal pointer to the root inode from the super block and once for the inode hanging off the dcache entry for root).
Also this patch tidys up the code dealing with looking up and creating inodes. We now pass Linux inodes (with gfs2_inodes attached) rather than the other way around and this reduces code duplication in various places.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
f42faf4f |
| 30-Jan-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Add gfs2_internal_read()
Add the new external read function. Its temporarily in jdata.c even though the protoype is in ops_file.h - this will change shortly. The current implementation will c
[GFS2] Add gfs2_internal_read()
Add the new external read function. Its temporarily in jdata.c even though the protoype is in ops_file.h - this will change shortly. The current implementation will change to a page cache one when that happens.
In order to effect the above changes, the various internal inodes now have Linux inodes attached to them. We keep the references to the Linux inodes, rather than the gfs2_inodes in the super block.
In order to get everything to work correctly I've had to reorder the init sequence on mount (which I should probably have done earlier when .gfs2_admin was made visible).
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|
#
2442a098 |
| 30-Jan-2006 |
Steven Whitehouse <swhiteho@redhat.com> |
[GFS2] Bug fix relating to endian conversion in inode.c
A two line fix to get endian conversion correct.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
|
#
d4e9c4c3 |
| 18-Jan-2006 |
Steven Whitehouse <steve@chygwyn.com> |
[GFS2] Add an additional argument to gfs2_trans_add_bh()
This adds an extra argument to gfs2_trans_add_bh() to indicate whether the bh being added to the transaction is metadata or data. Its current
[GFS2] Add an additional argument to gfs2_trans_add_bh()
This adds an extra argument to gfs2_trans_add_bh() to indicate whether the bh being added to the transaction is metadata or data. Its currently unused since all existing callers set it to 1 (metadata) but following patches will make use of it.
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
show more ...
|