#
1bcb5619 |
| 17-Apr-2013 |
Adheer Chandravanshi <adheer.chandravanshi@qlogic.com> |
[SCSI] qla4xxx: Fix smatch warnings
Fix following smatch warnings:- drivers/scsi/qla4xxx/ql4_os.c:6573 qla4xxx_sysfs_ddb_set_param() warn: possible memory leak of 'fw_ddb_entry' drivers/scsi/qla4xxx
[SCSI] qla4xxx: Fix smatch warnings
Fix following smatch warnings:- drivers/scsi/qla4xxx/ql4_os.c:6573 qla4xxx_sysfs_ddb_set_param() warn: possible memory leak of 'fw_ddb_entry' drivers/scsi/qla4xxx/ql4_os.c:6596 qla4xxx_sysfs_ddb_delete() warn: variable dereferenced before check 'fnode_sess' (see line 6584) drivers/scsi/qla4xxx/ql4_os.c:6632 qla4xxx_sysfs_ddb_delete() error: potential NULL dereference 'fw_ddb_entry'.
Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
#
28e02f1a |
| 17-Apr-2013 |
Vikas Chaudhary <vikas.chaudhary@qlogic.com> |
[SCSI] qla4xxx: Fix sparse warning for qla4xxx_sysfs_ddb_tgt_create
Fix following warning: drivers/scsi/qla4xxx/ql4_os.c:5507:5: warning: symbol 'qla4xxx_sysfs_ddb_tgt_create' was not declared. Shou
[SCSI] qla4xxx: Fix sparse warning for qla4xxx_sysfs_ddb_tgt_create
Fix following warning: drivers/scsi/qla4xxx/ql4_os.c:5507:5: warning: symbol 'qla4xxx_sysfs_ddb_tgt_create' was not declared. Should it be static?
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
#
b6130cea |
| 17-Apr-2013 |
Vikas Chaudhary <vikas.chaudhary@qlogic.com> |
[SCSI] qla4xxx: Silence gcc warning
Fix followig gcc warning:- drivers/scsi/qla4xxx/ql4_os.c: In function ‘qla4xxx_sysfs_ddb_get_param’: drivers/scsi/qla4xxx/ql4_os.c:6279: warning: comparison is al
[SCSI] qla4xxx: Silence gcc warning
Fix followig gcc warning:- drivers/scsi/qla4xxx/ql4_os.c: In function ‘qla4xxx_sysfs_ddb_get_param’: drivers/scsi/qla4xxx/ql4_os.c:6279: warning: comparison is always true due to limited range of data type drivers/scsi/qla4xxx/ql4_os.c:6290: warning: comparison is always true due to limited range of data type drivers/scsi/qla4xxx/ql4_os.c: In function ‘qla4xxx_sysfs_ddb_delete’: drivers/scsi/qla4xxx/ql4_os.c:6593: warning: ‘ddb_size’ may be used uninitialized in this function
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
Revision tags: v3.9-rc7, v3.9-rc6 |
|
#
a957a7d7 |
| 05-Apr-2013 |
Adheer Chandravanshi <adheer.chandravanshi@qlogic.com> |
[SCSI] qla4xxx: Use correct value for max flash node entries
Use correct value for max flash node entries supported based on adapter type.
Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi@
[SCSI] qla4xxx: Use correct value for max flash node entries
Use correct value for max flash node entries supported based on adapter type.
Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
#
37719c2a |
| 05-Apr-2013 |
Adheer Chandravanshi <adheer.chandravanshi@qlogic.com> |
[SCSI] qla4xxx: Restrict logout from boot target session using session id
Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic
[SCSI] qla4xxx: Restrict logout from boot target session using session id
Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
#
039acc1e |
| 05-Apr-2013 |
Adheer Chandravanshi <adheer.chandravanshi@qlogic.com> |
[SCSI] qla4xxx: Use correct flash ddb offset for ISP40XX
Use correct flash ddb offset to add and delete flash target entries for ISP40XX
Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi@ql
[SCSI] qla4xxx: Use correct flash ddb offset for ISP40XX
Use correct flash ddb offset to add and delete flash target entries for ISP40XX
Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
Revision tags: v3.9-rc5 |
|
#
c962c18b |
| 25-Mar-2013 |
Adheer Chandravanshi <adheer.chandravanshi@qlogic.com> |
[SCSI] qla4xxx: Replace dev type macros with generic portal type macros
Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.c
[SCSI] qla4xxx: Replace dev type macros with generic portal type macros
Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
Revision tags: v3.9-rc4 |
|
#
1e9e2be3 |
| 22-Mar-2013 |
Adheer Chandravanshi <adheer.chandravanshi@qlogic.com> |
[SCSI] qla4xxx: Add flash node mgmt support
This patch allows iscsiadm to manage iSCSI target information stored on qla4xxx adapter flash on per host basis.
Signed-off-by: Adheer Chandravanshi <adh
[SCSI] qla4xxx: Add flash node mgmt support
This patch allows iscsiadm to manage iSCSI target information stored on qla4xxx adapter flash on per host basis.
Signed-off-by: Adheer Chandravanshi <adheer.chandravanshi@qlogic.com> Signed-off-by: Manish Rangankar <manish.rangankar@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
#
17801c96 |
| 22-Mar-2013 |
Nilesh Javali <nilesh.javali@qlogic.com> |
[SCSI] qla4xxx: Skip retry of initialize_adapter for ISP80XX
While probe Skip retry of initialize_adapter only for ISP82XX and ISP83XX. We need to retry initialize_adapter for ISP40XX.
Signed-off-b
[SCSI] qla4xxx: Skip retry of initialize_adapter for ISP80XX
While probe Skip retry of initialize_adapter only for ISP82XX and ISP83XX. We need to retry initialize_adapter for ISP40XX.
Signed-off-by: Nilesh Javali <nilesh.javali@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
#
d11b0ca3 |
| 22-Mar-2013 |
Vikas Chaudhary <vikas.chaudhary@qlogic.com> |
[SCSI] qla4xxx: Added missing check for ISP83XX in CHAP related functions
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by:
[SCSI] qla4xxx: Added missing check for ISP83XX in CHAP related functions
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
Revision tags: v3.9-rc3, v3.9-rc2 |
|
#
a24058f9 |
| 07-Mar-2013 |
Tej Parkash <tej.parkash@qlogic.com> |
[SCSI] qla4xxx: Fixed request queue count manipulation on response path
Issue: Request queue count holds the information about free space in request queue which has to be manipulated based on reques
[SCSI] qla4xxx: Fixed request queue count manipulation on response path
Issue: Request queue count holds the information about free space in request queue which has to be manipulated based on request in and out pointer. But in driver response path, this count was incremented unconditionally, which could move req_in pointer beyond req_out pointer. This scenario leads fw hang during IO.
Solution: Request queue count manipulation has to be done in IO path only, keeping req_in and req_out pointer two IOCB count away
Signed-off-by: Tej Parkash <tej.parkash@qlogic.com> Signed-off-by: Shyam Sundar <shyam.sundar@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
#
6cf94121 |
| 07-Mar-2013 |
Vikas Chaudhary <vikas.chaudhary@qlogic.com> |
[SCSI] qla4xxx: Fix double reset in case of firmware hung for ISP83XX
In case of firmware hung we need to call "mailbox_premature_completion" to complete any pending mbox command as firmware is not
[SCSI] qla4xxx: Fix double reset in case of firmware hung for ISP83XX
In case of firmware hung we need to call "mailbox_premature_completion" to complete any pending mbox command as firmware is not alive.
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
#
ebd777de |
| 07-Mar-2013 |
Vikas Chaudhary <vikas.chaudhary@qlogic.com> |
[SCSI] qla4xxx: Set graceful reset bit for ISP83XX
For ISP83XX set graceful reset bit in IDC_DRV_CTRL if reset is issued by application
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> S
[SCSI] qla4xxx: Set graceful reset bit for ISP83XX
For ISP83XX set graceful reset bit in IDC_DRV_CTRL if reset is issued by application
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
#
3e788fb1 |
| 07-Mar-2013 |
Vikas Chaudhary <vikas.chaudhary@qlogic.com> |
[SCSI] qla4xxx: Boot from SAN fix for ISP83XX
Issue: ISP83XX check is missing in function get_fw_boot_info() because of this qla4xxx will not export boot target to sysfs and iscsistart cannot issue
[SCSI] qla4xxx: Boot from SAN fix for ISP83XX
Issue: ISP83XX check is missing in function get_fw_boot_info() because of this qla4xxx will not export boot target to sysfs and iscsistart cannot issue login to boot target.
Fix: Added check for ISP83XX in function get_fw_boot_info()
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
Revision tags: v3.9-rc1, v3.8, v3.8-rc7, v3.8-rc6, v3.8-rc5 |
|
#
c7a5e0d0 |
| 20-Jan-2013 |
Manish Rangankar <manish.rangankar@qlogic.com> |
[SCSI] qla4xxx: Fix return code for qla4xxx_session_get_param.
While reading sysfs chap_in_idx and chap_out_idx attribute, if chap authentication is not set we get an error as "Invalid argument".
S
[SCSI] qla4xxx: Fix return code for qla4xxx_session_get_param.
While reading sysfs chap_in_idx and chap_out_idx attribute, if chap authentication is not set we get an error as "Invalid argument".
Signed-off-by: Manish Rangankar <manish.rangankar@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
#
1dc8ed5d |
| 20-Jan-2013 |
Manish Rangankar <manish.rangankar@qlogic.com> |
[SCSI] qla4xxx: wait for boot target login response during probe.
Boot from SAN fails in some cases where boot target login response is slow. In this case, probe finishes early and triggers init, wh
[SCSI] qla4xxx: wait for boot target login response during probe.
Boot from SAN fails in some cases where boot target login response is slow. In this case, probe finishes early and triggers init, which doesn't find remote disk to mount root which leads to BFS failure.
Signed-off-by: Manish Rangankar <manish.rangankar@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
#
137257da |
| 20-Jan-2013 |
Poornima Vonti <poornima.vonti@qlogic.com> |
[SCSI] qla4xxx: Re-register IRQ handler while retrying initialize of adapter
Problem: If initialization of adapter fails for some reason, then the interrupt handlers are released. The interrupt hand
[SCSI] qla4xxx: Re-register IRQ handler while retrying initialize of adapter
Problem: If initialization of adapter fails for some reason, then the interrupt handlers are released. The interrupt handlers are not registered again when initialization of adapter is retried.
Solution: Re-register the interrupt handler when adapter initialization is retried.
Signed-off-by: Poornima Vonti <poornima.vonti@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
#
026fbd3a |
| 20-Jan-2013 |
Nilesh Javali <nilesh.javali@qlogic.com> |
[SCSI] qla4xxx: Quiesce driver activities while loopback
Quiesce all different activities performed by driver upon the link events while loopback diagnostics is in progress.
Signed-off-by: Nilesh J
[SCSI] qla4xxx: Quiesce driver activities while loopback
Quiesce all different activities performed by driver upon the link events while loopback diagnostics is in progress.
Signed-off-by: Nilesh Javali <nilesh.javali@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
Revision tags: v3.8-rc4, v3.8-rc3, v3.8-rc2 |
|
#
e951aca1 |
| 29-Dec-2012 |
Vikas Chaudhary <vikas.chaudhary@qlogic.com> |
[SCSI] qla4xxx: Pass correct function param to qla4_8xxx_rd_direct
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James
[SCSI] qla4xxx: Pass correct function param to qla4_8xxx_rd_direct
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Reviewed-by: Mike Christie <michaelc@cs.wisc.edu> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
Revision tags: v3.8-rc1, v3.7, v3.7-rc8, v3.7-rc7 |
|
#
3dd4849c |
| 23-Nov-2012 |
Manish Rangankar <manish.rangankar@qlogic.com> |
[SCSI] qla4xxx: Fix memory corruption issue in qla4xxx_get_ep_fwdb.
In qla4xxx_get_ep_fwdb(), dst_addr is of type struct sockaddr. We are copying sizeof(struct sockaddr_in6) bytes to dst_addr which
[SCSI] qla4xxx: Fix memory corruption issue in qla4xxx_get_ep_fwdb.
In qla4xxx_get_ep_fwdb(), dst_addr is of type struct sockaddr. We are copying sizeof(struct sockaddr_in6) bytes to dst_addr which is 12 bytes larger. This will cause memory corruption. So we change dst_addr to struct sockaddr_storage which is of 128 byte, large enough to hold sizeof(struct sockaddr_in6).
Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Manish Rangankar <manish.rangankar@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
#
ad5da8c4 |
| 23-Nov-2012 |
Harish Zunjarrao <harish.zunjarrao@qlogic.com> |
[SCSI] qla4xxx: Allow reset in link down case
Issue: Reset operation fails if port is in Link Down state
Fix: Do not wait till HBA comes online after reset command is invoked.
Signed-off-by: Haris
[SCSI] qla4xxx: Allow reset in link down case
Issue: Reset operation fails if port is in Link Down state
Fix: Do not wait till HBA comes online after reset command is invoked.
Signed-off-by: Harish Zunjarrao <harish.zunjarrao@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
#
5c19b92a |
| 23-Nov-2012 |
Vikas Chaudhary <vikas.chaudhary@qlogic.com> |
[SCSI] qla4xxx: Fix MBOX intr switching from polling to intr mode for ISP83XX
Issue: Mailbox command timed out after switching from polling mode to interrupt mode.
Events:- 1. Mailbox interrupts a
[SCSI] qla4xxx: Fix MBOX intr switching from polling to intr mode for ISP83XX
Issue: Mailbox command timed out after switching from polling mode to interrupt mode.
Events:- 1. Mailbox interrupts are disabled 2. FW generates AEN and at same time driver enables Mailbox Interrupt 3. Driver issues new mailbox to Firmware
In above case driver will not get AEN interrupts generated by FW in step #2 as FW generated this AEN when interrupts are disabled. During the same time driver enabled the mailbox interrupt, so driver will not poll for interrupt. Driver will never process AENs generated in step #2 and issues new mailbox to FW, but now FW is not able to post mailbox completion as AENs generated before are not processed by driver.
Fix: Enable Mailbox / AEN interrupts before initializing FW in case of ISP83XX. This will make sure we process all Mailbox and AENs in interrupt mode.
Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
#
6f039790 |
| 21-Dec-2012 |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
Drivers: scsi: remove __dev* attributes.
CONFIG_HOTPLUG is going away as an option. As a result, the __dev* markings need to be removed.
This change removes the use of __devinit, __devexit_p, __de
Drivers: scsi: remove __dev* attributes.
CONFIG_HOTPLUG is going away as an option. As a result, the __dev* markings need to be removed.
This change removes the use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit from these drivers.
Based on patches originally written by Bill Pemberton, but redone by me in order to handle some of the coding style issues better, by hand.
Cc: Bill Pemberton <wfp5p@virginia.edu> Cc: Adam Radford <linuxraid@lsi.com> Cc: "James E.J. Bottomley" <JBottomley@parallels.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
show more ...
|
Revision tags: v3.7-rc6, v3.7-rc5, v3.7-rc4, v3.7-rc3, v3.7-rc2, v3.7-rc1, v3.6, v3.6-rc7 |
|
#
546fef27 |
| 20-Sep-2012 |
Tej Parkash <tej.parkash@qlogic.com> |
[SCSI] qla4xxx: Disable generating pause frames for ISP83XX
In case of FW hung ISP83XX generates continuous pause frames which causes switch to disable port. Added fix to disable generating pause fr
[SCSI] qla4xxx: Disable generating pause frames for ISP83XX
In case of FW hung ISP83XX generates continuous pause frames which causes switch to disable port. Added fix to disable generating pause frames in case of FW hung
Signed-off-by: Tej Parkash <tej.parkash@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|
#
320a61de |
| 20-Sep-2012 |
Nilesh Javali <nilesh.javali@qlogic.com> |
[SCSI] qla4xxx: IDC implementation for Loopback
Handle IDC Request Notify AEN and post IDC Acknowledgement while participating in Loopback IDC.
Signed-off-by: Nilesh Javali <nilesh.javali@qlogic.co
[SCSI] qla4xxx: IDC implementation for Loopback
Handle IDC Request Notify AEN and post IDC Acknowledgement while participating in Loopback IDC.
Signed-off-by: Nilesh Javali <nilesh.javali@qlogic.com> Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com>
show more ...
|