History log of /openbmc/libpldm/src/requester/ (Results 26 – 31 of 31)
Revision Date Author Comments
(<<< Hide modified files)
(Show modified files >>>)
6005f1c805-Apr-2023 Andrew Jeffery <andrew@aj.id.au>

clang-tidy: Fix readability-identifier-naming diagnostic

For example:

```
/usr/bin/clang-tidy -checks=-*, readability-identifier-naming -export-fixes /tmp/tmpsjbxtnss/tmpbj5pbywt.yaml -p=build /mnt

clang-tidy: Fix readability-identifier-naming diagnostic

For example:

```
/usr/bin/clang-tidy -checks=-*, readability-identifier-naming -export-fixes /tmp/tmpsjbxtnss/tmpbj5pbywt.yaml -p=build /mnt/host/andrew/src/openbmc/libpldm/src/platform.c
/mnt/host/andrew/src/openbmc/libpldm/build/../include/libpldm/pdr.h:166:6: error: invalid case style for function 'pldm_pdr_update_TL_pdr' [readability-identifier-naming,-warnings-as-errors]
void pldm_pdr_update_TL_pdr(const pldm_pdr *repo, uint16_t terminusHandle,
^~~~~~~~~~~~~~~~~~~~~~
pldm_pdr_update_tl_pdr
/mnt/host/andrew/src/openbmc/libpldm/build/../include/libpldm/pdr.h:166:60: error: invalid case style for parameter 'terminusHandle' [readability-identifier-naming,-warnings-as-errors]
void pldm_pdr_update_TL_pdr(const pldm_pdr *repo, uint16_t terminusHandle,
^~~~~~~~~~~~~~
terminus_handle
/mnt/host/andrew/src/openbmc/libpldm/build/../include/libpldm/pdr.h:167:29: error: invalid case style for parameter 'tlEid' [readability-identifier-naming,-warnings-as-errors]
uint8_t tid, uint8_t tlEid, bool valid);
^~~~~
tl_eid
```

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I6419dade685ee656fe773451148f15aefb20becd

show more ...

1e0528c205-Apr-2023 Andrew Jeffery <andrew@aj.id.au>

clang-tidy: Fix readability-else-after-return diagnostics

```
/usr/bin/clang-tidy -checks=-*, readability-else-after-return -export-fixes /tmp/tmp4f2o40d3/tmp18pyt1xg.yaml -p=build /mnt/host/andrew/

clang-tidy: Fix readability-else-after-return diagnostics

```
/usr/bin/clang-tidy -checks=-*, readability-else-after-return -export-fixes /tmp/tmp4f2o40d3/tmp18pyt1xg.yaml -p=build /mnt/host/andrew/src/openbmc/libpldm/src/requester/pldm.c
/mnt/host/andrew/src/openbmc/libpldm/build/../src/requester/pldm.c:64:4: error: do not use 'else' after 'return' [readability-else-after-return,-warnings-as-errors]
} else if (length < min_len) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
```

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I43dd1da00ed3192cccaf1001e2eb6031cee12a27

show more ...

b705fb0a05-Apr-2023 Andrew Jeffery <andrew@aj.id.au>

clang-tidy: Fix bugprone-narrowing-conversion diagnostic

```
/usr/bin/clang-tidy -checks=-*, bugprone-narrowing-conversions -export-fixes /tmp/tmp9pcdq4bf/tmpulhoe1tp.yaml -p=build /mnt/host/andrew/

clang-tidy: Fix bugprone-narrowing-conversion diagnostic

```
/usr/bin/clang-tidy -checks=-*, bugprone-narrowing-conversions -export-fixes /tmp/tmp9pcdq4bf/tmpulhoe1tp.yaml -p=build /mnt/host/andrew/src/openbmc/libpldm/src/requester/pldm.c
../src/requester/pldm.c:32:7: error: narrowing conversion from 'ssize_t' (aka 'long') to signed type 'int' is implementation-defined [bugprone-narrowing-conversions,-warnings-as-errors]
rc = write(fd, &MCTP_MSG_TYPE_PLDM, sizeof(MCTP_MSG_TYPE_PLDM));
^
```

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I95e70d4692dd57d87216e75adb9ac26ab4b96bb9

show more ...

319304fd04-Apr-2023 Andrew Jeffery <andrew@aj.id.au>

clang-tidy: Fix clang-diagnostic-strict-prototypes diagnostics

Produces output such as:

```
/usr/bin/clang-tidy -checks=-*, bugprone-branch-clone -export-fixes /tmp/tmpjjns4w4i/tmp2vh08b10.yaml -p=

clang-tidy: Fix clang-diagnostic-strict-prototypes diagnostics

Produces output such as:

```
/usr/bin/clang-tidy -checks=-*, bugprone-branch-clone -export-fixes /tmp/tmpjjns4w4i/tmp2vh08b10.yaml -p=build /mnt/host/andrew/src/openbmc/libpldm/src/platform.c
/mnt/host/andrew/src/openbmc/libpldm/build/../include/libpldm/pdr.h:35:24: error: a function declaration without a prototype is deprecated in all versions of C [clang-diagnostic-strict-prototypes]
pldm_pdr *pldm_pdr_init();
^
void
```

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ib9b679682cc25b8c1b294d2be856031f77d755d9

show more ...

9a8e497528-Nov-2022 Manojkiran Eda <manojkiran.eda@gmail.com>

Fix includes using iwyu tool

These changes are done by running iwyu manually under clang14.

IWYU can increase readability, make maintenance easier, and avoid errors
in some cases. See details in
``

Fix includes using iwyu tool

These changes are done by running iwyu manually under clang14.

IWYU can increase readability, make maintenance easier, and avoid errors
in some cases. See details in
```
https: //github.com/include-what-you-use/include-what-you-use/blob/master/docs/WhyIWYU.md.
```
Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: Idaaeffd78c9ad7db2b41a057d40f889ade297c55

show more ...

9c76679210-Aug-2022 Andrew Jeffery <andrew@aj.id.au>

libpldm: Migrate to subproject

Organize files in libpldm to make it a subproject

In the current state, libpldm is not readily consumable
as a subproject.This commit does all the necessary re-organi

libpldm: Migrate to subproject

Organize files in libpldm to make it a subproject

In the current state, libpldm is not readily consumable
as a subproject.This commit does all the necessary re-organisation
of the source code to make it work as a subproject.

There are no .c/.h files changes in this commit, only meson
changes and re-organising the code structure.

Signed-off-by: Manojkiran Eda <manojkiran.eda@gmail.com>
Change-Id: I20a71c0c972b1fd81fb359d604433618799102c6

show more ...


/openbmc/libpldm/.clang-format
/openbmc/libpldm/LICENSE
/openbmc/libpldm/include/libpldm/base.h
/openbmc/libpldm/include/libpldm/bios.h
/openbmc/libpldm/include/libpldm/bios_table.h
/openbmc/libpldm/include/libpldm/entity.h
/openbmc/libpldm/include/libpldm/firmware_update.h
/openbmc/libpldm/include/libpldm/fru.h
/openbmc/libpldm/include/libpldm/meson.build
/openbmc/libpldm/include/libpldm/oem/ibm/libpldm/entity_oem_ibm.h
/openbmc/libpldm/include/libpldm/oem/ibm/libpldm/file_io.h
/openbmc/libpldm/include/libpldm/oem/ibm/libpldm/fru_oem_ibm.h
/openbmc/libpldm/include/libpldm/oem/ibm/libpldm/host.h
/openbmc/libpldm/include/libpldm/oem/ibm/libpldm/platform_oem_ibm.h
/openbmc/libpldm/include/libpldm/oem/ibm/libpldm/state_set_oem_ibm.h
/openbmc/libpldm/include/libpldm/pdr.h
/openbmc/libpldm/include/libpldm/platform.h
/openbmc/libpldm/include/libpldm/pldm.h
/openbmc/libpldm/include/libpldm/pldm_types.h
/openbmc/libpldm/include/libpldm/requester/pldm.h
/openbmc/libpldm/include/libpldm/state_set.h
/openbmc/libpldm/include/libpldm/states.h
/openbmc/libpldm/include/libpldm/utils.h
/openbmc/libpldm/libpldm.pc.in
/openbmc/libpldm/meson.build
/openbmc/libpldm/meson_options.txt
/openbmc/libpldm/src/base.c
/openbmc/libpldm/src/bios.c
/openbmc/libpldm/src/bios_table.c
/openbmc/libpldm/src/firmware_update.c
/openbmc/libpldm/src/fru.c
/openbmc/libpldm/src/meson.build
/openbmc/libpldm/src/oem/ibm/file_io.c
/openbmc/libpldm/src/oem/ibm/host.c
/openbmc/libpldm/src/oem/ibm/meson.build
/openbmc/libpldm/src/oem/ibm/platform.c
/openbmc/libpldm/src/pdr.c
/openbmc/libpldm/src/platform.c
meson.build
pldm.c
/openbmc/libpldm/src/utils.c
/openbmc/libpldm/subprojects/googletest.wrap
/openbmc/libpldm/tests/.clang-format
/openbmc/libpldm/tests/libpldm_base_test.cpp
/openbmc/libpldm/tests/libpldm_bios_table_test.cpp
/openbmc/libpldm/tests/libpldm_bios_test.cpp
/openbmc/libpldm/tests/libpldm_firmware_update_test.cpp
/openbmc/libpldm/tests/libpldm_fru_test.cpp
/openbmc/libpldm/tests/libpldm_pdr_test.cpp
/openbmc/libpldm/tests/libpldm_platform_test.cpp
/openbmc/libpldm/tests/libpldm_utils_test.cpp
/openbmc/libpldm/tests/meson.build
/openbmc/libpldm/tests/oem/ibm/libpldm_fileio_test.cpp
/openbmc/libpldm/tests/oem/ibm/libpldm_host_test.cpp

12