6896d41e | 10-Mar-2020 |
Andrew Jeffery <andrew@aj.id.au> |
mctp-demux-daemon: Silence warnings on remote close
If applications constantly connect then disconnect from the demux daemon we see a "flood" of messages like:
Mar 05 07:15:47 w57 mctp-demux[17
mctp-demux-daemon: Silence warnings on remote close
If applications constantly connect then disconnect from the demux daemon we see a "flood" of messages like:
Mar 05 07:15:47 w57 mctp-demux[177]: mctp-demux-daemon: can't receive(peek) from client: Connection reset by peer Mar 05 07:15:52 w57 mctp-demux[177]: mctp-demux-daemon: can't receive(peek) from client: Connection reset by peer Mar 05 07:15:52 w57 mctp-demux[177]: mctp-demux-daemon: can't receive(peek) from client: Connection reset by peer Mar 05 07:15:53 w57 mctp-demux[177]: mctp-demux-daemon: can't receive(peek) from client: Connection reset by peer Mar 05 07:15:54 w57 mctp-demux[177]: mctp-demux-daemon: can't receive(peek) from client: Connection reset by peer
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I99eabffd45693e5ab570575c4c8cca2ee55196e0
show more ...
|
13a4041f | 07-Feb-2020 |
Andrew Jeffery <andrew@aj.id.au> |
mctp-demux-daemon: Resolve uninitialised variable warning
Multiple error paths in client_process_recv() failed to set rc before returning it from the out_close label:
utils/mctp-demux-daemon.c:
mctp-demux-daemon: Resolve uninitialised variable warning
Multiple error paths in client_process_recv() failed to set rc before returning it from the out_close label:
utils/mctp-demux-daemon.c: In function ‘main’: utils/mctp-demux-daemon.c:457:7: error: ‘rc’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 457 | if (rc) | ^ utils/mctp-demux-daemon.c:307:6: note: ‘rc’ was declared here 307 | int rc; | ^~ cc1: all warnings being treated as errors
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I4196a2b5f7b242c53921040fead102525c92a286
show more ...
|
04b81fc7 | 04-Feb-2020 |
Andrew Jeffery <andrew@aj.id.au> |
mctp-demux-daemon: Explicitly disable verbose before option parsing
Otherwise we have control flow dependent on uninitialised data.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I0d9e5
mctp-demux-daemon: Explicitly disable verbose before option parsing
Otherwise we have control flow dependent on uninitialised data.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I0d9e5512ce198ceddf8fb7a09d15c8de991d0dbd
show more ...
|
8676c934 | 23-Jan-2020 |
Andrew Jeffery <andrew@aj.id.au> |
mctp-demux-daemon: Fix erroneous call to memset()
Detected with CFLAGS="-Wall -Werror":
utils/mctp-demux-daemon.c: In function ‘socket_process’: utils/mctp-demux-daemon.c:294:26: error: argument to
mctp-demux-daemon: Fix erroneous call to memset()
Detected with CFLAGS="-Wall -Werror":
utils/mctp-demux-daemon.c: In function ‘socket_process’: utils/mctp-demux-daemon.c:294:26: error: argument to ‘sizeof’ in ‘memset’ call is the same expression as the destination; did you mean to dereference it? [-Werror=sizeof-pointer-memaccess] 294 | memset(client, 0, sizeof(client)); | ^ cc1: all warnings being treated as errors
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Ifc78c83858804c2145f93b0df3924404a3a6a51a
show more ...
|
34b9b3d8 | 26-Nov-2019 |
Jeremy Kerr <jk@ozlabs.org> |
demux-daemon: Add a 'null' binding option
For cases where we don't have a specific hardware configuration available (eg., a platform-independent OpenBMC recipe), we want a provision to run the demux
demux-daemon: Add a 'null' binding option
For cases where we don't have a specific hardware configuration available (eg., a platform-independent OpenBMC recipe), we want a provision to run the demux daemon without specific hardware dependencies.
This change introduces a null binding for mctp-demux-daemon, in order to allow a hardware-neutral daemon process to be run.
Change-Id: I1d9e66f3c4b636f9160eb2fa31d547ca4add7f7a Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
show more ...
|
3b36d17c | 03-Sep-2019 |
Jeremy Kerr <jk@ozlabs.org> |
API: Add binding accessors to generic struct mctp_binding
Rather than have every binding include their own wrappers around binding<->core functions, introduce an accessor to retrieve the struct mctp
API: Add binding accessors to generic struct mctp_binding
Rather than have every binding include their own wrappers around binding<->core functions, introduce an accessor to retrieve the struct mctp_binding from each.
This means we no longer need the binding-specific registration callbacks. However, we do now need a ->start callback, to allow bindings to perform post-registration init.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org> Change-Id: I6cee9e93f37520f85c155a0ca34017cc0675552c
show more ...
|
bc53d35a | 28-Aug-2019 |
Jeremy Kerr <jk@ozlabs.org> |
astlpc: abstract hardware interactions to allow a non-fileio-based implementation
Currently, the astlpc binding assumes a particular method of access to the KCS and LPC interfaces, using reads and w
astlpc: abstract hardware interactions to allow a non-fileio-based implementation
Currently, the astlpc binding assumes a particular method of access to the KCS and LPC interfaces, using reads and writes to a pair of Linux devices.
We want to be able to use the astlpc binding in different environments, possibly not backed by file IO. This change adds an interface to provide custom operations to read and write the KCS and LPC state.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org> Change-Id: I3e403a025760657a7264098f5486f046e3ac436b
show more ...
|
f49b2ac8 | 02-Aug-2019 |
Jeremy Kerr <jk@ozlabs.org> |
mctp-demux-daemon: don't limit message sizes
Signed-off-by: Jeremy Kerr <jk@ozlabs.org> Change-Id: I3e13de50d086dddcb4f5c7d40bdcd24687f63f07 |
d690d8ea | 01-Aug-2019 |
Jeremy Kerr <jk@ozlabs.org> |
mctp-demux-daemon: fix eid in log message
Signed-off-by: Jeremy Kerr <jk@ozlabs.org> Change-Id: If1337e896a58784f4ba7a55f3dee6b37e28662d3 |
195a7c5e | 24-Jun-2019 |
Jeremy Kerr <jk@ozlabs.org> |
demux-daemon: Add support for loopback messages
If a demux client sends a message addressed to the local EID, loop it back to other clients.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org> Change-Id: I6
demux-daemon: Add support for loopback messages
If a demux client sends a message addressed to the local EID, loop it back to other clients.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org> Change-Id: I6ae4720688d6ad3e50793f1d74aa50259797649e
show more ...
|
0b278a63 | 30-May-2019 |
Jeremy Kerr <jk@ozlabs.org> |
demux-daemon: Set libmctp logging parameters
Just log to stderr, using --verbose to set the level.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org> |
3d36ee2e | 29-May-2019 |
Jeremy Kerr <jk@ozlabs.org> |
LICENSE: add GPLv2 license option.
As per the MCTP design document (https://github.com/openbmc/docs/blob/master/designs/mctp.md), a dual-licence (GPLv2+ and Apache-2.0) gives us flexibility with inc
LICENSE: add GPLv2 license option.
As per the MCTP design document (https://github.com/openbmc/docs/blob/master/designs/mctp.md), a dual-licence (GPLv2+ and Apache-2.0) gives us flexibility with including libcmtp code into various firmware environments.
This change adds GPLv2+ as a license option. All current contributors have agreed to this change.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
show more ...
|
8e31cfd1 | 07-May-2019 |
Jeremy Kerr <jk@ozlabs.org> |
utils: Add a demultiplexer daemon
As described by https://github.com/openbmc/docs/commit/bef44633c6, this change adds a MCTP multiplexer daemon, allowing clients to register for receiving messages
utils: Add a demultiplexer daemon
As described by https://github.com/openbmc/docs/commit/bef44633c6, this change adds a MCTP multiplexer daemon, allowing clients to register for receiving messages of a specific type.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
show more ...
|
672c8852 | 28-Feb-2019 |
Jeremy Kerr <jk@ozlabs.org> |
bindings: AST LPC binding implementation
Add a binding implementation for the ASPEED 2500 LPC + KCS devices. While not a standard, this does give us a hardware binding implementation to use on curre
bindings: AST LPC binding implementation
Add a binding implementation for the ASPEED 2500 LPC + KCS devices. While not a standard, this does give us a hardware binding implementation to use on current hardware.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
show more ...
|
bd4e3628 | 13-Mar-2019 |
Jeremy Kerr <jk@ozlabs.org> |
utils: move small utilities from tests/ dir to utils/
We want to start building up tests under tests, and the current contents are more utilities.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org> |