129ef93c | 22-May-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_astlpc: Introduce astlpc_assert_tx_packet()
astlpc_assert_tx_packet() is a quick test to ensure the expected packet has been enqueued on the interface.
Signed-off-by: Andrew Jeffery <andrew@aj
test_astlpc: Introduce astlpc_assert_tx_packet()
astlpc_assert_tx_packet() is a quick test to ensure the expected packet has been enqueued on the interface.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I5ef818bcfc4537329a590e0c3023eb3d22db2c05
show more ...
|
cb5d55cc | 21-May-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_astlpc: Add network_{init,destroy}() helpers
Make it easy to set up two endpoints that have completed the binding initialisation sequence and a ready to send messages.
Signed-off-by: Andrew Je
test_astlpc: Add network_{init,destroy}() helpers
Make it easy to set up two endpoints that have completed the binding initialisation sequence and a ready to send messages.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I0efa8fdd69e1635adfa84823ba0402023b643216
show more ...
|
f1a21310 | 21-May-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_astlpc: Add astlpc_test_simple_init
Separate out testing of the basic transport initialisation sequence to reduce use of asserts in other more extensive tests.
Signed-off-by: Andrew Jeffery <a
test_astlpc: Add astlpc_test_simple_init
Separate out testing of the basic transport initialisation sequence to reduce use of asserts in other more extensive tests.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Iad84d9fdb54ce0e895c1648206085f6d04e42c9b
show more ...
|
e756de86 | 21-May-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_astlpc: Extract single test case to dedicated function
There will be additional test cases, so lets prepare for their addition.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I0c7f
test_astlpc: Extract single test case to dedicated function
There will be additional test cases, so lets prepare for their addition.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I0c7f1812f672e36e1fbc6122b75c224b8a681be8
show more ...
|
d5e3cd76 | 12-May-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_astlpc: Instantiate a binding for each endpoint
Implement the test as we do for the serial binding where we instantiate an MCTP context for each endpoint and glue them together with shared reso
test_astlpc: Instantiate a binding for each endpoint
Implement the test as we do for the serial binding where we instantiate an MCTP context for each endpoint and glue them together with shared resources (memory in the case of the astlpc binding, pipes for the serial binding). The test scenario then executes the actions of each side in-turn, exercising binding initialisation for both sides as well as both of the binding's read and write paths.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Ie51fafcdb35ea8c86d872c5fef9066d6d50028b2
show more ...
|
7cceebab | 12-May-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_astlpc: Fix OBF flag behaviour in emulated KCS status byte
The implementation wasn't properly respecting the RW0C (read, write-zero-clear) behaviour of the OBF bit on the BMC side. Maintain the
test_astlpc: Fix OBF flag behaviour in emulated KCS status byte
The implementation wasn't properly respecting the RW0C (read, write-zero-clear) behaviour of the OBF bit on the BMC side. Maintain the set state of the bit if the new status value has its bit set and clear it otherwise, but don't blindly apply the bit state of the new status value to OBF.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: If16570dd0f35f27187fc9f9edb73ba5e48c4949f
show more ...
|
df5f6b95 | 12-May-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_astlpc: Include astlpc.c for internal structures
Remove the copied structure as this will be modified in the future and we want to stay in sync.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
test_astlpc: Include astlpc.c for internal structures
Remove the copied structure as this will be modified in the future and we want to stay in sync.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I151881ad7010963f16f79535139450bd2c19fa8a
show more ...
|
53ea147b | 23-May-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_astlpc: Make more functions static
Nothing besides main() should be exposed.
Change-Id: Ie17cecae424d0d8c11f19f669e3fd47e1e67ecd3 Signed-off-by: Andrew Jeffery <andrew@aj.id.au> |
b93b6112 | 04-Jun-2020 |
Andrew Jeffery <andrew@aj.id.au> |
bootstrap: Ratchet up compiler strictness
Replace the specific warning flags with -Wall -Wextra and turn on -Werror.
Covered by -Wall:
* -Wformat * -Warray-bounds * -Wimplicit-function-declaration
bootstrap: Ratchet up compiler strictness
Replace the specific warning flags with -Wall -Wextra and turn on -Werror.
Covered by -Wall:
* -Wformat * -Warray-bounds * -Wimplicit-function-declaration
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Iab21e67026d2453648aa6ebe4c299e1162fc5ebf
show more ...
|
c8908acb | 28-May-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_bridge: Clean up memory before exit
Cleaning up memory makes the test pass valgrind's leak-check.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I72d34315cd1a46183420c0548e7d7bbfab
test_bridge: Clean up memory before exit
Cleaning up memory makes the test pass valgrind's leak-check.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I72d34315cd1a46183420c0548e7d7bbfabebc44b
show more ...
|
ba6727e6 | 13-Mar-2020 |
Wiktor Gołgowski <wiktor.golgowski@linux.intel.com> |
core: Support transport control commands
This change introduces a control message request handler for MCTP bindings. If a handler is provided, transport control messages will be forwarded to the han
core: Support transport control commands
This change introduces a control message request handler for MCTP bindings. If a handler is provided, transport control messages will be forwarded to the handler, otherwise they will be forwarded to the default handler.
Change-Id: I62266d6bf2d512ec97759c0b8a3477c5e433d609 Signed-off-by: Wiktor Gołgowski <wiktor.golgowski@linux.intel.com> [AJ: Split out general control message handler, formatting] Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
show more ...
|
1dbf021d | 11-May-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_astlpc: Do debug logging before asserts
This way if the asserts fire it's obvious why.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Ibc3d9231696ec524498615a9d75c6ba19c060a7f |
ff25d7eb | 26-Mar-2020 |
Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com> |
Extract container_of definition out of individual bindings
This will make possible reuse this portion on code in the future.
Testing: no change in functionality; compiles successfuly
Signed-off-by
Extract container_of definition out of individual bindings
This will make possible reuse this portion on code in the future.
Testing: no change in functionality; compiles successfuly
Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@intel.com> Change-Id: Ie92161c547e275d9aa00d643d8d4879d2f5dd199
show more ...
|
06b2cd86 | 17-Mar-2020 |
Andrew Jeffery <andrew@aj.id.au> |
astlpc: Avoid requiring off_t
off_t is spec'ed to be defined in sys/types.h, however not all environments define it. The LPC FW address space is only 27 bits, so a long will be more than sufficient.
astlpc: Avoid requiring off_t
off_t is spec'ed to be defined in sys/types.h, however not all environments define it. The LPC FW address space is only 27 bits, so a long will be more than sufficient.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I44af91b8a98a08daace05e41f4928832bbdde5b7
show more ...
|
f0315a3e | 10-Mar-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_serial: Clean up after test case
Free all allocated memory to avoid false-positives from leak sanitizers. Resolves:
==15807==ERROR: LeakSanitizer: detected memory leaks
Indirect leak
test_serial: Clean up after test case
Free all allocated memory to avoid false-positives from leak sanitizers. Resolves:
==15807==ERROR: LeakSanitizer: detected memory leaks
Indirect leak of 4096 byte(s) in 1 object(s) allocated from: #0 0x7fb35b934f1e in __interceptor_realloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x10df1e) #1 0x7fb35b7f3065 in __mctp_realloc /home/andrew/src/openbmc/libmctp/alloc.c:48 #2 0x7fb35b7ed979 in mctp_msg_ctx_add_pkt /home/andrew/src/openbmc/libmctp/core.c:213 #3 0x7fb35b7f0a09 in mctp_bus_rx /home/andrew/src/openbmc/libmctp/core.c:383 #4 0x7fb35b7f467d in mctp_serial_finish_packet /home/andrew/src/openbmc/libmctp/serial.c:169 #5 0x7fb35b7f6071 in mctp_rx_consume_one /home/andrew/src/openbmc/libmctp/serial.c:254 #6 0x7fb35b7f6409 in mctp_rx_consume /home/andrew/src/openbmc/libmctp/serial.c:271 #7 0x7fb35b7f668a in mctp_serial_read /home/andrew/src/openbmc/libmctp/serial.c:288 #8 0x559680986cc7 in main tests/test_serial.c:113 #9 0x7fb35ac9e1e2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x271e2)
Indirect leak of 1384 byte(s) in 1 object(s) allocated from: #0 0x7fb35b934ae8 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x10dae8) #1 0x7fb35b7f2cf0 in __mctp_alloc /home/andrew/src/openbmc/libmctp/alloc.c:28 #2 0x7fb35b7f6cad in mctp_serial_init /home/andrew/src/openbmc/libmctp/serial.c:343 #3 0x559680986553 in main tests/test_serial.c:99 #4 0x7fb35ac9e1e2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x271e2)
Indirect leak of 552 byte(s) in 1 object(s) allocated from: #0 0x7fb35b934ae8 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x10dae8) #1 0x7fb35b7f2cf0 in __mctp_alloc /home/andrew/src/openbmc/libmctp/alloc.c:28 #2 0x7fb35b7ededc in mctp_init /home/andrew/src/openbmc/libmctp/core.c:234 #3 0x559680986485 in main tests/test_serial.c:96 #4 0x7fb35ac9e1e2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x271e2)
Indirect leak of 40 byte(s) in 1 object(s) allocated from: #0 0x7fb35b934ae8 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x10dae8) #1 0x7fb35b7f2cf0 in __mctp_alloc /home/andrew/src/openbmc/libmctp/alloc.c:28 #2 0x7fb35b7ee55f in mctp_register_bus /home/andrew/src/openbmc/libmctp/core.c:277 #3 0x559680986b64 in main tests/test_serial.c:105 #4 0x7fb35ac9e1e2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x271e2)
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I9f95104545cc6f633ee134fffc90cb0ea2c46eeb
show more ...
|
11b7e923 | 10-Mar-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_astlpc: Clean up after test case
Free all allocated memory to avoid false-positive leak reports.
Resolves:
==11807==ERROR: LeakSanitizer: detected memory leaks
Indirect leak of 552 b
test_astlpc: Clean up after test case
Free all allocated memory to avoid false-positive leak reports.
Resolves:
==11807==ERROR: LeakSanitizer: detected memory leaks
Indirect leak of 552 byte(s) in 1 object(s) allocated from: #0 0x7f74718fbae8 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x10dae8) #1 0x7f74717bacf0 in __mctp_alloc /home/andrew/src/openbmc/libmctp/alloc.c:28 #2 0x7f74717b5edc in mctp_init /home/andrew/src/openbmc/libmctp/core.c:234 #3 0x56157917c7ee in main tests/test_astlpc.c:160 #4 0x7f7470c661e2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x271e2)
Indirect leak of 384 byte(s) in 1 object(s) allocated from: #0 0x7f74718fbae8 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x10dae8) #1 0x7f74717bacf0 in __mctp_alloc /home/andrew/src/openbmc/libmctp/alloc.c:28 #2 0x7f74717c2cd0 in __mctp_astlpc_init /home/andrew/src/openbmc/libmctp/astlpc.c:364 #3 0x7f74717c31f0 in mctp_astlpc_init_ops /home/andrew/src/openbmc/libmctp/astlpc.c:388 #4 0x56157917c88f in main tests/test_astlpc.c:165 #5 0x7f7470c661e2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x271e2)
Indirect leak of 40 byte(s) in 1 object(s) allocated from: #0 0x7f74718fbae8 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x10dae8) #1 0x7f74717bacf0 in __mctp_alloc /home/andrew/src/openbmc/libmctp/alloc.c:28 #2 0x7f74717b655f in mctp_register_bus /home/andrew/src/openbmc/libmctp/core.c:277 #3 0x56157917c903 in main tests/test_astlpc.c:167 #4 0x7f7470c661e2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x271e2)
Indirect leak of 32 byte(s) in 1 object(s) allocated from: #0 0x7f74718fbae8 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x10dae8) #1 0x7f74717bacf0 in __mctp_alloc /home/andrew/src/openbmc/libmctp/alloc.c:28 #2 0x7f74717c34b2 in mctp_astlpc_init_ops /home/andrew/src/openbmc/libmctp/astlpc.c:400 #3 0x56157917c88f in main tests/test_astlpc.c:165 #4 0x7f7470c661e2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x271e2)
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I3f67e48b22948e18aea91d6fa28135e528268bc1
show more ...
|
7c73801e | 10-Mar-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_eid: Clean up after test case
Free all allocated memory to avoid false-positive leak reports. Resolves:
==10460==ERROR: LeakSanitizer: detected memory leaks
Indirect leak of 552 byte(
test_eid: Clean up after test case
Free all allocated memory to avoid false-positive leak reports. Resolves:
==10460==ERROR: LeakSanitizer: detected memory leaks
Indirect leak of 552 byte(s) in 1 object(s) allocated from: #0 0x7f3e1a574ae8 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x10dae8) #1 0x7f3e1a433cf0 in __mctp_alloc /home/andrew/src/openbmc/libmctp/alloc.c:28 #2 0x7f3e1a42eedc in mctp_init /home/andrew/src/openbmc/libmctp/core.c:234 #3 0x55f705f81268 in mctp_test_stack_init tests/test-utils.c:63 #4 0x55f705f7edff in main tests/test_eid.c:51 #5 0x7f3e198df1e2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x271e2)
Indirect leak of 56 byte(s) in 1 object(s) allocated from: #0 0x7f3e1a574ae8 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x10dae8) #1 0x7f3e1a433cf0 in __mctp_alloc /home/andrew/src/openbmc/libmctp/alloc.c:28 #2 0x55f705f80c99 in mctp_binding_test_init tests/test-utils.c:27 #3 0x55f705f812e1 in mctp_test_stack_init tests/test-utils.c:66 #4 0x55f705f7edff in main tests/test_eid.c:51 #5 0x7f3e198df1e2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x271e2)
Indirect leak of 40 byte(s) in 1 object(s) allocated from: #0 0x7f3e1a574ae8 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x10dae8) #1 0x7f3e1a433cf0 in __mctp_alloc /home/andrew/src/openbmc/libmctp/alloc.c:28 #2 0x7f3e1a42f55f in mctp_register_bus /home/andrew/src/openbmc/libmctp/core.c:277 #3 0x55f705f8121b in mctp_binding_test_register_bus tests/test-utils.c:56 #4 0x55f705f81405 in mctp_test_stack_init tests/test-utils.c:69 #5 0x55f705f7edff in main tests/test_eid.c:51 #6 0x7f3e198df1e2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x271e2)
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I34eae31219d4a31e8388d180be746ae8b7ec5c04
show more ...
|
c68d96e4 | 10-Mar-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_seq: Clean up after each test case
Free all allocated memory to avoid false-positive leak reports. Resolves:
==11106==ERROR: LeakSanitizer: detected memory leaks
Indirect leak of 1228
test_seq: Clean up after each test case
Free all allocated memory to avoid false-positive leak reports. Resolves:
==11106==ERROR: LeakSanitizer: detected memory leaks
Indirect leak of 12288 byte(s) in 3 object(s) allocated from: #0 0x7f92a1347f1e in __interceptor_realloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x10df1e) #1 0x7f92a1207065 in __mctp_realloc /home/andrew/src/openbmc/libmctp/alloc.c:48 #2 0x7f92a1201979 in mctp_msg_ctx_add_pkt /home/andrew/src/openbmc/libmctp/core.c:213 #3 0x7f92a1204a09 in mctp_bus_rx /home/andrew/src/openbmc/libmctp/core.c:383 #4 0x55ff747e1655 in mctp_binding_test_rx_raw tests/test-utils.c:50 #5 0x55ff747df302 in run_one_test tests/test_seq.c:122 #6 0x55ff747df6d6 in main tests/test_seq.c:141 #7 0x7f92a06b21e2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x271e2)
Indirect leak of 2208 byte(s) in 4 object(s) allocated from: #0 0x7f92a1347ae8 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x10dae8) #1 0x7f92a1206cf0 in __mctp_alloc /home/andrew/src/openbmc/libmctp/alloc.c:28 #2 0x7f92a1201edc in mctp_init /home/andrew/src/openbmc/libmctp/core.c:234 #3 0x55ff747e1738 in mctp_test_stack_init tests/test-utils.c:63 #4 0x55ff747def62 in run_one_test tests/test_seq.c:111 #5 0x55ff747df6d6 in main tests/test_seq.c:141 #6 0x7f92a06b21e2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x271e2)
Indirect leak of 224 byte(s) in 4 object(s) allocated from: #0 0x7f92a1347ae8 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x10dae8) #1 0x7f92a1206cf0 in __mctp_alloc /home/andrew/src/openbmc/libmctp/alloc.c:28 #2 0x55ff747e1169 in mctp_binding_test_init tests/test-utils.c:27 #3 0x55ff747e17b1 in mctp_test_stack_init tests/test-utils.c:66 #4 0x55ff747def62 in run_one_test tests/test_seq.c:111 #5 0x55ff747df6d6 in main tests/test_seq.c:141 #6 0x7f92a06b21e2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x271e2)
Indirect leak of 160 byte(s) in 4 object(s) allocated from: #0 0x7f92a1347ae8 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.5+0x10dae8) #1 0x7f92a1206cf0 in __mctp_alloc /home/andrew/src/openbmc/libmctp/alloc.c:28 #2 0x7f92a120255f in mctp_register_bus /home/andrew/src/openbmc/libmctp/core.c:277 #3 0x55ff747e16eb in mctp_binding_test_register_bus tests/test-utils.c:56 #4 0x55ff747e18d5 in mctp_test_stack_init tests/test-utils.c:69 #5 0x55ff747def62 in run_one_test tests/test_seq.c:111 #6 0x55ff747df6d6 in main tests/test_seq.c:141 #7 0x7f92a06b21e2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x271e2)
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I7fbc729740357eb89b679dd51bbf03d6735a75dc
show more ...
|
5c5673b5 | 10-Mar-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test-utils: Add mctp_binding_test_destroy()
Provide an abstraction to clean up memory to avoid false-positives with leak sanitizers.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Id62f
test-utils: Add mctp_binding_test_destroy()
Provide an abstraction to clean up memory to avoid false-positives with leak sanitizers.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Id62f0552f40cb2215be4b5fe9e87eb4048832ef0
show more ...
|
225c46dc | 10-Mar-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test-utils: Avoid undefined behaviour on indirect call
The start method pointer value of the test binding object wasn't well defined due to the missing memset(). Later conditionals concluded that th
test-utils: Avoid undefined behaviour on indirect call
The start method pointer value of the test binding object wasn't well defined due to the missing memset(). Later conditionals concluded that the pointer was valid and tried to call through it leading to a crash of the test binary.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I0e60d1108267f8823f653ae935003a027a13affd
show more ...
|
a501a580 | 10-Mar-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test-utils: Resolve control reaching the end of a non-void function
Resolves:
tests/test-utils.c: In function ‘mctp_binding_test_tx’: tests/test-utils.c:20:1: error: no return statement in
test-utils: Resolve control reaching the end of a non-void function
Resolves:
tests/test-utils.c: In function ‘mctp_binding_test_tx’: tests/test-utils.c:20:1: error: no return statement in function returning non-void [-Werror=return-type] 20 | } | ^ cc1: all warnings being treated as errors
Functions terminating in an assert() won't always have the assert() present to terminate them.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Ieb4338c994675e50b020962d22cff338e598e43a
show more ...
|
cdfafd91 | 07-Feb-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_bridge: Resolve control reaching the end of a non-void function
mctp_binding_bridge_rx() was missing a return:
tests/test_bridge.c: In function ‘mctp_binding_bridge_rx’: tests/test_bri
test_bridge: Resolve control reaching the end of a non-void function
mctp_binding_bridge_rx() was missing a return:
tests/test_bridge.c: In function ‘mctp_binding_bridge_rx’: tests/test_bridge.c:60:1: error: no return statement in function returning non-void [-Werror=return-type] 60 | } | ^ cc1: all warnings being treated as errors
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I2a52e872c4d4a0923e0fb14caf555c78dc57eabc
show more ...
|
89a2b8e0 | 07-Feb-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_serial: Resolve control reaching end of non-void function
mctp-binding_serial_pipe_tx() was missing a return:
tests/test_serial.c: In function ‘mctp_binding_serial_pipe_tx’: tests/test
test_serial: Resolve control reaching end of non-void function
mctp-binding_serial_pipe_tx() was missing a return:
tests/test_serial.c: In function ‘mctp_binding_serial_pipe_tx’: tests/test_serial.c:34:1: error: control reaches end of non-void function [-Werror=return-type] 34 | } | ^ cc1: all warnings being treated as errors
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Ia15a13fe4e283b76bfb4a856ea188a46ac5cf12c
show more ...
|
2cda40fa | 27-Feb-2020 |
Andrew Jeffery <andrew@aj.id.au> |
cmake: Add new tests to test suite
Bring functionality of the cmake build system up to autotools.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I2231b51cfd52460fb525b5af6893b0474508859b |
b633b3f5 | 24-Feb-2020 |
Andrew Jeffery <andrew@aj.id.au> |
test_serial: Fix assert triggered in core.c
$ ./tests/test_serial test_serial: core.c:252: mctp_register_bus: Assertion `mctp->n_busses == 0' failed. Aborted (core dumped)
I'm not sure
test_serial: Fix assert triggered in core.c
$ ./tests/test_serial test_serial: core.c:252: mctp_register_bus: Assertion `mctp->n_busses == 0' failed. Aborted (core dumped)
I'm not sure how this slipped through the cracks, and CI didn't catch it either. However, the scenario wasn't correctly modelled, so do the proper thing and instantiate two mctp contexts and assign a binding instance to each, connected by the pipes.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Ib5382a45cd0042c840fdb01b2038e9a531bf2384
show more ...
|