sensorcommands: move get sensor event status

Rewrite "Get sensor event status" cmd to new IPMI provider API

Tested:
1. verified ipmitool get sensor event status is same both before and
after the ch

sensorcommands: move get sensor event status

Rewrite "Get sensor event status" cmd to new IPMI provider API

Tested:
1. verified ipmitool get sensor event status is same both before and
after the changes
Before:
Command: ipmitool raw 0x04 0x2B 0x35
Response: 80 00 00 00 00
After:
Command: ipmitool raw 0x04 0x2B 0x35
Response: 80 00 00 00 00

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I3f2bd7d7a77deae266acbd691326242930e021ef
Signed-off-by: James Feist <james.feist@linux.intel.com>

show more ...

The CPLD i2c address is changed to 0x38

The earlier address 0x70 had got conflicts with another device.

Tested:
Run the below command in MFG mode:
ipmitool raw 0x32 0x91

Signed-off-by: Yong Li <

The CPLD i2c address is changed to 0x38

The earlier address 0x70 had got conflicts with another device.

Tested:
Run the below command in MFG mode:
ipmitool raw 0x32 0x91

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: I84ad367544eb977dbd8e7e700a53af4b48f6fe89

show more ...

Fix: Ignore reverting for validation unsecure mode

Ignore reverting executed manufacturing command behavior when
in validation unsecure mode. In that mode, just preserve the
set value as such till B

Fix: Ignore reverting for validation unsecure mode

Ignore reverting executed manufacturing command behavior when
in validation unsecure mode. In that mode, just preserve the
set value as such till BMC is rebooted.

Tested:
1. Verified by setting a FAN to 100 % PWM and it stays even after 15
minutes as expected.

Change-Id: I426f69d129dab0b04571afd4fde043119bc5e26b
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Change the bios version dbus interface to align with bmcweb

bmcweb uses the software interface for bios version query in redfish,
to align with it, the settings service implements this interface,
th

Change the bios version dbus interface to align with bmcweb

bmcweb uses the software interface for bios version query in redfish,
to align with it, the settings service implements this interface,
this reference needs to be changed too

Tested:
AC cycle the system, then DC cycle the host,
BiosVersion in redfish is the correct bios version:
https://$BMCIP/redfish/v1/Systems/system

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: I90d66d2f6c24779b09b694204fdbb5c1434f37d4

show more ...

Eliminate expensive DBus transaction in Get Device ID

Get Device ID incurred some performance issues at boot time because of
blocking IPMI function calls. This change focuses on using local file
con

Eliminate expensive DBus transaction in Get Device ID

Get Device ID incurred some performance issues at boot time because of
blocking IPMI function calls. This change focuses on using local file
content instead of making DBus calls. It eliminates reading the FRU
contents at boot as the dominant mode, which take quite some time to
complete.

Tested:
Used high_resolution_clock function calls to collect the run time from
start to finish of the ipmiAppGetDeviceId function. Rebooted the
system multiple times, and ran "ipmitool mc info" in a loop 60 times.
Before the change the function could take upwards of 6 seconds to
complete.
After the change the worst case observed was just over 1 second.

Change-Id: Ia8ebd8e21a1b3e2f77e50bdfdd7272dfe51a56ea
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Disable MDR V1 related OEM commands

MDR V1 service is disable since MDR V2 service has already covered
all MDR V1 features,
these V1 related OEM commands should be disabled too.

Tested:
ipmitool ra

Disable MDR V1 related OEM commands

MDR V1 service is disable since MDR V2 service has already covered
all MDR V1 features,
these V1 related OEM commands should be disabled too.

Tested:
ipmitool raw 0x3e 0x23 0x01 0xff 0x00 0x00
return 0xc1: Invalid command

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: I350280143918b01757dcdbf5ab7e40c9fc0b01c6

show more ...

Link to libgpiod for ipmid to dlopen this .so file correctly

There is a dlopen error with the below error message,
and causes the ipmid service crashes, modify the link option to fix this issue:
MES

Link to libgpiod for ipmid to dlopen this .so file correctly

There is a dlopen error with the below error message,
and causes the ipmid service crashes, modify the link option to fix this issue:
MESSAGE=ERROR opening IPMI provider
ERROR=/usr/lib/ipmid-providers/libzinteloemcmds.so.0.1.0: undefined symbol: _ZN5gpiod12line_request15FLAG_ACTIVE_LOWE

Tested:
Ipmitool sensor list works

Signed-off-by: Yong Li <yong.b.li@linux.intel.com>
Change-Id: Ia51e92253c866dd5e16890a409974478343cbd60

show more ...

bridgingcommands:Read event msg buf & update flag

Issue: Reading the message buffer should clear the event message
buffer full flag and it should give correct value when Get
message fl

bridgingcommands:Read event msg buf & update flag

Issue: Reading the message buffer should clear the event message
buffer full flag and it should give correct value when Get
message flags command is executed.

Fix:
1. Added new API ipmiAppReadEventMessageBuffer
2. Reading the message buffer should clear the event message buffer
full flag and it should give correct value when Get message flags
command is executed.

Tested:
Tested with ipmitool raw command
Before changes:
Command: ipmitool raw 0x06 0x35 //ReadEventMessageBuffer command
Response: 55 55 c0 41 a7 00 00 00 00 00 3a ff 00 ff ff ff
Command: ipmitool raw 0x06 0x31 //GetMsgFlags command
Response: 02
Command: ipmitool raw 0x06 0x30 0x02 //ClearMessageFlags command
Response:
Command: ipmitool raw 0x06 0x31 //GetMsgFlags command
Response: 02

After changes:
Case 1:
Command: ipmitool raw 0x06 0x31 //GetMsgFlags command
Response: 02
Command: ipmitool raw 0x06 0x35 //ReadEventMessageBuffer command
Response: 55 55 c0 41 a7 00 00 00 00 00 3a ff 00 ff ff ff
Command: ipmitool raw 0x06 0x31 //GetMsgFlags command
Response: 00
Case2:
After restarting the service:
Command: ipmitool raw 0x06 0x31 //GetMsgFlags command
Response: 02
Command: ipmitool raw 0x06 0x30 0x02 //ClearMessageFlags command
Response:
Command: ipmitool raw 0x06 0x31 //GetMsgFlags command
Response: 00

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I211c3389b5c75ec96e4ad08c94bc0f276b7be307

show more ...

Correct calculations of IPMI coefficient math

Massively refactored and improved
Using rounding, instead of truncation
Mantissa as large as possible, for best precision
Normalizing for consistent res

Correct calculations of IPMI coefficient math

Massively refactored and improved
Using rounding, instead of truncation
Mantissa as large as possible, for best precision
Normalizing for consistent results
Documenting, in comments, some of the magic that is done
Now works correctly, for narrow ranges with large bias away from zero
Now works correctly, for negative numbers and signed ranges
Clamps values slightly out of range, instead of erroring

Matching update test cases to reflect new coefficient choices

Now generates output in a human-readable table
Adding function from ipmitool for round-trip testing
Testing 5 points within byte range for each value range
Now handles both signed and unsigned
Added many more value ranges that were recommended to me
Changing some exponent values to reflect new choices
Changing some mantissa values because now rounding not truncation
The close range large bias test now succeeds instead of fails

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: I2ceaef581b1270ef19be97940dbab3b588f5768d

show more ...

convert sysfs gpio usage to libgpod

This change removes the need to have ledFault objects defined in dbus.
It depends on consistent led fault pin name definition in device tree.

Tested by:
ipmitool

convert sysfs gpio usage to libgpod

This change removes the need to have ledFault objects defined in dbus.
It depends on consistent led fault pin name definition in device tree.

Tested by:
ipmitool raw 0x30 0x57 0x0 0x5 0x0 0x0 0xff 0xff 0xff 0xff 0xbe 0xef 0xde 0xad
ipmitool raw 0x30 0x57 0x0 0x0 0x0 0x0 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xaa
LEDs were turned on/off following the command on my WP system.

Clean up base on review feedback.

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: I7cceae3ad343739e9f26374fe939f52f355c6442

show more ...

oemcommands: Fix for status LED when Solidgreen

Issue: GetLEDStatus command showing wrong response

Fix: Changed actionDbusToIpmi map value for Action on

Tested:
After complete reboot of server, ve

oemcommands: Fix for status LED when Solidgreen

Issue: GetLEDStatus command showing wrong response

Fix: Changed actionDbusToIpmi map value for Action on

Tested:
After complete reboot of server, verified the statusLED status
showing as solid green
Command : ipmitool raw 0x30 0xB0 //Get LED status
Response: 00 20 //solidgreen

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Iad7c102daa501e66126989c3249a71a57bbcad6d

show more ...

manufacturingcmds: added intrusionsensor status

Modified appMTMGetSignal API to support intrusion sensor status.

Tested:
Tested intrusion sensor status with ipmitool raw command

Command: ipmitool

manufacturingcmds: added intrusionsensor status

Modified appMTMGetSignal API to support intrusion sensor status.

Tested:
Tested intrusion sensor status with ipmitool raw command

Command: ipmitool raw 0x30 0x14 0x04 0x00 0x00
Response: 01 //hardware Intrusion

Signed-off-by: anil kumar appana <anil.kumarx.appana@intel.com>
Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I6a0cf6738dacbbaeece6a66d0264e870963bed5b

show more ...

bridgingcommands:Move ClearMessageFlags to new API

Rewrite ipmiAppClearMessageFlags command to use the newly
introduced IPMI provider API.

Tested:
Verified using ipmitool ClearMessageFlags behavior

bridgingcommands:Move ClearMessageFlags to new API

Rewrite ipmiAppClearMessageFlags command to use the newly
introduced IPMI provider API.

Tested:
Verified using ipmitool ClearMessageFlags behavior is same
before and after the changes.

Command : ipmitool raw 0x06 0x31 //Get Message Flags
Response: 02

Command : ipmitool raw 0x06 0x30 0x00 //Clear Message Flags
Response:

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I8c03050332408e909ab61994f337cfa2c1c036a4

show more ...

Firmware update commmands re-write

Firmware update commands re-write
* Updated to new API style
* Coding guidelines for all names
* Restricted few commands for PFR
* Few updates as per new OpenB

Firmware update commmands re-write

Firmware update commands re-write
* Updated to new API style
* Coding guidelines for all names
* Restricted few commands for PFR
* Few updates as per new OpenBMC EPS
* Changes for fw update status
* Removed legacy API's used for FW update

Tested:
- Tested firmware update using fwpiaupd.efi tool
in usb and kcs trasfer mode.
- Tested all firmware update commands over LAN.

Change-Id: I666cb139b2ca61d352e1cb6b1c18d045b7b1f197
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

Enchance the set specialuser password cmd for ASD

For AtScaleDebug service, special user "asdbg" must enabled.
once special user(asdbg)pwd is enabled by this command then
"SecurityASDSpecialUserEnab

Enchance the set specialuser password cmd for ASD

For AtScaleDebug service, special user "asdbg" must enabled.
once special user(asdbg)pwd is enabled by this command then
"SecurityASDSpecialUserEnabled" Event should be logged.

If asdbg user password is set to NULL then
"SecurityASDSpecialUserDisabled" Event should be logged.

This special user enabled only by KCS interface.

Tested:

Set the asdbg special user password via KCS interface
ipmitool 0x30 0x5f 1 0x30 0x70 0x65 0x6e 0x42 0x6d 0x63 0x31 0x32

1.ASD security Events should be logged and asdbg user is enabled
2.ASD service should be active. This can be done by security-manger
3.asdbg user should not list in ipmi user list
4.Only ASD session can be established via this asdbg user
5."SecurityASDSpecialUserEnabled" Event must logged.

Set the asdbg special password to NULL via KCS interface
ipmitool 0x30 0x5f 1

1.ASD security Event should be logged and asdbg user is disabled
2.ASD service should be stopped. This can be done by security-manager
3."SecurityASDSpecialUserDisabled" Event must logged.

Signed-off-by: Suryakanth Sekar <suryakanth.sekar@linux.intel.com>
Change-Id: Ia81b10771fa9b4499ed3ac9002c337a6e5c0be3e

show more ...

Updated BMCState when firmware update mode is set

Updated BMCState value to "UpdateInProgress" when
user sets the Firmware Update mode via IPMI command
and resetting it to "Ready" during exit Firmwa

Updated BMCState when firmware update mode is set

Updated BMCState value to "UpdateInProgress" when
user sets the Firmware Update mode via IPMI command
and resetting it to "Ready" during exit Firmware update
mode.

This change will make sure correct setting of BMCState
when device is in update mode and same will be reflected
in GetDeviceId byte4 as per IPMI specification.

New value "UpdateInProgress" is added to dbus as part of
below change.
https://gerrit.openbmc-project.xyz/#/c/openbmc/phosphor-dbus-interfaces/+/26867/

Tested:
Set and reset the Firmware Update mode using OEM IPMI
commands and verified the get device ID response.
root@intel-obmc:~# ipmitool raw 8 0x26
7f 64 a5 c9 af 00 b9 30
root@intel-obmc:~# ipmitool raw 8 0x27 0x7f 0x64 0xa5 0xc9 0xaf 0x00 0xb9 0x30

root@intel-obmc:~# ipmitool raw 6 1
23 00 80 01 02 bf 57 01 00 7b 00 ca 0a 9a 62
root@intel-obmc:~# ipmitool raw 8 0x28

root@intel-obmc:~# ipmitool raw 6 1
23 00 00 01 02 bf 57 01 00 7b 00 ca 0a 9a 62
root@intel-obmc:~#

Change-Id: Ie7e4a778cb80708a0a8ca239e9a24e82de1f9de2
Signed-off-by: AppaRao Puli <apparao.puli@linux.intel.com>

show more ...

oemcommands: move OEM set fan config to new API

Rewrite "OEM set Fan Config" command to
use the newly introduced IPMI provider API.

Tested:
verified using ipmitool OEM set fan config command

Comma

oemcommands: move OEM set fan config to new API

Rewrite "OEM set Fan Config" command to
use the newly introduced IPMI provider API.

Tested:
verified using ipmitool OEM set fan config command

Command: ipmitool raw 0x30 0x89 0x20 0x24
Response:
Command: ipmitool raw 0x30 0x89 0x20 0xc0 //Acoustic mode
Response: //Success
Command: ipmitool raw 0x30 0x89 0x20 0xc4 //Performance mode
Response: //Success

Change-Id: I6875e914f636a0048ff456589d303c7b1c709cac
Signed-off-by: anil kumar appana <anil.kumarx.appana@intel.com>
Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>

show more ...

Restrict ME bridging commands

Restrict sensitive ME commands sent via BMC bridging
commands, and return invalid field in request as response
for those.

Tested:
Verified response invalid field in re

Restrict ME bridging commands

Restrict sensitive ME commands sent via BMC bridging
commands, and return invalid field in request as response
for those.

Tested:
Verified response invalid field in request for the following
ipmitool -t 0x2C -b 0x1 raw 0x6 0x52 0x57 0x0 0x20 0x1 0x0
and got proper response for
ipmitool -t 0x2C -b 0x1 raw 6 1

Change-Id: I53fae25ae27e7d1c257871d2cbadfea6f4c4ba17
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Add support for HDD LED assert/deassert mfg cmd

Support added for HDD LED assert / deassert in Set SM Signal
command.

Tested:
1. Verified that drive asserted state being updated accordingly
after
i

Add support for HDD LED assert/deassert mfg cmd

Support added for HDD LED assert / deassert in Set SM Signal
command.

Tested:
1. Verified that drive asserted state being updated accordingly
after
ipmitool raw 0x30 0x15 3 0 1 --> Drive 1 LED assert
ipmitool raw 0x30 0x15 3 0 0 --> Drive 1 LED deassert

Change-Id: Ic568d4bdc8b9de87eba4f8b0da61233494131d4c
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Filter: Delete SEL not supported through filter

Issue: Doing SEL reserve and issuing IPMI Delete SEL,
returns 0xcb instead of 0xc1

Fix: fixed by returning proper error code as invalid comman

Filter: Delete SEL not supported through filter

Issue: Doing SEL reserve and issuing IPMI Delete SEL,
returns 0xcb instead of 0xc1

Fix: fixed by returning proper error code as invalid command (0xc1)

Tested:
verified with ipmitool raw commands

Command : ipmitool raw 0x0a 0x42 //reserve Sel
Response: 05 00

Command : ipmitool raw 0x0a 0x46 0x05 0x00 0xff 0xff // delete Sel
Response: Unable to send RAW command (channel=0x0 netfn=0xa lun=0x0
cmd=0x46 rsp=0xc1): Invalid command

Signed-off-by: jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Ie89c3dd9d48a0c586f2782f2e528e540ed156bc3

show more ...

Fix: Prod ID mismatch from issuing Get Device Id

With SUT boot up, "Get Device Id" gives product id "7B 00" which is set
as default value in json file till the time entity manager starts.

The fix s

Fix: Prod ID mismatch from issuing Get Device Id

With SUT boot up, "Get Device Id" gives product id "7B 00" which is set
as default value in json file till the time entity manager starts.

The fix shows that until the time entity manager service starts,
product id shows up as "00 00" and not of any other platform's prod id
which is set as default.

Tested:
Ipmitool raw 6 1
23 00 00 22 02 bf 57 01 00 00 00 01 4c ea c7

After entity manager service starts:
Ipmitool raw 6 1
23 00 00 22 02 bf 57 01 00 91 00 01 4c ea c7

Signed-off-by: Joshi, Mansi <mansi.joshi@linux.intel.com>
Change-Id: I9bbe77ecc9fac12389c0bc389f9bdccefd63ca12

show more ...

Fix bug in IPMI sensor attribute bit stuffing

Audited the 5 attributes and made sure each was stuffed correctly
This fixes a nasty bug in which bExp was truncated to zero

Signed-off-by: Josh Lehan

Fix bug in IPMI sensor attribute bit stuffing

Audited the 5 attributes and made sure each was stuffed correctly
This fixes a nasty bug in which bExp was truncated to zero

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Ie09f8a56b3bd561c4df728329f15ab3ee464ddf4

show more ...

Updated set security command for val unsecure

Support added for set security mode command to set the validation
unsecure value when image is build with debug-tweaks. This will be
used to enable the

Updated set security command for val unsecure

Support added for set security mode command to set the validation
unsecure value when image is build with debug-tweaks. This will be
used to enable the validation unsecure mode permanently, till
reset to defaults is performed. By default this feature will be disabled
and will be enabled when validation unsecure mode is specified.

Tested:
Tested along with special mode manager changes
1. Verified feature working state with validation-unsecure and not working
without validation-unsecure
2. Verified that set security mode enables the validation unsecure
3. Manufacturing commands are executed when in validation unsecure
mode

Change-Id: Ib160fbafc0e92cf33cc129039ae932364ad4dee4
Signed-off-by: Richard Marian Thomaiyar <richard.marian.thomaiyar@linux.intel.com>

show more ...

Changing std::pow argument 10 to 10.0 for double

Sanity check to ensure correct std::pow function overload called

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Iac67371a25adbcfc03c85c09

Changing std::pow argument 10 to 10.0 for double

Sanity check to ensure correct std::pow function overload called

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Iac67371a25adbcfc03c85c09c4609063d00f6c37

show more ...

Add additional temporary files to .gitignore

Adding a few more temporary files to .gitignore,
to make it easier to work within an IDE.
The .vscode file is already present,
so there is precedent for

Add additional temporary files to .gitignore

Adding a few more temporary files to .gitignore,
to make it easier to work within an IDE.
The .vscode file is already present,
so there is precedent for adding IDE files here.

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Ic5324a1e5df91a5861b0fca53d33a7c4e7723314

show more ...