Klockwork Issue Fix : Index range check

Though the caller of smbiosIsUpdating() is handling index range check
(#757), it is preferable that the function also has the right check in
place. With the p

Klockwork Issue Fix : Index range check

Though the caller of smbiosIsUpdating() is handling index range check
(#757), it is preferable that the function also has the right check in
place. With the present implementation, index can go up to maxDirEntries
which is not the correct functionality. This commit fixes the range
check.

Signed-off-by: P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com>
Change-Id: I4f3cb15c3a26e9462ee6e0f425c8e9156bce4731

show more ...

Klocwork Issue Fix - File Resource Lost

In the event when file_size() fails and file open was successful,
with the current implementation, the function would return without
closing the file.
This co

Klocwork Issue Fix - File Resource Lost

In the event when file_size() fails and file open was successful,
with the current implementation, the function would return without
closing the file.
This commit fixes this condition by having separate checks for
file_size error code and file open failure.

Signed-off-by: P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com>
Change-Id: I44e46a4093f5fab087b40bb95440fbb3d215bad8

show more ...

oemcommands: Validate reserved field content

In "Set Processor Error Configuration" command, byte-1’s [7-2],
byte-2, byte-3's [7-1], bits are reserved and in "Disable BMC System
Reset Action" comm

oemcommands: Validate reserved field content

In "Set Processor Error Configuration" command, byte-1’s [7-2],
byte-2, byte-3's [7-1], bits are reserved and in "Disable BMC System
Reset Action" command, byte-1’s [7-1] bits are reserved. So return
"InvalidFieldRequest" when reserved content is non-zero.

Tested:
IPMI Command: Set Processor Error Configuration
Case 1: Byte 1 - reserved1 bits zero
Command: ipmitool raw 0x30 0x9b 0x03 0x0 0x01
Response: //Success
Case 2: Byte 1 - reserved1 bits non-zero
Command: ipmitool raw 0x30 0x9b 0xf3 0x0 0x01
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0x9b rsp=0xcc): Invalid data field in request
Case 3: Byte 2 - reserved2 bits zero
Command: ipmitool raw 0x30 0x9b 0x03 0x0 0x01
Response: //Success
Case 4: Byte 2 - reserved2 bits non-zero
Command: ipmitool raw 0x30 0x9b 0x03 0x1 0x01
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0x9b rsp=0xcc): Invalid data field in request
Case 5: If byte - 3 is not present
Command: ipmitool raw 0x30 0x9b 0x03 0x0
Response: //Success
Case 6: byte-3 with reserved portion(reserved3) zero
Command: ipmitool raw 0x30 0x9b 0x03 0x0 0x01
Response: //Success
Case 7: byte-3 with reserved portion (reserved3) non-zero.
Command: ipmitool raw 0x30 0x9b 0x03 0x0 0xf1
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0x9b rsp=0xcc): Invalid data field in request

IPMI Command: Disable BMC System Reset Action
Case 1: Byte-1 reserved portion (reserved1) non-zero.
Command : ipmitool raw 0x30 0x42 0x03
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0x42 rsp=0xcc): Invalid data field in request
Case 2: Byte-1 reserved portion (reserved1) is zero.
Command : ipmitool raw 0x30 0x42 0x01
Response: //Success

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I84a6e3be21d6101824867ff9f92b83be2e6aa406

show more ...

Add channel support to Get System Restart Cause

Channel was previously unsupported. This adds the channel support that
is available from the ipmi::Context. It also reworks the D-Bus calls
made in th

Add channel support to Get System Restart Cause

Channel was previously unsupported. This adds the channel support that
is available from the ipmi::Context. It also reworks the D-Bus calls
made in that command to use the yielding variants now that the
ipmi::Context is present.

Tested: before: ipmitool -I lanplus ... raw 0 7
00 00
after: ipmitool -I lanplus ... raw 0 7
00 03

Change-Id: I94727c945f4fcf7fb5420960acb828e979a8e3bc
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

OOB NV File Handling flow is corrected.

1.OOB NV files are restored properly after BMC reset
2.Added File Error handling

Tested:
Get OOB BIOS capability
ipmitool raw 0x30 0xd4

Set OOB BIOS Capabil

OOB NV File Handling flow is corrected.

1.OOB NV files are restored properly after BMC reset
2.Added File Error handling

Tested:
Get OOB BIOS capability
ipmitool raw 0x30 0xd4

Set OOB BIOS Capability
ipmitool raw 0x30 0xd3 0x16 0 0 0

SetPayload Start Info :
ipmitool raw 0x30 0xd5 0 3 0 0 0x44 0 0 0 0xc 0xab 0xc2 0x53 0x0
Success with Reservation ID
SetPayload InProgress :
ipmitool raw 0x30 0xd5 1 3 <Reservation ID> 0 0 0 0 0x44 0 0 0
0xc 0xab 0xc2 0x53 0x50 0x58 0x4F 0x24 0x44 00 0x20 00 0x02
0x4E 0x81 00 0x03 00 0x03 0xF8 0x02 00 00 0x79 0x18 00
0x04 00 0x07 00 00 00 00 00 00 00 0x02 0x24 00 00 0xE8
0x7E 0xF8 0x83 0x06 00 00 00 00 00 00 00 00 00 00 00 00
0x7F 00 0x07 00 00 0x81 00 00 00 00 00 00 00 00 00
EndOfTransfer:
ipmitool raw 0x30 0xd5 2 3 <Reservation ID>
Success with data
Reboot the BMC
reboot

Get Payload Info:
ipmitool raw 0x30 0xd6 0 3
Success with data
Get Payload:
ipmitool raw 0x30 0xd6 1 3 0 0 0 0 0x44 0 0 0
Success with data

Delete the Payload3 File:
Get Payload Info
ipmitool raw 0x30 0xd6 0 3
0xFF // Unspecified Error

Get Payload :
ipmitool raw 0x30 0xd6 1 3 0 0 0 0 0x44 0 0 0
0xFF // Unspecified Error

Signed-off-by: Suryakanth Sekar <suryakanth.sekar@linux.intel.com>
Change-Id: I6c09e4154d4a33557fe02449f20e820204a8e0f5

show more ...

fix: correct SetBiosPwdHash and GetBiosPwdHash cmd

As per recent EDK core, there is a change in BIOS password handling.
User password option in BIOS setup is removed for security reasons.
Also, move

fix: correct SetBiosPwdHash and GetBiosPwdHash cmd

As per recent EDK core, there is a change in BIOS password handling.
User password option in BIOS setup is removed for security reasons.
Also, moved to SHA256 algo and seed size is increased from 16 bytes
to 32 bytes.

This change is to correct the two password handling commands to comply
with the the new bios changes.

Tested:
Executed both the commands D7 and D8 through KCS interface.
Verified cmd response is success and as expected.

Signed-off-by: Ayushi Smriti <smriti.ayushi@linux.intel.com>
Change-Id: I8fbd1623c5feaf33a9a8f91905bb1773163fbbae

show more ...

sensorcommands:Platform Event Message command corrected

Add support to check the incoming channel type and update the
generatorID based on requester slave address.

Add support to check for valid ev

sensorcommands:Platform Event Message command corrected

Add support to check the incoming channel type and update the
generatorID based on requester slave address.

Add support to check for valid evmRev and Sensor Type.

Tested:
Command: ipmitool -I lanplus -H <BMC_IP> -U root -P 0penBmc raw 0x04
0x02 0x04 0x6a 0xcd 0xf6 0x6b 0xed 0x0f
Response: Unable to send RAW command (channel=0x0 netfn=0x4 lun=0x0
cmd=0x2 rsp=0xcc): Invalid data field in request

Command: ipmitool -I lanplus -H <BMC_IP> -U root -P 0penBmc raw 0x04
0x02 0x54 0x6a 0xcd 0xf6 0x6b 0xed 0x0f
Response: Unable to send RAW command (channel=0x0 netfn=0x4 lun=0x0
cmd=0x2 rsp=0xcc): Invalid data field in request

Signed-off-by: Chalapathi Venkataramashetty <chalapathix.venkataramashetty@intel.com>
Change-Id: Ibb93d09777f5a7c515d45a4aa910c657d503d9ce

show more ...

whitelist: Remove DCMI commands

A set of DCMI commands were added to the whitelist by mistake in
change:

https://gerrit.openbmc-project.xyz/c/openbmc/intel-ipmi-oem/+/33973

This commit removes the

whitelist: Remove DCMI commands

A set of DCMI commands were added to the whitelist by mistake in
change:

https://gerrit.openbmc-project.xyz/c/openbmc/intel-ipmi-oem/+/33973

This commit removes them.

Tested:
I was able to call GetDcmiCapabilityInfo command and I get
expected reponse cc=0xd4 (Insufficient privilege level).

Signed-off-by: Zbigniew Kurzynski <zbigniew.kurzynski@intel.com>
Change-Id: I4635781e36b96a3f4aa1f8dcbaea1a14d4ce6d1c

show more ...

sensorcommands: check for reserved sensor number in sensor commands.

Add support to check for reserved sensor number (0xFF) in sensor
commands.

Tested:
Command: Set Sensor Threshold
ipmitool raw 0x

sensorcommands: check for reserved sensor number in sensor commands.

Add support to check for reserved sensor number (0xFF) in sensor
commands.

Tested:
Command: Set Sensor Threshold
ipmitool raw 0x04 0x26 0xff 0x00 0x3a 0xab 0x03 0x02 0xef 0x63
Response: Unable to send RAW command (channel=0x0 netfn=0x4 lun=0x0
cmd=0x26 rsp=0xcc): Invalid data field in request

Signed-off-by: Chalapathi Venkataramashetty <chalapathix.venkataramashetty@intel.com>
Change-Id: Id99f5ef1515263ac3dbf2edec7f94b0b4badb4e3

show more ...

[Chassis]: Validate reserved field content is zero

In Set Front Panel Button Enables Command, byte-1’s [7:4] is reserved.
Return InvalidFieldRequest when reserved content is non-zero.
Tested:
~# ipm

[Chassis]: Validate reserved field content is zero

In Set Front Panel Button Enables Command, byte-1’s [7:4] is reserved.
Return InvalidFieldRequest when reserved content is non-zero.
Tested:
~# ipmitool raw 0x00 0x0a 0x10
Unable to send RAW command (channel=0x0 netfn=0x0 lun=0x0 cmd=0xa rsp=0xcc)
:Invalid data field in request

Signed-off-by: sunitakx <sunitax.kumari@linux.intel.com>
Change-Id: I20284f741ce7e2c235d48ba905d922db5c9d2885

show more ...

Fix build issues

* Fix casting issues that are causing the build to fail.
* Fix gtest warnings by updating the source revision

Change-Id: Id6eb6b1fef335f88e7e12074f712b82ecd1a233a
Signed-off-by: Ja

Fix build issues

* Fix casting issues that are causing the build to fail.
* Fix gtest warnings by updating the source revision

Change-Id: Id6eb6b1fef335f88e7e12074f712b82ecd1a233a
Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>

show more ...

Bug fix: wrong cmake external project cmd format.

With original format of CONFIGURE_COMMAND/BUILD_COMMAND, cmake will
generate wrong argument list when logs are turned on.

The problem is justified

Bug fix: wrong cmake external project cmd format.

With original format of CONFIGURE_COMMAND/BUILD_COMMAND, cmake will
generate wrong argument list when logs are turned on.

The problem is justified on both cmake version of 3.16.3 and 3.18.4

Signed-off-by: Hao Jiang <jianghao@google.com>
Change-Id: I28d8d3de81703f797876bf144340a9a629ace1f6

show more ...

Fix for SMMDR - Send Directory Info

Issue: SMMDR send directory Info command giving response as 0xce
which is incorrect.

Fix: Update request for SMMDR send directory Info command as per IPMI
OEM co

Fix for SMMDR - Send Directory Info

Issue: SMMDR send directory Info command giving response as 0xce
which is incorrect.

Fix: Update request for SMMDR send directory Info command as per IPMI
OEM commands documentation and provided fix to get correct response
as provided in test results.

Tested:
Verified using ipmitool raw commands.
Before:
Command: ipmitool raw 0x3E 0x38 0x01 0x01 2 1 1 0 40 41 42 43 44 45 46
47 48 49 50 51 52 53 50 0x42 40 41 42 43 44 45 46 47 48 49 50
51 52 53 50 0x42 //SMMDR send Dir info
Response: Unable to send RAW command (channel=0x0 netfn=0x3e lun=0x0
cmd=0x38 rsp=0xce): Command response could not be provided

After:
Command: ipmitool raw 0x3E 0x38 0x01 0x01 2 1 2 0 40 41 42 43 44 45 46
47 48 49 50 51 52 53 50 0x42 40 41 42 43 44 45 46 47 48 49 50
51 52 53 50 0x42 //SMMDR send Dir info
Response: 01 //True
Command : ipmitool raw 0x3E 0x31 1 1 0 //SMMDR get Dir info
Response: 02 01 01 00 28 29 2a 2b 2c 2d 2e 2f 30 31 32 33
34 35 36 42

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: I75d5d08c479922dbd541b1d1b6587f3cf24de5f0

show more ...

oemcommands: check for non-printable characters in biosID

Issue: sdbusplus throws exception and core dumped when non ascii
characters are present in biosID.

Fix: check for non printable characters

oemcommands: check for non-printable characters in biosID

Issue: sdbusplus throws exception and core dumped when non ascii
characters are present in biosID.

Fix: check for non printable characters in biosID string and return
Invalid data field in request response.

Tested:
Command: ipmitool raw 0x30 0x26 0x1 0xAF
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0x26 rsp=0xcc): Invalid data field in request

Command: ipmitool raw 0x30 0x26 0x1 0x09
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0x26 rsp=0xcc): Invalid data field in request

Command: ipmitool raw 0x30 0x26 0x1 0x1F
Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0
cmd=0x26 rsp=0xcc): Invalid data field in request

Command: ipmitool raw 0x30 0x26 0x1 0x20
Response: 01

Command: ipmitool raw 0x30 0x26 0x1 0x43
Response: 01

Signed-off-by: Chalapathi Venkataramashetty <chalapathix.venkataramashetty@intel.com>
Change-Id: I7c6733a9f65f740b26a5b92e8b1630b9e52e9622

show more ...

Fix issue on BaseBIOSTable updating

All attributes can be generated, but fail to
modify BaseBIOSTable property due to struct changed.

Tested:
oem command could change BaseBIOSTable correctly.
root@

Fix issue on BaseBIOSTable updating

All attributes can be generated, but fail to
modify BaseBIOSTable property due to struct changed.

Tested:
oem command could change BaseBIOSTable correctly.
root@intel-obmc:~# ipmitool raw 0x30 0xd5 2 0 0

Jan 01 00:38:37 intel-obmc ipmid[199]: ipmiOEMSetPayload : Convert XML into native-dbus DONE
Jan 01 00:38:37 intel-obmc ipmid[199]: generateAttributesData
Jan 01 00:38:37 intel-obmc ipmid[199]: QuietBoot
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICEnable_0
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICPortEnable_0
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICPortEnable_1
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICPortEnable_2
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICPortEnable_3
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICEnable_1
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICPortEnable_4
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICPortEnable_5
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICPortEnable_6
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICPortEnable_7
Jan 01 00:38:37 intel-obmc ipmid[199]: IB1_PXE
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICIOMPortPXEEnable_8
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICIOMPortPXEEnable_9
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICIOMPortPXEEnable_10
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICIOMPortPXEEnable_11
Jan 01 00:38:37 intel-obmc ipmid[199]: IB2_PXE
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICIOMPortPXEEnable_12
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICIOMPortPXEEnable_13
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICIOMPortPXEEnable_14
Jan 01 00:38:37 intel-obmc ipmid[199]: OnboardNICIOMPortPXEEnable_15
Jan 01 00:38:37 intel-obmc ipmid[199]: Pci64BitResourceAllocation

root@intel-obmc:~# busctl call xyz.openbmc_project.BIOSConfigManager /xyz/openbmc_project/bios_config/manager org.freedesktop.DBus.Properties Get ss xyz.openbmc_project.BIOSConfig.Manager BaseBIOSTable --json=pretty |more
{
"type" : "v",
"data" : [
{
"type" : "a{s(sbsssvva(sv))}",
"data" : {
"ADDDCEn" : [
"xyz.openbmc_project.BIOSConfig.Manager.AttributeType.String",
false,
"ADDDC Sparing",
"Enable/Disable Adaptive Double Device Data Correction Sparing.",
"./Advanced/Memory Configuration/Memory RAS and Performance Configuration/ADDDC Sparing",
{
"type" : "s",
"data" : "0x00"
},
{
"type" : "s",
"data" : "0x00"
},
[
[
"xyz.openbmc_project.BIOSConfig.Manager.BoundType.OneOf",
{
"type" : "s",
"data" : "0x1"
}
],
[
"xyz.openbmc_project.BIOSConfig.Manager.BoundType.OneOf",
{
"type" : "s",
"data" : "0x0"
}
]
]
],
"ADREn" : [
"xyz.openbmc_project.BIOSConfig.Manager.AttributeType.String",
false,
"Enable ADR",
"Enables the detecting and enabling of ADR.",
"./Advanced/Memory Configuration/Enable ADR",
{
"type" : "s",
"data" : "0x01"
},

Change-Id: I8c0183c5738d008f617c4e6e1a44a53e3e8bde82
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>

show more ...

Add WARNING log in Restore Configuration IPMI cmd

BMC configurable items like user details will be lost on BMC reboot
after Restore Configuration IPMI cmd is called. Add a WARNING log
to track comma

Add WARNING log in Restore Configuration IPMI cmd

BMC configurable items like user details will be lost on BMC reboot
after Restore Configuration IPMI cmd is called. Add a WARNING log
to track command executions.

Tested:
Verified the log added after executing Restore Configuration IPMI
command.

Signed-off-by: Arun P. Mohanan <arun.p.m@linux.intel.com>
Change-Id: Id7439d833487f645dce036815208264e57f6917d

show more ...

bridgingcommands:Fix for Get Message command

Updated channel permissions for Get Message command in
ipmi-whitelist.conf

Tested:
1. Verified using cmdtool utility and clear linux OS.
2. Enable Provi

bridgingcommands:Fix for Get Message command

Updated channel permissions for Get Message command in
ipmi-whitelist.conf

Tested:
1. Verified using cmdtool utility and clear linux OS.
2. Enable ProvisionedHostWhitelist mode (KCS trust policy) and verified.

Verified executing from BMC.
Command: ipmitool raw 0x06 0x33 //Get Message
Response: Unable to send RAW command (channel=0x0 netfn=0x6 lun=0x0
cmd=0x33 rsp=0xd4): Insufficient privilege level

Verified from system interface using cmdtool utility and Clear linux.
Command: cmdtool.efi 20 18 33 //Get Message
Response: 80 //no data available

Verified using Clear Linux (System Interface)
Note: OpenIPMI driver provided by the Linux kernel will reject the
Get Message command because it handles the message sequencing
internally.
https://manpages.debian.org/testing/ipmitool/ipmitool.1.en.html

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Ica41829523fa17a4009cded5fa89b2d94595d6d1

show more ...

Remove unused POST code D-Bus defines

The object path is no longer valid so better to remove it.

Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
Change-Id: Ifd980d1170a26e6b3049030c6fdbe7e

Remove unused POST code D-Bus defines

The object path is no longer valid so better to remove it.

Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
Change-Id: Ifd980d1170a26e6b3049030c6fdbe7e559536042

show more ...

Fix the ResetBIOS value from bios-settings-mgr srv

GetStoredHash command always return 0xCE becuase fail to
get the proper resetBIOS value from ReadResetBIOSSettings function

Fix: Added proper Rese

Fix the ResetBIOS value from bios-settings-mgr srv

GetStoredHash command always return 0xCE becuase fail to
get the proper resetBIOS value from ReadResetBIOSSettings function

Fix: Added proper ResetBIOS value check in ReadResetBIOSSettings
function and also corrected the seedData filename.

Tested:

GetStoredHash command is working fine.
ipmitool raw 0x30 0xd8 // Request
02 18 de c8 83 d1 5d cc 58 a4 f1 af ee f0 2a 9c
d0 12 83 45 eb f7 06 72 62 e9 dd f5 1d 78 68 13
41 63 2c 8a fb 9f 01 17 30 6c 69 b8 1d 67 d6 6d
13 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 75 99 3f 96 e2 e0 81 2d 4e 40 b7 ee 2a be a3
6a 9d c9 69 6b 3a d3 6c 04 a0 0b 41 82 0c a4 b1
48 2b 92 7a 2a 23 7f 86 5b 22 6b e7 08 31 87 b8
14 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
00

Signed-off-by: Suryakanth Sekar <suryakanth.sekar@linux.intel.com>
Change-Id: Ie15cfa06371b7c77901fb10b9bc61f70ae0dd0c9

show more ...

oemcommands: Clear security sensitive data

As password is sensitive data Clear after use.

Tested:
Verified using cmdtool utility command
//Set special UserPassword
Command: cmdtool.efi 20 c0 5f 0 3

oemcommands: Clear security sensitive data

As password is sensitive data Clear after use.

Tested:
Verified using cmdtool utility command
//Set special UserPassword
Command: cmdtool.efi 20 c0 5f 0 30 70 65 6e 42 6d 63 31
Response: 00 //Success

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Iad64f7baf176b2ecfd34ecf5e1d4012ffa9db396

show more ...

sensorcommands: Add IPMI reading logging instrumentation

Noteworthy sensor readings, such as the first reading,
a new minimum or maximum value, or ending a good or
bad streak of readings, will now h

sensorcommands: Add IPMI reading logging instrumentation

Noteworthy sensor readings, such as the first reading,
a new minimum or maximum value, or ending a good or
bad streak of readings, will now have some useful logging output.

Tested: Example logs
```
root@bmc:~# journalctl --no-pager | grep 'IPMI sensor'
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor0: First reading, value=6 byte=51
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor0: Range min=0 max=30, Coefficients mValue=118 rExp=-3 bValue=0 bExp=0 bSigned=0
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor1: First reading, value=7 byte=59
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor1: Range min=0 max=30, Coefficients mValue=118 rExp=-3 bValue=0 bExp=0 bSigned=0
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor2: First reading, value=1.437 byte=12
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor2: Range min=0 max=30, Coefficients mValue=118 rExp=-3 bValue=0 bExp=0 bSigned=0
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor3: First reading, value=1.437 byte=12
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor3: Range min=0 max=30, Coefficients mValue=118 rExp=-3 bValue=0 bExp=0 bSigned=0
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor4: First reading, value=1.96 byte=17
Jan 01 00:03:16 bmc ipmid[2865]: IPMI sensor sensor4: Range min=0 max=30, Coefficients mValue=118 rExp=-3 bValue=0 bExp=0 bSigned=0
...
```
Machine and sensors names are replaced.

Signed-off-by: Josh Lehan <krellan@google.com>
Change-Id: Idf7c8d4285b286fdc0afb3f0e7260c2d4915b326
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

Remove James from MAINTAINERS

Will be off the project starting Oct 9th.

Change-Id: I779811cf94ad7711ab8a563907039341301a5c48
Signed-off-by: James Feist <james.feist@linux.intel.com>

Fix for ID LED smsignal configuration

Issue: ID LED status reverting to default state after exiting
manufacturing mode

Fix: Provided fix for ID LED status should not revert to default state

Fix for ID LED smsignal configuration

Issue: ID LED status reverting to default state after exiting
manufacturing mode

Fix: Provided fix for ID LED status should not revert to default state
after exiting manufacturing mode

Tested:
1. Keep the BMC in Manufacturing mode
2. Update Physical LED state to ON.
Command: ipmitool raw 0x30 0x15 0x0d 0x00 0x01
Response: Success
3. Check the status of ID LED status
Command: busctl get-property xyz.openbmc_project.LED.Controller.identify
/xyz/openbmc_project/led/physical/identify
xyz.openbmc_project.Led.Physical State
Response: s "xyz.openbmc_project.Led.Physical.Action.On"
4. Wait for Manufacturing mode to exit and verify ID LED status.
LED status is showing ON even after existing from mfg mode.

Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com>
Change-Id: Ia7fe1946cd5c93a0f145b230026abde5ae724d48

show more ...

Fix sensor missing issue.

There is issue for "BMC randomly unable to get sensor readings".
When invoking "ipmitool sdr" from Linux OS (host), it only
returns three sensors like following partial rec

Fix sensor missing issue.

There is issue for "BMC randomly unable to get sensor readings".
When invoking "ipmitool sdr" from Linux OS (host), it only
returns three sensors like following partial records:
[root@localhost ~]# ipmitool sdr
CPU Power | 0 Watts | ok
Memory Power | 0 Watts | ok
Total Power | 0 Watts | ok
[root@localhost ~]#

There 2 caches sensorTree and sensorDataRecords.
When sensorDataRecords cache and sensorTree cache is not sync,
which causes this issue, like sensorTree cache has 10 sensors
but there are just 5 sensors in sensorDataRecords cache.
Most important sensorDataRecords cache is not necessary,
ipmiStorageGetSDR could get data from dbus directly and
no any performance impact.

Using sensorMapUpdatePeriod(10s) but not sensorMapSdrUpdatePeriod(60s),
60 seconds are too long to answer user with some SDR content
at the first time of BMC bootup.

Tested:
All sensors could be listed even at booting phase.
Could print correct sensor set along with the boot progress.

root@intel-obmc:~# ipmitool sdr
CPU Power | 202 Watts | ok
Memory Power | 0 Watts | ok
Total Power | 312 Watts | ok
root@intel-obmc:~# ipmitool sdr
System Airflow | 14 unspecified | ok
PSU1 In Current | 1.18 Amps | ok
PSU1 Out Current | 20.80 Amps | ok
PSU2 In Current | 0 Amps | ok
PSU2 Out Current | no reading | ns
Pwm 1 | 29.79 unspecifi | ok
Pwm 2 | 29.79 unspecifi | ok
Pwm 3 | 29.79 unspecifi | ok
Pwm 4 | 29.79 unspecifi | ok
Pwm 5 | 29.79 unspecifi | ok
Pwm 6 | 29.79 unspecifi | ok
Pwm 13 | 29.79 unspecifi | ok
Pwm 14 | 29.79 unspecifi | ok
Pwm 15 | 29.79 unspecifi | ok
Pwm 16 | 29.79 unspecifi | ok
Pwm PSU1 Fan 1 | 39.98 unspecifi | ok
Pwm PSU1 Fan 2 | 39.98 unspecifi | ok
.............
PVCCD HV CPU1 | 1.18 Volts | ok
PVCCFA EHV FIVRA | 1.16 Volts | ok
PVCCINFAON CPU1 | 1.11 Volts | ok
PVCCIN CPU1 | 1.68 Volts | ok
PVNN PCH AUX | 1.03 Volts | ok
root@intel-obmc:~#

Change-Id: I729d9bcbf91f0e96c62fb5f5ebe0240a0eaa47df
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>
Signed-off-by: Helen Huang <he.huang@linux.intel.com>
Signed-off-by: Kuiying Wang <kuiying.wang@intel.com>

show more ...

Status-BIT4/BIT5 contain Password Hash status

In setPasswordHash command, status- BIT4/ BIT5 contain password
status.so we need to filter out the status bit for checking the
supported Algorithm. St

Status-BIT4/BIT5 contain Password Hash status

In setPasswordHash command, status- BIT4/ BIT5 contain password
status.so we need to filter out the status bit for checking the
supported Algorithm. Status BIT4 and BIT5 are used in
bios-settings-mgr service.

Tested:
SetPassword Hash command is working fine.

Signed-off-by: Suryakanth Sekar <suryakanth.sekar@linux.intel.com>
Change-Id: I8f3005c5b9fc1928f1728d86939625d3583da2e6

show more ...