baa579f9 | 08-Oct-2021 |
Manish Baing <manish.baing@intel.com> |
Add limit check to fan speed offset
ipmiOEMSetFanSpeedOffset was accepting offset value greater than its limit. Fix added for limit check for fan speed offset.
Tested : Verified using IPMI command.
Add limit check to fan speed offset
ipmiOEMSetFanSpeedOffset was accepting offset value greater than its limit. Fix added for limit check for fan speed offset.
Tested : Verified using IPMI command.
Command: ipmitool raw 0x30 0x8C 0x65 //set fan speed offset to 101. Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0 cmd=0x8c rsp=0xcc): Invalid data field in request
Signed-off-by: Manish Baing <manish.baing@intel.com> Change-Id: I99b6a18dc69b7956c4488f39306fb69afd1f522b
show more ...
|
31c45f60 | 18-Oct-2021 |
Arun P. Mohanan <arun.p.m@linux.intel.com> |
Separately handle RestrictionMode & POSTComplete
Having single try catch to get 2 separate D-Bus properties from different services resulted in incorrect value for 2nd property. In the previous impl
Separately handle RestrictionMode & POSTComplete
Having single try catch to get 2 separate D-Bus properties from different services resulted in incorrect value for 2nd property. In the previous implementation, when `RestrictionModeService` is not initialized it will throw and return. In this case it was missing to read the `OperatingSystemState` property and it was defaulting postComplete as true but actually it can be false.
The above case resulted in a a situation where BMC blocked the IPMI commands(Over KCS trust policy- DenyAll & Whitelist ) over KCS channel even before BIOS completes booting. As a result BIOS never get response for IPMI commands like getDeviceID(In DenyAll mode) and caused further issues.
Separate out these into seperate try catch to avoid above issue. Also updated the function to use getDbusProperty() API.
Tested: Verified postComplete value is getting cached correctly even if the restrictionModeService is not up and running.
Signed-off-by: Arun P. Mohanan <arun.p.m@linux.intel.com> Change-Id: I394a7c46703e917b0075da6cc5469de1b66a9b7a
show more ...
|
d4b74b4f | 08-Oct-2021 |
sureshvijayv1 <suresh.vijayakumar@intel.com> |
Fix for SDR Repository Info command returning off-by-one SDR Count
NM Discovery SDR is not added to record count during the time of record count manipulation in the command.
Tested: Issued 'ipmitoo
Fix for SDR Repository Info command returning off-by-one SDR Count
NM Discovery SDR is not added to record count during the time of record count manipulation in the command.
Tested: Issued 'ipmitool sdr dump /tmp/xxxx.bin' Performed a hex dump on the binary data and reviewed the SDR with record type 0xC0.
Issued 'ipmitool sdr info' Observed that the SDR record count returns correctly as per the number of SDR records including NM Discovery SDR count in it.
Change-Id: Ic91985ff8f6051db5d799c250b6cfb079cb33fba Signed-off-by: sureshvijayv1 <suresh.vijayakumar@intel.com>
show more ...
|
f4d5e05e | 22-Sep-2021 |
Johnathan Mantey <johnathanx.mantey@intel.com> |
Guarantee SDR Type12 byte alignment matches the IPMI spec
The Type12 structure used a uint24_t to assign storage for 3 reserved bytes in the Type12 SDR definition. This turned out to be an issue as
Guarantee SDR Type12 byte alignment matches the IPMI spec
The Type12 structure used a uint24_t to assign storage for 3 reserved bytes in the Type12 SDR definition. This turned out to be an issue as the compiler promoted the uint24_t to a uint32_t, which added one additional byte to the structure. This in turn pushed the trailing bytes out of alignment.
The defintion has been changed to use an explicit uint8_t array that is three bytes in size. This defines the structure in a way that guarantees the size of the record is correct.
The structure has also had a constructor added to it to eliminate code duplication, and to reduce the likelihood of errors caused by manual calculation of values.
Tested: Issued 'ipmitool sdr dump /tmp/sdrs.bin' Performed a hex dump on the binary data and reviewed the Type12 records. Confirmed all fields were correctly assigned, including the inclusion of only 3 reserved bytes.
Change-Id: I3fef5a1fe67877e5a6cf6e7928c5f15599bfb6f6 Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>
show more ...
|
3c7ec2d0 | 22-Sep-2021 |
Adrian Ambrożewicz <adrian.ambrozewicz@intel.com> |
Fix assigning Generator ID for IPMB path
Per IPMI spec - Generator ID is defined as follows for I2C sender: [7-1] = I2C Slave Address [0] = 0 (indicates IPMB Slave Address)
This change is introduci
Fix assigning Generator ID for IPMB path
Per IPMI spec - Generator ID is defined as follows for I2C sender: [7-1] = I2C Slave Address [0] = 0 (indicates IPMB Slave Address)
This change is introducing proper shift for IPMB path, so Generator ID is correctly assigned.
Tested: - tested on actual system with IPMB events originating from ME, - after this change SEL entries from ME have correct generator ID (0x2C).
Change-Id: I5b94e2242e5ac2b4d4ecc5c7e7cd9e8a93bd98ab Signed-off-by: Adrian Ambrożewicz <adrian.ambrozewicz@intel.com>
show more ...
|
e83c70aa | 22-Sep-2021 |
Arun Lal K M <arun.lal@intel.com> |
Add 'greater than' support in depex computation.
Added support in code to compute depex expressions with _GE_ and _GTE_.
Tested: With bios.xml file which had the following knob:
<knob type="scalar
Add 'greater than' support in depex computation.
Added support in code to compute depex expressions with _GE_ and _GTE_.
Tested: With bios.xml file which had the following knob:
<knob type="scalar" setupType="numeric" name="CoreDisableMask_0" varstoreIndex="05" prompt="CoreDisableMask_0" description="Core Disable Bitmap (Hex) 0: Enable all cores. 0xffff: Disable all cores " size="8" offset="0x014A" depex="Sif( SstPpLevelTotalCount _GT_ 1 AND ( ( IssTdpLevel _EQU_ 0xFF AND SstPpLevelEnableSystem_0 _NEQ_ 1 ) OR ( IssTdpLevel _NEQ_ 0xFF AND IssTdpLevel _GT_ 0 ) OR DynamicIss _EQU_ 1 ) )" default="0x0000000000000000" CurrentVal="0x0000000000000000" min="0x0" max="0xFFFFFFFFFFFFFFFF" step="0x1"/>
Signed-off-by: Arun Lal K M <arun.lal@intel.com> Change-Id: I45cd879ca1bb35e6cde9ea581b3a5c63577525d0
show more ...
|
b0caca06 | 05-Sep-2021 |
Arun Lal K M <arun.lal@intel.com> |
Fix support for Get Payload.
Get Payload is split into two as follows: 1) Get Payload Info (ipmitool raw 0x30 0xd6 0 1): Return info of Payload1 (pending list) data
2) Get Payload data (ipmitool ra
Fix support for Get Payload.
Get Payload is split into two as follows: 1) Get Payload Info (ipmitool raw 0x30 0xd6 0 1): Return info of Payload1 (pending list) data
2) Get Payload data (ipmitool raw 0x30 0xd6 1 1): Return Payload1 (pending list) data.
Note: Pending list is the BIOS knobs edited by patch to https://<IP>/redfish/v1/Systems/system/Bios/Settings, which is stored in BMC.
Tested: Step 1) Patch to https://<IP>/redfish/v1/Systems/system/Bios/Settings with the following data: { "data":{ "Ce2LmLoggingEn": "0x0", "CoreCrashLogDisable": "0x1", "CpuCrashLogClear": "0x0", "DfxEadrDebugLogs": "0x1", "DfxFadrDebugLogs": "0x1", "WheaLogMemoryEn": "0x1" } }
Step 2) Give command ipmitool raw 0x30 0xd6 0 1
Response: 00 00 01 7e 00 00 00 08 4c d3 e9 00 01 a8 9e 00 00
Step 3) Give command ipmitool raw 0x30 0xd6 1 1 0x09 0 0 0 0x7e 0 0 0
Response: 01 75 00 00 00 89 51 07 a0 69 6e 67 45 6e 3d 30 78 30 0a 43 6f 72 65 43 72 61 73 68 4c 6f 67 44 69 73 61 62 6c 65 3d 30 78 31 0a 43 70 75 43 72 61 73 68 4c 6f 67 43 6c 65 61 72 3d 30 78 30 0a 44 66 78 45 61 64 72 44 65 62 75 67 4c 6f 67 73 3d 30 78 31 0a 44 66 78 46 61 64 72 44 65 62 75 67 4c 6f 67 73 3d 30 78 31 0a 57 68 65 61 4c 6f 67 4d 65 6d 6f 72 79 45 6e 3d 30 78 31 0a
Signed-off-by: Arun Lal K M <arun.lal@intel.com> Change-Id: I6a3bec66f78c2c9b6296e3dbba7743971b372f75
show more ...
|
98cb6186 | 31-Aug-2021 |
Arun P. Mohanan <arun.p.m@linux.intel.com> |
fix: Correct bit mask for GetBMCServiceStatus cmd
Bit 14 and 15 of GetBMCServiceStatus command response represents status of Video and USB redirection. These 2 bits should match since a single servi
fix: Correct bit mask for GetBMCServiceStatus cmd
Bit 14 and 15 of GetBMCServiceStatus command response represents status of Video and USB redirection. These 2 bits should match since a single service maintains both. The logic for the same is already implemented. But incorrect mask resulted in error values when previously un-used bits(bit 13) got defined for new services.
This change corrects the bit mask to extract only bit 15
Tested: Verified commands is giving expected response Command: ipmitool raw 0x30 0xb2 Response: 68 e0 Command: ipmitool raw 0x30 0xB1 0x00 0x68 0xe0 Response: Success Command: ipmitool raw 0x30 0xb2 Response: 00 00
Signed-off-by: Arun P. Mohanan <arun.p.m@linux.intel.com> Change-Id: Iba8e44fe6ee21e599c6f1575c7ba90a48cdee746
show more ...
|
153d4c14 | 25-Aug-2021 |
Arun Lal K M <arun.lal@intel.com> |
Kloxwork Issue : NULL check after EVP_MD_CTX_new
EVP_MD_CTX_new could return NULL. This Commit adds a NULL check to avoid NULL pointer dereferencing.
Tested: By performing firmware update using fol
Kloxwork Issue : NULL check after EVP_MD_CTX_new
EVP_MD_CTX_new could return NULL. This Commit adds a NULL check to avoid NULL pointer dereferencing.
Tested: By performing firmware update using following steps.
1. Generate fw update random number ipmitool raw 0x08 0x26
2. Enter fw update mode ipmitool raw 0x08 0x27 0xa8 0xa8 0x32 0x49 0x0a 0x28 0xef 0x40
3. Start Image transfer ipmitool raw 0x08 0x29 0x01
4. Set Firmware update options ipmitool raw 0x08 0x2B 0x04 0x04 0xe3 0xb0 0xc4 0x42 0x98 0xfc 0x1c 0x14 0x9a 0xfb 0xf4 0xc8 0x99 0x6f 0xb9 0x24 0x27 0xae 0x41 0xe4 0x64 0x9b 0x93 0x4c 0xa4 0x95 0x99 0x1b 0x78 0x52 0xb8 0x55
5. Set file name (file:///tmp/BMC.Bin) ipmitool raw 0x08 0x29 0x04 0x13 0x66 0x69 0x6c 0x65 0x3a 0x2f 0x2f 0x2f 0x74 0x6d 0x70 0x2f 0x42 0x4d 0x43 0x2e 0x42 0x69 0x6e
6. End Image transfer ipmitool raw 0x08 0x29 0x02
7. Exit fw-update mode ipmitool raw 0x08 0x28
Signed-off-by: Arun Lal K M <arun.lal@intel.com> Change-Id: Iefb83247278bfc58af209dad252f01c4bf01f2f4
show more ...
|
3b3d29b1 | 05-Aug-2021 |
Vernon Mauery <vernon.mauery@linux.intel.com> |
Update to use SecureString and SecureBuffer
ipmiOEMSetUser2Activation gets a SecureBuffer and the extra OPENSSL_cleanse functions can be removed for SecureString
Change-Id: Ib629ea4c3bd12c446dfad67
Update to use SecureString and SecureBuffer
ipmiOEMSetUser2Activation gets a SecureBuffer and the extra OPENSSL_cleanse functions can be removed for SecureString
Change-Id: Ib629ea4c3bd12c446dfad671bb47ed0b61001fd6 Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
show more ...
|
69245b70 | 02-Sep-2021 |
Patrick Williams <patrick@stwcx.xyz> |
exception: switch to public sdbus exception
SdBusError was intended to be a private error type inside sdbusplus. Switch all catch locations to use the general sdbusplus::exception type.
Signed-off-
exception: switch to public sdbus exception
SdBusError was intended to be a private error type inside sdbusplus. Switch all catch locations to use the general sdbusplus::exception type.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: I9915c0207bbca91296548e7a1e707e499c3d7838
show more ...
|
23939855 | 02-Sep-2021 |
Patrick Williams <patrick@stwcx.xyz> |
oemcommands: use SecureString for password
The ipmiSetSpecialUserPassword API changed to now require a SecureString instead of a std::string.
See phosphor-host-ipmid commit 1e22a0f1a0348846eb56f534
oemcommands: use SecureString for password
The ipmiSetSpecialUserPassword API changed to now require a SecureString instead of a std::string.
See phosphor-host-ipmid commit 1e22a0f1a0348846eb56f534f101776dc445b764.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: Idc7a7f80b299b0753c958ae6d012812f2081810e
show more ...
|
d065702b | 26-Aug-2021 |
Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> |
Fix for ME version in get OEM Device info command
Issue: With current implementation, get OEM device info command is giving incorrect ME minor version in response.
Fix: Populate ME minor version sa
Fix for ME version in get OEM Device info command
Issue: With current implementation, get OEM device info command is giving incorrect ME minor version in response.
Fix: Populate ME minor version same as ME get device ID command minor version.
Tested: Verified using IPMI commands Command: ipmitool raw 0x30 0x27 1 //get OEM device info Response: 0a 00 72 ff ff ff ff 06 01 ff ff //ME get device ID Command: ipmitool -I lanplus -H <bmc-ip> -U <username> -P <password> -C 17 -t 0x2c -b 6 raw 6 1 Response: 50 01 06 01 02 21 57 01 00 18 0b 06 02 70 01
Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Change-Id: Ie0c6533eda5cb59f41a92be0381a21768a2d1082
show more ...
|
5cb2c045 | 17-Aug-2021 |
Jason M. Bills <jason.m.bills@linux.intel.com> |
Add PCIe scan option to BMC Feature Control command
This adds an option to enable and disable the PCIe scan feature using the MTM BMC Feature Control command.
Changes to request bytes for PCIe scan
Add PCIe scan option to BMC Feature Control command
This adds an option to enable and disable the PCIe scan feature using the MTM BMC Feature Control command.
Changes to request bytes for PCIe scan feature: Byte 1 – Supported features 01h - PCIe scan Byte 2 – Enable/Disable feature 00h – Stops the given feature 01h – Starts the given feature 02h – Disables the given feature 03h – Enables the given feature Byte 3:5 – reserved
Tested: Verified PCIe scan feature can be enabled/disabled as expected in MTM mode
Disable PCIe scan: ipmitool raw 0x30 0xa4 1 2 0 0 0
Enable PCIe scan: ipmitool raw 0x30 0xa4 1 3 0 0 0
Change-Id: I90be0b10469542bba80d3b29ff0c727b8a817dfe Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
show more ...
|
06584cd0 | 13-Aug-2021 |
Arun P. Mohanan <arun.p.m@linux.intel.com> |
Add MTM BMC Feature Control IPMI command
Certain features having security concerns needs to be enabled/disabled only in manufacturing mode. Add a command to support the same for MCTP feature.
In ad
Add MTM BMC Feature Control IPMI command
Certain features having security concerns needs to be enabled/disabled only in manufacturing mode. Add a command to support the same for MCTP feature.
In addition to starting or stopping a service, add an option to enable or disable a service which will persist across AC cycles.
Request bytes: Byte 1 – Supported features 00h - MCTP 01h to FFh - reserved (will be adding support for more features as needed) Byte 2 – Enable/Disable feature 00h – Stops the given feature 01h – Starts the given feature 02h - Disables the given feature 03h - Enables the given feature 04h to FFh – reserved Byte 3 - Custom feature arguments When byte 2 value is 00h: 00h - MCTP over PCIe 01h - MCTP over SMBus HSBP 02h - MCTP over SMBus PCIe slot 03h to FFh - reserved Byte 4:5 – reserved
Tested: Verified MCTP feature can be enabled/disabled as expected in MTM mode the change will persist across AC cycles.
Signed-off-by: Arun P. Mohanan <arun.p.m@linux.intel.com> Signed-off-by: Sumanth Bhat <sumanth.bhat@linux.intel.com> Change-Id: I8f8be36ee3e0fd85cfb1e44599cd0db0a6a8d34a
show more ...
|
36ed8d24 | 03-Aug-2021 |
P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com> |
Fix Klocwork Issue: Uninitialized variable
The boolean return value(ret) from smbiosUnlock() function is been declared but not initialized. Assigning "false" as the default value.
The variable "val
Fix Klocwork Issue: Uninitialized variable
The boolean return value(ret) from smbiosUnlock() function is been declared but not initialized. Assigning "false" as the default value.
The variable "value" in getMultiNodeRole() function is declared, but is being initialized in if-else-if condition, and missses the final else condition which could render the variable "value" to be uninitialized. Adding an else condition to return nullopt to fix this issue.
Signed-off-by: P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com> Change-Id: I51088b91d1d48ad1d1cc4779b2ed58fd2b79ee9c
show more ...
|
2346b5d2 | 06-Aug-2021 |
Johnathan Mantey <johnathanx.mantey@intel.com> |
Improve SDR sensor number mapping for sensor nums above 510
The recent submission to support SDR records defining Type 01 records for sensors did not work when the system had more than 510 sensors.
Improve SDR sensor number mapping for sensor nums above 510
The recent submission to support SDR records defining Type 01 records for sensors did not work when the system had more than 510 sensors. A recent change supplied a system that enumerated more sensors then IPMI can support. The change highlighted an error in how the Type 01 records were built.
This commit handles systems with a larger set of sensors. The code for handling SDR # 511 correctly creates sensor number 768. It then fills sensors to the limit of LUN 3.
Tested: A SUT that supplied 1946 sensors was used to implement and test the code. Test cases: "ipmitool sdr elist" returns 765 sensors "ipmitool sensor list" returns 765 sensors "ipmitool -l <lun> raw 4 0x2d <sn>" performed the correct behavior for luns 0-3, sensor numbers 0, 254, 255.
Change-Id: I8e5160c93e79a366b897554efdd60e2edcd3594a Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>
show more ...
|
27d2356e | 12-Aug-2021 |
Vernon Mauery <vernon.mauery@linux.intel.com> |
Add MFG Set FITc Layout command
FITc layout is used as the ROM ID for incremental PCH image updates to enforce image layout compatibility. The update image also contains this value and is compared u
Add MFG Set FITc Layout command
FITc layout is used as the ROM ID for incremental PCH image updates to enforce image layout compatibility. The update image also contains this value and is compared upon receipt of the update image.
Tested: set the layout: - enter MFG mode - ipmitool raw 0x30 0xa3 W X Y Z - inspect fitc layout file on BMC
Change-Id: I72930407a230b55340f6d12cef48e0e8d273ed6e Signed-off-by: Vernon Mauery <vernon.mauery@linux.intel.com>
show more ...
|
a87dbd4e | 23-Jul-2021 |
gokulsanker <gokul.sanker.v.g@intel.com> |
Code clean up to handle memory exception
Modified the code to Pass string data pointer instead of the string object reference
Signed-off-by: gokulsanker <gokul.sanker.v.g@intel.com> Change-Id: I287
Code clean up to handle memory exception
Modified the code to Pass string data pointer instead of the string object reference
Signed-off-by: gokulsanker <gokul.sanker.v.g@intel.com> Change-Id: I28759c5d9d7a2632222c5395b08366a81a0ec4fd
show more ...
|
e7725610 | 15-Jul-2021 |
Arun Lal K M <arun.lal@intel.com> |
Add depex support in bios.xml parsing.
Added logic to execute depex expression for every knob in bios.xml. knob is added to BiosAttributeRegistry only if depex evaluation result is TRUE.
Tested: By
Add depex support in bios.xml parsing.
Added logic to execute depex expression for every knob in bios.xml. knob is added to BiosAttributeRegistry only if depex evaluation result is TRUE.
Tested: By giving GET Request to 'redfish/v1/Registries/BiosAttributeRegistry/BiosAttributeRegistry'. Output sample showing few knobs added becuase depex evaluation result was TRUE:
{ "AttributeName": "AEPErrorInjEn", "CurrentValue": "0x00", "DefaultValue": "0x00", "DisplayName": "AEPErrorInjEn", "HelpText": "Enable/Disable PMem Error Injection", "MenuPath": "./", "ReadOnly": false, "Type": "String", "Value": [ { "OneOf": "0x0" }, { "OneOf": "0x1" } ] } { "AttributeName": "wrVrefCenter", "CurrentValue": "0x01", "DefaultValue": "0x01", "DisplayName": "wrVrefCenter", "HelpText": "Write Vref Centering Disable/Enable", "MenuPath": "./", "ReadOnly": false, "Type": "String", "Value": [ { "OneOf": "0x0" }, { "OneOf": "0x1" } ] }
Following are few knobs rejected becuase depex evaluation result was FALSE:
<knob type="scalar" setupType="oneof" name="PfrProvision" varstoreIndex="04" prompt="PFR Provision" description="Selectable if PFR is not locked." size="1" offset="0x0126" depex="Sif( PfrSupported _EQU_ 0 ) _AND_ Gif( PfrLockStatus _EQU_ 1 OR PfrProvisionStatus _EQU_ 1 )" default="0x00" CurrentVal="0x00"> <options> <option text="Disable" value="0x0"/> <option text="Enable" value="0x1"/> </options> </knob>
<knob type="scalar" setupType="oneof" name="SataHotPlugController0_0" varstoreIndex="01" prompt=" Hot Plug" description="Designates this port as Hot Pluggable." size="1" offset="0x0119" depex="Sif( PchSata_0 _EQU_ 0 ) _AND_ Sif( SataExternalController0_0 _EQU_ 1 )" default="0x00" CurrentVal="0x00"> <options> <option text="Disabled" value="0x0"/> <option text="Enabled" value="0x1"/> </options> </knob>
Signed-off-by: Arun Lal K M <arun.lal@intel.com> Change-Id: Iff1ea01fb06200e21cc7f2a2e0fdfdff70376581
show more ...
|
b485b1e6 | 28-Jul-2021 |
Johnathan Mantey <johnathanx.mantey@intel.com> |
Make sensor/sdr list commands work on systems with > 255 sensors
The "ipmitool sdr elist" and "ipmitool sensor list" commands failed to operate correctly on systems that contain more than 255 sensor
Make sensor/sdr list commands work on systems with > 255 sensors
The "ipmitool sdr elist" and "ipmitool sensor list" commands failed to operate correctly on systems that contain more than 255 sensors. A change made in the past assigned up to 255 sensors to LUN 0, 1, and 3. The code for iterating the SDR's did not get updated at the same time. The SDR record number acted as the sensor number. This incompatibility caused error response codes to be returned when sensor number 255 (which is reserved) was accessed.
The change in this commit modifies the SDR access code to prevent using the reserved sensor number. SDR records are still assigned in order. The sensor number associated with the SDR are assigned to avoid the reserved value, and in the same manner as code previously submitted and merged.
Tested: Installed the modified code on a SUT that enumerates more than 256 sensors. Issued "ipmitool sensor list" and confirmed all sensors were displayed. The "Get SDR 00ff command failed: Invalid data field in request" error message was not displayed. Issued "ipmitool sdr elist" and confirmed all sensors were displayed. The "Get SDR 00ff command failed: Invalid data field in request" error message was not displayed. Confirmed the sensor number/LUN guard code was not activated.
Change-Id: I194a3116fdf255527a8c5036ee71b8b478c9b275 Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>
show more ...
|
3694d07a | 22-Jul-2021 |
Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> |
Fix for set/get EFI boot options unsupported param
In Set/get EFI boot Options IPMI command, for unsupported parameter giving incorrect response. So return as ccParameterNotSupported for unsupporte
Fix for set/get EFI boot options unsupported param
In Set/get EFI boot Options IPMI command, for unsupported parameter giving incorrect response. So return as ccParameterNotSupported for unsupported parameters.
Tested: Verified using IPMI command Command : ipmitool raw 0x30 0xea 0x27 0x27 //Set EFI boot options Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0 cmd=0xea rsp=0x80): Unknown (0x80) Command : ipmitool raw 0x30 0xea 0x7 0x27 0x34 Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0 cmd=0xea rsp=0x80): Unknown (0x80) Command : ipmitool raw 0x30 0xeb 0x27 0x27 0x34 //Get EFI boot options Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0 cmd=0xea rsp=0x80): Unknown (0x80) Command : ipmitool raw 0x30 0xeb 0x7 0x27 0x34 Response: Unable to send RAW command (channel=0x0 netfn=0x30 lun=0x0 cmd=0xea rsp=0x80): Unknown (0x80)
Signed-off-by: Jayaprakash Mutyala <mutyalax.jayaprakash@intel.com> Change-Id: I6b3dd9d8d8bef501698b7b82c5934ef9f1f381ec
show more ...
|
440f62bf | 15-Jul-2021 |
Manish Baing <manish.baing@intel.com> |
Reset ChannelInfo before calling getChannelInfo()
chInfo is initialized with '0' in statement 'ChannelInfo chInfo{};' This is to make sure even if getChannelInfo function fails to update chInfo,u
Reset ChannelInfo before calling getChannelInfo()
chInfo is initialized with '0' in statement 'ChannelInfo chInfo{};' This is to make sure even if getChannelInfo function fails to update chInfo,un-initialized/previous chInfo data will not be used for further execution in function ipmiOEMSetUser2Activation.
Tested: By printing structure chInfo for each IPMI channel before calling getChannelInfo function, we observed that 'chInfo' structure intialized with zeroes for each IPMI channel.
Signed-off-by: Manish Baing <manish.baing@intel.com> Change-Id: I0fcfabd30d05f4d360758cff31bb98fff01c5f7e
show more ...
|
9f8d027a | 14-Jul-2021 |
P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com> |
Klockwork Issue Fix : Index range check
Though the caller of smbiosIsUpdating() is handling index range check (#757), it is preferable that the function also has the right check in place. With the p
Klockwork Issue Fix : Index range check
Though the caller of smbiosIsUpdating() is handling index range check (#757), it is preferable that the function also has the right check in place. With the present implementation, index can go up to maxDirEntries which is not the correct functionality. This commit fixes the range check.
Signed-off-by: P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com> Change-Id: I4f3cb15c3a26e9462ee6e0f425c8e9156bce4731
show more ...
|
c08e9752 | 14-Jul-2021 |
P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com> |
Klocwork Issue Fix - File Resource Lost
In the event when file_size() fails and file open was successful, with the current implementation, the function would return without closing the file. This co
Klocwork Issue Fix - File Resource Lost
In the event when file_size() fails and file open was successful, with the current implementation, the function would return without closing the file. This commit fixes this condition by having separate checks for file_size error code and file open failure.
Signed-off-by: P Dheeraj Srujan Kumar <p.dheeraj.srujan.kumar@intel.com> Change-Id: I44e46a4093f5fab087b40bb95440fbb3d215bad8
show more ...
|