| 47a0ada2 | 29-Nov-2023 |
Patrick Williams <patrick@stwcx.xyz> |
build: use allowed over enabled
Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer retur
build: use allowed over enabled
Meson feature options are typically in a tri-state of enabled, disabled,
or auto. The enabled and disabled functions on an option (from
`get_option`) no longer return true for auto features. Instead, the
expectation is to use `allowed()` which is true for both enabled and auto.
Switch all uses of `enabled` to `allowed`.
Change-Id: I91fe34f9d6743a3afeef73c3e55847542cea143c
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| 6084957f | 20-Oct-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest
clang-format: copy latest and re-format
clang-format-17 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.
Change-Id: I4610d1d37873b2019baa2ae22c036f81f4319214
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| a9a98258 | 18-Sep-2023 |
Willy Tu <wltu@google.com> |
ncsid: Fix if_packet warnings
The new Docker CI now hits the following error.
```
/usr/include/linux/if_packet.h:24:17: error: flexible array member 'sockaddr_ll::<unnamed union>::<unnamed struct>::
ncsid: Fix if_packet warnings
The new Docker CI now hits the following error.
```
/usr/include/linux/if_packet.h:24:17: error: flexible array member 'sockaddr_ll::<unnamed union>::<unnamed struct>::sll_addr_flex' not at end of 'class ncsi::SockIO'
24 | __DECLARE_FLEX_ARRAY(unsigned char, sll_addr_flex);
| ^~~~~~~~~~~~~~~~~~~~
../subprojects/ncsid/src/ncsi_sockio.h:55:15: note: next member 'const int ncsi::SockIO::kpoll_timeout_' declared here
55 | const int kpoll_timeout_ = 10;
| ^~~~~~~~~~~~~~
../subprojects/ncsid/src/ncsi_sockio.h:29:7: note: in the definition of 'class ncsi::SockIO'
29 | class SockIO : public net::SockIO
```
Removed the sockaddr_ll variable.
Change-Id: I67e700f6cd728bfbc822c1b8661915f8306711a1
Signed-off-by: Willy Tu <wltu@google.com>
show more ...
|
| f8bb4779 | 21-Jul-2023 |
William A. Kennington III <wak@google.com> |
ncsid: Fix build issue
IWYU
Change-Id: Ibd54f428ea8e6e5c9f9dfd2ec8da4fcfbafdb572
Signed-off-by: William A. Kennington III <wak@google.com> |
| cc45be7c | 06-Jul-2023 |
John Wedig <johnwedig@google.com> |
espi-control: Add program to disable eSPI
This commit introduces a program that can disable and re-enable eSPI on
a Nuvoton BMC.
Tested:
- Ran "npcm7xx_espi_control -d", and confirmed that IPMI sto
espi-control: Add program to disable eSPI
This commit introduces a program that can disable and re-enable eSPI on
a Nuvoton BMC.
Tested:
- Ran "npcm7xx_espi_control -d", and confirmed that IPMI stopped
working.
- Ran "npcm7xx_espi_control", and confirmed that IPMI started working
again.
Change-Id: I9637ac4d84b82931f107946ff53e7ef16a965d25
Signed-off-by: John Wedig <johnwedig@google.com>
show more ...
|
| adb8ffe4 | 17-Jul-2023 |
Willy Tu <wltu@google.com> |
iwyu: Cleanup include headers
Triggered iwyu and add/remove used headers.
Change-Id: Iadbdb459563b3c89baf2d56f90a540342d020cd5
Signed-off-by: Willy Tu <wltu@google.com> |
| bb53161d | 16-Jul-2023 |
Willy Tu <wltu@google.com> |
cleanup fmt::format for std::format
Update the code to use std::format since gcc13 supports it now. Also
cleaned up some unused headers.
Change-Id: Ief2ad4df9e8b8227168f4f98213da8b3978fda03
Signed-
cleanup fmt::format for std::format
Update the code to use std::format since gcc13 supports it now. Also
cleaned up some unused headers.
Change-Id: Ief2ad4df9e8b8227168f4f98213da8b3978fda03
Signed-off-by: Willy Tu <wltu@google.com>
show more ...
|
| 1dfe24ea | 12-Jul-2023 |
Patrick Williams <patrick@stwcx.xyz> |
build: upgrade to C++23
Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.
Change-Id: Ibb8913a93032d388399b6
build: upgrade to C++23
Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.
Change-Id: Ibb8913a93032d388399b65904013e284780dad70
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| 580abaff | 06-Jul-2023 |
Willy Tu <wltu@google.com> |
build: Fix build warnings
```
../subprojects/metrics-ipmi-blobs/util.hpp:32:5: error: 'uint64_t' does not name a type
32 | uint64_t firmwareTime = 0;
| ^~~~~~~~
../subprojects/metri
build: Fix build warnings
```
../subprojects/metrics-ipmi-blobs/util.hpp:32:5: error: 'uint64_t' does not name a type
32 | uint64_t firmwareTime = 0;
| ^~~~~~~~
../subprojects/metrics-ipmi-blobs/util.hpp:18:1: note: 'uint64_t' is defined in header '<cstdint>'; did you forget to '#include <cstdint>'?
17 | #include <string>
+++ |+#include <cstdint>
18 | #include <string_view>
...
../subprojects/nemora-postd/src/serializer.cpp:66:28: error: call of overloaded 'format(const char [15], std::string)' is ambiguous
66 | log<level::INFO>(format("NemoraEvent {}", pb.DebugString()).c_str());
```
Change-Id: Id7da1567cdf8cd74d94bd71fa338099b1f0b861e
Signed-off-by: Willy Tu <wltu@google.com>
show more ...
|
| 2be45238 | 10-May-2023 |
Patrick Williams <patrick@stwcx.xyz> |
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest
clang-format: copy latest and re-format
clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.
Change-Id: Ia240047e2472bccb2bb039ff71bea20a7a602ec4
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| 4c4e94f0 | 12-Apr-2023 |
Patrick Williams <patrick@stwcx.xyz> |
meson: remove deprecated get_pkgconfig_variable
Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig
meson: remove deprecated get_pkgconfig_variable
Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.
Change-Id: Ibc0692c5cd05546e797c20973e1c1f172dcb8379
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| 5ca20ffe | 30-Mar-2023 |
Yuxiao Zhang <yuxiaozhang@google.com> |
dhcp-done: send status to notify netboot service
This enables the daemon for sending boot status so that netboot service
can take actions accordingly.
Tested with nc and verified that the data byte
dhcp-done: send status to notify netboot service
This enables the daemon for sending boot status so that netboot service
can take actions accordingly.
Tested with nc and verified that the data byte is present.
Change-Id: I570bbd7c05028b6c007ff9d5a00a8589da73a8ff
Signed-off-by: Yuxiao Zhang <yuxiaozhang@google.com>
show more ...
|
| 27364013 | 27-Feb-2023 |
William A. Kennington III <wak@google.com> |
ncsid: Only delete static addresses
Technically this is safe, but it causes errors to be logged.
Change-Id: I5872e2dd7c9da4ce0dc82b80dd642c715d76b0be
Signed-off-by: William A. Kennington III <wak@g
ncsid: Only delete static addresses
Technically this is safe, but it causes errors to be logged.
Change-Id: I5872e2dd7c9da4ce0dc82b80dd642c715d76b0be
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| 1e5029b4 | 27-Feb-2023 |
William A. Kennington III <wak@google.com> |
ncsid: UpdateIP should not add the nul address
It's technically safe, but it produces errors unnecessarily.
Change-Id: I48aee2560f9bf58553147febe6b3abaf49c7414d
Signed-off-by: William A. Kennington
ncsid: UpdateIP should not add the nul address
It's technically safe, but it produces errors unnecessarily.
Change-Id: I48aee2560f9bf58553147febe6b3abaf49c7414d
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| 25c55c54 | 08-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
prettier: re-format
Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.
prettier: re-format
Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.
Change-Id: Ib442712e2562fac166148ce795f0a83511ad84cd
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| 59486679 | 08-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
beautysh: re-format
beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.
Change-Id: I6a61656dd
beautysh: re-format
beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.
Change-Id: I6a61656dd6033329cba124ac0754152cbd1e9de3
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
show more ...
|
| 5d074370 | 04-Dec-2022 |
Patrick Williams <patrick@stwcx.xyz> |
ncsid: add shebang on shell libraries
In order for these files to be clearly identified as shell,
it is useful to add the shebang on them. Otherwise, the linters
cannot identify them as shell and d
ncsid: add shebang on shell libraries
In order for these files to be clearly identified as shell,
it is useful to add the shebang on them. Otherwise, the linters
cannot identify them as shell and do not pass them to shellcheck.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia214e5418e24b53af29cbdec151f2838d08ae506
show more ...
|
| 9632cb8a | 05-Oct-2022 |
Harvey.Wu <Harvey.Wu@quantatw.com> |
nemora-postd: update add_option function
- cli11 update from 1.9.1 to 2.2.2 in PR-57585(ref1)
According cli11's commit(ref2), the add_option function needs update
ref:
1. https://gerrit.openbmc.o
nemora-postd: update add_option function
- cli11 update from 1.9.1 to 2.2.2 in PR-57585(ref1)
According cli11's commit(ref2), the add_option function needs update
ref:
1. https://gerrit.openbmc.org/c/openbmc/openbmc/+/57585
2. https://github.com/CLIUtils/CLI11/commit/e2e3cb2fed20b0c25eaf6d2689784b9c0e3730f1
Signed-off-by: Harvey.Wu <Harvey.Wu@quantatw.com>
Change-Id: I165f35dc02d27afb56ca4e88a9e08f0564033acd
show more ...
|
| 24695690 | 04-Aug-2022 |
Patrick Williams <patrick@stwcx.xyz> |
MAINTAINERS: remove file
The MAINTAINERS file is deprecated in favor of OWNERS.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I524eafe25c461b0dd987e7c31f142264866c6fa3
|
| 5cc62fe6 | 04-Aug-2022 |
Patrick Williams <patrick@stwcx.xyz> |
OWNERS: fix syntax
Two subdirectory OWNERS files had invalid syntax which caused the
tools to crash.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia7cef2eae99eaf6fbdddc099b2261e35
OWNERS: fix syntax
Two subdirectory OWNERS files had invalid syntax which caused the
tools to crash.
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia7cef2eae99eaf6fbdddc099b2261e35862cb18e
show more ...
|
| 59ac2c2d | 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5055fac459cb021ea94686e058e233bcc476a32d
show more ...
|
| d7989581 | 27-May-2022 |
William A. Kennington III <wak@google.com> |
ncsid: Fix interruptible RA
Capturing directly from a subshell into a variable blocks the bash
process from waiting on a signal. Instead, use `coproc` and `read` to
achieve the same result.
Change-
ncsid: Fix interruptible RA
Capturing directly from a subshell into a variable blocks the bash
process from waiting on a signal. Instead, use `coproc` and `read` to
achieve the same result.
Change-Id: I7ad8b01e2508c5a0c871d77d3a629ac5812656c5
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| a5c9d7a4 | 11-May-2022 |
William A. Kennington III <wak@google.com> |
ncsid: Guarantee MAC override
This allows us to runtime configure the mac address of the link while
still being able to have ncsid write an updated one.
Tested: On hardware and verified that the fi
ncsid: Guarantee MAC override
This allows us to runtime configure the mac address of the link while
still being able to have ncsid write an updated one.
Tested: On hardware and verified that the file gets written with the
MAC updated.
Change-Id: I1081ace0829f686e2e5bb34321433c5eb5b531dd
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| ac9dad14 | 26-May-2022 |
William A. Kennington III <wak@google.com> |
ncsid: update-ra-gw: Always keep RA updated
Even if we aren't using ncsid itself we should still try and update the
default router.
Change-Id: Idd8599dcb7003eafa50c03bde58ef5c3cb931e9f
Signed-off-b
ncsid: update-ra-gw: Always keep RA updated
Even if we aren't using ncsid itself we should still try and update the
default router.
Change-Id: Idd8599dcb7003eafa50c03bde58ef5c3cb931e9f
Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
| 3d7cd157 | 25-Apr-2022 |
Michael Shen <gpgpgp@google.com> |
metrics-ipmi-blobs: Fix memory leak with readMem
Add `munmap` after `mmap` succeeded.
Otherwise it might cause memory after 65500+ times.
Tested:
(Provided by @suichen)
```
Without munmap:
/tmp# .
metrics-ipmi-blobs: Fix memory leak with readMem
Add `munmap` after `mmap` succeeded.
Otherwise it might cause memory after 65500+ times.
Tested:
(Provided by @suichen)
```
Without munmap:
/tmp# ./mmap_test
...
65100 mmaps
65200 mmaps
65300 mmaps
65400 mmaps
65500 mmaps
ERR: 12
ERROR with 65503 mmaps
ERR: 12
-----------------------------------------------------------------
With unmap:
/tmp# WITH_UNMAP=1 ./mmap_test
...
161700 mmaps
161800 mmaps
161900 mmaps
162000 mmaps
162100 mmaps
162200 mmaps
...
```
Signed-off-by: Michael Shen <gpgpgp@google.com>
Change-Id: Ie68d4f42337ca3459ae60dc1f649ed1b25631b17
show more ...
|