cleanup fmt::format for std::format

Update the code to use std::format since gcc13 supports it now. Also
cleaned up some unused headers.

Change-Id: Ief2ad4df9e8b8227168f4f98213da8b3978fda03
Signed-

cleanup fmt::format for std::format

Update the code to use std::format since gcc13 supports it now. Also
cleaned up some unused headers.

Change-Id: Ief2ad4df9e8b8227168f4f98213da8b3978fda03
Signed-off-by: Willy Tu <wltu@google.com>

show more ...

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: Ibb8913a93032d388399b6

build: upgrade to C++23

Meson 1.1.1 and GCC-13 both support C++23 and a sufficient portion of
the standard has been implemented. Upgrade the build to leverage it.

Change-Id: Ibb8913a93032d388399b65904013e284780dad70
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest

clang-format: copy latest and re-format

clang-format-16 has some backwards incompatible changes that require
additional settings for best compatibility and re-running the formatter.
Copy the latest .clang-format from the docs repository and reformat the
repository.

Change-Id: Ia240047e2472bccb2bb039ff71bea20a7a602ec4
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig

meson: remove deprecated get_pkgconfig_variable

Since meson 0.56, the `get_pkgconfig_variable` has been deprecated. In
meson 0.58 the `get_variable` was enhanced to no longer require the
`pkgconfig` keyword argument. Ensure meson 0.58 is required and update
the usage of all `get_pkgconfig_variable` and `get_variable` to be the
modern variant.

Change-Id: Ibc0692c5cd05546e797c20973e1c1f172dcb8379
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

ncsid: Only delete static addresses

Technically this is safe, but it causes errors to be logged.

Change-Id: I5872e2dd7c9da4ce0dc82b80dd642c715d76b0be
Signed-off-by: William A. Kennington III <wak@g

ncsid: Only delete static addresses

Technically this is safe, but it causes errors to be logged.

Change-Id: I5872e2dd7c9da4ce0dc82b80dd642c715d76b0be
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ncsid: UpdateIP should not add the nul address

It's technically safe, but it produces errors unnecessarily.

Change-Id: I48aee2560f9bf58553147febe6b3abaf49c7414d
Signed-off-by: William A. Kennington

ncsid: UpdateIP should not add the nul address

It's technically safe, but it produces errors unnecessarily.

Change-Id: I48aee2560f9bf58553147febe6b3abaf49c7414d
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

prettier: re-format

Prettier is enabled in openbmc-build-scripts on Markdown, JSON, and YAML
files to have consistent formatting for these file types. Re-run the
formatter on the whole repository.

Change-Id: Ib442712e2562fac166148ce795f0a83511ad84cd
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: I6a61656dd

beautysh: re-format

beautysh is enabled in the openbmc-build-scripts on Bash/Zsh/POSIX-sh
files to have a consistent formatting. Re-run the formatter on the
whole repository.

Change-Id: I6a61656dd6033329cba124ac0754152cbd1e9de3
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

ncsid: add shebang on shell libraries

In order for these files to be clearly identified as shell,
it is useful to add the shebang on them. Otherwise, the linters
cannot identify them as shell and d

ncsid: add shebang on shell libraries

In order for these files to be clearly identified as shell,
it is useful to add the shebang on them. Otherwise, the linters
cannot identify them as shell and do not pass them to shellcheck.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia214e5418e24b53af29cbdec151f2838d08ae506

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I5055fac459cb021ea94686e058e233bcc476a32d

show more ...

ncsid: Fix interruptible RA

Capturing directly from a subshell into a variable blocks the bash
process from waiting on a signal. Instead, use `coproc` and `read` to
achieve the same result.

Change-

ncsid: Fix interruptible RA

Capturing directly from a subshell into a variable blocks the bash
process from waiting on a signal. Instead, use `coproc` and `read` to
achieve the same result.

Change-Id: I7ad8b01e2508c5a0c871d77d3a629ac5812656c5
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ncsid: Guarantee MAC override

This allows us to runtime configure the mac address of the link while
still being able to have ncsid write an updated one.

Tested: On hardware and verified that the fi

ncsid: Guarantee MAC override

This allows us to runtime configure the mac address of the link while
still being able to have ncsid write an updated one.

Tested: On hardware and verified that the file gets written with the
MAC updated.

Change-Id: I1081ace0829f686e2e5bb34321433c5eb5b531dd
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ncsid: update-ra-gw: Always keep RA updated

Even if we aren't using ncsid itself we should still try and update the
default router.

Change-Id: Idd8599dcb7003eafa50c03bde58ef5c3cb931e9f
Signed-off-b

ncsid: update-ra-gw: Always keep RA updated

Even if we aren't using ncsid itself we should still try and update the
default router.

Change-Id: Idd8599dcb7003eafa50c03bde58ef5c3cb931e9f
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ncsid: Fix IP / Gateway updating

Sometimes phosphor-networkd incorrectly determines that DHCP should be
enabled. This prevents us from assigning IPs and gateways to the BMC.
Disable DHCP to fix assi

ncsid: Fix IP / Gateway updating

Sometimes phosphor-networkd incorrectly determines that DHCP should be
enabled. This prevents us from assigning IPs and gateways to the BMC.
Disable DHCP to fix assignment.

Change-Id: I91c8da79afb2ff1f1dba924f8c229ee8862bdeab
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ncsid: Use per-interface gateway

Change-Id: I97185fc181918ad4668cb4e758eec25c51090b04
Signed-off-by: William A. Kennington III <wak@google.com>

ncsid: Fix update_ra_gw for multi-RA

Change-Id: I2a3e796b39fe3dd4a3de0b347277d846896c010a
Signed-off-by: William A. Kennington III <wak@google.com>

ncsid: update_ra_gw: Fix SIGTERM handling

We need to make sure we handle TERMS correctly so the service can
shutdown in a reasonable amount of time.

Change-Id: I955f0871d7f9764de7565390913a7db2942e

ncsid: update_ra_gw: Fix SIGTERM handling

We need to make sure we handle TERMS correctly so the service can
shutdown in a reasonable amount of time.

Change-Id: I955f0871d7f9764de7565390913a7db2942e418e
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ncsid: Only log errors a single time

This reduces the amount of contents in the journal when an NCSI cable
is missing or the interface is broken.

It still periodically logs repeat messages, but onl

ncsid: Only log errors a single time

This reduces the amount of contents in the journal when an NCSI cable
is missing or the interface is broken.

It still periodically logs repeat messages, but only once per hour
instead of potentially many times a second.

Change-Id: Ic2efad4d3dea170863a5d4cbe48668a13007045c
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ncsid: Add service for discovering routers

This will be required for relaying egress traffic from the BMC network
once the static network configurations go away. Currently this will just
be redundan

ncsid: Add service for discovering routers

This will be required for relaying egress traffic from the BMC network
once the static network configurations go away. Currently this will just
be redundant behavior with existing gateway discovery.

Change-Id: I26b3f040f0752b948b9c1d9a9110a975f8168f8a
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ncsid: Ignore delete failures

Some of the spurious objects fail to delete. We should just ignore them
as this is normal for any non-static addresses or neighbors.

Change-Id: I10e58b94160bb935a5dd77

ncsid: Ignore delete failures

Some of the spurious objects fail to delete. We should just ignore them
as this is normal for any non-static addresses or neighbors.

Change-Id: I10e58b94160bb935a5dd77aefd0b0ecfeaa9d680
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

build: Update to c++20, c18, and meson >= 0.57.0

Change-Id: I6b4862f1aa2f8778d63b2b905762437071afd9c6
Signed-off-by: Willy Tu <wltu@google.com>

ncsid: Fix update_ra_neighbor.sh license

Change-Id: If4bcdd0f5d816a29e1c29a0f633c5c7e1bae4d05
Signed-off-by: William A. Kennington III <wak@google.com>

ncsid: Support parsing unsolicited RA announcements

We depend on this for router's whose MACs change over the lifetime of
the BMC and need updates even when we can't send neighbor solicitations
and

ncsid: Support parsing unsolicited RA announcements

We depend on this for router's whose MACs change over the lifetime of
the BMC and need updates even when we can't send neighbor solicitations
and receive advertisements.

Change-Id: Id7eb8ee8d44aea597a63276acc698f8fee9059b2
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ncsid: Stop targets when daemon stops

We want to make sure dhcp clients and neighbor updaters stop if the ncsi
daemon is stopped.

Change-Id: I5a5a0d412621591d3725425110d55d5804b31a0f
Signed-off-by:

ncsid: Stop targets when daemon stops

We want to make sure dhcp clients and neighbor updaters stop if the ncsi
daemon is stopped.

Change-Id: I5a5a0d412621591d3725425110d55d5804b31a0f
Signed-off-by: William A. Kennington III <wak@google.com>

show more ...

ncsid: build: Fix fallback dependency

Change-Id: Ifc59893845f2b95d62f49528d00a69861436ec41
Signed-off-by: William A. Kennington III <wak@google.com>