ba32fe4e | 19-Mar-2019 |
Patrick Venture <venture@google.com> |
build: enable valgrind
Enable valgrind to check memory usage.
Change-Id: I0d1e5d72b713819d125e365b33c4bc4f58890f73 Signed-off-by: Patrick Venture <venture@google.com> |
45fad1bb | 18-Mar-2019 |
Patrick Venture <venture@google.com> |
style change: lowerCamel
Methods in openbmc are lowercamel.
Change-Id: I57567b66acdc1fc618f3ca7d237455d55783630c Signed-off-by: Patrick Venture <venture@google.com> |
49f23ad9 | 16-Mar-2019 |
Patrick Venture <venture@google.com> |
add handler logic to handle i2c pcie commands
Add handler logic to manage the i2c pcie commands and their corresponding data structure.
Tested: Only ran unit-tests (added new ones). Change-Id: Ibd6
add handler logic to handle i2c pcie commands
Add handler logic to manage the i2c pcie commands and their corresponding data structure.
Tested: Only ran unit-tests (added new ones). Change-Id: Ibd65d6745202dbf6bd67cd2cb480914ca6ae4ed1 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
72e1a882 | 16-Mar-2019 |
Patrick Venture <venture@google.com> |
pcie_i2c: cleanup headers
Cleanup headers by dropping unused ones and adding missing ones.
Tested: Only ran unit-tests. Change-Id: I64ee6164e7de0295226c399b0f03d67bba34554f Signed-off-by: Patrick V
pcie_i2c: cleanup headers
Cleanup headers by dropping unused ones and adding missing ones.
Tested: Only ran unit-tests. Change-Id: I64ee6164e7de0295226c399b0f03d67bba34554f Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
3fb74294 | 16-Mar-2019 |
Patrick Venture <venture@google.com> |
util: add i2c->pcie map build method
Move method to util that handles creating a mapping between i2c-bus numbers and their pci-e slot names. It's done as a list of tuples.
Tested: Only ran unit-te
util: add i2c->pcie map build method
Move method to util that handles creating a mapping between i2c-bus numbers and their pci-e slot names. It's done as a list of tuples.
Tested: Only ran unit-tests. Change-Id: Ie09d193add63245eebcf3806255311232a7c4c9a Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
8d5c9cec | 16-Mar-2019 |
Patrick Venture <venture@google.com> |
util: move read_file to readPropertyFile
Move a method that reads a file and discards any trailing nul-terminator found. This is expected in dts property files.
Tested: Only ran unit-tests. Change
util: move read_file to readPropertyFile
Move a method that reads a file and discards any trailing nul-terminator found. This is expected in dts property files.
Tested: Only ran unit-tests. Change-Id: I4a551c0098862bcc1cfb7b20d518d7e2fa890a85 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
ab650004 | 16-Mar-2019 |
Patrick Venture <venture@google.com> |
entityName: move pieces into handler object
Move different items used by the handler into the handler and enable unit-testing by parameterizing different aspects of the code.
Tested: Only ran unit-
entityName: move pieces into handler object
Move different items used by the handler into the handler and enable unit-testing by parameterizing different aspects of the code.
Tested: Only ran unit-tests (added new ones). Change-Id: Ia3b4b5792c0ac1ae5bc6513eadfc9ee35f7a369f Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
91c2158d | 16-Mar-2019 |
Patrick Venture <venture@google.com> |
handler: delete extra namespace alias
Delete extra namespace alias for phosphor::logging.
ested: Only ran unit-tests. Change-Id: I2ed78bae5dba4c51d4d151d8c9e670ec04419e98 Signed-off-by: Patrick Ven
handler: delete extra namespace alias
Delete extra namespace alias for phosphor::logging.
ested: Only ran unit-tests. Change-Id: I2ed78bae5dba4c51d4d151d8c9e670ec04419e98 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
07f85150 | 15-Mar-2019 |
Patrick Venture <venture@google.com> |
add handler logic to handle SysEntityName
Add handler logic to handler for SysEntityName such that it splits the true IPMI processing from the business logic.
Tested: Only ran unit-tests (added new
add handler logic to handle SysEntityName
Add handler logic to handler for SysEntityName such that it splits the true IPMI processing from the business logic.
Tested: Only ran unit-tests (added new ones). Change-Id: I6d672a80f85843ff98c2c7e5daf4689932ff96f9 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
e8ecdf49 | 16-Mar-2019 |
Patrick Venture <venture@google.com> |
entity_name: cleanup headers
Drop unused headers, add missing explicit header.
Change-Id: I35d94ba205cef677e59620c24e27ec0bffba7743 Signed-off-by: Patrick Venture <venture@google.com> |
aa374120 | 15-Mar-2019 |
Patrick Venture <venture@google.com> |
add handler logic to handle SysPsuHardReset
Add handler logic to handler for SysPsuHardReset such that it splits the true IPMI processing from the business logic.
Tested: Only ran unit-tests (added
add handler logic to handle SysPsuHardReset
Add handler logic to handler for SysPsuHardReset such that it splits the true IPMI processing from the business logic.
Tested: Only ran unit-tests (added new ones). Change-Id: Id5dae85cbc54db7dee3cb5e62ed80c77ff3d5719 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
bb90d4fd | 15-Mar-2019 |
Patrick Venture <venture@google.com> |
add handler logic to handle SysCpldVersion
Add handler logic to handler for SysCpldVersion such that it splits the true IPMI processing from the business logic.
Tested: Only ran unit-tests (added n
add handler logic to handle SysCpldVersion
Add handler logic to handler for SysCpldVersion such that it splits the true IPMI processing from the business logic.
Tested: Only ran unit-tests (added new ones). Change-Id: I09d95d8be8fbe75648b3332af898336b00074c2f Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
d2037c6a | 15-Mar-2019 |
Patrick Venture <venture@google.com> |
add handler logic to handle SysCableCheck
Add handler logic to handler for SysCableCheck such that it splits the true IPMI processing from the business logic.
Tested: Only ran unit-tests (added new
add handler logic to handle SysCableCheck
Add handler logic to handler for SysCableCheck such that it splits the true IPMI processing from the business logic.
Tested: Only ran unit-tests (added new ones). Change-Id: Ieec35cc8839dcd3cfb864b68ffbd1a45d1326fee Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
92b507d8 | 15-Mar-2019 |
Patrick Venture <venture@google.com> |
makefile: adjust alignment
Adjust alignment of items listed.
Tested: Only ran unit-tests (added new ones). Change-Id: Iba8a026f6904fade4b13c554dac3b31f23f62b16 Signed-off-by: Patrick Venture <ventu
makefile: adjust alignment
Adjust alignment of items listed.
Tested: Only ran unit-tests (added new ones). Change-Id: Iba8a026f6904fade4b13c554dac3b31f23f62b16 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
f085d91d | 15-Mar-2019 |
Patrick Venture <venture@google.com> |
add handler logic to handle SysGetEthDevice
Add a handler to handle code logic outside of the actual IPMI processing.
Tested: Only ran unit-tests (added new ones). Change-Id: Iadd8c4f2d9b3e2cfba24a
add handler logic to handle SysGetEthDevice
Add a handler to handle code logic outside of the actual IPMI processing.
Tested: Only ran unit-tests (added new ones). Change-Id: Iadd8c4f2d9b3e2cfba24ae32cda2ef66177b1177 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
6667a646 | 13-Mar-2019 |
Patrick Venture <venture@google.com> |
build: add code coverage
Add code coverage to build
Change-Id: I198d8bc9e6b99556582c14fc4dfd4c835150b5e0 Signed-off-by: Patrick Venture <venture@google.com> |
1ddb94ff | 13-Mar-2019 |
Patrick Venture <venture@google.com> |
test: add basic tests for eth command
Add basic tests for eth command.
Change-Id: I2232b8769ada0fe3405e9cafb8909e7351089ecb Signed-off-by: Patrick Venture <venture@google.com> |
6eb29408 | 14-Mar-2019 |
William A. Kennington III <wak@google.com> |
Makefile: split out common libary code for testing
We want to be able to link against our library code for testing without including the ipmi specific start up code. This refactors the build to prod
Makefile: split out common libary code for testing
We want to be able to link against our library code for testing without including the ipmi specific start up code. This refactors the build to produce a static library with most of the logic which gets linked into the final ipmi provider.
Change-Id: I97ec6613654d8209fca29a1a33103527b78d154e Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
5d26d832 | 13-Mar-2019 |
Patrick Venture <venture@google.com> |
eth: move structure to header
Move the structure definition to the header file to expose it to the testing code.
Change-Id: I019a322364e5d6c5cc9d79419c854ee47b65e03e Signed-off-by: Patrick Venture
eth: move structure to header
Move the structure definition to the header file to expose it to the testing code.
Change-Id: I019a322364e5d6c5cc9d79419c854ee47b65e03e Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
848b938c | 13-Mar-2019 |
Patrick Venture <venture@google.com> |
build: add build of empty tests
Add tests to the build.
Change-Id: Ic12b5eee708a3ec8e16d997f2a7d18adec2c779d Signed-off-by: Patrick Venture <venture@google.com> |
0788699a | 08-Mar-2019 |
Patrick Venture <venture@google.com> |
use filesystem instead of experimental
Use filesystem now that it should be available instead of experimental::filesystem.
Change-Id: I43758ca2fd02862cc6e3c673275d8e2120d02ff2 Signed-off-by: Patric
use filesystem instead of experimental
Use filesystem now that it should be available instead of experimental::filesystem.
Change-Id: I43758ca2fd02862cc6e3c673275d8e2120d02ff2 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
a289fa2e | 15-Feb-2019 |
Jaghathiswari Rankappagounder Natarajan <jaghu@google.com> |
Add support for some more entity types
We support an OEM command so that the system can query the BMC for an Entity name given the Entity ID and Entity Instance. This patch adds support for some mor
Add support for some more entity types
We support an OEM command so that the system can query the BMC for an Entity name given the Entity ID and Entity Instance. This patch adds support for some more entity types.
Change-Id: Id8b8019122044e11f195184ad8c5612dd60f044c Signed-off-by: Jaghathiswari Rankappagounder Natarajan <jaghu@google.com>
show more ...
|
c662465b | 13-Feb-2019 |
Patrick Venture <venture@google.com> |
build: pkg anti-pattern: use defaults
Use the defaults in the pkg check where the default error message is sufficient to identify which package is missing.
Change-Id: I376ccea8b294c47e05b2e67c7da32
build: pkg anti-pattern: use defaults
Use the defaults in the pkg check where the default error message is sufficient to identify which package is missing.
Change-Id: I376ccea8b294c47e05b2e67c7da3244582f2d550 Signed-off-by: Patrick Venture <venture@google.com>
show more ...
|
2c9e1625 | 07-Feb-2019 |
William A. Kennington III <wak@google.com> |
Convert host-ipmid -> libipmid
phosphor-host-ipmid now exposes a library along with headers for interfacing with the ipmi daemon. Compile and link against the new library.
Change-Id: I7dfdf4ce6364a
Convert host-ipmid -> libipmid
phosphor-host-ipmid now exposes a library along with headers for interfacing with the ipmi daemon. Compile and link against the new library.
Change-Id: I7dfdf4ce6364a29b5bbc0696adc1e695651fbe1c Signed-off-by: William A. Kennington III <wak@google.com>
show more ...
|
575a55ae | 12-Feb-2019 |
Patrick Venture <venture@google.com> |
build: check for json header
Check for the json header during configuration.
Change-Id: Icf926d5fb96a3223af261eeaf3bcd2e02c4e4f86 Signed-off-by: Patrick Venture <venture@google.com> |