Detect how many address bytes needed for a given EEPROM memory

Introduce different modes to detect how many address byte(s) needed
for a given EEPROM device.

MODE_1:
-------
The existing upstream f

Detect how many address bytes needed for a given EEPROM memory

Introduce different modes to detect how many address byte(s) needed
for a given EEPROM device.

MODE_1:
-------
The existing upstream function isDevice16Bit() bases on sending
1-byte write operation (with a STOP condition) and 8 subsequent
1-byte read operations with SINGLE byte address.

1. This MODE_1 expects the following logic:
- if the device requires 1 address byte, it EXPECTS that the data
will be read from a single location so 8 bytes read will be the
same.
- if the device requires 2 address bytes, it EXPECTS that the data
will be read from 8 DIFFERENT LOCATIONS and at least one byte
read is different than 7 other reads.

2. Issue and potential issue with this MODE_1
- If any "2 address bytes" EEPROM from any vendor has the same data
in all memory locations (0-7) the existing upstream function read,
this device will be identified as "1 address byte" device.
- ONSEMI EEPROM (a 2 address bytes device) return the same data from
the same single byte address read --> therefore, existing function
wrongly identifies it as 1 byte address device.

MODE_2:
-------
The proposal MODE_2 changes to isDevice16Bit() sends 8 instructions
of 2-bytes write operation (WITHOUT a STOP condition ie. prohibited
STOP) followed by a 1-byte read operation. The proposed solution
fully complies with

IIC standard and should be applicable to any IIC EEPROM manufacturer.

| Start | SlaveAddr + W | 0x00 | 0x00 | STOP PROHIBITED HERE | Start |
SlaveAddr + R | data byte | Stop |
|-------|---------------|------|------|----------------------|-------|
--------------|-----------|------|
| Start | SlaveAddr + W | 0x00 | 0x01 | STOP PROHIBITED HERE | Start |
SlaveAddr + R | data byte | Stop |
| Start | SlaveAddr + W | 0x00 | 0x02 | STOP PROHIBITED HERE | Start |
SlaveAddr + R | data byte | Stop |
| Start | SlaveAddr + W | 0x00 | 0x03 | STOP PROHIBITED HERE | Start |
SlaveAddr + R | data byte | Stop |
| Start | SlaveAddr + W | 0x00 | 0x04 | STOP PROHIBITED HERE | Start |
SlaveAddr + R | data byte | Stop |
| Start | SlaveAddr + W | 0x00 | 0x05 | STOP PROHIBITED HERE | Start |
SlaveAddr + R | data byte | Stop |
| Start | SlaveAddr + W | 0x00 | 0x06 | STOP PROHIBITED HERE | Start |
SlaveAddr + R | data byte | Stop |
| Start | SlaveAddr + W | 0x00 | 0x07 | STOP PROHIBITED HERE | Start |
SlaveAddr + R | data byte | Stop |

1. If the device requires a single data byte, then it will always
load address 0x00, so the subsequent read byte will be the same for
all 8 instructions. The second byte on the write would be interpreted
as data byte, thus not modifying the address pointer.

2. If two address bytes are required, then the device will interpret
both bytes as addresses, thus reading from different addresses every
time, similar with what the existing function is using now.

Notes & reasons:
-----------------
There is no STOP condition after the second (potential) address byte.
A START condition must be sent after the second byte.
If STOP condition is sent, then the 1-byte address devices will start
internal write cycle, altering the EEPROM content which is not good.

This proposal MODE_2 suffers the same 1st issue (#2a) as before (what
if the EEPROM has the same data at all those addresses).
However, this proposal MODE_2 addresses the 2nd issue (#2b)
where existing MODE_1 upstream function EXPECTS that the data will
be read from 8 DIFFERENT LOCATIONS if the device requires 2 address
bytes. This expectation is the ambiguity (not standard defined) in
the IIC spec
(https://www.nxp.com/docs/en/user-guide/UM10204.pdf)

1. Section 3.1.10, Note 2 -> "All decisions on auto-increment or
decrement of previously accessed memory locations, etc., are taken by
the designer of the device."
Based on this note, the designer of every EEPROM has the "freedom"
to use whatever architecture considers appropriate and suitable to
process everyone of the two address bytes. There are no restrictions
on this.

Based on this, the others EEPROM (not ONSEMI EEPROM) auto-increment -
observed with one address byte sent instead of two - is a
manufacturer-specific behavior, and not standard defined.

2. Section 3.1.10, Note 1 -> "Combined formats can be used, for
example, to control a serial memory. The internal memory location
must be written during the first data byte. After the START
condition and slave address is repeated, data can be transferred."

This proposal MODE_2 implements this note. The memory location
referred herein is the address pointer, as being the first data
byte in I2C communication. Based on this note, EEPROM must update
this pointer immediately following this first address byte.

Tested:
--------
1. With ONSEMI I2C eeprom memory on Nvidia Bluefield-3 HCA
a. Without this patch or with this patch MODE_1

root@dpu-bmc:~# ipmitool fru
FRU Device Description : Builtin FRU Device (ID 0)
Device not present (Requested sensor, data, or record not found)

FRU Device Description : Nvidia-BMCMezz (ID 169)
Board Mfg Date : Thu May 11 13:00:00 2023 UTC
Board Mfg : Nvidia
Board Product : Nvidia-BMCMezz
Board Serial : MT2319XZ04K6
Board Part Number : 900-9D3B6-00CV-AA0

b. With this patch MODE_2

root@dpu-bmc:~# ipmitool fru
FRU Device Description : Builtin FRU Device (ID 0)
Chassis Type : Main Server Chassis
Chassis Part Number : 900-9D3B6-00CV-AA0
Chassis Serial : MT2319XZ04K6
Chassis Extra : N/A
Chassis Extra : N/A
Chassis Extra : N/A
Chassis Area Checksum : OK
Board Mfg Date : Thu May 11 13:00:00 2023 UTC
Board Mfg : N/A
Board Product : N/A
Board Serial : MT2319XZ04K6
Board Part Number : 900-9D3B6-00CV-AA0
Board Extra : N/A
Board Area Checksum : OK
Product Manufacturer : N/A
Product Name : N/A
Product Part Number : 900-9D3B6-00CV-AA0
Product Serial : MT2319XZ04K6
Product Asset Tag : N/A
Product Extra : N/A
Product Area Checksum : OK

FRU Device Description : Nvidia-BMCMezz (ID 169)
Board Mfg Date : Thu May 11 13:00:00 2023 UTC
Board Mfg : Nvidia
Board Product : Nvidia-BMCMezz
Board Serial : MT2319XZ04K6
Board Part Number : 900-9D3B6-00CV-AA0
Board Area Checksum : OK

2. With other I2C eeprom memory on Nvidia Bluefield-3 HCA, and
without this patch or with this patch on both MODE_1/MODE_2

root@dpu-bmc:~# ipmitool fru
FRU Device Description : Builtin FRU Device (ID 0)
Chassis Type : Main Server Chassis
Chassis Part Number : 900-9D3B4-00EN-EAA
Chassis Serial : MT2315XZ0599
Chassis Extra : N/A
Chassis Extra : N/A
Chassis Extra : N/A
Chassis Area Checksum : OK
Board Mfg Date : Tue Apr 18 10:25:00 2023 UTC
Board Mfg : N/A
Board Product : N/A
Board Serial : MT2315XZ0599
Board Part Number : 900-9D3B4-00EN-EAA
Board Extra : N/A
Board Area Checksum : OK
Product Manufacturer : N/A
Product Name : N/A
Product Part Number : 900-9D3B4-00EN-EAA
Product Version : N/A
Product Serial : MT2315XZ0599
Product Asset Tag : N/A
Product Extra : N/A
Product Area Checksum : OK

FRU Device Description : Nvidia-BMCMezz (ID 169)
Board Mfg Date : Tue Apr 18 10:25:00 2023 UTC
Board Mfg : Nvidia
Board Product : Nvidia-BMCMezz
Board Serial : MT2315XZ0599
Board Part Number : 900-9D3B4-00EN-EAA
Board Area Checksum : OK

Change-Id: I296c22334c919f4248fb3a7f19e384ce802cba17
Signed-off-by: Vu Pham <vuhuong@nvidia.com>

show more ...

configurations: yosemite4: Revise MEDUSA voltage sensor

Revise MEDUSA voltage sensors: INA238, ISL28022, RTQ6056.
1. Change RTQ6056 to read shunt voltage.
2. Revise voltage scale and threshold.
3. A

configurations: yosemite4: Revise MEDUSA voltage sensor

Revise MEDUSA voltage sensors: INA238, ISL28022, RTQ6056.
1. Change RTQ6056 to read shunt voltage.
2. Revise voltage scale and threshold.
3. Add "in1_Min" and "in_voltage0_Min" in schemas/legacy.json.

Tested:
Check sensor reading of INA238, ISL28022, RTQ6056.
They all work fine.

Change-Id: I61ec1d6f98a1e5051486e2871b24e70f899e59ab
Signed-off-by: Yikai Tsai <yikai.tsai.wiwynn@gmail.com>

show more ...

correct the name of Inventory.Item.Bmc interface

As defined in the PDIs [1], the correct name of this interface is
Inventory.Item.Bmc (not BMC). This commit corrects all configuration
that are using

correct the name of Inventory.Item.Bmc interface

As defined in the PDIs [1], the correct name of this interface is
Inventory.Item.Bmc (not BMC). This commit corrects all configuration
that are using incorrect interface name.

[1] https://github.com/openbmc/phosphor-dbus-interfaces/blob/master/yaml/xyz/openbmc_project/Inventory/Item/Bmc.interface.yaml

Change-Id: Icc9b4b33725999a72cd925fd0f0e5995aacadcdc
Signed-off-by: Thang Tran <thuutran@amperecomputing.com>

show more ...

meta: yosemite4: modify fan speed thresholds

Based on Thermal team's requirements, modified fan speed rpm
UNR and UCR thresholds:
1. Inlet Fan speed:
UNC changed to 14600
UCR changed to 18960

meta: yosemite4: modify fan speed thresholds

Based on Thermal team's requirements, modified fan speed rpm
UNR and UCR thresholds:
1. Inlet Fan speed:
UNC changed to 14600
UCR changed to 18960
2. Outlet Fan speed:
UNC changed to 13300
UCR changed to 19200

Change-Id: I42fad972986d718346001d6d8923056013e362b6
Signed-off-by: Eric Yang <eric.yang.wiwynn@gmail.com>

show more ...

meta: yosemite4: Adjust fan duty for corner case

Modified the fan table for the following corner cases, based on the
thermal team's requirements:
1. When one fan fails, fan duty is set to 90%.
2. Wh

meta: yosemite4: Adjust fan duty for corner case

Modified the fan table for the following corner cases, based on the
thermal team's requirements:
1. When one fan fails, fan duty is set to 90%.
2. When one slot is unplugged during service time, fan duty
is set to 90%.

Change-Id: Ia378e5917ef1dbe41b8c832e235ffd1914d401a7
Signed-off-by: Eric Yang <eric.yang.wiwynn@gmail.com>

show more ...

configurations: yosemite4: Add new fan board combination

Support a new fan board combination with a different LED controller.

Change-Id: I157a790e5b408e16bc0f0ee37eb513b5b698e3f2
Signed-off-by: Mar

configurations: yosemite4: Add new fan board combination

Support a new fan board combination with a different LED controller.

Change-Id: I157a790e5b408e16bc0f0ee37eb513b5b698e3f2
Signed-off-by: Marshall Zhan <marshall.zhan.wiwynn@gmail.com>

show more ...

configurations: yosemite4: add fan config to monitor FIO temperature

Add fan config to monitor original FIO temperature so the
phosphor-pid-control service would set to failsafe mode when the FIO
te

configurations: yosemite4: add fan config to monitor FIO temperature

Add fan config to monitor original FIO temperature so the
phosphor-pid-control service would set to failsafe mode when the FIO
temperature sensor failed.

Change-Id: I74f4cd6b700ef3434b331b3ec48e4aef67bf6526
Signed-off-by: Ricky CX Wu <ricky.cx.wu.wiwynn@gmail.com>

show more ...

configurations: minerva_pdb_hsc_xdp: add hysteresis

The hysteresis value is set to 2% of the trigger threshold
to ensure more precise triggering of assert and deassert for
sensors like a 12V sensor.

configurations: minerva_pdb_hsc_xdp: add hysteresis

The hysteresis value is set to 2% of the trigger threshold
to ensure more precise triggering of assert and deassert for
sensors like a 12V sensor. For example, with normal readings
and thresholds at ±10% (10.8V to 13.2V), the default value of
2.55 is too large for this range.

Change-Id: Ib612861a4ad70aa669b5fb8dc90a9ccf0a231c8e
Signed-off-by: Daniel Hsu <Daniel-Hsu@quantatw.com>

show more ...

configurations: minerva_pdb: add hysteresis

The hysteresis value is set to 2% of the trigger threshold
to ensure more precise triggering of assert and deassert for
sensors like a 12V sensor. For exa

configurations: minerva_pdb: add hysteresis

The hysteresis value is set to 2% of the trigger threshold
to ensure more precise triggering of assert and deassert for
sensors like a 12V sensor. For example, with normal readings
and thresholds at ±10% (10.8V to 13.2V), the default value of
2.55 is too large for this range.

Change-Id: Ib6cdd14edc8370d840c073c153c9373579d112f1
Signed-off-by: Daniel Hsu <Daniel-Hsu@quantatw.com>

show more ...

configurations: harma_mb_vr_infineon: add hysteresis

The hysteresis value is set to 2% of the trigger threshold
to ensure more precise triggering of assert and deassert for
sensors like a 12V sensor

configurations: harma_mb_vr_infineon: add hysteresis

The hysteresis value is set to 2% of the trigger threshold
to ensure more precise triggering of assert and deassert for
sensors like a 12V sensor. For example, with normal readings
and thresholds at ±10% (10.8V to 13.2V), the default value of
2.55 is too large for this range.

Change-Id: Ic3b6db086068c84e1c09cb4819f80bbba3a3f542
Signed-off-by: Daniel Hsu <Daniel-Hsu@quantatw.com>

show more ...

configurations: harma_mb: add hysteresis

The hysteresis value is set to 2% of the trigger threshold
to ensure more precise triggering of assert and deassert for
sensors like a 12V sensor. For exampl

configurations: harma_mb: add hysteresis

The hysteresis value is set to 2% of the trigger threshold
to ensure more precise triggering of assert and deassert for
sensors like a 12V sensor. For example, with normal readings
and thresholds at ±10% (10.8V to 13.2V), the default value of
2.55 is too large for this range.

Change-Id: I1cdb58e7baa078d89c8f60fcf9ee3cbb46b6724e
Signed-off-by: Daniel Hsu <Daniel-Hsu@quantatw.com>

show more ...

configurations: catalina: add scale and offset for P12V & P48V sensors

Add scale and offset for calibration on below sensors
- PDB_P12V_NIC0_CURR_A
- PDB_P12V_NIC0_PWR_W
- PDB_P12V_NIC1_CURR_A
- PDB

configurations: catalina: add scale and offset for P12V & P48V sensors

Add scale and offset for calibration on below sensors
- PDB_P12V_NIC0_CURR_A
- PDB_P12V_NIC0_PWR_W
- PDB_P12V_NIC1_CURR_A
- PDB_P12V_NIC1_PWR_W
- PDB_P12V_SCM_CURR_A
- PDB_P12V_SCM_PWR_W
- PDB_P48V_HSC1_CURR_A
- PDB_P48V_HSC1_PWR_W
- PDB_P48V_HSC2_CURR_A
- PDB_P48V_HSC2_PWR_W

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: I7d60ae27d043fb760b38bc198e39b217ad45f48e

show more ...

configurations: catalina: revise pdb and hdd sensor config names

Revise the sensor config name (Name) to be the subset of actual sensor
name (in0_Name, in1_Name, etc.) to match with internal naming

configurations: catalina: revise pdb and hdd sensor config names

Revise the sensor config name (Name) to be the subset of actual sensor
name (in0_Name, in1_Name, etc.) to match with internal naming rule.

TestResults:
EM still works normally after changes
```
root@bmc:~# busctl tree xyz.openbmc_project.EntityManager | grep Catalina_PDB
├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/Catalina_PDB_FRU
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/FAN0_TACH_IL_SPEED_RPM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/FAN0_TACH_OL_SPEED_RPM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/FAN1_TACH_IL_SPEED_RPM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/FAN1_TACH_OL_SPEED_RPM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/FAN2_TACH_IL_SPEED_RPM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/FAN2_TACH_OL_SPEED_RPM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/FAN3_TACH_IL_SPEED_RPM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/FAN3_TACH_OL_SPEED_RPM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/FAN4_TACH_IL_SPEED_RPM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/FAN4_TACH_OL_SPEED_RPM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/FAN5_TACH_IL_SPEED_RPM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/FAN5_TACH_OL_SPEED_RPM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/FAN6_TACH_IL_SPEED_RPM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/FAN6_TACH_OL_SPEED_RPM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/FAN7_TACH_IL_SPEED_RPM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/FAN7_TACH_OL_SPEED_RPM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/PDB_CABLE_TSENSE_NEGATIVE
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/PDB_CABLE_TSENSE_POSITIVE
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/PDB_P12V_FAN
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/PDB_P12V_NIC0
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/PDB_P12V_NIC1
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/PDB_P12V_SCM
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/PDB_P48V_HSC1
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/PDB_P48V_HSC2
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/PDB_POSITIVE_VDROP
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/PDB_RETURN_VDROP
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/PDB_TEMP_C
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/PDB_VR_P12V_AUX
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/PDB_VR_P12V_N1
│ └─ /xyz/openbmc_project/inventory/system/board/Catalina_PDB/PDB_VR_P12V_N2
root@bmc:~# busctl tree xyz.openbmc_project.EntityManager | grep Catalina_HDD_Carrier
├─ /xyz/openbmc_project/inventory/system/board/Catalina_HDD_Carrier
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_HDD_Carrier/Catalina_HDD_Board_FRU
│ ├─ /xyz/openbmc_project/inventory/system/board/Catalina_HDD_Carrier/HDDBOARD_SSD0
│ └─ /xyz/openbmc_project/inventory/system/board/Catalina_HDD_Carrier/HDDBOARD_SSD2
```

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: I42ecaab444668acd1b7715d4b78be1d771546f36

show more ...

configurations: catalina: add sensor threshold hysteresis

Set hysteresis to 2% of trigger threshold to ensure more precise
triggering assert and deassert of sensor threshold event log.

Add hysteres

configurations: catalina: add sensor threshold hysteresis

Set hysteresis to 2% of trigger threshold to ensure more precise
triggering assert and deassert of sensor threshold event log.

Add hysteresis setting for below config files:
- catalina_fio.json
- catalina_hdd_nvme.json
- catalina_hdd.json
- catalina_pdb.json
- catalina_scm.json

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: I4df8f35f650fa73943214cee51e23e6a10884ad4

show more ...

configurations: catalina_pdb: Add PowerState for host VR sensors

Host VR (VR_N1 & VR_N2) sensor readings are only available when the host
is powered on. Set the PowerState to "on" for host VR sensor

configurations: catalina_pdb: Add PowerState for host VR sensors

Host VR (VR_N1 & VR_N2) sensor readings are only available when the host
is powered on. Set the PowerState to "on" for host VR sensors.

Test results:
- Host off
```
root@bmc:~# mfg-tool sensor-display 2>/dev/null | table-sensor-display | grep VR_P12V_N
PDB_VR_P12V_N1_CURR_A unavailable N/A Amperes N/A N/A N/A N/A N/A N/A
PDB_VR_P12V_N1_PWR_W unavailable N/A Watts N/A N/A N/A N/A N/A N/A
PDB_VR_P12V_N1_TEMP_C unavailable N/A DegreesC N/A 5 N/A N/A 125 N/A
PDB_VR_P12V_N1_VOLT_V unavailable N/A Volts N/A 10.5 N/A N/A 13.6 N/A
PDB_VR_P12V_N2_CURR_A unavailable N/A Amperes N/A N/A N/A N/A N/A N/A
PDB_VR_P12V_N2_PWR_W unavailable N/A Watts N/A N/A N/A N/A N/A N/A
PDB_VR_P12V_N2_TEMP_C unavailable N/A DegreesC N/A 5 N/A N/A 125 N/A
PDB_VR_P12V_N2_VOLT_V unavailable N/A Volts N/A 10.5 N/A N/A 13.6 N/A
```
- Host on
```
root@bmc:~# mfg-tool sensor-display 2>/dev/null | table-sensor-display | grep VR_P12V_N
PDB_VR_P12V_N1_CURR_A ok 21 Amperes N/A N/A N/A N/A N/A N/A
PDB_VR_P12V_N1_PWR_W ok 225 Watts N/A N/A N/A N/A N/A N/A
PDB_VR_P12V_N1_TEMP_C ok 33 DegreesC N/A 5 N/A N/A 125 N/A
PDB_VR_P12V_N1_VOLT_V ok 11.995 Volts N/A 10.5 N/A N/A 13.6 N/A
PDB_VR_P12V_N2_CURR_A ok 19.6 Amperes N/A N/A N/A N/A N/A N/A
PDB_VR_P12V_N2_PWR_W ok 240 Watts N/A N/A N/A N/A N/A N/A
PDB_VR_P12V_N2_TEMP_C ok 33 DegreesC N/A 5 N/A N/A 125 N/A
PDB_VR_P12V_N2_VOLT_V ok 12 Volts N/A 10.5 N/A N/A 13.6 N/A
```

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: I90bd290493bbbe1534db15f87054fb6ba124941e

show more ...

test-fru-utils: fix clang-tidy error

clang-tidy-19 suggests making a trivial reserve call due to a sequence
of push_back calls in the test case. Add as directed.

```
../test/test_fru-utils.cpp:173

test-fru-utils: fix clang-tidy error

clang-tidy-19 suggests making a trivial reserve call due to a sequence
of push_back calls in the test case. Add as directed.

```
../test/test_fru-utils.cpp:173:9: error: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
```

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ia453674492b0ca5fb3b56fd2bf5326b3c1ca7f86

show more ...

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have b

clang-format: re-format for clang-19

clang-format-19 isn't compatible with the clang-format-18 output, so we
need to reformat the code with the latest version. A few parameters
in clang-tidy have been deprecated, so adjust the style file
accordingly.

See Ie2f6eb3b043f2d655c9df806815afd7971fd0947 for updated style.
See I88192b41ab7a95599a90915013579608af7bc56f for clang-19 enablement.

Change-Id: I01fcad7867561151b7543e86204d9e875205f9fb
Signed-off-by: Patrick Williams <patrick@stwcx.xyz>

show more ...

configurations: yosemite4: Add config for Medusa Board

Modify config:
Medusa Board ADC-RNS-ISL 12VHSC-ADI 48VHSC-INF
(Modify 12VHSC from MPS to an ADI that matches the name.)

Add config:
Medusa Boa

configurations: yosemite4: Add config for Medusa Board

Modify config:
Medusa Board ADC-RNS-ISL 12VHSC-ADI 48VHSC-INF
(Modify 12VHSC from MPS to an ADI that matches the name.)

Add config:
Medusa Board ADC-RNS-ISL 12VHSC-MPS 48VHSC-ADI
Medusa Board ADC-RNS-ISL 12VHSC-MPS 48VHSC-INF
Medusa Board ADC-RNS-ISL 12VHSC-ADI 48VHSC-ADI

Modify meson.build:
Added new config filenames.

Change-Id: I608e61f026a0a932acaeb9b72289c53fdb97854e
Signed-off-by: Leo Yang <Leo-Yang@quantatw.com>

show more ...

configurations: minerva_cmm: add hysteresis

The hysteresis value is set to 2% of the trigger threshold
to ensure more precise triggering of assert and deassert for
sensors like a 12V sensor. For exa

configurations: minerva_cmm: add hysteresis

The hysteresis value is set to 2% of the trigger threshold
to ensure more precise triggering of assert and deassert for
sensors like a 12V sensor. For example, with normal readings
and thresholds at ±10% (10.8V to 13.2V), the default value of
2.55 is too large for this range.

Change-Id: Ifb0597181725ec19fdff4082f27e7cc553bac512
Signed-off-by: Yang Chen <yang.chen@quantatw.com>

show more ...

configurations: minerva_cmm_scm: add hysteresis

The hysteresis value is set to 2% of the trigger threshold
to ensure more precise triggering of assert and deassert for
sensors like a 12V sensor. For

configurations: minerva_cmm_scm: add hysteresis

The hysteresis value is set to 2% of the trigger threshold
to ensure more precise triggering of assert and deassert for
sensors like a 12V sensor. For example, with normal readings
and thresholds at ±10% (10.8V to 13.2V), the default value of
2.55 is too large for this range.

Change-Id: I5b3e5deeb339ed0deba43ff450a50c238f20ff49
Signed-off-by: Yang Chen <yang.chen@quantatw.com>

show more ...

configurations: minerva_fanboard: add hysteresis

The hysteresis value is set to 2% of the trigger threshold
to ensure more precise triggering of assert and deassert for
sensors like a 12V sensor. Fo

configurations: minerva_fanboard: add hysteresis

The hysteresis value is set to 2% of the trigger threshold
to ensure more precise triggering of assert and deassert for
sensors like a 12V sensor. For example, with normal readings
and thresholds at ±10% (10.8V to 13.2V), the default value of
2.55 is too large for this range.

Change-Id: I53e14070ab6be0796dc962ea28ff2ec913625946
Signed-off-by: Yang Chen <yang.chen@quantatw.com>

show more ...

OWNERS: add Patrick as owner for Meta

In order to speed review and reduce burden on maintainers
for changes which only affect Meta hardware, add Patrick
as owner for 'configurations/meta'.

Signed-o

OWNERS: add Patrick as owner for Meta

In order to speed review and reduce burden on maintainers
for changes which only affect Meta hardware, add Patrick
as owner for 'configurations/meta'.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: Ic9aceea38a4400de5838b1f67ff166d923df66b5

show more ...

meta: move hardware configs to vendor directory

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I083a5dcea1369bba64bc2a88650f784804993a30

configurations: add VENDOR guidelines

In order to allow configurations to be arranged in subdirectories
for vendors, some guidelines are proposed on who is a vendor.

Signed-off-by: Patrick Williams

configurations: add VENDOR guidelines

In order to allow configurations to be arranged in subdirectories
for vendors, some guidelines are proposed on who is a vendor.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I1e5f329ddd5066b2226077c9930488927358abd1

show more ...

configurations: catalina_pdb: fix PDB VR voltage threshold

Fix the wrong label used in all PDB VR voltage threshold.
- PDB_VR_P12V_N1_VOLT_V
- PDB_VR_P12V_N2_VOLT_V
- PDB_VR_P12V_AUX_VOLT_V

Test re

configurations: catalina_pdb: fix PDB VR voltage threshold

Fix the wrong label used in all PDB VR voltage threshold.
- PDB_VR_P12V_N1_VOLT_V
- PDB_VR_P12V_N2_VOLT_V
- PDB_VR_P12V_AUX_VOLT_V

Test results:
```
root@bmc:~# mfg-tool sensor-display | jq '.PDB_VR_P12V_N1_VOLT_V'
{
"critical": {
"high": 13.6,
"low": 10.5
},
"max": 255.0,
"min": 0.0,
"status": "critical",
"unit": "Volts",
"value": 0.175
}
root@bmc:~# mfg-tool sensor-display | jq '.PDB_VR_P12V_N2_VOLT_V'
{
"critical": {
"high": 13.6,
"low": 10.5
},
"max": 255.0,
"min": 0.0,
"status": "critical",
"unit": "Volts",
"value": 0.17
}
root@bmc:~# mfg-tool sensor-display | jq '.PDB_VR_P12V_AUX_VOLT_V'
{
"critical": {
"high": 13.6,
"low": 10.5
},
"max": 255.0,
"min": 0.0,
"status": "ok",
"unit": "Volts",
"value": 12.0
}
```

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: I926a822be8b6e65cd589d1ced3ad52e0e03aa393

show more ...