2af39224 | 22-Jul-2022 |
Patrick Williams <patrick@stwcx.xyz> |
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types. Switch to using them to provide better code clarity and shorter lines. Possible replacements are
sdbusplus: use shorter type aliases
The sdbusplus headers provide shortened aliases for many types. Switch to using them to provide better code clarity and shorter lines. Possible replacements are for: * bus_t * exception_t * manager_t * match_t * message_t * object_t * slot_t
Signed-off-by: Patrick Williams <patrick@stwcx.xyz> Change-Id: If2c7da2a8105c39fb0eadf0a86337165b0fe4aa1
show more ...
|
9afef3a3 | 13-Jul-2022 |
Zev Weiss <zev@bewilderbeest.net> |
overlay: Factor out deviceDirName() routine
Replace a couple open-coded instances of this pattern with a dedicated function, and rename a variable in deviceIsCreate() to avoid potential confusion be
overlay: Factor out deviceDirName() routine
Replace a couple open-coded instances of this pattern with a dedicated function, and rename a variable in deviceIsCreate() to avoid potential confusion between 'dirName' and 'directoryName'.
Signed-off-by: Zev Weiss <zev@bewilderbeest.net> Change-Id: Ib3bc2591ec996dda296b82e5fcc3dc1300878ff1
show more ...
|
c11b5da3 | 12-Jul-2022 |
Zev Weiss <zev@bewilderbeest.net> |
overlay: Rename devicePath as busPath
It's the path to the sysfs directory representing an i2c bus, not a device on that bus; let's name it to reflect that.
Signed-off-by: Zev Weiss <zev@bewilderbe
overlay: Rename devicePath as busPath
It's the path to the sysfs directory representing an i2c bus, not a device on that bus; let's name it to reflect that.
Signed-off-by: Zev Weiss <zev@bewilderbeest.net> Change-Id: I1525f45cc2fd4a9690dc261fbe93ea734952057e
show more ...
|
e7d56e06 | 15-Jul-2022 |
Zev Weiss <zev@bewilderbeest.net> |
overlay: Fix missing space in error message
Signed-off-by: Zev Weiss <zev@bewilderbeest.net> Change-Id: Ia950f27295166b65155df65aa998f4328c509279 |
309c0b13 | 24-Feb-2022 |
Zev Weiss <zev@bewilderbeest.net> |
fru-device: add FRUReader EEPROM cache
This doesn't provide a huge benefit currently, but is a preparatory step for adding support for a wider variety of FRU format parsers. If parsers for multiple
fru-device: add FRUReader EEPROM cache
This doesn't provide a huge benefit currently, but is a preparatory step for adding support for a wider variety of FRU format parsers. If parsers for multiple formats are interested in reading the same areas of an EEPROM, the caching provided by this abstraction avoids the redundant bus traffic of all of them re-reading the same bytes over and over.
Tested: on an ASRock Rack romed8hm3, fru-device successfully recognizes and parses the baseboard FRU EEPROM as it did prior to this patch.
Signed-off-by: Zev Weiss <zev@bewilderbeest.net> Change-Id: I0d774508bc29dbda346309fe7fe42dbdf97bee43
show more ...
|
e45d8c71 | 25-May-2022 |
Brad Bishop <bradleyb@fuzziesquirrel.com> |
treewide: comply with the OpenBMC style guidelines
The guidelines say cpp source code filenames should be lower_snake_case: https://github.com/openbmc/docs/blob/master/cpp-style-and-conventions.md#f
treewide: comply with the OpenBMC style guidelines
The guidelines say cpp source code filenames should be lower_snake_case: https://github.com/openbmc/docs/blob/master/cpp-style-and-conventions.md#files
Signed-off-by: Brad Bishop <bradleyb@fuzziesquirrel.com> Change-Id: Ia04017b0eb9a65ce1303af5b6dc36e730410fd91
show more ...
|
8482ffc3 | 20-May-2022 |
Jiaqing Zhao <jiaqing.zhao@intel.com> |
FruDevice: Fix ReScanBus behavior on mux buses
In commit d8884f1 ("Fix for devices behind the mux being wrongly detected on lower bus address"), FruDevice skips will not add the FRU object to DBus i
FruDevice: Fix ReScanBus behavior on mux buses
In commit d8884f1 ("Fix for devices behind the mux being wrongly detected on lower bus address"), FruDevice skips will not add the FRU object to DBus if it is already found on a lower numbered bus. But it doen't check the bus number, meaning that it also skips the bus it is on, causing rescan on mux buses not working. This patch fixes it by comparing the bus number.
Tested: Verified the behavior of ReScanBus method are the same on mux and non-mux buses by adding some logs.
Change-Id: I668c489af6365ec1e8d4e6994b2fe29bc562378f Signed-off-by: Jiaqing Zhao <jiaqing.zhao@intel.com>
show more ...
|
14a7bc93 | 01-Aug-2021 |
Andrew Jeffery <andrew@aj.id.au> |
meson: nlohmann/json has a meson build
Exploit the usual configuration available for subprojects that support meson directly.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Ifef98dc70a2
meson: nlohmann/json has a meson build
Exploit the usual configuration available for subprojects that support meson directly.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Ifef98dc70a24f41df1b199fcbf28fe034a5526bc
show more ...
|
1c9d3788 | 30-Mar-2022 |
Jae Hyun Yoo <quic_jaehyoo@quicinc.com> |
Utils: Fix big number string parsing error
Current configuration parsing logic can't handle big number strings so a string is just left as a string without getting converted to an integer and eventu
Utils: Fix big number string parsing error
Current configuration parsing logic can't handle big number strings so a string is just left as a string without getting converted to an integer and eventually it introduces crash issues in dbus-sensors because the string can't be cast to an integer directly. This issue could be observed when we add an I3C device which has 0x4cc31020000 as its Address setting as an example.
To avoid this issue, this commit replaces 'stoul' with std::from_chars. Note that std::from_chars is not smart enough to detect number base automatically so it also adds '0x' prefix checking code.
Tested: Big numbers were parsed properly.
Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com> Change-Id: Ib7b74c5c21377895f25005e7e0edcf5f8ed6d1f2
show more ...
|
af9b46b1 | 20-Apr-2022 |
Andrew Jeffery <andrew@aj.id.au> |
PerformScan: Drop dbusSubtree parameter from updateSystemConfiguration()
PerformProbe was reaching into the PerformScan instance to pass updateSystemConfiguration() PerformScan's own dbusProbeObject
PerformScan: Drop dbusSubtree parameter from updateSystemConfiguration()
PerformProbe was reaching into the PerformScan instance to pass updateSystemConfiguration() PerformScan's own dbusProbeObjects. We can just use the implicit `this` to access it inside updateSystemConfiguration().
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I27124c01358e227c78c7054070ba1fc8384ac4ac
show more ...
|
ea4ff02b | 20-Apr-2022 |
Andrew Jeffery <andrew@aj.id.au> |
PerformProbe: Invoke PerformScan::updateSystemConfiguration() directly
Drop the lambda we previously required.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I4cfa0a8a026226a6a4d7719104
PerformProbe: Invoke PerformScan::updateSystemConfiguration() directly
Drop the lambda we previously required.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I4cfa0a8a026226a6a4d77191045da43c5b4a30a7
show more ...
|
ae6c1a44 | 19-Apr-2022 |
Andrew Jeffery <andrew@aj.id.au> |
PerformScan: Add updateSystemConfiguration() as a member function
Pull the guts out of the PerformProbe callback lambda and add it as a member function on PerformScan.
Signed-off-by: Andrew Jeffery
PerformScan: Add updateSystemConfiguration() as a member function
Pull the guts out of the PerformProbe callback lambda and add it as a member function on PerformScan.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I30b815f92b303d4cd81b0b6a417c1982c11f7b1d
show more ...
|
98f3d534 | 19-Apr-2022 |
Andrew Jeffery <andrew@aj.id.au> |
PerformScan: Promote recordPtr to reference
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I3af46421c62601f68ef30a6883255f11ce14eeff |
38834872 | 19-Apr-2022 |
Andrew Jeffery <andrew@aj.id.au> |
PerformScan: Reorganise config loop early-exits
Keep them contiguous at the top as much as possible.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I3f7ab1529c2c39c98dd6e4a887c8e86d2613
PerformScan: Reorganise config loop early-exits
Keep them contiguous at the top as much as possible.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I3f7ab1529c2c39c98dd6e4a887c8e86d261367f4
show more ...
|
dabee98a | 18-Apr-2022 |
Andrew Jeffery <andrew@aj.id.au> |
PerformScan: Extract generateDeviceName()
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I8575e42536924e60dad5a5534475c38711a8ada1 |
b48779db | 14-Apr-2022 |
Andrew Jeffery <andrew@aj.id.au> |
PerformScan: Extract applyExposeActions()
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I425bd1602967d8ce43b2f80e165adac4a2b26a1a |
da45e5eb | 14-Apr-2022 |
Andrew Jeffery <andrew@aj.id.au> |
PerformScan: Rename configList in applyConfigExposeActions()
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Id1e8a6a31c25751e2c9238c419df5a8ce16ff8c0 |
060ac9c0 | 14-Apr-2022 |
Andrew Jeffery <andrew@aj.id.au> |
PerformScan: Avoid continue in applyExposeActions()
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Ibfc9a4313cdedc290294f1138ec6dde6486ea793 |
5468f8e2 | 14-Apr-2022 |
Andrew Jeffery <andrew@aj.id.au> |
PerformScan: Extract applyConfigExposeActions()
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I92bc8bbf591421b97f599e3ff82c7b77598022c3 |
cf11bd3e | 14-Apr-2022 |
Andrew Jeffery <andrew@aj.id.au> |
PerformScan: Extract apply{Bind,Disable}Action() from run()
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Ic05dba3ee9f2544166df36a4ee0f051aaba1087f |
1a02da84 | 14-Apr-2022 |
Andrew Jeffery <andrew@aj.id.au> |
PerformScan: Lift lambda from args in isExposeActionRecord()
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I41da02ebba7680056c27b52b39fe51da41db1b1c |
219c11fd | 14-Apr-2022 |
Andrew Jeffery <andrew@aj.id.au> |
PerformScan: Eliminate foundMatches
Erase elements from matches and test that it's not empty instead of compiling a new foundMatches list only to compare their sizes.
Signed-off-by: Andrew Jeffery
PerformScan: Eliminate foundMatches
Erase elements from matches and test that it's not empty instead of compiling a new foundMatches list only to compare their sizes.
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I4d88ff872accef03d3b08670f388d2a94c44524e
show more ...
|
d8213b93 | 14-Apr-2022 |
Andrew Jeffery <andrew@aj.id.au> |
PerformScan: Rename exposeRecord in isExposeActionRecord()
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I66f8b804ae4c356f35fcfb1d2450544ceda51c99 |
6de53fb1 | 14-Apr-2022 |
Andrew Jeffery <andrew@aj.id.au> |
PerformScan: Extract findExposeActionRecord()
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: Ia4ee080ad5423a25a48987a1ccf186c54796c0de |
a244984b | 14-Apr-2022 |
Andrew Jeffery <andrew@aj.id.au> |
PerformScan: Use nlohmann::json::is_{string,array}() for type checks
Signed-off-by: Andrew Jeffery <andrew@aj.id.au> Change-Id: I7f632623fa589147dcc72f5e8483e48251f8a60e |