Add Timer check avoid multiple clicks

There are too many calls if power status changed quickly.
Add timer check to avoid multiple calls.

Tested: Power status change quickly, only one call to

Add Timer check avoid multiple clicks

There are too many calls if power status changed quickly.
Add timer check to avoid multiple calls.

Tested: Power status change quickly, only one call to
rescanBusses.

Change-Id: Ib982f2dea205399a30eb3d68855b24456130b392
Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com>

show more ...

FruDevice: Fix crash when fru name is duplicated

The path in dbus has prefix "/xyz/openbmc_project/FruDevice/", without
this prefix the regex_match in findIndexForFRU will nevert be true and
cause s

FruDevice: Fix crash when fru name is duplicated

The path in dbus has prefix "/xyz/openbmc_project/FruDevice/", without
this prefix the regex_match in findIndexForFRU will nevert be true and
cause service crash.

Tested:
Before:
Sevice crash with the following error:
'''
Jan 01 05:33:27 qbmc fru-device[6635]: terminate called after throwing an instance of 'sdbusplus::exception::SdBusError'
Jan 01 05:33:27 qbmc fru-device[6635]: what(): sd_bus_add_object_vtable: org.freedesktop.DBus.Error.FileExists: File exists
'''
After:
Service alive and works good.
'''
root@qbmc:~# busctl tree xyz.openbmc_project.FruDevice | grep x8x8
|-/xyz/openbmc_project/FruDevice/cable_x8x8
`-/xyz/openbmc_project/FruDevice/cable_x8x8_0
'''

Signed-off-by: Jeff Lin <JeffLin2@quantatw.com>
Change-Id: Id0bf3ccb29be8de95d4f17a86ef962b1c30280cb

show more ...

Add a helper function getFruData to updateFRUProperty

Refactoring updateFRUProperty function and created a new helper
function getFruData. Moved this function to fru_utils.cpp as it
is common for al

Add a helper function getFruData to updateFRUProperty

Refactoring updateFRUProperty function and created a new helper
function getFruData. Moved this function to fru_utils.cpp as it
is common for all fru-device deamons and avoid code duplication.

This patch is created based on suggestion on the below patch.
https://gerrit.openbmc.org/c/openbmc/entity-manager/+/51555

TESTED : Built Facebook YosemiteV2 images and loaded
on the target hardware. Verified all the fru's read and write.

Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>
Change-Id: I7514469d5798c68efce7353ca486195016cacf81

show more ...

Refactor : Add a helper function to addFruObjectToDbus

Refactoring addFruObjectToDbus function and created a new helper
function getProductName. Moved this function to fru_utils.cpp as
it is common

Refactor : Add a helper function to addFruObjectToDbus

Refactoring addFruObjectToDbus function and created a new helper
function getProductName. Moved this function to fru_utils.cpp as
it is common for all fru-device deamons and avoid code duplication.

This patch is created based on suggestion on the below patch.
https://gerrit.openbmc.org/c/openbmc/entity-manager/+/51555

TESTED : Built Facebook YosemiteV2 images and loaded
on the target hardware. Verified all the fru's read and write.

Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>
Change-Id: I272d2fd2fc664a471774c668503d87147eb80a54

show more ...

entity-manager: Allow exposing BMC inventory with "ContainsThisBMC"

Recently there appeared use cases involving the usage of a BMC Inventory
item. One example is the utilization sensors in phosphor-

entity-manager: Allow exposing BMC inventory with "ContainsThisBMC"

Recently there appeared use cases involving the usage of a BMC Inventory
item. One example is the utilization sensors in phosphor-health-monitor;
those sensors need to be connected to the BMC inventory item via an
association edge so they can be found by bmcweb.

Based on the conventions of OpenBMC, when a daemon owns a BMC Inventory
item, it is expected to have a complete understanding of the underlying
object. As such, Entity-Manager is in a better position to own the BMC
Inventory item compared to any other daemon.

Customarily, an Inventory item must always refer to a tangible, physical
object such as a board. The BMC Inventory item Inventory item is an
exception, since in most cases a BMC is not a discrete physical object
and is usually embedded into another physical component, such as a
DC-SCM module or a Board. A such, the information regarding a BMC must
be encoded in the board's JSON file, rather than a JSON file of its own.

This change makes entity-manager add an Inventory.Item.Bmc upon seeing
an "Exposed" entry with "BMC" type.

Tested: After adding 'HasThisBMC: true' to a board .JSON file, the BMC
item shows up:

bmc# busctl tree xyz.openbmc_project.EntityManager
`-/xyz
`-/xyz/openbmc_project
|-/xyz/openbmc_project/EntityManager
`-/xyz/openbmc_project/inventory
`-/xyz/openbmc_project/inventory/system
|-/xyz/openbmc_project/inventory/system/board
| `-/xyz/openbmc_project/inventory/system/board/SuperBoard
| `-/xyz/openbmc_project/inventory/system/board/SuperBoard/BMC

Signed-off-by: Sui Chen <suichen@google.com>
Change-Id: Iaf3595d4c336dbcf1f4e42f4aaa2c6c1840f9584

show more ...

Remove index from list when device is skipped

If there is a duplicate deviceName added in system.json, it will cause
vicious circle that entity-manager crashed with error "file exeists"
and then res

Remove index from list when device is skipped

If there is a duplicate deviceName added in system.json, it will cause
vicious circle that entity-manager crashed with error "file exeists"
and then restart forever.

The index should also be removed when the device is erased from
foundDevices.

Tested:
Add the following config: /usr/share/entity-manager/configurations/x8x8.json
{
"Exposes": [],
"Name": "cable_x8x8_$index",
"Probe": "xyz.openbmc_project.FruDevice({'BOARD_PRODUCT_NAME': '^cable_x8x8$'})",
"Type": "Board",
"xyz.openbmc_project.Inventory.I2CLocation": {
"Bus": "$BUS",
"Address": "$ADDRESS",
"Name": "cable_x8x8_$index"
}
}
root@qbmc:~# busctl tree xyz.openbmc_project.EntityManager | grep cable_x8x8
| |-/xyz/openbmc_project/inventory/system/board/cable_x8x8_1
| |-/xyz/openbmc_project/inventory/system/board/cable_x8x8_2
root@qbmc:~# busctl introspect xyz.openbmc_project.EntityManager /xyz/openbmc_project/inventory/system/board/cable_x8x8_1 xyz.openbmc_project.Inventory.I2CLocation
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.Address property t 82 emits-change
.Bus property t 6 emits-change
.Name property s "cable_x8x8_1" emits-change
root@qbmc:~# busctl introspect xyz.openbmc_project.EntityManager /xyz/openbmc_project/inventory/system/board/cable_x8x8_2 xyz.openbmc_project.Inventory.I2CLocation
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.Address property t 82 emits-change
.Bus property t 9 emits-change
.Name property s "cable_x8x8_2" emits-change

And then write cable_x8x8 fru data to bus 5, and use "ReScan" method in
FruDevice's dbus.

Before this patch the entity-manager will crash with the following log:

Mar 09 12:41:05 qbmc entity-manager[2713]: Inventory Added: cable_x8x8_1
Mar 09 12:41:06 qbmc entity-manager[2713]: terminate called after throwing an instance of 'sdbusplus::exception::SdBusError'
Mar 09 12:41:06 qbmc entity-manager[2713]: what(): sd_bus_add_object_vtable: org.freedesktop.DBus.Error.FileExists: File exists

root@qbmc:~# cat /var/configuration/system.json | grep 'xyz.openbmc_project.Inventory.I2CLocation' -A 4
"xyz.openbmc_project.Inventory.I2CLocation": {
"Address": 82,
"Bus": 6,
"Name": "cable_x8x8_1"
}
--
"xyz.openbmc_project.Inventory.I2CLocation": {
"Address": 82,
"Bus": 5,
"Name": "cable_x8x8_1"
}
--
"xyz.openbmc_project.Inventory.I2CLocation": {
"Address": 82,
"Bus": 9,
"Name": "cable_x8x8_2"
}

After adding this patch:
root@qbmc:~# busctl tree xyz.openbmc_project.EntityManager | grep cable_x8x8
| |-/xyz/openbmc_project/inventory/system/board/cable_x8x8_1
| |-/xyz/openbmc_project/inventory/system/board/cable_x8x8_2
| |-/xyz/openbmc_project/inventory/system/board/cable_x8x8_3
root@qbmc:~# busctl introspect xyz.openbmc_project.EntityManager /xyz/openbmc_project/inventory/system/board/cable_x8x8_1 xyz.openbmc_project.Inventory.I2CLocation
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.Address property t 82 emits-change
.Bus property t 6 emits-change
.Name property s "cable_x8x8_1" emits-change
root@qbmc:~# busctl introspect xyz.openbmc_project.EntityManager /xyz/openbmc_project/inventory/system/board/cable_x8x8_2 xyz.openbmc_project.Inventory.I2CLocation
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.Address property t 82 emits-change
.Bus property t 9 emits-change
.Name property s "cable_x8x8_2" emits-change
root@qbmc:~# busctl introspect xyz.openbmc_project.EntityManager /xyz/openbmc_project/inventory/system/board/cable_x8x8_3 xyz.openbmc_project.Inventory.I2CLocation
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
.Address property t 82 emits-change
.Bus property t 5 emits-change
.Name property s "cable_x8x8_3" emits-change

Signed-off-by: JinFuLin <JeffLin2@quantatw.com>
Change-Id: I081301a68c12e0c0c8ea4e8f54445dd8ff8b9ed1

show more ...

Refactor : Add a helper function findIndexForFRU to
addFruObjectToDbus

Refactoring addFruObjectToDbus function and created a new helper
function findIndexForFRU. Moved this function to fru_utils.cpp

Refactor : Add a helper function findIndexForFRU to
addFruObjectToDbus

Refactoring addFruObjectToDbus function and created a new helper
function findIndexForFRU. Moved this function to fru_utils.cpp
as it is common for all fru-device deamons and avoid code
duplication.

This patch is created based on suggestion on the below patch.
https://gerrit.openbmc.org/c/openbmc/entity-manager/+/51555

TESTED : Built Facebook YosemiteV2 images and loaded
on the target hardware. Verified all the fru's read and write.

Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>
Change-Id: I2c9b3eb0dfb6050217c3ad459932cda59deea8c8

show more ...

Add a helper function copyRestFRUArea to updateFRUProperty

Refactoring updateFRUProperty function and created a new helper
function copyRestFRUArea. Moved this function to fru_utils.cpp
as it is com

Add a helper function copyRestFRUArea to updateFRUProperty

Refactoring updateFRUProperty function and created a new helper
function copyRestFRUArea. Moved this function to fru_utils.cpp
as it is common for all fru-device deamons and avoid code
duplication.

This patch is created based on suggestion on the below patch.
https://gerrit.openbmc.org/c/openbmc/entity-manager/+/51555

TESTED : Built Facebook YosemiteV2 images and loaded
on the target hardware. Verified all the fru's read and write.

Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>
Change-Id: I3a3ac6ff3190f0d91f5806e4824400cca0a590e4
Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>

show more ...

Fru-device : Extended support for 16bit logic bus

The uint8_t bus of getFruInfo() restricted the number of logical I2C
buses that we could implement in the sysfs interface, and it was
unfortunately

Fru-device : Extended support for 16bit logic bus

The uint8_t bus of getFruInfo() restricted the number of logical I2C
buses that we could implement in the sysfs interface, and it was
unfortunately static_cast'ed to uint_8.which limit on busses to 255.
while Linux kernel can extend the logical I2C bus number to more than
512 without any issues.
This commit add the support of 16 bit logical bus.

reference Link :-
https://lore.kernel.org/all/CACWQX82=MuAavxCqOerxi-Sdywh0xatb-f+1YzGyVSg74oNGqA@mail.gmail.com/T/

Tested :
fru-device successfully recognizes all 8 and 16 bit logic bus.

dependent commit:-
https://gerrit.openbmc.org/c/openbmc/phosphor-host-ipmid/+/58635

Signed-off-by: krishnar4 <krishnar@ami.com>
Change-Id: I4cea81999dc194a1b6915681eeefc846580de15f

show more ...

Add reading FRU support from different MUX channel

If the same FRU content is available in different MUX channels under
same bus, the current implementation will reject it. Also fixed
second layer M

Add reading FRU support from different MUX channel

If the same FRU content is available in different MUX channels under
same bus, the current implementation will reject it. Also fixed
second layer MUX buses (buses from MUX which is already behind a MUX)
is not treating the FRU from parent buses as a new FRU.

Tested:
The fix was tested on a platform with HSBP FRUs pupulated on both
channels of same MUX and found working fine.

Signed-off-by: AKSHAY RAVEENDRAN K <akshay.raveendran.k@intel.com>
Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: I0e541f3047de7122540633619987976b3d51a8e8

show more ...

entity_manager: convert Type to lower case for schema filename

There is an inconsistent string of object type between bmcweb and EM.

When adding StepwiseController via redfish, bmcweb assign "Stepw

entity_manager: convert Type to lower case for schema filename

There is an inconsistent string of object type between bmcweb and EM.

When adding StepwiseController via redfish, bmcweb assign "Stepwise" to
"Type" and passes it to EM's AddObject method. In EM's AddObject, EM
retrieves the "Type" value and use it to get schema file.

Because all schema filenames have fully switched to lower case, add
boost::to_lower_copy() to convert "Type" value to get correct filename.

Tested on bletchley:

- send PATCH to add new StepwiseController call "SWTest"

PATCH Body:
{
"Oem": {
"OpenBmc": {
"Fan": {
"StepwiseControllers": {
"SWTest": {
"Direction": "Floor",
"Inputs": [
"MB_U402_THERM_LOCAL"
],
"NegativeHysteresis": 0.0,
"PositiveHysteresis": 0.0,
"Steps": [
{
"Output": 0.0,
"Target": 48.0
},
{
"Output": 15.0,
"Target": 49.0
}
],
"Zones": [
{
"@odata.id": "/redfish/v1/Managers/bmc#/Oem/OpenBmc/Fan/FanZones/Zone0"
}
]
}
}
}
}
}
}

Response:
{
"@Message.ExtendedInfo": [
{
"@odata.type": "#Message.v1_1_1.Message",
"Message": "The request completed successfully.",
"MessageArgs": [],
"MessageId": "Base.1.13.0.Success",
"MessageSeverity": "OK",
"Resolution": "None"
}
]
}

- BMC add new StepwiseController successfully.

root@bletchley:~# busctl introspect xyz.openbmc_project.EntityManager \
> /xyz/openbmc_project/inventory/system/chassis/Bletchley_Chassis/SWTest
NAME TYPE SIGNATURE RESULT/VALUE FLAGS
org.freedesktop.DBus.Introspectable interface - - -
.Introspect method - s -
org.freedesktop.DBus.Peer interface - - -
.GetMachineId method - s -
.Ping method - - -
org.freedesktop.DBus.Properties interface - - -
.Get method ss v -
.GetAll method s a{sv} -
.Set method ssv - -
.PropertiesChanged signal sa{sv}as - -
xyz.openbmc_project.Configuration.Stepwise interface - - -
.Delete method - - -
.Class property s "Floor" emits-change writable
.Inputs property as 1 "MB U402 THERM LOCAL" emits-change writable
.Name property s "SWTest" emits-change writable
.NegativeHysteresis property d 0 emits-change writable
.Output property ad 2 0 15 emits-change writable
.PositiveHysteresis property d 0 emits-change writable
.Reading property ad 2 48 49 emits-change writable
.Type property s "Stepwise" emits-change writable
.Zones property as 1 "Zone0" emits-change writable

Signed-off-by: Potin Lai <potin.lai@quantatw.com>
Change-Id: I6498125bf108e005d5d138a0d7798d92558ed44c

show more ...

ignore unique-name dbus connections

Unique-named dbus connections should not be exposing dbus objects
and are created by dbus clients (if only an unnamed connection exists).
Filter these out in orde

ignore unique-name dbus connections

Unique-named dbus connections should not be exposing dbus objects
and are created by dbus clients (if only an unnamed connection exists).
Filter these out in order to reduce the re-scanning effort in
entity-manager.

On some systems with a high number shell-script driven `busctl`
operations, this was reported to have a net performance benefit. I
ran this on Bletchley hardware and observed a small (<1sec) boot time
performance, which was difficult to distinguish from the noise.

Tested: Ran on Bletchley and observed identical EM `busctl tree`.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I08b1fe87665312e9bab019f7bff748e03cdc0027

show more ...

Add a helper function findFruAreaLocationAndField to
updateFRUProperty

Refactoring updateFRUProperty function and created a new helper
function findFruAreaLocationAndField. Moved this function to
fr

Add a helper function findFruAreaLocationAndField to
updateFRUProperty

Refactoring updateFRUProperty function and created a new helper
function findFruAreaLocationAndField. Moved this function to
fru_utils.cpp as it is common for all fru-device deamons and
avoid code duplication.

This patch is created based on suggestion on the below patch.
https://gerrit.openbmc.org/c/openbmc/entity-manager/+/51555

TESTED : Built Facebook YosemiteV2 images and loaded
on the target hardware. Verified all the fru's read and write.

Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>
Change-Id: I82265e66ea5db10003e96978979250ea45c2052d

show more ...

clang-15: fixes for const-auto iterators

clang-tidy-15 is giving a number of warnings which it autofixed of
the form:

```
../src/perform_scan.cpp:407:10: error: 'auto &' can be declared as 'const a

clang-15: fixes for const-auto iterators

clang-tidy-15 is giving a number of warnings which it autofixed of
the form:

```
../src/perform_scan.cpp:407:10: error: 'auto &' can be declared as 'const auto &' [readability-qualified-auto,-warnings-as-errors]
for (auto& [configId, config] : systemConfiguration.items())
^
const
```

Apply autofixes.

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I61870f7ab7b68aae61472056f0f707c6e229d7b3

show more ...

entity_manager: reset the path of ObjectManager

Currently, EntityManager places the ObjectManager at "/". According to
the email thread [1], the org has agreed to put object managers at a
fixed loca

entity_manager: reset the path of ObjectManager

Currently, EntityManager places the ObjectManager at "/". According to
the email thread [1], the org has agreed to put object managers at a
fixed location according to the type of objects.

[1] https://lists.ozlabs.org/pipermail/openbmc/2022-July/031336.html

In commit [2], the org has approved that all inventory items shall have
a object manager at /xyz/openbmc_project/inventory. Thus, this commit
changed EntityManager to respect the convention.

[2] https://gerrit.openbmc.org/c/openbmc/phosphor-dbus-interfaces/+/55308

The default ObjectManager at root now becomes useless since most objects
move to ObjectManager at /xyz/openbmc_project/inventory. The only object
left at "/" is the EntityManager object isself which only has a "ReScan"
method. According to the discussion in [3], we are okay to remove this
object manager.

[3] https://discord.com/channels/775381525260664832/1018929092009144380/1021827714619015168

Tested: tested on hardware, EM is working correctly, and a new object at
"/xyz/openbmc_project/inventory" appears, which implements the
ObjectManager interfaces.

Signed-off-by: Nan Zhou <nanzhoumails@gmail.com>
Change-Id: Ic565aa28218275231d020e2cfd77cc5140dfa540

show more ...

Fix persist configuration changes from user

There are user commands that can modify system configuration, like
sensor thresholds. These changes are expected to persist through power
cycles until the

Fix persist configuration changes from user

There are user commands that can modify system configuration, like
sensor thresholds. These changes are expected to persist through power
cycles until they are changed again or factory reset is performed.

Issue: these changes are not persistent because the cached system.json
gets overwritten by perform_scan's updateSystemConfiguration with old
json record. Check if the device already exist in current system json
before loading record from last saved configuration.

Tested:
ipmitool commands to change sensor threshold and the change persist
across power cycles.

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: I160d1910c9b3559558c6a1c3b1b10a454879ae3d

show more ...

FruDevice: Correct the host on match string

When the CurrentHostState D-Bus property value ends with "Running",
FruDevice detects the host as running and starts rescan all D-Bus to
find new Fru devi

FruDevice: Correct the host on match string

When the CurrentHostState D-Bus property value ends with "Running",
FruDevice detects the host as running and starts rescan all D-Bus to
find new Fru devices. From the commit "host state transitioning
support", phosphor-state-manager package supports the transition state
"TransitioningToRunning". This state will be also updated to
CurrentHostState property. This causes FruDevice detects the host is
running when host is transiting to running state.
This commit fixs that issue.

Tested:
1. Power off the host.
2. Power on the host.
3. Make sure FruDevice only rescans bus when the
CurrentHostState is xyz.openbmc_project.State.Host.HostState.Running.

Signed-off-by: Thu Nguyen <thu@os.amperecomputing.com>
Change-Id: I1d307352ee37245816f9b132cd99b7a54a765db7

show more ...

Replace ExportTempate createsHWMon boolean with an enumeration type

The createsHWMon boolean in the ExportTemplate structure applies an
important initialization strategy for some I2C devies. When ne

Replace ExportTempate createsHWMon boolean with an enumeration type

The createsHWMon boolean in the ExportTemplate structure applies an
important initialization strategy for some I2C devies. When new I2C
devices are added to the map of potential I2C devices it is common for
entries to be copied, and pasted, without review of all of the
parameters.

This change is an attempt to reduce copy/paste errors. An enumeration
provides better guidance for initializing the new entry.

Tested:
Confirmed, during debug, the correct initialization path is taken
based upon the hasHWMonDir value.
Confirmed I2C entries are still initialized.

Change-Id: I9141e1875ee99bfe1e7abdc616fb5ea2446e40ba
Signed-off-by: Johnathan Mantey <johnathanx.mantey@intel.com>

show more ...

Fix sign-compare build error

A recent change introduced a compare between 'int ret' and
'array.size()'. array.size() is evaluating to an unsigned int which is
causing a sign-compare build error.

Th

Fix sign-compare build error

A recent change introduced a compare between 'int ret' and
'array.size()'. array.size() is evaluating to an unsigned int which is
causing a sign-compare build error.

This adds a static_cast to remove the sign-compare difference.

Tested:
Confirmed that it builds without a sign-compare error.

Signed-off-by: Jason M. Bills <jason.m.bills@linux.intel.com>
Change-Id: I253ea6fa844678e70fe5975c4a57b65f15e49f0a

show more ...

Make clang-tidy changes

clang-tidy has a number of checks it recommends. These checks are
documented in the next commit, but make the code pass our coding
standard.

Tested:
Minor changes made by t

Make clang-tidy changes

clang-tidy has a number of checks it recommends. These checks are
documented in the next commit, but make the code pass our coding
standard.

Tested:
Minor changes made by the robot.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I6cfaab92211af9c4c1eccd981ba9fe7b8c523457

show more ...

overlay: Simplify path-checking in buildDevice

We know the path we're looking for, so we don't need to go into
directory reading and recursion to check if it's there, we can just do a
direct lookup

overlay: Simplify path-checking in buildDevice

We know the path we're looking for, so we don't need to go into
directory reading and recursion to check if it's there, we can just do a
direct lookup instead.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: Ica84ebc757fc990b1a2477f162008f0f36d937bd

show more ...

overlay: Simplify check/retry logic

deviceIsCreated() should know the value of 'createsHWMon' when
determining what path to check for, not 'retrying'. While changing that
in its caller (buildDevice

overlay: Simplify check/retry logic

deviceIsCreated() should know the value of 'createsHWMon' when
determining what path to check for, not 'retrying'. While changing that
in its caller (buildDevice()), make the logical flow more intuitive:
first check if it's already there, if not try to create it, and only
delete and retry if that doesn't take effect.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: I5c42581c4e862d1730ea0dcc63d0a039302a4af1

show more ...

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are

sdbusplus: use shorter type aliases

The sdbusplus headers provide shortened aliases for many types.
Switch to using them to provide better code clarity and shorter
lines. Possible replacements are for:
* bus_t
* exception_t
* manager_t
* match_t
* message_t
* object_t
* slot_t

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: If2c7da2a8105c39fb0eadf0a86337165b0fe4aa1

show more ...

overlay: Factor out deviceDirName() routine

Replace a couple open-coded instances of this pattern with a dedicated
function, and rename a variable in deviceIsCreate() to avoid potential
confusion be

overlay: Factor out deviceDirName() routine

Replace a couple open-coded instances of this pattern with a dedicated
function, and rename a variable in deviceIsCreate() to avoid potential
confusion between 'dirName' and 'directoryName'.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: Ib3bc2591ec996dda296b82e5fcc3dc1300878ff1

show more ...

overlay: Rename devicePath as busPath

It's the path to the sysfs directory representing an i2c bus, not a
device on that bus; let's name it to reflect that.

Signed-off-by: Zev Weiss <zev@bewilderbe

overlay: Rename devicePath as busPath

It's the path to the sysfs directory representing an i2c bus, not a
device on that bus; let's name it to reflect that.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: I1525f45cc2fd4a9690dc261fbe93ea734952057e

show more ...