EntityManager: Destructure exposed items in postToDbus()

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Iedc8d011ed92b6e476de2835c2caf240e8077d7a

EntityManager: Destructure items when iterating newConfiguration

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ia0658d3068da8d9d0a2731c39d9583c849db6623

EntityManager: Destructure dict items in populateInterfaceFromJson()

Reduce the noise in constantly extracting the underlying values through
.key() and .value() calls.

Signed-off-by: Andrew Jeffery

EntityManager: Destructure dict items in populateInterfaceFromJson()

Reduce the noise in constantly extracting the underlying values through
.key() and .value() calls.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ie676f524bfc1d110a7f80894b4b1ef4812b8173b

show more ...

EntityManager: Rename key to path in populateInterfaceFromJson()

Make way for using the name 'key' for a different variable.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ib724dbc2f99a

EntityManager: Rename key to path in populateInterfaceFromJson()

Make way for using the name 'key' for a different variable.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ib724dbc2f99a0d08ffc6760bf3360b43386e868b

show more ...

PerformScan: Destructure config items in run()

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Id826cd684094b893a228e0a80351617ab8799f84

FruUtils: Fix code formatting

format-code didn't include an invocation of clang-format, and as the
in-repo format-code script overrides the default script in
openbmc-build-scripts there was no code-

FruUtils: Fix code formatting

format-code didn't include an invocation of clang-format, and as the
in-repo format-code script overrides the default script in
openbmc-build-scripts there was no code-formatting being applied in CI.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I68bd7d2c930b752da4045412e7e286b303ac8ff6

show more ...

fru-device: fix return value of i2cSmbusWriteThenRead()

It had been returning the number of messages exchanged, not the number
of bytes received. At present this hasn't been causing any problems,
b

fru-device: fix return value of i2cSmbusWriteThenRead()

It had been returning the number of messages exchanged, not the number
of bytes received. At present this hasn't been causing any problems,
but some impending changes have some stricter requirements for the
return value of ReadBlockFunc functions that this wouldn't have matched.

Tested: on a Delta AHE-50DC, fru-device continued operating as before;
nothing broke.

Signed-off-by: Zev Weiss <zev@bewilderbeest.net>
Change-Id: Ife23043218c719305bf014772f3be2a5acf7e192

show more ...

Move getFRUInfo function to FruUtils.cpp file.

Moved the common function getFRUInfo from FruDevice.cpp to FruUtils.cpp
for handling fru deamon and ipmb-fru deamon to avoid code duplication
in entity

Move getFRUInfo function to FruUtils.cpp file.

Moved the common function getFRUInfo from FruDevice.cpp to FruUtils.cpp
for handling fru deamon and ipmb-fru deamon to avoid code duplication
in entity-manager.

TESTED : Built Facebook YosemiteV2 images and loaded
on the target hardware. Verified all the fru's read and write.

Note : This patch is added as Dependent and follow up patch
for the below patch.
https://gerrit.openbmc-project.xyz/c/openbmc/entity-manager/+/50894
It should merge after the parent patch.

Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>
Change-Id: I186d750e397730c184fc3b59d1c6815408c7642f

show more ...

Move global variable busMap to FruUtil.hpp

Moved the static global variable busMap from FruDevice.cpp to
FruUtil.hpp to make it accessible for fru and ipmb-fru daemons.

Seperating patches into smal

Move global variable busMap to FruUtil.hpp

Moved the static global variable busMap from FruDevice.cpp to
FruUtil.hpp to make it accessible for fru and ipmb-fru daemons.

Seperating patches into small patches to achieve moving common
functions/Variables from FruDevice.cpp to FruUtils.cpp.
https://gerrit.openbmc-project.xyz/c/openbmc/entity-manager/+/47246

Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>
Change-Id: Ie424944edeb44c98a8996d0a8c898dd6140b53ee

show more ...

Fix dangling references to powerIsOn

After refactoring powerIsOn to be not global, there were several
dangling references introduced. Make it a `const bool&` in all parameter
lists so that the vario

Fix dangling references to powerIsOn

After refactoring powerIsOn to be not global, there were several
dangling references introduced. Make it a `const bool&` in all parameter
lists so that the various callbacks (and async thread) can safely access
its current value.

Signed-off-by: Jonathan Doman <jonathan.doman@intel.com>
Change-Id: Id86c0264cbbf91b0afdeb2f80d0103254fe160b4

show more ...

Rename function `formatFRU` to `formatIPMIFRU`

`FruDevice` can parse FRU content more than IPMI format.
Rename the function to a more specific name.

Signed-off-by: Michael Shen <gpgpgp@google.com>

Rename function `formatFRU` to `formatIPMIFRU`

`FruDevice` can parse FRU content more than IPMI format.
Rename the function to a more specific name.

Signed-off-by: Michael Shen <gpgpgp@google.com>
Change-Id: If24f9cb0d51bb18c924b800fee595f52f85673dc

show more ...

Remove unused debug variable in entity-manager

This variable is unused, as clang correctly points out.

Tested:
Code compiles in clang. No-op change.

Signed-off-by: Ed Tanous <edtanous@google.com>

Remove unused debug variable in entity-manager

This variable is unused, as clang correctly points out.

Tested:
Code compiles in clang. No-op change.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I634165b9967a6dd79de2a0f2bbfbeb76152b33a5

show more ...

Move global variables io service and bus to local variables.

Moved the global variables io service and bus declaration
to the local variable and passed as parameter to appropriate
functions.

This f

Move global variables io service and bus to local variables.

Moved the global variables io service and bus declaration
to the local variable and passed as parameter to appropriate
functions.

This fix to avoid the usage of global variable and declaring
global variable in .hpp files while moving common FruDevice.cpp
functions to FruUtils.cpp

Seperating patches into small patches to achieve moving common
functions from FruDevice.cpp to FruUtils.cpp.
https://gerrit.openbmc-project.xyz/c/openbmc/entity-manager/+/47246

Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>
Change-Id: Icd3978cff7f025b3c4e03d3954adacefeacd2a97

show more ...

Move global variable powerIsOn to local variable.

Moved the global variable powerIsOn declaration to the local
variable and passed as parameter to appropriate functions.

This fix to avoid the usage

Move global variable powerIsOn to local variable.

Moved the global variable powerIsOn declaration to the local
variable and passed as parameter to appropriate functions.

This fix to avoid the usage of global variable and declaring
global variable in .hpp files while moving common FruDevice.cpp
functions to FruUtils.cpp

Seperating patches into small patches to achieve moving common
functions from FruDevice.cpp to FruUtils.cpp.
https://gerrit.openbmc-project.xyz/c/openbmc/entity-manager/+/47246

TESTED : Verified all the fru's read, write and scan in
Facebook YosemiteV2 platform.

Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>
Change-Id: I2172b14538a056508a5600722a297745faf3c4eb

show more ...

Cleanup of code to pass CI, clang-tidy-13

With the move to clang-tidy-13 entity-manager wasn't passing CI.
src/Utils.cpp:76:34: error: statement should be inside braces

Tested: After code updat

Cleanup of code to pass CI, clang-tidy-13

With the move to clang-tidy-13 entity-manager wasn't passing CI.
src/Utils.cpp:76:34: error: statement should be inside braces

Tested: After code update entity-manager is now passing CI with
clang-tidy-13.

Signed-off-by: Bruce Mitchell <bruce.mitchell@linux.vnet.ibm.com>
Change-Id: I54e9e7b0dc825dc860338df47bad5a5952d80d02

show more ...

entity-manager: Search sysconfdir for configurations

Make it easier to iteratively develop configurations in-place with a
read-only /usr.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id:

entity-manager: Search sysconfdir for configurations

Make it easier to iteratively develop configurations in-place with a
read-only /usr.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Id0853b579a61394cb2b6ef0a3858ba01e5cb2893

show more ...

EntityManager: Clean up use of probeTypes

Remove the duplication by introducing findProbeType() to hide the map
definition.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I62704bac7aef6

EntityManager: Clean up use of probeTypes

Remove the duplication by introducing findProbeType() to hide the map
definition.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I62704bac7aef6c6ea5d9f81aee429861b13cca6c

show more ...

EntityManager: Split out PerformProbe

Continue breaking down the code so regular people can comprehend it.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ic4458054df7426d579cb99dd21f357

EntityManager: Split out PerformProbe

Continue breaking down the code so regular people can comprehend it.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ic4458054df7426d579cb99dd21f3578d1265711d

show more ...

EntityManager: Split out PerformScan

Start breaking down the code so regular people can comprehend it.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I82fec105fbe29bd09145feaaa48fbcb875

EntityManager: Split out PerformScan

Start breaking down the code so regular people can comprehend it.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I82fec105fbe29bd09145feaaa48fbcb875ca930f

show more ...

Move global variable to local variable.

Moved the global variable unknownBusObjectCount declaration
to the local variable and passed as parameter to appropriate
functions.

This fix to avoid the usa

Move global variable to local variable.

Moved the global variable unknownBusObjectCount declaration
to the local variable and passed as parameter to appropriate
functions.

This fix to avoid the usage of global variable and declaring
global variable in .hpp files while moving common FruDevice.cpp
functions to FruUtils.cpp

TESTED : Verified all the fru's read, write and scan
in Facebook YosemiteV2 platform.

Signed-off-by: Kumar Thangavel <thangavel.k@hcl.com>
Change-Id: Ife8172f4753bbd07e3dc471f948338297f78058e

show more ...

FruUtils: Add support for finding FRU at an offset

This change adds findFRUHeader which can detect non-IPMI headers to
identify the offset for IPMI FRU data. An implementation for "$TYAN$"
has been

FruUtils: Add support for finding FRU at an offset

This change adds findFRUHeader which can detect non-IPMI headers to
identify the offset for IPMI FRU data. An implementation for "$TYAN$"
has been added. The new findFRUHeader is now used by readFRUContents
to generically read IPMI FRU both at offset 0 and at a offset as
determined by findFRUHeader.

Signed-off-by: Oskar Senft <osk@google.com>
Change-Id: I4325aac7737db59aaa11359ad7a0d575957f16e7

show more ...

Utils: Fix more than one template replace

There is a bug in templateCharReplace function that only the first
template gets replaced correctly and additional templates are left
unchanged.

Add a new

Utils: Fix more than one template replace

There is a bug in templateCharReplace function that only the first
template gets replaced correctly and additional templates are left
unchanged.

Add a new test case twoReplacementsWithMath2 to show the issue.
Difference with the existing passing test case is key string
"ADDRESS" is less than "BAR".
nlohmann::json j = {{"foo", "4 / 2 equals $ADDRESS / 2 $BAR"}};
data["ADDRESS"] = 4;
data["BAR"] = std::string("bar");

With this change the new test case passes.

Tested:
All unit tests passed.

Signed-off-by: Zhikui Ren <zhikui.ren@intel.com>
Change-Id: I121ec8c0fcfce645f52518ed4429228549ff9371

show more ...

catch exceptions as const

Signed-off-by: Patrick Williams <patrick@stwcx.xyz>
Change-Id: I17001575bc409351f5187b1b269e66968d402c1c

Revert "meson: nlohmann/json has a meson build"

and Revert "meson: Rework valijson subproject dependency"

This reverts commit 9fedd141288d36d41345305532251e4659535751.
and e7948f447eaeb3afaa78d5d29

Revert "meson: nlohmann/json has a meson build"

and Revert "meson: Rework valijson subproject dependency"

This reverts commit 9fedd141288d36d41345305532251e4659535751.
and e7948f447eaeb3afaa78d5d298dc12b0730b8a84.

As they break the yocto build.

Signed-off-by: Ed Tanous <edtanous@google.com>
Change-Id: I8034a362f0866342a1527f468dc84a6ff1c67bd7

show more ...

FruUtils: Avoid truncation in derivation of fruAreaSize

FRU areas can be up to 255 * 8 bytes in length. 2040 can't be
represented in an unsigned 8-bit type, so widen the result type to
match fruBloc

FruUtils: Avoid truncation in derivation of fruAreaSize

FRU areas can be up to 255 * 8 bytes in length. 2040 can't be
represented in an unsigned 8-bit type, so widen the result type to
match fruBlockSize.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ie331abc2a50d1d91fced2f03d2ba3275331bdeaa

show more ...