PerformScan: Clean up timer declarations using auto

We can infer the type from the right-hand side.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I7a93c524e02e4d64b0b0acddd3a47d4ef1f09

PerformScan: Clean up timer declarations using auto

We can infer the type from the right-hand side.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I7a93c524e02e4d64b0b0acddd3a47d4ef1f0956c

show more ...

PerformScan: Introduce DBusInterfaceInstance

Clean up getInterfaces() a little by using names rather than tuple
indexes.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Id6a76b197e38089c

PerformScan: Introduce DBusInterfaceInstance

Clean up getInterfaces() a little by using names rather than tuple
indexes.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Id6a76b197e38089c06054caa1557b692ef243961

show more ...

PerformScan: Eliminate interfaceConnections

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Iea610223ee89e5d690d4500bed81216426c990c9

PerformScan: Extract processDbusObjects()

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I29d547831d3cb43d4ec619de375893b99c1f406c

PerformScan: Remove redundant early-return

The only thing we subsequently do with interfaceConnections is iterate
over it, which if it's empty will result in no action anyway.

Signed-off-by: Andrew

PerformScan: Remove redundant early-return

The only thing we subsequently do with interfaceConnections is iterate
over it, which if it's empty will result in no action anyway.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ibe13538ae46d820a0b09fe57687c794b1d65f963

show more ...

PerformScan: All interfaces on a path is an object

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I34148c64eac419396ff04be85ae3f97c09fa25df

EntityManager: Make MapperGetSubTreeResponse type comprehensible

From there, rework a bunch of uses of the unaliased types to use the new
aliased types and fix up some of the variable names to impro

EntityManager: Make MapperGetSubTreeResponse type comprehensible

From there, rework a bunch of uses of the unaliased types to use the new
aliased types and fix up some of the variable names to improve
readability.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I498e0d93091cae43e59907ee1908afc97ac601ee

show more ...

EntityManager: Remove dead ManagedObjectType definition

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ibbe63b705b3cb5c5060fbd161ce96e1967c98873

EntityManager: Rename BasicVariantType to DBusValueVariant

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ifde3020ee286ee6b98951df4bad5c3bd8d0251d2

EntityManager: Rename DBusProbeObjectT to MapperGetSubTreeResponse

Reflect that it's the result of a subtree query and align the type name
with that used in bmcweb.

Signed-off-by: Andrew Jeffery <a

EntityManager: Rename DBusProbeObjectT to MapperGetSubTreeResponse

Reflect that it's the result of a subtree query and align the type name
with that used in bmcweb.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I02066127833737b7df04ece20da5392b52ced676

show more ...

EntityManager: Rename findJsonFiles() to loadConfigurations()

loadConfigurations() seems like a better description of its job.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ib37de324ee

EntityManager: Rename findJsonFiles() to loadConfigurations()

loadConfigurations() seems like a better description of its job.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ib37de324ee6157d4d12be99a7f8f76de0583f40b

show more ...

EntityManager: Extract publishNewConfiguration()

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Icac8bee4cc7830ec203782372a3f79ff43413212

EntityManager: Extract deriveNewConfiguration()

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Id9ad4739aa1672bd33e0799785aa1d5ed3360b5d

EntityManager: Extract pruneConfiguration()

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: If2ce19c6353cdf49212fc586ab6354f8b8e608ad

EntityManager: Clean up interface removal condition

The early exit only serves to decrease readability by negating a
condition and adding more lines. Instead, add another negation and
remove a line.

EntityManager: Clean up interface removal condition

The early exit only serves to decrease readability by negating a
condition and adding more lines. Instead, add another negation and
remove a line.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I3c2dc571b4fe7b1c763f5951c64e35d43b77ce0a

show more ...

EntityManager: Exploit destructuring for configuration removed loop

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I8c48cb26775d5f535e094bbaddb236d771188461

EntityManager: Introduce getDeviceInterfaces()

Drop some noise from the loop in propertiesChangedCallback().

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ib4b4496aa82cd3cbe46b68dd86cf

EntityManager: Introduce getDeviceInterfaces()

Drop some noise from the loop in propertiesChangedCallback().

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ib4b4496aa82cd3cbe46b68dd86cf88f7f2b83d97

show more ...

EntityManager: Flip condition to start removed timer

Use the condition to select the behaviour we want rather than the one we
don't to improve readability.

Signed-off-by: Andrew Jeffery <andrew@aj.

EntityManager: Flip condition to start removed timer

Use the condition to select the behaviour we want rather than the one we
don't to improve readability.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I0f31d6d093043d1edc8292b8f2acb184854ba033

show more ...

EntityManager: Refactor pruneDevice() early-exits

Clean up the condition to improve readability.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: If4d65a8d757aaf5c4fa57ae6b455d0ad11e2a358

EntityManager: Introduce pruneDevice()

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Iac01b11acd19be915a6a428af31ead8b8c3d394b

EntityManager: Exploit destructuring for device removed loop

This makes the code a bit nicer to read.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Icea51f4841e316c0ba259cf6c104e3e449b

EntityManager: Exploit destructuring for device removed loop

This makes the code a bit nicer to read.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Icea51f4841e316c0ba259cf6c104e3e449bb4dbe

show more ...

EntityManager: Continue the loop if the entity is present

Avoid nesting further logic by inverting the presence test.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I679943181aa5c3ad862

EntityManager: Continue the loop if the entity is present

Avoid nesting further logic by inverting the presence test.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I679943181aa5c3ad8620c4ffc8ab5b984ca06b8f

show more ...

EntityManager: Determine device config presence with .contains()

This is less verbose than .find() == .end()

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I509463d5811415804dc2136aec5e

EntityManager: Determine device config presence with .contains()

This is less verbose than .find() == .end()

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I509463d5811415804dc2136aec5ea530318935b3

show more ...

EntityManager: Rename isDetectedPowerOn for clarity

This is about the configuration at hand, not directly about the current
host power state.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-

EntityManager: Rename isDetectedPowerOn for clarity

This is about the configuration at hand, not directly about the current
host power state.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Id602f6a7374b2a4b6316df81583b062d76f78593

show more ...

EntityManager: Refactor deviceRequiresPowerOn() with early-exits

Make the state space easier to follow.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: If5c57583c01c62cb1c94ca05c1a3c7eb9

EntityManager: Refactor deviceRequiresPowerOn() with early-exits

Make the state space easier to follow.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: If5c57583c01c62cb1c94ca05c1a3c7eb9be726f0

show more ...