PerformScan: Use early returns in extractExposeActionRecordNames()

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ib41c5edf587ce0fc6b1c7260c94ff3affe92a01c

PerformScan: Extract extractExposeActionRecordNames()

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I4758ff0ed0cf047bf2a56685bef2b9e76060ec7f

PerformScan: Bind and DisableNode Expose directives are actions

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Iee5331ed5dac3dd19235145fb1fe90eff03b0316

PerformScan: Split conditionals to improve readability

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I6596cb9580c5ad5e9a540f0c8622b1fabe1ebcba

PerformScan: Tidy condition using nlohmann::json::is_array()

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I59e79457d275fde03cc898dea608de2bab89c4ce

PerformScan: Un-nest continue by merging conditionals

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: If1d0230b0cf1cbe2e688a962b1c8de02298a79c4

PerformScan: Searching with 'recordName' means we found a 'record'

Rename fromLastJson to something sensible.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I2c400eb59d395129002fb473f3d

PerformScan: Searching with 'recordName' means we found a 'record'

Rename fromLastJson to something sensible.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I2c400eb59d395129002fb473f3dbd97e57968e72

show more ...

PerformScan: Reorder operations when processing old configuration

recordDiscoveredIdentifiers() doesn't modify the record held in
*fromLastJson, so move it to below pruneRecordExposes() to implement

PerformScan: Reorder operations when processing old configuration

recordDiscoveredIdentifiers() doesn't modify the record held in
*fromLastJson, so move it to below pruneRecordExposes() to implement a
logical flow of operations.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I516e4afa365a218a9042ccdb01e0fa62872a6529

show more ...

PerformScan: Rename fromLastJson in recordDiscoveredIdentifiers()

Now that we're freed from the caller context give it a name that
represents it the object in the context of the function.

Signed-of

PerformScan: Rename fromLastJson in recordDiscoveredIdentifiers()

Now that we're freed from the caller context give it a name that
represents it the object in the context of the function.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ie7c384b5f3fc9cc281c15193c150f383c3a295dd

show more ...

PerformScan: Drop hasTemplateName from recordDiscoveredIdentifiers()

The variable is only used once, just put the statement directly in the
early-return if-condition.

Signed-off-by: Andrew Jeffery

PerformScan: Drop hasTemplateName from recordDiscoveredIdentifiers()

The variable is only used once, just put the statement directly in the
early-return if-condition.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ia842df91e578fa74c4943535482b340ee5148e63

show more ...

PerformScan: Extract recordDiscoveredIdentifiers()

Update the data structures tracking known names and unused indexes in a
function we can call from the loop processing the existing system
config.

PerformScan: Extract recordDiscoveredIdentifiers()

Update the data structures tracking known names and unused indexes in a
function we can call from the loop processing the existing system
config.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Id4ea1584dec5b67e689885a4f48b69581cd3ae2e

show more ...

PerformScan: Avoid `continue` when updating unused indexes

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I0b86a2d79710f0c549a24d5dda05fa272c7a32c5

PerformScan: Untemplated record name allows early continue

Continuing early in the loop reduces indentation.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ife17dbe9ab437e4779e86c3f75b4

PerformScan: Untemplated record name allows early continue

Continuing early in the loop reduces indentation.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ife17dbe9ab437e4779e86c3f75b4a1edd02ba051

show more ...

PerformScan: Reduce indentation with early continue for absent record

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I5e740034a0a08f7648a72c0666fee72be4bd0238

PerformScan: Concurrent modification of container needs visibility

We're removing an item from foundDevices while iterating over
foundDevices. Improve the visibility of what's going on, especially
g

PerformScan: Concurrent modification of container needs visibility

We're removing an item from foundDevices while iterating over
foundDevices. Improve the visibility of what's going on, especially
given the odd loop header (missing the 'post' action of the for-loop)
and the presence of many `continue` keywords.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I491b69369598e2454812c1945baacab5aeeeebb9

show more ...

PerformScan: Flip condition to avoid continue in pruneNullExposes()

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: If4789a0edd76c614e618dfd317a558ad6f17f097

PerformScan: Return early from pruneRecordExposes()

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ie5a128c4d3abcd817710b1116e3c10908aa1de8f

PerformScan: Rename fromLastJson in pruneRecordExposes()

The initial code motion preserved the name to minimise the differences.
Rename the variable now so it's a little more sensible.

Signed-off-b

PerformScan: Rename fromLastJson in pruneRecordExposes()

The initial code motion preserved the name to minimise the differences.
Rename the variable now so it's a little more sensible.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I54ce197e25d280e6a1fd5ee5c6d74bdce974bea1

show more ...

PerformScan: Extract pruneRecordExposes()

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I95b56e7a1c1c3733e1d98501f5d3076da56a91f4

PerformScan: Rename ifacesIt to objectIt

Make it reflect that the returned pair represents an object (set of
interfaces) at the provided path.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change

PerformScan: Rename ifacesIt to objectIt

Make it reflect that the returned pair represents an object (set of
interfaces) at the provided path.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I99e0ae61e8c3e5848c5ede5a518d9178702cbed0

show more ...

PerformScan: Lift name key update out of the for-loop

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ie4b6472cd6547f2b6d782927473858d4dd261a05

PerformScan: Drop redundant assignment into system configuration

We just did this in the line above the diff hunk. It's enough to just
continue.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Chan

PerformScan: Drop redundant assignment into system configuration

We just did this in the line above the diff hunk. It's enough to just
continue.

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I1d36f5143822edcb5dbac175245c106a50b1ae4f

show more ...

PerformScan: Make getRecordName() static

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I7dbeb257d067de032327144e0e1046a3e838e33c

PerformScan: Promote dbusObject from pointer to reference

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: Ia2094e141c0b2878e62dbd05884ca05e8bfe33ce

PerformScan: allInterfaces is a subtree result

Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Change-Id: I4084170f43a49ff5bd99791372a613f27622b101